[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

aaron.ballman added reviewers: steveire, klimek, sammccall. aaron.ballman added a subscriber: steveire. aaron.ballman added a comment. In D88275#2295413 , @ymandel wrote: > In D88275#2295379 , @aaron.ballman > wrot

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk created this revision. vsk added reviewers: jkorous, ahatanak. Herald added a subscriber: dexonsmith. Herald added a project: clang. vsk requested review of this revision. Extend -fsanitize=nullability-arg to handle call sites which accept C++ member function pointers. rdar://62476022 Repos

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. "Minimal" example for the behavior I described before. `clang++ -fsyntax-only ~/llvm/clang/test/SemaCXX/warn-range-loop-analysis.cpp -Wrange-loop-analysis 2>&1 | wc -l` 269 Then fix it by: `~/llvm/build-const-fix/bin/clang-tidy ~/llvm/clang/test/SemaCXX/warn-ra

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a tool to simply parse a

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. Off-Topic: I was just attempting to apply this to my codebase at work. Seems this will be more challenging than anticipated 😉 My best guess is this is related to D72730 Applying fixes ... terminate called after throwing an ins

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall added inline comments. Comment at: clang/include/clang/AST/Mangle.h:130 + bool includeCategoryNamespace = true); void mangleObjCMethodName(const ObjCMethodDecl *MD, raw_ostream &); Could you switch the polarity

[clang] 58cdbf5 - Sema: add support for `__attribute__((__swift_private__))`

Author: Saleem Abdulrasool Date: 2020-09-25T22:33:53Z New Revision: 58cdbf518b6ebaee59d0492375e2e8f7da87ca41 URL: https://github.com/llvm/llvm-project/commit/58cdbf518b6ebaee59d0492375e2e8f7da87ca41 DIFF: https://github.com/llvm/llvm-project/commit/58cdbf518b6ebaee59d0492375e2e8f7da87ca41.diff

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG58cdbf518b6e: Sema: add support for `__attribute__((__swift_private__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87720?vs=294167&id=294443#toc Repository: rG LLVM G

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

ahatanak added a comment. It looks like this still doesn't check null correctly (i.e., compare to -1) for data member pointers. Is that correct? Comment at: clang/lib/CodeGen/CGCall.cpp:3750 + // Under the Itanium ABI, if the argument has member pointer type, it's a + // pai

[PATCH] D88345: [CUDA] Allow `static const {__constant__, __device__}` variables.

tra created this revision. tra added reviewers: jlebar, yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. tra requested review of this revision. While CUDA documentation claims that such variables are not allowed[1], NVCC has been accepting them since CUDA-10.0

[clang] a000580 - [RISCV] Update driver tests

Author: Evandro Menezes Date: 2020-09-25T18:36:53-05:00 New Revision: a000580a89718a1ff27a3129e34367b9a3fa1730 URL: https://github.com/llvm/llvm-project/commit/a000580a89718a1ff27a3129e34367b9a3fa1730 DIFF: https://github.com/llvm/llvm-project/commit/a000580a89718a1ff27a3129e34367b9a3fa1730.dif

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. wha... As you know, `const` doesn't mean anything, that can be const-casted away. And then you'll be able to observe that this nominally-static variable is just a normal variable. Since this doesn't make sense and contradicts their documentation, I'm tempted to say thi

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk updated this revision to Diff 294457. vsk added a comment. Simplify, per Akira's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88336/new/ https://reviews.llvm.org/D88336 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExpr

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk added a comment. In D88336#2296051 , @ahatanak wrote: > It looks like this still doesn't check null correctly (i.e., compare to -1) > for data member pointers. Is that correct? Thanks for catching this. The new revision takes advantage of CXXABI::Em

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294461. ellis added a comment. Rename `mangleObjCMethodName` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Man

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 ___ cfe-com

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

MaskRay added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:372 apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``flto=thin``. typo: `-flto=thin` Repository: rG LLVM Gi

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGExpr.cpp:1181 + if (T->isMemberPointerType()) +return CGM.getCXXABI().EmitMemberPointerIsNotNull( +*this, V, T->getAs())

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc created this revision. ddcc added a reviewer: ostannard. Herald added a subscriber: dang. Herald added a project: clang. ddcc requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88349 Files: clang/include/clang/Driver/Options.td Index: clan

[clang] ebb1092 - [Clang][OpenMP] Added support for nowait target in CodeGen via regular task

Author: Shilei Tian Date: 2020-09-25T22:10:36-04:00 New Revision: ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff URL: https://github.com/llvm/llvm-project/commit/ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff DIFF: https://github.com/llvm/llvm-project/commit/ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff.diff L

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task

This revision was automatically updated to reflect the committed changes. Closed by commit rGebb1092a2875: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D88333: Correctly parse attributes on the declaration of an anonymous bit-field

rsmith added a comment. I think we established rough consensus in CWG (at least, no one objected) that this is a grammar bug -- there's nothing for these attributes to appertain to, so they shouldn't be permitted. Unless CWG indicates it wants to change direction here I think we should continue

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

dmajor added a comment. This change broke the configure step of Firefox mingw builds. The build bot won't give me the full details, so I'll need to set up a local repro next week if needed, but my hunch is that we have some test like `$CC $CFLAGS conftest.c -o conftest` and then check for the e

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. benshi001 requested review of this revision. AVR.cpp should be kept up-to-date with AVRDevices.td Repository: rG LLVM Github Monorepo http

[clang] 96318f6 - [Driver] Perform Linux distribution detection only once

Author: Dmitry Antipov Date: 2020-09-26T08:44:08+03:00 New Revision: 96318f64a7864747ebbb4e33cb75b0dea465abfc URL: https://github.com/llvm/llvm-project/commit/96318f64a7864747ebbb4e33cb75b0dea465abfc DIFF: https://github.com/llvm/llvm-project/commit/96318f64a7864747ebbb4e33cb75b0dea465abfc.diff

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

This revision was automatically updated to reflect the committed changes. Closed by commit rG96318f64a786: [Driver] Perform Linux distribution detection only once (authored by dmantipov). Changed prior to commit: https://reviews.llvm.org/D87187?vs=294302&id=294478#toc Repository: rG LLVM Git

[clang] 2ca0ea1 - [Driver] Fix formatting as suggested by clang-format (NFC)

Author: Dmitry Antipov Date: 2020-09-26T08:52:51+03:00 New Revision: 2ca0ea15e5c910ff93874679f0a03c923fe85e5b URL: https://github.com/llvm/llvm-project/commit/2ca0ea15e5c910ff93874679f0a03c923fe85e5b DIFF: https://github.com/llvm/llvm-project/commit/2ca0ea15e5c910ff93874679f0a03c923fe85e5b.diff

<    1   2