[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza marked 5 inline comments as done. lanza added a comment. Fixed and added a test under the `REDUNDANCY` prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 _

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:466 + for (; begin != end; ++begin) +AppendFirstRuntimeProtocols(*begin, PDs); + rjmccall wrote: > Should this make an effort to avoid declaring redundant bases? e.g. > > ``` > @protocol

[PATCH] D87953: [xray] Function coverage groups

ianlevesque added a comment. I can update the docs @MaskRay, not a problem. I'll tweak the test a little too per your comment. @dberris I think if we wanted to control it in a non-'random' (the crc32 was chosen so it would be consistent even though it's not really predictable up front) way we'

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

mzeren-vmw added a comment. Perhaps PointerAlignment should be an enum of Left, Middle, Right? We maintain an internal patch that adds "ReferenceAlignment" as separate from PointerAlignment. So one could have: PointerAlignment: Middle ReferenceAlignment: Left Repository: rG LLVM Github M

[PATCH] D87953: [xray] Function coverage groups

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Okay, I think I understand the motivation a little bit more now (i.e. sampling seems to be a useful thing to do anyway, regardless of whether we have the other facilities). Repository: r

[PATCH] D87953: [xray] Function coverage groups

ianlevesque updated this revision to Diff 294213. ianlevesque added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add static function to the test case, update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

jranieri-grammatech added a comment. In D54222#1290789 , @JonasToth wrote: > I agree with @Eugene.Zelenko that this check should rather live in > `bugprone-` as the issue its diagnosing is not LLVM specific. It is ok to add > an alias into the llvm modul

[clang] 8c98c88 - PR47176: Don't read from an inactive union member if a friend function

Author: Richard Smith Date: 2020-09-24T19:02:27-07:00 New Revision: 8c98c8803430804010da06a07cfb291dab59067c URL: https://github.com/llvm/llvm-project/commit/8c98c8803430804010da06a07cfb291dab59067c DIFF: https://github.com/llvm/llvm-project/commit/8c98c8803430804010da06a07cfb291dab59067c.diff

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 294215. ffrankies edited the summary of this revision. ffrankies added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Rebased code and fixed merge conflicts with D66564 - Added KernelNa

[PATCH] D87953: [xray] Function coverage groups

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7fbdd2857f: [xray] Function coverage groups (authored by ianlevesque). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D

[clang] 6f7fbdd - [xray] Function coverage groups

Author: Ian Levesque Date: 2020-09-24T22:09:53-04:00 New Revision: 6f7fbdd2857fc8a7280afbb26fd4e1a6450069e4 URL: https://github.com/llvm/llvm-project/commit/6f7fbdd2857fc8a7280afbb26fd4e1a6450069e4 DIFF: https://github.com/llvm/llvm-project/commit/6f7fbdd2857fc8a7280afbb26fd4e1a6450069e4.diff

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-kernel-name-restriction.rst:4 +altera-kernel-name-restriction + + Please make same length as text above. CHANGES SINCE LAST ACTION h

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. ymandel requested review of this revision. This matcher combines the features of the `hasParent` matcher with skip-implicit-expression-nodes behavior of `ignoringImplicit`. It finds the first ancest

[clang] 64b8a63 - [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

Author: Chris Bowler Date: 2020-09-24T23:28:40-04:00 New Revision: 64b8a633a872f25c8b3f9414c22165405400ea10 URL: https://github.com/llvm/llvm-project/commit/64b8a633a872f25c8b3f9414c22165405400ea10 DIFF: https://github.com/llvm/llvm-project/commit/64b8a633a872f25c8b3f9414c22165405400ea10.diff

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

This revision was automatically updated to reflect the committed changes. Closed by commit rG64b8a633a872: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex (authored by cebowleratibm, committed by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D88105?vs=293917&id=294222#to

[PATCH] D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88130/new/ https://reviews.llvm.org/D88130 __

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:490 + llvm::UniqueVector FoundProtocols; + std::set DeclaredProtocols; + You should use llvm::DenseSet for this. But in general there are more sets here than I think you really need, and

[clang] 7db7a35 - Fix uninitialized XRayArg

Author: Ian Levesque Date: 2020-09-25T00:20:36-04:00 New Revision: 7db7a355453887906d12ffb67df8fbaa5e9e873d URL: https://github.com/llvm/llvm-project/commit/7db7a355453887906d12ffb67df8fbaa5e9e873d DIFF: https://github.com/llvm/llvm-project/commit/7db7a355453887906d12ffb67df8fbaa5e9e873d.diff

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff updated this revision to Diff 294230. sepavloff added a comment. Added diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.llvm.org/D87822 Files: clang/include/clang/AST/Expr.h clang/include/cl

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme created this revision. Esme added reviewers: steven.zhang, masoud.ataei, shchenz, jsji, qiucf. Herald added subscribers: llvm-commits, cfe-commits, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. Esme requested review of this revision. This patch implements the builtins for

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2438 +/// Check if the given evaluation result is allowed for constant evaluation. +static bool checkFloatingPointResult(EvalInfo &Info, const Expr *E, + APFloat::opSta

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2584 +// Vector test software functions. +def : Pat<(i32 (int_ppc_vsx_xvtdivdp v2f64:$A, v2f64:$B)), Vector test for software divide and sqrt Repository: rG LLVM Github M

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. Looks good. Makes the tsan and instrumentation interaction also cleaner. Comment at: clang/test/CodeGen/code-coverage-tsan.c:1 -/// -fsanitize=thread requires the (potentia

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay updated this revision to Diff 294232. MaskRay marked an inline comment as done. MaskRay added a comment. Thanks for review! I will wait until next week. Fixed a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/ https://review

[PATCH] D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. Oh, I think now what do you mean: iterators stored in containers, thus iterators iterating over iterators. Yes, the current working of the checker does not support it because it stores iterator positions for both the prvalues and the glvalues. This is so from

<    1   2   3