[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai added a comment. In D86895#2288262 , @tschuett wrote: > Where is the test? `ALWAYS_ENABLED_STATISTIC` has its own unit tests. And tests that use added stats are in another revision in the stack D86896 . Reposit

[PATCH] D83296: [clang-format] Add a MacroExpander.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ship it! Comment at: clang/lib/Format/FormatToken.h:177 +/// EndOfExpansion: 0 0 0 21 0 1 +struct MacroContext { + MacroContext(MacroRole Role) : Role(Rol

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein updated this revision to Diff 293538. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-function-re

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. @rsmith this patch should be ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 ___ cfe-commits mailing li

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 11:28 AM Albion Fung via Phabricator wrote: > > Conanap added a comment. > > It looks like this commit is causing a few failures on nearly all PPC bots > and a sanitizer bot; would it be possible to revert this commit for now until > the issue is resolved? Ya sure, I can

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293550. jhuber6 added a comment. Updated runtime library to have legacy calls into the new functions with source location information. Because the library interface requires C function naming this required adding a suffix to all the functions clang generates

[clang] b89059a - Revert "The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled."

Author: Sriraman Tallam Date: 2020-09-22T12:32:43-07:00 New Revision: b89059a31347dd09b55a96b99b3dbe38d7749908 URL: https://github.com/llvm/llvm-project/commit/b89059a31347dd09b55a96b99b3dbe38d7749908 DIFF: https://github.com/llvm/llvm-project/commit/b89059a31347dd09b55a96b99b3dbe38d7749908.dif

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

MaskRay added a comment. In D87921#2288395 , @Conanap wrote: > It looks like this commit is causing a few failures on nearly all PPC bots > and a sanitizer bot; would it be possible to revert this commit for now until > the issue is resolved? It would b

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with comment typo fix Comment at: llvm/include/llvm/LTO/LTOBackend.h:59 + +/// Distributed ThinlTO: load the referenced modules, keeping their buffers +/// alive i

[clang] cf11238 - [ThinLTO] Option to bypass function importing.

Author: Mircea Trofin Date: 2020-09-22T13:12:11-07:00 New Revision: cf112382ddd0d717edf0b8a3e5b061de925258e9 URL: https://github.com/llvm/llvm-project/commit/cf112382ddd0d717edf0b8a3e5b061de925258e9 DIFF: https://github.com/llvm/llvm-project/commit/cf112382ddd0d717edf0b8a3e5b061de925258e9.diff

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf112382ddd0: [ThinLTO] Option to bypass function importing. (authored by mtrofin). Changed prior to commit: https://reviews.llvm.org/D87949?vs=293506&id=293555#toc Repository: rG LLVM Github Monorep

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *RetValUnderCons

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. I'm also in favor, I think this is good direction ahead. It'd be nice if following issues were fixed -- in subsequent patches if you wish: - Stage1 `ninja check-scudo` fails many tests for me, see F13037612: errors.txt . - Stage2 `ninj

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

rsmith added a comment. In D87808#2288186 , @dblaikie wrote: > In D87808#2286664 , @rsmith wrote: > >> But I think this code should give the same outcome either way, because a >> class with any constructor other th

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin created this revision. mtrofin added reviewers: steven_wu, tejohnson. Herald added a reviewer: alexshap. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. mtrofin requested review of this revision. This is important to not regress because it allows us to cap

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 293559. nickdesaulniers added a comment. Herald added a reviewer: whitequark. Herald added a reviewer: aaron.ballman. - add tests, make fn attrs mutually exclusive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. The revert did not fix the PPC bots. I suspect there is some kind of resource issue from the logs: msgget:: No space left on device sysmsg.c.tmp: /home/buildbots/ppc64le-clang-lnt-test/clang-ppc64le-lnt/llvm/compiler-rt/test/sanitizer_common/TestCases/Linux/sysms

[PATCH] D87953: [xray] Function coverage groups

ianlevesque added a comment. This is ready for another review, I think I addressed everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 ___ cfe-commits mai

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added a comment. I obviously have a few todos left to resolve, but CC'ing reviewers now for general feedback. One thing I'm unsure of; it felt curious to me that nothing was enforcing that these different levels of stack protection were mutually exclusive. I've added that here

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

MarcusJohnson91 added a comment. In D88084#2287450 , @MyDeveloperDay wrote: > I noticed the pre-merge tests failed! Yeah I just noticed that too, not sure what's up but I'll check into it, and yeah that's a good idea about initializing some of these dup

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L updated this revision to Diff 293561. Xiangling_L marked 16 inline comments as done. Xiangling_L added a comment. Addressed the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D88115: [CUDA][HIP] Fix static device var used by host code only

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. A static device variable may be accessed in host code through cudaMemCpyFromSymbol etc. Currently clang does not emit the static device variable if it is only referenced by host code, which causes

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

steven_wu added a comment. I am not sure what exactly is expected here. What is your definition for pre-optimized bitcode and how your test case ensures that? Can you explain a bit more for context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin added a comment. In D88114#2288732 , @steven_wu wrote: > I am not sure what exactly is expected here. What is your definition for > pre-optimized bitcode and how your test case ensures that? Can you explain a > bit more for context? Pre-optimize

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

steven_wu added a comment. In D88114#2288737 , @mtrofin wrote: > In D88114#2288732 , @steven_wu wrote: > >> I am not sure what exactly is expected here. What is your definition for >> pre-optimized bitcode and how

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

wallace added a comment. I like this a lot!! Amazing work. I think it'll be useful for my Trace patch. I'll do a corresponding refactor using probably this new functionality. I find the diff straightforward to follow. Unless anyone has objections, I'm fine with the patch at it is. Repository:

[PATCH] D87451: add new clang option -mno-xcoff-visibility

DiggerLin updated this revision to Diff 293571. DiggerLin added a comment. Herald added subscribers: llvm-commits, kbarton, hiraditya, nemanjai. Herald added a project: LLVM. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd updated this revision to Diff 293574. compnerd marked 6 inline comments as done. compnerd added a comment. Update for feedback from @aaron.ballman The `ParseAttrCommonArgs` refactoring still needs to be looked at, but this should address the feedback, and doesn't need to be predicated o

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2292-2300 + bool hasCtor = false; + for (const auto *Ctor : RD->ctors()) { if (Ctor->isTrivial() && !Ctor->isCopyOrMoveConstructor()) return false; +if (!Ctor->isCopyOrMoveConstructor()

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293577. tianshilei1992 added a comment. Rebased the source code and refined `declare_mapper_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files:

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin added a comment. In D88114#2288749 , @steven_wu wrote: > In D88114#2288737 , @mtrofin wrote: > >> In D88114#2288732 , @steven_wu >> wrote: >> >>> I am not sure what

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

steven_wu added a comment. Ok, I guess we are on the same page. The idea sounds fine to me. I would suggest just check that the output matches the input file as much as possible, rather than just check a label and a call instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D87451: add new clang option -mno-xcoff-visibility

daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + This seems like it needs the corresponding comand-

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293579. akhuang added a comment. Update ctor homing check, and add some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugIn

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. @jdoerfert Ready to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2286838 , @rjmccall wrote: > In D80344#228 , @tentzen wrote: > >> Thank you for prompt reply again. >> >>> [rjmccall] And I agree with him that the potential benefits are >>>

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, rnk, echristo. craig.topper requested review of this revision. I believe the inline asm emitted here should have a memory clobber since it writes to memory. It was also missing the dirflag clobber that we use by d

[clang] 1009229 - [Clang] Fix a typo in implicit-int-float-conversion.c

Author: Yuanfang Chen Date: 2020-09-22T16:51:23-07:00 New Revision: 10092291d7a770fee9eec8d8c7f60aeca9a8d7fb URL: https://github.com/llvm/llvm-project/commit/10092291d7a770fee9eec8d8c7f60aeca9a8d7fb DIFF: https://github.com/llvm/llvm-project/commit/10092291d7a770fee9eec8d8c7f60aeca9a8d7fb.diff

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Master branch has too many false positives for tidy - would it be possible to create a branch that contains this patch set on top of llvm-11.0-rc3? I would then add this to our internal CI. For the legacy code (see previous reports) we found quite a few false posit

[clang] 15d94a7 - Revert "Canonicalize declaration pointers when forming APValues."

Author: Leonard Chan Date: 2020-09-22T17:40:53-07:00 New Revision: 15d94a7d0f8f0d6b3b5308fff51b286957e45650 URL: https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b286957e45650 DIFF: https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b286957e45650.diff

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver updated this revision to Diff 293606. zoecarver edited the summary of this revision. zoecarver added a comment. - Add more test cases. - Fix typo. - Add codegen tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87974/new/ https://revie

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2292-2300 + bool hasCtor = false; + for (const auto *Ctor : RD->ctors()) { if (Ctor->isTrivial() && !Ctor->isCopyOrMoveConstructor()) return false; +if (!Ctor->isCopyOrMoveConstructor(

[PATCH] D88003: Fix typos in ASTMatchers.h

YangZhihui added a comment. In D88003#2287580 , @aaron.ballman wrote: > LGTM! I don't have commit access maybe you can help me commit it Thanks : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88003/new/ https://reviews.llvm.org/D88003

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm updated this revision to Diff 293625. cebowleratibm marked an inline comment as done. cebowleratibm added a comment. Added ppc64le target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 Files: clang/test/CodeGen/powerpc-c99compl

[PATCH] D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX

cebowleratibm created this revision. cebowleratibm added reviewers: ZarkoCA, daltenty, sfertile. Herald added subscribers: cfe-commits, nemanjai. Herald added a project: clang. cebowleratibm requested review of this revision. Builds on D88105 to add AIX calling c

[PATCH] D87953: [xray] Function coverage groups

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1136 + if (Opts.XRayTotalFunctionGroups < 1) { +const Arg *A = Args.getLastArg(OPT_fxray_function_groups); +Diags.Report(diag::err_drv_invalid_value) Errors here are not

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

nemanjai added a comment. In D87921#2288686 , @morehouse wrote: > The revert did not fix the PPC bots. I suspect there is some kind of > resource issue from the logs: > > msgget:: No space left on device > sysmsg.c.tmp: > /home/buildbots/ppc64le-cla

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

MaskRay added a comment. When you recommit, consider adding the header to the description. The original message started with "The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled." The header was missing. Repository: rG LLVM Github Monorepo

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

nemanjai added a comment. It turns out that the culprit for the PPC bot failures is actually https://reviews.llvm.org/rG144e57fc9535 But this just took a while to manifest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87921/new/ https://reviews.l

[clang] 47e6851 - [Analyzer][WebKit] Use tri-state types for relevant predicates

Author: Jan Korous Date: 2020-09-22T21:57:24-07:00 New Revision: 47e6851423fd32f0685a643236ad946e23ab14ff URL: https://github.com/llvm/llvm-project/commit/47e6851423fd32f0685a643236ad946e23ab14ff DIFF: https://github.com/llvm/llvm-project/commit/47e6851423fd32f0685a643236ad946e23ab14ff.diff LO

[PATCH] D88133: [Analyzer][WebKit] Use tri-state types for relevant predicates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG47e6851423fd: [Analyzer][WebKit] Use tri-state types for relevant predicates (authored by jkorous). Herald added a project

[PATCH] D88133: [Analyzer][WebKit] Use tri-state types for relevant predicates

jkorous added a comment. Created this for eventual post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88133/new/ https://reviews.llvm.org/D88133 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D88092: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. A joy of reviewing C++ code is that you get to marvel in all the great things the language has, without having to pull fistfuls of hair out to get get to that point. These patches are al

[PATCH] D88100: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yup, we've talked about this before. This is indeed a better interface design. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88100/n

[clang] d7eb917 - [PowerPC] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

Author: Albion Fung Date: 2020-09-23T01:18:14-05:00 New Revision: d7eb917a7cb793f49e16841fc24826b988dd5c8f URL: https://github.com/llvm/llvm-project/commit/d7eb917a7cb793f49e16841fc24826b988dd5c8f DIFF: https://github.com/llvm/llvm-project/commit/d7eb917a7cb793f49e16841fc24826b988dd5c8f.diff L

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *

<    1   2