[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 289085. tambre added a comment. Remove define to change driver behaviour, use ToolChain::getCompilerRTArgString() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D8687

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

nikic added a comment. Just for the record, the additional analysis has a measurable compile-time impact (0.3% at O0): https://llvm-compile-time-tracker.com/compare.php?from=e7f53044e7263cdbbb4fed9abf086b88ba486bba&to=cff6dda604cb0548bef5e5951dd1e74536110588&stat=instructions Repository: rG

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 ___ c

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre added a comment. In D86877#2248064 , @phosek wrote: > This was discussed when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` was introduced > and there was a pushback against changing the driver behavior depending on > the value of that option, so if we're

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong updated this revision to Diff 289099. martong added a comment. - Support empty ranges Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsCh

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Looks good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 __

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

martong added a comment. > Note that we don't deal with wrapping here. Wrapping? Please elaborate. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:226 + // No unsigned symbolic value can be less then a negative constant. + if (const auto SymbolicRoot =

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

martong added inline comments. Comment at: clang/test/Analysis/out-of-bounds-false-positive.c:34 + +void symbolic_uint_and_int0(unsigned len) { + (void)a[len + 1]; // no-warning Hmm, this seems to be quite redundant with the `size_t` tests. Why is it not enough

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added a comment. I'd prefer to have a couple more green lights. In particular, another look on the constraint manager and Objective C stuff would be great. Comment at: clang/docs/ReleaseNotes.rst:487 +- While still in alpha, ``alpha.unix.PthreadLock``, the iterator a

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

vsavchenko accepted this revision. vsavchenko added a comment. In D86533#2248856 , @Szelethus wrote: > I'd prefer to have a couple more green lights. In particular, another look on > the constraint manager and Objective C stuff would be great. Those part

[PATCH] D86873: [analyzer][NFC] Refactor ArrayBoundCheckerV2

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:52 + /// Offset: SymIntExpr{conj{n, int}, +, 12, long long} + class RawOffsetCalculator final + : public MemRegionVisitor { Since you are already deep in

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

steakhal added inline comments. Comment at: clang/test/Analysis/out-of-bounds-false-positive.c:34 + +void symbolic_uint_and_int0(unsigned len) { + (void)a[len + 1]; // no-warning martong wrote: > Hmm, this seems to be quite redundant with the `size_t` tests. Why

[PATCH] D86873: [analyzer][NFC] Refactor ArrayBoundCheckerV2

Szelethus added a comment. Before we dive into this too much, if you can point to discussion that explains why we have a 2 versions of the same checker, that would be nice. Why did you chose to work on this one, and not the other? I recall us talking about this in a meeting, but its always grea

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 289103. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Add further tests and extract `IgnoreImplicitConstructorSingleStep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ h

[PATCH] D86873: [analyzer][NFC] Refactor ArrayBoundCheckerV2

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:52 + /// Offset: SymIntExpr{conj{n, int}, +, 12, long long} + class RawOffsetCalculator final + : public MemRegionVisitor { martong wrote: > Since you a

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/out-of-bounds-false-positive.c:34 + +void symbolic_uint_and_int0(unsigned len) { + (void)a[len + 1]; // no-warning ste

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. I tried to run the benchmark on the small set of projects but it would take an enormous time to analyze all such projects 20 times each... Dedicating a box for this is unfeasible for me. So I stuck with analyzing only `tmux` with 20 iterations. The results are not convin

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247786 , @efriedma wrote: > > For compiler-rt, the XFAILs should probably reflect whatever config the bot > is running. (Alternatively, you could use UNSUPPORTED, but that doesn't seem > warranted here.) That's been m

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa787a4ed16d6: [analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API (authored by martong). Changed prior to commit: http

[clang] a787a4e - [analyzer][StdLibraryFunctionsChecker] Use Optionals throughout the summary API

Author: Gabor Marton Date: 2020-09-01T11:36:20+02:00 New Revision: a787a4ed16d6867f56d81159a8fcf2b711d18a8a URL: https://github.com/llvm/llvm-project/commit/a787a4ed16d6867f56d81159a8fcf2b711d18a8a DIFF: https://github.com/llvm/llvm-project/commit/a787a4ed16d6867f56d81159a8fcf2b711d18a8a.diff

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247791 , @jrtc27 wrote: > GCC on Linux defines `__sparc_v9__` even with `-m32`. I don't know what > Solaris does but please don't break other operating systems just because > Solaris has broken headers that conflate the CPU

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

steakhal added inline comments. Comment at: clang/test/Analysis/out-of-bounds-false-positive.c:34 + +void symbolic_uint_and_int0(unsigned len) { + (void)a[len + 1]; // no-warning martong wrote: > steakhal wrote: > > martong wrote: > > > Hmm, this seems to be qui

[PATCH] D86921: [FPEnv] Partially implement #pragma STDC FENV_ROUND

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, kpn, andrew.w.kaylor, steven_wu, mibintc, shafik. Herald added a subscriber: dexonsmith. Herald added a project: clang. sepavloff requested review of this revision. This change implements pragma STDC FENV_ROUND, which i

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 289111. awarzynski marked an inline comment as done. awarzynski added a comment. Update README.md with instructions for building `flang-new` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://r

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

martong added inline comments. Comment at: clang/test/Analysis/out-of-bounds-false-positive.c:34 + +void symbolic_uint_and_int0(unsigned len) { + (void)a[len + 1]; // no-warning steakhal wrote: > martong wrote: > > steakhal wrote: > > > martong wrote: > > > > Hm

[PATCH] D86721: [clang-format] Parse double-square attributes as pointer qualifiers

arichardson updated this revision to Diff 289118. arichardson added a comment. add test case with argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86721/new/ https://reviews.llvm.org/D86721 Files: clang/lib/Format/TokenAnnotator.cpp clan

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Currently a test failure always reports a line number inside v

[PATCH] D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier

arichardson updated this revision to Diff 289120. arichardson added a comment. rebase and add one more testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86775/new/ https://reviews.llvm.org/D86775 Files: clang/lib/Format/FormatToken.h clan

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289122. arichardson added a comment. fix formatting and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rst cla

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

hans added a comment. Okay, adding it to clang-cl seems fine to me. But I think it could be a simple alias? Comment at: clang/include/clang/Driver/Options.td:4693 HelpText<"Set architecture for code generation">; +def _SLASH_tune : CLCompileJoined<"tune:">, + HelpText<"Set

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro updated this revision to Diff 289128. ro added a comment. Define `__sparcv8` only on 32-bit Solaris/SPARC. Update testcase. Remove `XFAIL`s that only apply to `clang`/2-stage builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:327 +using ObjCForLctxPair = +std::pair; + martong wrote: > Why it is not enough to simply have ObjCForCollectionStmt* as a key? `Environment` is the data structure we

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: x = (STACK_OF(uint64_t)) & a; After: x = (STACK_OF(ui

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 added a comment. Actually, `__sparcv8` is only for V8; if you have 32-bit V9 on Solaris it defines `__sparcv8plus` _instead_: jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 -xdumpmacros &1 | grep sparc #define __sparcv8plus 1 #define __sparc 1 #define s

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85743#2244839 , @leonardchan wrote: >> The IR differences were caused by the new pass manager which is on by >> default for the Fuchsia builder. I've re-landed the patch with a fix for >> `CodeGen/attr-arm-sve-vector-bits-ca

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2249240 , @jrtc27 wrote: > Actually, `__sparcv8` is only for V8; if you have 32-bit V9 on Solaris it > defines `__sparcv8plus` _instead_: > > jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 > -xdu

[clang] 2114f71 - [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

Author: Yang Fan Date: 2020-09-01T08:45:38-04:00 New Revision: 2114f71aaa8dc2e75fe9cd79aa4d72d164e9b95d URL: https://github.com/llvm/llvm-project/commit/2114f71aaa8dc2e75fe9cd79aa4d72d164e9b95d DIFF: https://github.com/llvm/llvm-project/commit/2114f71aaa8dc2e75fe9cd79aa4d72d164e9b95d.diff LOG:

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2114f71aaa8d: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (authored by nullptr.cpp, committed by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan updated this revision to Diff 289148. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Thanks Hubert, I removed the lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Introduce a new diagnostic, and respect the bracket-depth (256) by default. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86936 Files:

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Confirming LGTM. @abhina.sreeskantharajan, it seems that you have a good number of commits to the project (I see at least three). If you do not yet have commit access, it may be appropriate to request it now s

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

fghanim added a comment. In D85619#2248195 , @kiranchandramohan wrote: > What is the plan for this patch? Waiting on you to review it ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85619/new/ https://re

[clang] 5a3ede5 - [NFC] Test commit, whitespace changes

Author: Abhina Sreeskantharajan Date: 2020-09-01T09:55:01-04:00 New Revision: 5a3ede58e2c1df53cf1f74d2b8c4916c4a974b0b URL: https://github.com/llvm/llvm-project/commit/5a3ede58e2c1df53cf1f74d2b8c4916c4a974b0b DIFF: https://github.com/llvm/llvm-project/commit/5a3ede58e2c1df53cf1f74d2b8c4916c4a97

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim added a comment. In D79677#2248663 , @lebedev.ri wrote: > Tests missing I am not sure what to test here that isn't tested elsewhere in the series. This patch is the last in a series, and it represents the "usage" of the functionality added by th

[PATCH] D86926: FormatTest: Provide real line number in failure messages

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:69 - void verifyFormat(llvm::StringRef Expected, llvm::StringRef Code, -const FormatStyle &Style = getLLVMStyle()) { + void _verifyFormat(const char *File, int Line, ll

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

MyDeveloperDay added a comment. I'm wondering if this could be used to help the CUDA usages of clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 ___ cf

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:69 - void verifyFormat(llvm::StringRef Expected, llvm::StringRef Code, -const FormatStyle &Style = getLLVMStyle()) { + void _verifyFormat(const char *File, int Line, llvm:

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson added a comment. In D86782#2249399 , @MyDeveloperDay wrote: > I'm wondering if this could be used to help the CUDA usages of clang-format Do you have any examples that are not formatted sensibly? I was also considering adding another list fo

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. The documentation currently shows `__capability` being included, but from looking at this patch does the configuration file not append (which I think makes sense, at least for `__cap

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 289161. tambre added a comment. Rework patch to simply cleanup runtime handling in the bare-metal toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 Files: cla

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13966 if (index.isUnsigned() || !index.isNegative()) { -// It is possible that the type of the base expression after -// IgnoreParenCasts is incomplete, even though the type of the base -//

[clang] 3e1e5f5 - [SystemZ][z/OS] Adding initial toolchain for z/OS

Author: Abhina Sreeskantharajan Date: 2020-09-01T10:15:01-04:00 New Revision: 3e1e5f54492d5bdebd40388247254e310cf62c3d URL: https://github.com/llvm/llvm-project/commit/3e1e5f54492d5bdebd40388247254e310cf62c3d DIFF: https://github.com/llvm/llvm-project/commit/3e1e5f54492d5bdebd40388247254e310cf6

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1e5f54492d: [SystemZ][z/OS] Adding initial toolchain for z/OS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/ne

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre added a comment. @phosek Please review again. I've overhauled the patch as I realized that per-target runtime directories don't make sense for the bare-metal target, since the runtime is only distinguished by the //specific// architecture and nothing else. As a result I've simply changed

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx marked an inline comment as done. chrish_ericsson_atx added a comment. I will tinker with the math to simplify as you suggest. Working with APInt and APSInt seems to promulgate sensitive and brittle code, which makes trying alternative expressions more tedious than I'd like

[PATCH] D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

bsaleil accepted this revision. bsaleil added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86795/new/ https://reviews.llvm.org/D86795 __

[clang] c831a14 - [SystemZ][z/OS] Fix build break in z/OS toolchain

Author: Abhina Sreeskantharajan Date: 2020-09-01T10:40:10-04:00 New Revision: c831a14aa16a74fa94c94a351a4bc7812a8bd166 URL: https://github.com/llvm/llvm-project/commit/c831a14aa16a74fa94c94a351a4bc7812a8bd166 DIFF: https://github.com/llvm/llvm-project/commit/c831a14aa16a74fa94c94a351a4bc7812a8b

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

hokein added a comment. thanks, the current behavior looks nicer than before. IIUC, you're mostly fixing the issues mentioned in https://github.com/clangd/vscode-clangd/pull/44#issuecomment-669092168. If it just contains two fixes (this, and https://reviews.llvm.org/D86424), I think it might m

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

ldionne accepted this revision. ldionne added a comment. This LGTM, but I agree someone should sign off on whether `__has_feature` is the right approach here. @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https://review

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson added a comment. In D86782#2249408 , @jrtc27 wrote: > The documentation currently shows `__capability` being included, but from > looking at this patch does the configuration file not append (which I think > makes sense, at least for `__capab

[PATCH] D86941: [clang-format] Add a test showing the current config file list parsing

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius, jrtc27. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Currently clang-format starts overriding the default v

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

ASDenysPetrov added inline comments. Comment at: clang/docs/ReleaseNotes.rst:453 + equal or known to be non-equal. + +- Added :ref:`on-demand parsing ` capability to Cross Translation I've added the patch "Reasoning about comparison expressions in RangeConstra

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289167. arichardson added a comment. - fix name of key in config file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rs

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23 using clang::tooling::toReplacements; +using testing::internal::ScopedTrace; This is an internal class in the current gtest.h, but upstream has now included it in the publ

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289180. arichardson added a comment. - Add test for config parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

ldionne added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + This isn't great, since it won't run on clang-12, etc. I'll change it to: ``` // UNSUPPORTED: clang-4, clang-5, clang-6, clang-7, clang-8, clang-9

[PATCH] D86926: FormatTest: Provide real line number in failure messages

arichardson updated this revision to Diff 289181. arichardson added a comment. - fix missing argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86926/new/ https://reviews.llvm.org/D86926 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:483 bool GapRegion = CR.value().Kind == CounterMappingRegion::GapRegion; if (CR.index() + 1 == Regions.size() || zequanwu wrote: > vsk wrote: > > zequanwu wro

[PATCH] D86950: [clang-format] Check that */& after typename macros are pointers/references

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Depends on D86930 (Fix the a

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

jtmott-intel added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + ldionne wrote: > This isn't great, since it won't run on clang-12, etc. I'll change it to: > > ``` > // UNSUPPORTED: clang-4, clang-5, clang-

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8649

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

lalovic added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86707/new/ https://reviews.llvm.org/D86707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 289190. ASDenysPetrov added a comment. Added //timed// functions support and tests for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85984/new/ https://reviews.llvm.org/D85984 Files: clang/include/clang/StaticAnalyzer/Checkers/Checker

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

ldionne added inline comments. Comment at: libcxx/test/libcxx/atomics/ext-int.verify.cpp:1 +// REQUIRES: clang-11 + jtmott-intel wrote: > ldionne wrote: > > This isn't great, since it won't run on clang-12, etc. I'll change it to: > > > > ``` > > // UNSUPPORTED:

[PATCH] D85031: [builtins] Unify the softfloat division implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e90d8d4fed8: [builtins] Unify the softfloat division implementation (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. In D62574#2242471 , @Anastasia wrote: > The only thing is that it would be good to test the new target setting logic > somehow... do you have any ideas in mind? We could think of creating a dummy > target for that or adding a dum

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

nridge added a comment. In D86861#2249490 , @hokein wrote: > IIUC, you're mostly fixing the issues mentioned in > https://github.com/clangd/vscode-clangd/pull/44#issuecomment-669092168. If it > just contains two fixes (this, and https://reviews.llvm.org/

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen added a comment. In D85676#2245787 , @asbirlea wrote: > Seems like a good idea. I'm curious if you saw any impact from this change. Yeah, I'm curious too but I didn't measure it yet. What's the recommended ways to measure it? Repository: rG LLV

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

martong added a comment. I don't have anymore immediate concerns, but I will need more time to comb through the rest of the patch in more details... hopefully I can do that in the following days. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:327 +using ObjCForLct

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson created this revision. tejohnson added a reviewer: hans. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. tejohnson requested review of this revision. This adds documentation for the options added / changed by D71913

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

MaskRay added inline comments. Comment at: lld/docs/ReleaseNotes.rst:29 (`D77231 `_) -* ``--lto-whole-program-visibility`` is added to support LTO whole-program devirtualization. +* ``--lto-whole-program-visibility`` is added to specify that c

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus added a comment. In D86736#2249920 , @martong wrote: > I don't have anymore immediate concerns, but I will need more time to comb > through the rest of the patch in more details... hopefully I can do that in > the following days. Thank you so

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. Before: _Atomic(uint64_t) * a; After: _Atomic(uint64_t) *a

[PATCH] D86960: [clang-format] Parse __underlying_type(T) as a type

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. Before: MACRO(__underlying_type(A) * a); After: MACRO(__u

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2243575 , @staffantj wrote: > As one of the SG14 industry members driving this, I'm firmly in the camp that > this is what we're expecting. In the first case the 1/2 case are "neutral". > This is a very explicit,

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2250034 , @aaron.ballman wrote: > In D86559#2243575 , @staffantj wrote: > >> As one of the SG14 industry members driving this, I'm firmly in the camp >> that this is what we're

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Serialization/ASTReader.cpp:8395 +for (unsigned Idx = 0, N = LateParsed.size(); Idx < N; + /* In loop */) { + FunctionDecl *FD

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

bruno added inline comments. Comment at: clang/test/Modules/explicit-module-maps.cpp:4 + +// RUN: %clang_cc1 -fmodule-map-file=%S/Inputs/explicit-module-maps/invalid.modulemap -verify %s +// expected-no-diagnostics Minor suggestion here given the content of the

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2250106 , @staffantj wrote: > In D86559#2250034 , @aaron.ballman > wrote: > >> In D86559#2243575 , @staffantj >> wrote: >> >>> As o

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1693 +The attributes are used to aid the compiler to determine which branch is +likely or unlikely to be taken. This is done by marking the first statement in +the branch with one of the two at

[PATCH] D86721: [clang-format] Parse double-square attributes as pointer qualifiers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86721/new/ https://reviews.llvm.org/D86721 __

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added a comment. bumping for review. Are there additional reviewers we could add to share the burden? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86508/new/ https://reviews.llvm.org/D86508 ___

[PATCH] D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. A recent change increased the stack size of memoizedMatchesAncestorOfRecursively leading to stack overflows on re

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

arichardson added a comment. In D86713#2242381 , @arichardson wrote: > In D86713#2242354 , @JakeMerdichAMD > wrote: > >> In D86713#2242300 , @arichardson >> wrote: >> >>> I

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg updated this revision to Diff 289236. andrewjcg added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Modules/e

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson updated this revision to Diff 289235. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/CodeGen/CG

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

bruno added reviewers: rsmith, v.g.vassilev. bruno added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:870 + // definition (which is required for `setPure`). + const bool pure = Record.readInt(); FD->setHasInheritedPrototype(Record.readInt()); --

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson updated this revision to Diff 289238. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86958/new/ https://reviews.llvm.org/D86958 Files: clang/docs/ReleaseNotes.rst lld/docs/ReleaseNotes.rst

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

dyung created this revision. dyung added a reviewer: probinson. dyung added a project: clang. dyung requested review of this revision. For the PS4, do not emit "-tune-cpu generic" since the platform only has 1 known CPU and we do not want to prevent optimizations by tuning for a generic rather t

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93eed63d2f31: [builtins] Make __div[sdt]f3 handle denormal results (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE L

  1   2   >