[PATCH] D86757: Improved suggestions from code review and clang-tidy. 1) Add keyword `const` to variables which checked via clang-tidy. 2) Add log to clang-tools-extra/docs/ReleaseNotes.rst. [Euge

2020-08-27 Thread Douglas Chen via Phabricator via cfe-commits
dougpuob created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. dougpuob requested review of this revision. ...ot. [Eugene.Zelenko] ...specified explicitly. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86757 Files: clang-tools-extra/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

2020-08-27 Thread Douglas Chen via Phabricator via cfe-commits
dougpuob updated this revision to Diff 288520. dougpuob added a comment. Herald added a subscriber: mgehre. Improved suggestions from code review and clang-tidy. 1. Add keyword `const` to variables which checked via clang-tidy. 2. Add log to clang-tools-extra/docs/ReleaseNotes.rst. [Suggestion fr

[PATCH] D86000: Add an unsigned shift base sanitizer

2020-08-27 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG82d29b397bb2: Add an unsigned shift base sanitizer (authored by jfb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D860

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

2020-08-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. It'll be good idea to add test case. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +* Added: Add IdentifierNamingCheck::CaseType, CT_HungarianNotation, supporting naming check with Hungarian notation. + Please move to

[PATCH] D86763: RedeclarePropertyAccessor (clang/lib/Sema/SemaObjCProperty.cpp shipped with https://reviews.llvm.org/rG2073dd2da702baca447efaf1879cb6151e8c6100) create a synthesized property accessor

2020-08-27 Thread 酷酷的哀殿 via Phabricator via cfe-commits
sunbohong created this revision. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. sunbohong requested review of this revision. ...metadata in RewriteModernObjC.cpp. This commit will fix https://bugs.llvm.org/show_bug.cgi?id=47330 . Repository: rG LLVM Github Monor

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

2020-08-27 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. In D77925#2236519 , @tejohnson wrote: > In D77925#2229484 , @mehdi_amini > wrote: > >> Overall that would likely work for XLA. Something I'd like to mention though >> in response to: >> >>>

<    1   2   3