[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX updated this revision to Diff 284987. ArcsinX added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85193/new/ https://reviews.llvm.org/D85193 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/init-invalid-stru

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

eduucaldas updated this revision to Diff 284988. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. use arguments instead of children Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85750/new/ https://reviews.llvm.org/D85750 Fi

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1024 + // representation of built-in and user-defined operators. + if (child->getBeginLoc() == S->getOperatorLoc()) +continue; gribozavr2 wrote: > eduucaldas wr

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

hokein added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4582 +if (isLeftFold()) + return getEllipsisLoc(); +return getLHS()->getBeginLoc(); nridge wrote: > Can this case (left fold and no parenthesis) ever happen? It would be > i

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc7b1e9db581: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang] dc7b1e9 - [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

Author: Haojian Wu Date: 2020-08-12T09:20:23+02:00 New Revision: dc7b1e9db58152273d3232cca3fa95cef721796b URL: https://github.com/llvm/llvm-project/commit/dc7b1e9db58152273d3232cca3fa95cef721796b DIFF: https://github.com/llvm/llvm-project/commit/dc7b1e9db58152273d3232cca3fa95cef721796b.diff LO

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

vsavchenko added a comment. Awesome, thanks! Bt, maybe we can use `\ref` form, it looks like it's a preferred form in the codebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85105/new/ https://reviews.llvm.org/D85105 ___ cfe-commits

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

OikawaKirie updated this revision to Diff 284991. OikawaKirie added a comment. Ok, I got it. I will pay attention to this in the future submits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85105/new/ https://reviews.llvm.org/D85105 Files: clang/include/clang/StaticAnalyzer/Core/Bug

[PATCH] D84886: Create LoopNestPass

fhahn added a comment. In D84886#2212202 , @TaWeiTu wrote: > @ychen Again, thanks for your comment! > > 1. Currently, `LoopInterchange` returns immediately if the loop is not a > top-level one. The main purpose of the loop nest pass is to prevent > situa

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 284995. hokein added a comment. rebase and adjust more existing diagnostic tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInv

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added a comment. > As you said, we can't land this before the branch cut, and we shouldn't land > this until we've run internal experiments to show it's not horribly crashy. The internal experiment result is good, I think we're close to land it. After a new rebase, we need to adjust more

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:265 + SmallVector CastToTyVec; + for (unsigned idx = 0; idx < FD->getTemplateSpecializationArgs()->size() - 1; + ++idx) { Do we intentionally skip the last

[clang] ac37afa - [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

Author: Eduardo Caldas Date: 2020-08-12T08:01:18Z New Revision: ac37afa650271d8366b706d79ff8e217fc624cbb URL: https://github.com/llvm/llvm-project/commit/ac37afa650271d8366b706d79ff8e217fc624cbb DIFF: https://github.com/llvm/llvm-project/commit/ac37afa650271d8366b706d79ff8e217fc624cbb.diff LOG

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rGac37afa65027: [SyntaxTree] Unbox operators into tokens for nodes generated from… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8575

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clan

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

whisperity added a comment. @baloghadamsoftware Maybe there is a typo in the summary of the patch > then `&B` //is a// `&B` Shouldn't this be "&A is a &B"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85752/new/ https://reviews.llvm.org/D85752

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84932/new/ https://reviews.llvm.org/D84932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We do that because: - Big tests generated big tree dumps that could hardly serve as documentation. - In most cases the tests didn't share setup, t

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko added a comment. On linter diagnostics: error messages are due to linter trying to lint `*.inc` file that is not self-contained by design. D85731: [builtins] Make softfloat-related errors less noisy tries to make those errors more meaningful, at lea

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. Before we had an UnqualifiedId test that tested for everything in the grammar . Now we just split this test and test the alternatives separately. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:6

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added a subscriber: ilya-biryukov. Fixes https://github.com/clangd/clangd/issues

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285035. eduucaldas added a comment. Split tests for `UserDefinedLiteral` Split tests for `NumericUserDefinedLiteral` Split tests for `NestedBinaryOperator` Split tests for `UserDefinedBinaryOperator` Split tests for `UserDefinedPrefixOperator` Repository:

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

baloghadamsoftware updated this revision to Diff 285036. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85752/new/ https://reviews.llvm.org/D85752 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp cla

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:73 +Ty = STTPTy->getReplacementType(); + if (Ty->isPointerType()) +Ty = Ty->getPointeeType(); xazax.h

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); kadircet wrote: > can'

[clang-tools-extra] 35bee35 - [clang-tidy] prevent generated checks from triggering assertions on anonymous functions

Author: Bogdan Serea Date: 2020-08-12T12:43:40+01:00 New Revision: 35bee3503f4c33d92434a314e49e3e6f4f7419bc URL: https://github.com/llvm/llvm-project/commit/35bee3503f4c33d92434a314e49e3e6f4f7419bc DIFF: https://github.com/llvm/llvm-project/commit/35bee3503f4c33d92434a314e49e3e6f4f7419bc.diff

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rG35bee3503f4c: [clang-tidy] prevent generated checks from triggering assertions on anonymous… (authored by bogser01, committed by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D85218?vs

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added a comment. In D76211#2212203 , @jdoerfert wrote: > Are you planning to add support for the actual OpenMP selectors as well? > All the other traits, scoring, etc. I left a comment below that points you to > the right place as we ha

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

jdoerfert added a comment. In D82317#2211643 , @guiand wrote: > After discussing with @eugenis, for the meantime it might be best to do the > following: > > - Change the masking attribute to be `-fdisable-noundef-analysis` (name > notwithstanding), and h

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG31e5f7120bdd: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2203887 , @lxfind wrote: > In D79219#2201415 , @phosek wrote: > >> This is correct. That target is provided by `find_package(ZLIB)`. In >> LLVMConfig.cmake, we invoke `find_package

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added a comment. Great, one benefit of this is that zlib can now be detected in non-system libs. Maybe we should handle ncurses / TERMINFO in a similar manner? It currently has similar logic as finding zlib had Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 284931. guiand added a comment. Made the compiler flag non-public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. @phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well. Thank you for the extra work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

baloghadamsoftware updated this revision to Diff 285047. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85728/new/ https://reviews.llvm.org/D85728 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp cla

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

sberg added a comment. Fixes all the false positives it had reported for LibreOffice (which had all involved expressions containing either ~ or +). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85778/new/ https://reviews.llvm.org/D85778 _

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:270-272 +default: + llvm_unreachable("Invalid template argument for isa<> or " + "isa_a

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

aaron.ballman added a comment. I have a suggestion for the added comment, but I also forgot to ask, do you need someone to commit on your behalf? Comment at: clang/lib/Sema/SemaInit.cpp:3094 +// This initializer overwrites a previous initializer. +// Emit warning if `e

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 285057. balazske added a comment. Improved comments, code clean-up. Improved detection of explicit cast to void. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files:

[PATCH] D85834: [AST] Fix a crash on calling getASTRecordLayout on an invalid RecordDecl.

hokein created this revision. hokein added reviewers: sammccall, rsmith. Herald added a project: clang. hokein requested review of this revision. The getASTRecordLayout method requires a valid decl. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85834 Files: clang/lib/AST/AS

[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks for your work! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:190 void test_notnull_symbolic2(FILE *fp, int *buf) { - if (!buf) //

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); adamcz wrote: > kadi

[PATCH] D85834: [AST] Fix a crash on calling getASTRecordLayout on an invalid RecordDecl.

hokein added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2463 -unsigned PreferredAlign = static_cast( -toBits(getASTRecordLayout(RT->getDecl()).PreferredAlignment)); -assert(PreferredAlign >= ABIAlign && - "PreferredAlign should be at lea

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

hansec removed a reviewer: hansec. hansec added a comment. I think I was added to this in error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits m

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); kadircet wrote: > adam

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2210255 , @balazske wrote: > More results in CodeChecker: emacs_errorreturn >

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2199333 , @balazske wrote: > Test results for tmux are available here >

[PATCH] D85543: Limit Max Vector alignment on COFF targets to 8192

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4bc1cb7978: Limit Max Vector alignment on COFF targets to 8192. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] aa4bc1c - Limit Max Vector alignment on COFF targets to 8192.

Author: Erich Keane Date: 2020-08-12T06:35:35-07:00 New Revision: aa4bc1cb7978b87bdbdb75910da0abbd27889800 URL: https://github.com/llvm/llvm-project/commit/aa4bc1cb7978b87bdbdb75910da0abbd27889800 DIFF: https://github.com/llvm/llvm-project/commit/aa4bc1cb7978b87bdbdb75910da0abbd27889800.diff L

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec9563c54ed2: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks. (authored by ABataev). Repository: rG LLVM Github Monorepo

[clang] ec9563c - [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

Author: Alexey Bataev Date: 2020-08-12T09:37:24-04:00 New Revision: ec9563c54ed25e9f9cbe60985399212d50bd801d URL: https://github.com/llvm/llvm-project/commit/ec9563c54ed25e9f9cbe60985399212d50bd801d DIFF: https://github.com/llvm/llvm-project/commit/ec9563c54ed25e9f9cbe60985399212d50bd801d.diff

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah I think this is the right approach for now, because the cached modules don't include diagnostics and ensuring that they're persisted and available is a larger project. ==

[PATCH] D85826: [clang] Make signature help work with dependent args

hokein added a comment. This looks like a nice improvement. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1212 + R"cpp( +int foo(int a, int b); +template void bar(T t) { These tests are nice. But we're changing Sema

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:270-272 +default: + llvm_unreachable("Invalid template argument for isa<> or " + "isa_and_nonnull<>"); baloghadamsoftware wrote: > NoQ

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79431/new/ https://reviews.llvm.org/D79431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 3651658 - Revert "[OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks."

Author: Alexey Bataev Date: 2020-08-12T09:50:32-04:00 New Revision: 3651658bdd11a085b727783f27495a198c4f3bc5 URL: https://github.com/llvm/llvm-project/commit/3651658bdd11a085b727783f27495a198c4f3bc5 DIFF: https://github.com/llvm/llvm-project/commit/3651658bdd11a085b727783f27495a198c4f3bc5.diff

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285070. eduucaldas added a comment. - [SyntaxTree] Split tests for `QualifiedId` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Syn

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285071. eduucaldas added a comment. Rename tests following `TestSuite_TestCase` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Synt

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1005 + +TEST_P(SyntaxTreeTest, QualifiedIdWithNamespace) { + if (!GetParam().isCXX()) { Here I didn't merely split the tests, I also changed them a bit. PTAL. ==

[PATCH] D84886: Create LoopNestPass

Whitney added a comment. Examples of existing transformations that can be benefited from LoopNestPass: LoopInterchange, LoopUnrollAndJam, LoopFusion, LoopIdiom, LoopDistribution, ... And their corresponding cost model analyses can be benefited from LoopNestAnalysis, e.g. LoopCacheCost. Reposi

[clang] ddbd21d - [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

Author: Alexey Bataev Date: 2020-08-12T10:06:52-04:00 New Revision: ddbd21d288f6ff7d175f18ddee0ee6407626445a URL: https://github.com/llvm/llvm-project/commit/ddbd21d288f6ff7d175f18ddee0ee6407626445a DIFF: https://github.com/llvm/llvm-project/commit/ddbd21d288f6ff7d175f18ddee0ee6407626445a.diff

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGddbd21d288f6: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D85755?vs=284806&id=285074#toc Repo

[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbe234e4e7: [analyzer] StdLibraryFunctionsChecker: Add support for new functions (authored by zukatsinadze). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 25bbe23 - [analyzer] StdLibraryFunctionsChecker: Add support for new functions

Author: Zurab Tsinadze Date: 2020-08-12T16:20:00+02:00 New Revision: 25bbe234e4e73e6345f4f0b61e680abf5a90d59f URL: https://github.com/llvm/llvm-project/commit/25bbe234e4e73e6345f4f0b61e680abf5a90d59f DIFF: https://github.com/llvm/llvm-project/commit/25bbe234e4e73e6345f4f0b61e680abf5a90d59f.diff

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = njames93 wrote: > Return by StringRef?

[PATCH] D85834: [AST] Fix a crash on calling getASTRecordLayout on an invalid RecordDecl.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:2463 -unsigned PreferredAlign = static_cast( -toBits(getASTRecordLayout(RT->getDecl()).PreferredAlignment));

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith, the patch is ready for another round of review. Would be nice to have it in clang11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:73 + // If the variable has an alias then it can be changed by that alias as well. + // FIXME: Track pointers and references. + if (hasPtrOrReferenceInFunc(Func,

[clang] 3c8a4ee - [OpenCL] Remove warning for variadic macros in C++ for OpenCL.

Author: Anastasia Stulova Date: 2020-08-12T16:17:54+01:00 New Revision: 3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8 URL: https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8 DIFF: https://github.com/llvm/llvm-project/commit/3c8a4ee0764cafb2ba204c7cb7d8b37e6adf72a8.d

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8a4ee0764c: [OpenCL] Remove warning for variadic macros in C++ for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:73 + // If the variable has an alias then it can be changed by that alias as well. + // FIXME: Track pointers and references. + if (hasPtrOrReferenceInFunc(Func, Cond

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

whisperity added a comment. In D72705#2210255 , @balazske wrote: > More results in CodeChecker: emacs_errorreturn >

[clang] f4f3f67 - [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

Author: Alexey Bataev Date: 2020-08-12T11:28:19-04:00 New Revision: f4f3f678f1994d47f745cbfd6a1026f2408425c6 URL: https://github.com/llvm/llvm-project/commit/f4f3f678f1994d47f745cbfd6a1026f2408425c6 DIFF: https://github.com/llvm/llvm-project/commit/f4f3f678f1994d47f745cbfd6a1026f2408425c6.diff

[clang] fbd6d2c - [OPENMP] Fix PR47063: crash when trying to get captured statetment.

Author: Alexey Bataev Date: 2020-08-12T12:05:58-04:00 New Revision: fbd6d2c54e57a4968d29bb22742dd49759b3ecd0 URL: https://github.com/llvm/llvm-project/commit/fbd6d2c54e57a4968d29bb22742dd49759b3ecd0 DIFF: https://github.com/llvm/llvm-project/commit/fbd6d2c54e57a4968d29bb22742dd49759b3ecd0.diff

[PATCH] D68720: Support -fstack-clash-protection for x86

sberg added a comment. I filed https://bugs.llvm.org/show_bug.cgi?id=47139 "Misspelled -fnostack-clash-protection" now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84908/new/ https://reviews.llvm.org/D84908 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] fc915d1 - [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests

Author: Erik Pilkington Date: 2020-08-12T12:12:10-04:00 New Revision: fc915d13b8671ceddea06e3f2f2d0e18869c41fe URL: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe DIFF: https://github.com/llvm/llvm-project/commit/fc915d13b8671ceddea06e3f2f2d0e18869c41fe.dif

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

ArcsinX updated this revision to Diff 285101. ArcsinX added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85193/new/ https://reviews.llvm.org/D85193 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/init-invalid-struct-

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2040 + +if (ConstStructTimevalPtrTy && StructTimespecPtrTy) + // int nanosleep(const struct timespec *rqtp, struct timespec *rmtp); Should be `C

[PATCH] D85193: [clang] Check `expr` inside `InitListChecker::UpdateStructuredListElement()`

ArcsinX added a comment. In D85193#2212976 , @aaron.ballman wrote: > I have a suggestion for the added comment, Fixed comment according to your suggestion. > but I also forgot to ask, do you need someone to commit on your behalf? I already have commit

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. In D72705#2213300 , @whisperity wrote: > In D72705#2210255 , @balazske wrote: > >> More results in CodeChecker: emacs_errorreturn >>

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. >From the documentation comment above >`NestedNameSpecifierLoc::getLocalSourceRange()` /// Retrieve the source range covering just the last par

[PATCH] D85843: Add "status" to the list of absl libraries.

oontvoo created this revision. oontvoo added a reviewer: sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. oontvoo requested review of this revision. The Abseil-NoInternalDependenciesCheck currently mistakenly triggers on any usage of internal helpers even if it is wi

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

xbolva00 created this revision. xbolva00 added a reviewer: sberg. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. xbolva00 requested review of this revision. Clang command line docs mention `-fno-stack-clash-protection`, and GCC also uses -fno-stack-clash-protection.

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

NoQ added a comment. That's a fix for https://bugs.llvm.org/show_bug.cgi?id=46264. Your code looks great but i don't understand at a glance what the crash was caused by and how does your code fix it, can you explain? Like, the original test doesn't have any `void *`s and it doesn't have any ind

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85844/new/ https://reviews.llvm.org/D85844

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285116. kadircet added a comment. - Add tests into clang-lit - Make sure current number of args is less than overloads param count. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285117. kadircet marked 2 inline comments as done. kadircet added a comment. - Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm.org/D85826 Files: clang-tools

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3bfaa39071: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection (authored by xbolva00). Repository: rG LLVM Github Monore

[clang] df3bfaa - [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

Author: Dávid Bolvanský Date: 2020-08-12T18:36:26+02:00 New Revision: df3bfaa39071a1382a59a94658ee1a2da30d92fd URL: https://github.com/llvm/llvm-project/commit/df3bfaa39071a1382a59a94658ee1a2da30d92fd DIFF: https://github.com/llvm/llvm-project/commit/df3bfaa39071a1382a59a94658ee1a2da30d92fd.dif

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285122. eduucaldas added a comment. Don't assume the code is completely correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpec

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

thakis added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:390 +for nameless_value in nameless_values: +if re.fullmatch(nameless_value.ir_prefix + r'[0-9]+?', var, re.IGNORECASE): +warn("Change IR value name '%s' to prevent possible c

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added inline comments. Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:3457 + if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation())) +Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect"); + rnk wrote: > Clang gener

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285129. eduucaldas added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5573 + // performing any semantic checks on availability. That's to improve user + // experience, it is better to see all overloads rather than none. + if (Expr::hasAnyTypeDependentArguments(Args))

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

miyuki added a comment. For intrinsics that are plain functions (not macros) you could just check the signatures using assignments to function pointers, e.g.: #include uint16_t (*fp1)(int32_t) = &vqmovuns_s32; $ clang -target=aarch64-arm-none-eabi -march=armv8-a+simd -c neon.c -fsynta

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 285124. c-rhodes added a comment. Added missing implicit conversions for C++. I considered handling this with the existing implicit vector conversion although one side of the conversion will be an SVE builtin, so instead I've added a new conversion specifical

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas added a comment. Unit tests will be provided once we decide that this is the way to go ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 ___ cfe-commi

  1   2   >