[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31 utils::IncludeSorter::IS_LLVM)), -

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

hokein updated this revision to Diff 284592. hokein marked an inline comment as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85645/new/ https://reviews.llvm.org/D85645 Files: clang/include/

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

hokein added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4587 + return RParenLoc; +return getPattern()->getEndLoc(); + } nridge wrote: > Wouldn't `EllipsisLoc` be more accurate? yeah, that sounds more reasonable. Repository: rG LL

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein added a comment. In D85635#2208325 , @nridge wrote: > Do you mean "inactive" (instead of "interactive") in the commit message? oh, right. Fixed the typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

Re: [clang] 6170072 - Improve modeling of variable template specializations with dependent

On Sun, 9 Aug 2020, Richard Smith via cfe-commits wrote: Author: Richard Smith Date: 2020-08-09T23:22:26-07:00 New Revision: 617007240cbfb97c8ccf6d61b0c4ca0bb62d43c9 URL: https://github.com/llvm/llvm-project/commit/617007240cbfb97c8ccf6d61b0c4ca0bb62d43c9 DIFF: https://github.com/llvm/llvm-p

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added a comment. Thanks for feedback:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. rsmith requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. C++ permits use of (cond ? x.a : y.b) as an

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

rsmith updated this revision to Diff 284594. rsmith added a comment. - Remove development aid from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85710/new/ https://reviews.llvm.org/D85710 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/C

Re: [clang] 6170072 - Improve modeling of variable template specializations with dependent

On Tue, 11 Aug 2020 at 00:29, Martin Storsjö wrote: > On Sun, 9 Aug 2020, Richard Smith via cfe-commits wrote: > > > > > Author: Richard Smith > > Date: 2020-08-09T23:22:26-07:00 > > New Revision: 617007240cbfb97c8ccf6d61b0c4ca0bb62d43c9 > > > > URL: > https://github.com/llvm/llvm-project/commit/

[clang-tools-extra] c6d2078 - [clangd] Improve diagnostics in dexp interface

Author: Kirill Bobyrev Date: 2020-08-11T09:50:33+02:00 New Revision: c6d2078a35d536c8fa152fa9205924f8f10cbaac URL: https://github.com/llvm/llvm-project/commit/c6d2078a35d536c8fa152fa9205924f8f10cbaac DIFF: https://github.com/llvm/llvm-project/commit/c6d2078a35d536c8fa152fa9205924f8f10cbaac.diff

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Githu

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ugh, I forgot to hit submit and went on vacation :-\ Really sorry again. As much as we can simplify/unify the tests that helps, but let's not block on this anymore, up to you. ===

[clang] 497d060 - [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

Author: Balázs Kéri Date: 2020-08-11T10:10:13+02:00 New Revision: 497d060d0a741e13dd5e6218ba7301a7ec96f332 URL: https://github.com/llvm/llvm-project/commit/497d060d0a741e13dd5e6218ba7301a7ec96f332 DIFF: https://github.com/llvm/llvm-project/commit/497d060d0a741e13dd5e6218ba7301a7ec96f332.diff L

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG497d060d0a74: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added a comment. 6 findings in the //LLVM Project//. All of them confirmed as trues positives, 5 of them already fixed. Fix pending for the last one. D82555 , D8556 , D82557 , D

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

arichardson accepted this revision. arichardson added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85099/new/ https://reviews.llvm.org/D85099 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D85713: [SyntaxTree]: Use Annotations in tests to reduce noise

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85713 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittest

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:387 + !llvm::StringRef(ProjectRoot).endswith(llvm::sys::path::get_separator())) +ProjectRoot += llvm::sys::path::get_separator(); + Instead of handling this in all

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov added a comment. @NoQ > Umm, why don't you extend `PthreadLockChecker` instead? First of all I wanted to try to go through all the steps, since it's my first checker. The second is that I considered `PthreadLockChecker` designed for C-functions. Another reason is that it better h

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

sberg added a comment. I think this generates a false positive with `test.cc` enum E { E1 = 1, E2 = 2 }; bool f(E e) { return ((e & E1) ? 1 : 0) + ((e & E2) ? 1 : 0) > 1; } and `clang++ -fsyntax-only -Wtautological-value-range-compare test.cc` test.cc:2:62: warning: result of comparison o

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284609. kbobyrev marked an inline comment as done. kbobyrev added a comment. Handle slash appending in Marshaller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 File

[PATCH] D85713: [SyntaxTree]: Use Annotations in tests to reduce noise

eduucaldas updated this revision to Diff 284610. eduucaldas added a comment. Use unsigned long in the loop index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85713/new/ https://reviews.llvm.org/D85713 Files: clang/unittests/Tooling/Syntax/TreeT

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284611. kbobyrev added a comment. Remove redundant `.str()` calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 Files: clang-tools-extra/clangd/index/remote/Clien

[PATCH] D85713: [SyntaxTree]: Use Annotations in tests to reduce noise

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. A proposition, upon review I'll change other tests. One concern is that we might lose coverage while reducing noise. But I'll take a look into that with calm when changing the tests. Comment at: clang/unitte

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX updated this revision to Diff 284612. ArcsinX added a comment. Check for `expr == nullptr` inside `InitListChecker::UpdateStructuredListElement()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85193/new/ https://reviews.llvm.org/D85193 Fi

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX added a comment. In D85193#2207798 , @aaron.ballman wrote: > In D85193#2207052 , @ArcsinX wrote: > >> In D85193#2204685 , @aaron.ballman >> wrote: >> >>> I sort of

Re: [clang] 6170072 - Improve modeling of variable template specializations with dependent

On Tue, 11 Aug 2020, Richard Smith wrote: On Tue, 11 Aug 2020 at 00:29, Martin Storsjö wrote: On Sun, 9 Aug 2020, Richard Smith via cfe-commits wrote: > > Author: Richard Smith > Date: 2020-08-09T23:22:26-07:00 > New Revision: 617007240cbfb97c8ccf6d61b0c4ca0bb62d4

[PATCH] D85714: [AST][RecoveryExpr] Don't preserve the return type if the FunctionDecl is invalid.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. If a functionDecl is invalid (e.g. return type cannot be formed), int is use as he fallback type, which may lead to some bogus diagnostics. Repository: rG

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett added a comment. Thanks for the pointer, I found more mistakes this way, e.g.: https://godbolt.org/z/f6n95z (I don't think I can use in a test but there is clang/test/Headers/x86-64-apple-macosx-types.cpp which uses is_same with it's own implementation so I can use/copy that) Th

[PATCH] D85713: [SyntaxTree]: Use Annotations in tests to reduce noise

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:186-187 +auto AnnotatedRanges = AnnotatedCode.ranges(); +assert(AnnotatedRanges.size() == TreeDumps.size()); +for (auto i = 0u; i < AnnotatedRanges.size(); i++) { + auto *An

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3aece05313e: [SystemZ/ZOS] Add binary format goff and operating system zos to the triple (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[clang] b3aece0 - [SystemZ/ZOS] Add binary format goff and operating system zos to the triple

Author: Kai Nacke Date: 2020-08-11T05:26:26-04:00 New Revision: b3aece05313e740d26e517a9f32af90818ee4390 URL: https://github.com/llvm/llvm-project/commit/b3aece05313e740d26e517a9f32af90818ee4390 DIFF: https://github.com/llvm/llvm-project/commit/b3aece05313e740d26e517a9f32af90818ee4390.diff LOG

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

njames93 added a comment. Is 'over-unscoped' really needed in the name, would just 'prefer-scoped-enum' be better, WDYT? For the case of macro, you can check if the location is a macro using `SourceLocation::isMacroID()`. For this to work you would also need to check every single usage of the

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

njames93 added a comment. Should a line be added to the release notes to explain this behaviour: 'Checks that specify files to include now support wrapping the include in angle brackets to create a system include'? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D85716: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85716 Files: clang/lib/Sema/SemaStmt.cpp clang/test/SemaCXX/recovery-expr-type.cpp Inde

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 284623. atrosinenko added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 Files: compiler-rt/lib/builtins/divdf3.c compiler-rt/lib/builti

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko updated this revision to Diff 284624. atrosinenko added a comment. Re-upload after amending previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 Files: compiler-rt/lib/builtins/fp_d

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429 ___ cfe-commits mailing list c

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

janosbenjaminantal added a comment. In D85697#2209272 , @njames93 wrote: > Is 'over-unscoped' really needed in the name, would just 'prefer-scoped-enum' > be better, WDYT? > > For the case of macro, you can check if the location is a macro using > `Sourc

[clang-tools-extra] 73a6a36 - [clangd] RIFF.cpp - Use logical && instead of bitwise & for padding check

Author: Simon Pilgrim Date: 2020-08-11T11:38:43+01:00 New Revision: 73a6a36469468bb72d409d5179c6244e751545e2 URL: https://github.com/llvm/llvm-project/commit/73a6a36469468bb72d409d5179c6244e751545e2 DIFF: https://github.com/llvm/llvm-project/commit/73a6a36469468bb72d409d5179c6244e751545e2.diff

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1362-1367 +if (Style.AlignOperands != FormatStyle::OAS_DontAlign && Previous && +(Previous->getPrecedence() == prec::Assignment || + Previous->is(tok::kw_return) || +

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

fickert updated this revision to Diff 284643. fickert added a comment. Resolved repetitive conditions in the two consecutive `if`s and added a small comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85600/new/ https://reviews.llvm.org/D85600

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85600/new/ https://reviews.llvm.org/D85600 ___

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

fickert added a comment. Thanks! I don't have push permissions to the repository so I cannot submit the commit myself (Maximilian Fickert ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85600/new/ https://reviews.llvm.org/D85600

[clang-tools-extra] bd1013a - [clangd] Enforce trailing slash for remote index's project root

Author: Kirill Bobyrev Date: 2020-08-11T13:24:43+02:00 New Revision: bd1013a4825bf2cf58b3c75320f64b24b244f343 URL: https://github.com/llvm/llvm-project/commit/bd1013a4825bf2cf58b3c75320f64b24b244f343 DIFF: https://github.com/llvm/llvm-project/commit/bd1013a4825bf2cf58b3c75320f64b24b244f343.diff

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

kbobyrev updated this revision to Diff 284648. kbobyrev added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 Files: clang-tools-extra/clangd/index/remote/Client.cpp clang-tools-extra

[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1013a4825b: [clangd] Enforce trailing slash for remote index's project root (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

Typz added a comment. Could this also be causing https://bugs.llvm.org/show_bug.cgi?id=33896 ? I'll try to see if changes something in that case... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85600/new/ https://reviews.llvm.org/D85600 _

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. fixes https://github.com/clangd/clang

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

Typz added a comment. In D85600#2209545 , @Typz wrote: > Could this also be causing https://bugs.llvm.org/show_bug.cgi?id=33896 ? > > I'll try to see if changes something in that case... Actually, I can confirm this is unrelated. Comme

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

fickert added a comment. Yes I think it's unrelated, though this patch should fix the alignment in that example when using the `UT_AlignWithSpaces` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85600/new/ https://reviews.llvm.org/D85600 _

[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

shchenz added a comment. With this change, we get verify failure for below case: int test_builtin_trap(int num) { volatile int i = 0; if (num > 0) __builtin_unreachable(); else goto L1; L1: return i; } clang t.c -target powerpc-unknown-unknown -c -mllvm -verif

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

svenvh accepted this revision. svenvh added a comment. LGTM, but just wondering if the test actually belongs to this patch, as it doesn't demonstrate the problem without one of your other patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83325

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

fickert added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1360 + if (Style.AlignOperands == FormatStyle::OAS_AlignAfterOperator) +NewParenState.UnindentOperator = true; + // Mark indentation as alignment if the expression is aligned. -

[clang] 031738a - [AST][RecoveryExpr] Don't preserve the return type if the FunctionDecl is invalid.

Author: Haojian Wu Date: 2020-08-11T13:49:57+02:00 New Revision: 031738a5611843674d5f739e739e8a386d5e741b URL: https://github.com/llvm/llvm-project/commit/031738a5611843674d5f739e739e8a386d5e741b DIFF: https://github.com/llvm/llvm-project/commit/031738a5611843674d5f739e739e8a386d5e741b.diff LO

[PATCH] D85714: [AST][RecoveryExpr] Don't preserve the return type if the FunctionDecl is invalid.

This revision was automatically updated to reflect the committed changes. Closed by commit rG031738a56118: [AST][RecoveryExpr] Don't preserve the return type if the FunctionDecl is… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

Typz added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1360 + if (Style.AlignOperands == FormatStyle::OAS_AlignAfterOperator) +NewParenState.UnindentOperator = true; + // Mark indentation as alignment if the expression is aligned.

[clang] ee17f72 - Fix Wdocumentation unknown param warning. NFC.

Author: Simon Pilgrim Date: 2020-08-11T12:52:37+01:00 New Revision: ee17f72e13b839001a6e8a77e767d5b15d2bd4d1 URL: https://github.com/llvm/llvm-project/commit/ee17f72e13b839001a6e8a77e767d5b15d2bd4d1 DIFF: https://github.com/llvm/llvm-project/commit/ee17f72e13b839001a6e8a77e767d5b15d2bd4d1.diff

[clang] 49193e1 - Fix Wdocumentation unknown param warnings. NFC.

Author: Simon Pilgrim Date: 2020-08-11T12:52:37+01:00 New Revision: 49193e1fe7e143555d3b740610d6d1d20a553b2f URL: https://github.com/llvm/llvm-project/commit/49193e1fe7e143555d3b740610d6d1d20a553b2f DIFF: https://github.com/llvm/llvm-project/commit/49193e1fe7e143555d3b740610d6d1d20a553b2f.diff

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

sammccall added a comment. Yup, this is a nice improvement, though there are further things we could do. As discussed offline, we could consider mapping "disabled" to an attribute but we can't really consume that well in VSCode (or any other editor yet) so let's leave it. Co

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nsz added a comment. In D80791#2207203 , @chill wrote: > I would prefer to avoid the situation where the markings of two otherwise > identical files were different, > depending on how the files were produced, no matter if it was a common or a > special c

[PATCH] D85722: [z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: thakis, hubert.reinterpretcast, uweigand, yusra.syeda, Kai, zibi, MaskRay, anirudhp. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revis

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D80791#2209624 , @nsz wrote: > In D80791#2207203 , @chill wrote: > >> I would prefer to avoid the situation where the markings of two otherwise >> identical files were different, >> depend

[PATCH] D85713: [SyntaxTree]: Use Annotations in tests to reduce noise

eduucaldas updated this revision to Diff 284678. eduucaldas added a comment. Use annotations to reduce noise of expression tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85713/new/ https://reviews.llvm.org/D85713 Files: clang/unittests/Tool

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGb18c63e85aa8: [clang-format] use spaces for alignment of binary/ternary expressions with… (authored by fickert, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] b18c63e - [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

Author: Maximilian Fickert Date: 2020-08-11T14:56:26+02:00 New Revision: b18c63e85aa8191e583cd1014757904c344b45d7 URL: https://github.com/llvm/llvm-project/commit/b18c63e85aa8191e583cd1014757904c344b45d7 DIFF: https://github.com/llvm/llvm-project/commit/b18c63e85aa8191e583cd1014757904c344b45d7.

[PATCH] D85727: [clangd] Disable ExtractFunction for C

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This tweak uses constructs like auto

[PATCH] D85727: [clangd] Disable ExtractFunction for C

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. > This tweak uses constructs like auto and refs, which are not available in C. I didn't find this tweak is using `auto`. I think we need to do the same thing for extract variable tweak as well

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1620 // Macros can be very spammy, so we only support prefix completion. // We won't end up with underfull

[PATCH] D85728: [Analyzer][WIP] Support for the new variadic isa<> and isa_and_nod_null<> in CastValueChecker

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Charusso. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, wh

[PATCH] D85728: [Analyzer][WIP] Support for the new variadic isa<> and isa_and_nod_null<> in CastValueChecker

baloghadamsoftware added a comment. This patch intends to fix bug 47037 . It is still work in progress with lots of debug printouts. I described the issue with this patch at the bug report: //The variadic tests fail because the whole Dyanamic Type l

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

saiislam added a comment. Ping for this (part-1), D85150 (part-2), and D85214 (part-3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 _

[PATCH] D85728: [Analyzer][WIP] Support for the new variadic isa<> and isa_and_nod_null<> in CastValueChecker

baloghadamsoftware added a comment. My proposal is the following: do not store the casing info between pointers and references but the underlying types themselves. There are two ways to implement this: in the checkers using it (currently only this one) or behind the API of `DynamicCastInfo`. Ma

[PATCH] D85716: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:353 return; +if (isa(E)) + return; This seems like a very specific patch to a special case of a potentially more general problem... Comment at: clang/test

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

kadircet updated this revision to Diff 284694. kadircet added a comment. - Drop the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85721/new/ https://reviews.llvm.org/D85721 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[clang-tools-extra] 24a816c - [clangd] Disable ExtractFunction for C

Author: Kadir Cetinkaya Date: 2020-08-11T16:00:39+02:00 New Revision: 24a816c7d3925eb21970ea733d7d6bda11088ac7 URL: https://github.com/llvm/llvm-project/commit/24a816c7d3925eb21970ea733d7d6bda11088ac7 DIFF: https://github.com/llvm/llvm-project/commit/24a816c7d3925eb21970ea733d7d6bda11088ac7.dif

[PATCH] D85727: [clangd] Disable ExtractFunction for C

This revision was automatically updated to reflect the committed changes. Closed by commit rG24a816c7d392: [clangd] Disable ExtractFunction for C (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85727/new/ https://reviews.llvm.o

[clang-tools-extra] b626f45 - [clangd] Unify macro matching in code completion for AST and Index based macros

Author: Kadir Cetinkaya Date: 2020-08-11T16:00:39+02:00 New Revision: b626f45329e8575f72e6cd444b444942d4913e9c URL: https://github.com/llvm/llvm-project/commit/b626f45329e8575f72e6cd444b444942d4913e9c DIFF: https://github.com/llvm/llvm-project/commit/b626f45329e8575f72e6cd444b444942d4913e9c.dif

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb626f45329e8: [clangd] Unify macro matching in code completion for AST and Index based macros (authored by kadircet). Repository: rG LLVM Github M

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

kadircet updated this revision to Diff 284702. kadircet added a comment. - Move new test closer to other FakeHeaderGuard tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85590/new/ https://reviews.llvm.org/D85590 Files: clang/lib/Tooling/Inc

[PATCH] D85731: [builtins] Make softfloat-related errors less noisy

atrosinenko created this revision. atrosinenko added reviewers: asl, scanon, howard.hinnant. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. atrosinenko requested review of this revision. Choose SINGLE_PRECISION by default in fp_lib.h after `#error`ing when incorrectly c

[PATCH] D85607: CfgTraits: add CfgInstructionRef

arsenm added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:100 +// provide one at all. We don't want to lay a subtle performance trap here. +abort(); + } llvm_unreachable? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea8e71c3da56: [clang][HeaderInsert] Do not treat defines with values as header guards (authored by kadircet). Repository: rG LLVM Github Monorepo

[clang] ea8e71c - [clang][HeaderInsert] Do not treat defines with values as header guards

Author: Kadir Cetinkaya Date: 2020-08-11T16:02:11+02:00 New Revision: ea8e71c3da56f76ae2ab2f9ee7afc608ffab URL: https://github.com/llvm/llvm-project/commit/ea8e71c3da56f76ae2ab2f9ee7afc608ffab DIFF: https://github.com/llvm/llvm-project/commit/ea8e71c3da56f76ae2ab2f9ee7afc608ffab.dif

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added a comment. thanks, lgtm. mostly comments arounds tests, sorry for not looking at them before. Comment at: clang-tools-extra/clangd/index/FileIndex.h:156 /// Exposed to assist in unit tests. -SlabTuple indexMainDecls(ParsedAST &AST); +SlabTuple indexMainDecls(Pa

[PATCH] D84828: [clang] Don't make synthesized accessor stub functions visible twice

This revision was automatically updated to reflect the committed changes. Closed by commit rG442a80292d50: [clang] Don't make synthesized accessor stub functions visible twice (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[clang] 442a802 - [clang] Don't make synthesized accessor stub functions visible twice

Author: Raphael Isemann Date: 2020-08-11T16:23:51+02:00 New Revision: 442a80292d50d895396eb14418bd471e7da68fd0 URL: https://github.com/llvm/llvm-project/commit/442a80292d50d895396eb14418bd471e7da68fd0 DIFF: https://github.com/llvm/llvm-project/commit/442a80292d50d895396eb14418bd471e7da68fd0.dif

[clang] 02899d7 - [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit ObjCInterfaceDecl

Author: Raphael Isemann Date: 2020-08-11T16:24:32+02:00 New Revision: 02899d7f1b9ae7f6da30bd020a714c7b3eb2c59f URL: https://github.com/llvm/llvm-project/commit/02899d7f1b9ae7f6da30bd020a714c7b3eb2c59f DIFF: https://github.com/llvm/llvm-project/commit/02899d7f1b9ae7f6da30bd020a714c7b3eb2c59f.dif

[PATCH] D85733: [libTooling] Cleanup and reorder `RewriteRule.h`.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. ymandel requested review of this revision. This patch lifts `RootID` out of the `RewriteRule` class so that constructs (e.g. inline functions) can that refer to the root id don't need to depend on t

[PATCH] D84829: [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit ObjCInterfaceDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG02899d7f1b9a: [clang] Don't make ObjCIvarDecl visible twice when adding them to an implicit… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: r

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nsz added a comment. In D80791#2209703 , @chill wrote: > In D80791#2209624 , @nsz wrote: > >> - it is not useful to have a bti annotated function unless everything else >> is bti compatible too: it is all or nothin

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein updated this revision to Diff 284715. hokein marked 3 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D85635 Files: clang-tools-ext

[PATCH] D85733: [libTooling] Cleanup and reorder `RewriteRule.h`.

ymandel updated this revision to Diff 284716. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85733/new/ https://reviews.llvm.org/D85733 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h clang/lib/Too

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno updated this revision to Diff 284718. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85613/new/ https://reviews.llvm.org/D85613 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl

[PATCH] D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity.

ymandel created this revision. ymandel added reviewers: tdl-g, gribozavr2. Herald added a project: clang. ymandel requested review of this revision. Currently, changes to includes are applied to an entire rule. However, include changes may be specific to particular edits within a rule (for example

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3843 /// The declaration that this binding binds to part of. + // FIXME: Currently not set during deserialization of the BindingDecl; + // only set when the corresponding DecompositionDecl is vis

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:112 // if (DRE->isNonOdrUse() != NOUR_Unevaluated) return S.Diag(DRE->getBeginLoc(), This can use `DiagnoseIfOdrUse` as soon as the inconsistency between parameters and

[PATCH] D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity.

ymandel updated this revision to Diff 284720. ymandel added a comment. tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85734/new/ https://reviews.llvm.org/D85734 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h clang/lib/Toolin

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, yaxunl. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Herald added a sub

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss added a comment. >> it is not useful to have a bti annotated function unless everything else is >> bti compatible too: it is all or nothing per elf module. > > This is false. Some functions in an elf module could be in a guarded region, > some in a non-guarded region. Some function ma

  1   2   3   >