[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

2020-08-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptReference(*TC)); hokein wr

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 282814. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85146/new/ https://reviews.llvm.org/D85146 Files: clang/lib/T

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

2020-08-04 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. I would add one more test for the undefined case. Like a local array variable that is uninitialized. That could mirror some of the null-dereference cases. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:135 +DerefKindStr = "d

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-04 Thread Rainer Orth via Phabricator via cfe-commits
ro added a reviewer: MaskRay. ro added a comment. Ping? It's been two weeks now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 ___ cfe-commits mailing list cfe

[clang-tools-extra] 7c4782c - [clang-tidy] Fix regression in RenamerClangTidy

2020-08-04 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-08-04T09:27:01+01:00 New Revision: 7c4782ce91d66a8447a851362b99bb86a42b7c08 URL: https://github.com/llvm/llvm-project/commit/7c4782ce91d66a8447a851362b99bb86a42b7c08 DIFF: https://github.com/llvm/llvm-project/commit/7c4782ce91d66a8447a851362b99bb86a42b7c08.diff

[PATCH] D85185: [SyntaxTree] Add test coverage for `->*` operator

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. This was the last binary operator that we supported but didn't have any test coverage. The recent fix in a crash in member pointers allowed us to a

[PATCH] D85186: [SyntaxTree] Add support for `LiteralExpression`

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We use inheritance to model the grammar's disjunction rule: literal: integer-literal character-literal floating-point-literal string-liter

[clang] 141cb8a - [analyzer] Model iterator random incrementation symmetrically

2020-08-04 Thread Endre Fulop via cfe-commits
Author: Endre Fülöp Date: 2020-08-04T11:04:12+02:00 New Revision: 141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5 URL: https://github.com/llvm/llvm-project/commit/141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5 DIFF: https://github.com/llvm/llvm-project/commit/141cb8a1eecc0c843cdd4e788a28d2b6715e4dc5.diff L

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

2020-08-04 Thread Endre Fülöp via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG141cb8a1eecc: [analyzer] Model iterator random incrementation symmetrically (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

2020-08-04 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 282837. gamesh411 marked an inline comment as done. gamesh411 added a comment. rename file name in header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: cla

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

2020-08-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D67422#2192407 , @NoQ wrote: > One bit that's not directly related but i decided to keep it from the > original patch was moving the plist-html diagnostic builder function into its > own file. That is a great call indeed.

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D85128#2191108 , @tschuett wrote: > Stupid questions. > > - Is it for convenience? You get arrays, global variables, structs, ... . > Vectorization becomes easier ... Yes, this allows the definition of types that can be used

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

2020-08-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 282852. vabridgers added a comment. isRelationalOp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files: clang/docs/DiagnosticsReference.rst clang/include/clang

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

2020-08-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 282854. vabridgers added a comment. fix misc test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files: clang/docs/DiagnosticsReference.rst clang/inc

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

2020-08-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers marked 2 inline comments as done. vabridgers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14047 +static bool isComparisonOpSamePrecedence(BinaryOperatorKind Opc) { + switch (Opc) { njames93 wrote: > Quuxplusone wrote: > > Same prec

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

2020-08-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. We definitely need more tests. The idea overall however is amazing, thanks! Comment at: clang/test/Analysis/misc-ps-region-store.m:1160 struct list_pr8141 *items; - for (;; items = ({ do { } while (0); items->tail; })) // expected-warning{{Derefe

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

2020-08-04 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. Is this patch needed anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82949/new/ https://reviews.llvm.org/D82949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

2020-08-04 Thread Victor Campos via Phabricator via cfe-commits
vhscampos added a comment. Not really. Closing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82949/new/ https://reviews.llvm.org/D82949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

2020-08-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Would it be possible to publish these results on a public CodeChecker server? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-c

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D85128#2191401 , @efriedma wrote: > Not going to write detailed review comments, but this looks like the right > approach in general. Thanks for taking a look! I'll split this up into separate patches soon. > One high-level

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added reviewers: jasonliu, efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. ebevhan requested review of this revision. In D79719 , LayoutField was refactored to fetch the size of field types in

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-08-04 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. I submitted a patch with the changes at D85191 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___ cf

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D85128#2192867 , @c-rhodes wrote: > In D85128#2191108 , @tschuett wrote: > >> - Is it compatible with GCC? > > Support for this attribute landed in GCC 10 and it's more complete than wha

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

2020-08-04 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. In D80791#2164543 , @danielkiss wrote: >> If any function has the attribute "sign-return-address", then the output note >> section should have PAC bit set. The return address signing is completely >> local >> to the function, and fu

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

2020-08-04 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. This approach looks way too hackish to me with multiple opposing attributes ("sign-return-address" vs. "ignore-sign-return-address") and some convoluted logic to resolve the contradiction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.l

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

2020-08-04 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. I was surprised too. Perhaps there is a way to write the test file such that any type mismatch is a warning and compile with -Werror (maybe a new file, the IR might get messy). I will spend some time looking into this. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

2020-08-04 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ArcsinX requested review of this revision. This patch prevents `InitListChecker::UpdateStructuredListElement()` call with `expr == nullptr` which could cause a crash. Repository: rG LLVM Gith

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

2020-08-04 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 282876. baloghadamsoftware added a comment. `else` branch merged with inner `if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

2020-08-04 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Herald added a subscriber: steakhal. Ping! Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:199 // Utility methods - std::pair - static assumeZero(CheckerContext &C, -ProgramStateRef state, SVal V, QualType

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

2020-08-04 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 282890. njames93 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81923/new/ https://reviews.llvm.org/D81923 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector). ---

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

2020-08-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 282902. vabridgers edited the summary of this revision. vabridgers added a comment. ok, I think it's all sorted out now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D851

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Sorry. I meant ABI. Can link GCC .o files with Clang .o files using the attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85128/new/ https://reviews.llvm.org/D85128 ___

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

2020-08-04 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a subscriber: bevinh. vabridgers added a comment. ok, I think it's all sorted out now. Thanks @bevinh for the desk review. Let's start at the beginning again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://revi

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

2020-08-04 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:56 +SVal RetVal) const; + void handleErase(CheckerContext &C, const Expr *CE, SVal Cont, SVal It

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 282906. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85124/new/ https://reviews.llvm.org/D85124 Files: clang/include/clang/AS

[clang] 1c0a0df - [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

2020-08-04 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-08-04T15:58:12+02:00 New Revision: 1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915 URL: https://github.com/llvm/llvm-project/commit/1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915 DIFF: https://github.com/llvm/llvm-project/commit/1c0a0dfa0236514fd1fbb1bccd8ad29f9d64e915.diff LO

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c0a0dfa0236: [Concepts] Include the found concept decl when dumping the… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 860cbbd - [SyntaxTree] Add support for `LiteralExpression`

2020-08-04 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-08-04T14:05:09Z New Revision: 860cbbdd6b84017e6d37e1752b0358a05da6b115 URL: https://github.com/llvm/llvm-project/commit/860cbbdd6b84017e6d37e1752b0358a05da6b115 DIFF: https://github.com/llvm/llvm-project/commit/860cbbdd6b84017e6d37e1752b0358a05da6b115.diff LOG

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

2020-08-04 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 282909. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp cl

[PATCH] D85186: [SyntaxTree] Add support for `LiteralExpression`

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG860cbbdd6b84: [SyntaxTree] Add support for `LiteralExpression` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision. amyk added a comment. I think overall it LGTM and the indentation can be addressed when committing. Comment at: clang/lib/Headers/altivec.h:17082 +/* vec_extractl */ +static __inline__ vector unsigned long long __ATTRS_o_ai vec_extractl( -

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

2020-08-04 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 282914. baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. Minor fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1841 auto setDeclInfo = [&](bool IsIncompleteArrayType) { -TypeInfo TI = Context.getTypeInfo(D->getType()); -FieldAlign = Context.toCharUnitsFromBits(TI.Align); +auto TI = Context.

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 282916. hokein added a comment. address review comments: - treat contains-errors expression as being potentially constant; - handle the value-dependent expressions for EvaluateInPlace; - remove the bailing out for constructor initializers that contains errors;

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 282917. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-function-re

[clang] 8ce15f7 - [SyntaxTree] Fix crash on pointer to member function

2020-08-04 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-08-04T14:31:12Z New Revision: 8ce15f7eeb122c0bba4b676d797217359dd57c30 URL: https://github.com/llvm/llvm-project/commit/8ce15f7eeb122c0bba4b676d797217359dd57c30 DIFF: https://github.com/llvm/llvm-project/commit/8ce15f7eeb122c0bba4b676d797217359dd57c30.diff LOG

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce15f7eeb12: [SyntaxTree] Fix crash on pointer to member function (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85146/new/ https:

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: clang/lib/Headers/altivec.h:17217 + +/* vs[l | r | ra] */ +static __inline__ vector unsigned __int128 __ATTRS_o_ai Add a space after this comment. Comment at: clang/lib/Headers/altivec.h:17227 +vec_sl(vec

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4961 } +if (IS->getCond()->isValueDependent()) + return EvaluateDependentExpr(IS->getCond(), Info); The `if` stmt (the same to `while`,

[clang] 961da69 - Improve diagnostics for disallowed attributes used with multiversioning

2020-08-04 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-08-04T07:40:27-07:00 New Revision: 961da69d7eafe44411d5ac9719209653d196f9e2 URL: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2 DIFF: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2.diff L

[clang] 0a8ac91 - Permit nowthrow and nonnull with multiversioning.

2020-08-04 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-08-04T07:40:27-07:00 New Revision: 0a8ac91a084504929b1ef4ec1fee693455bd796d URL: https://github.com/llvm/llvm-project/commit/0a8ac91a084504929b1ef4ec1fee693455bd796d DIFF: https://github.com/llvm/llvm-project/commit/0a8ac91a084504929b1ef4ec1fee693455bd796d.diff L

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

2020-08-04 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added a comment. Would it be better to add a new value to `"sign-return-address"` as `"none"`? I don't see any other alternative option, I'm open to any other idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

2020-08-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a reviewer: gamesh411. Szelethus added a comment. LGTM on my end, but please wait for approval from either @gamesh411 or @NoQ. In D77150#2191049 , @baloghadamsoftware wrote: > However, I think we should c

[PATCH] D85213: Use --dsym-dir when compiling with a compiler that supports it

2020-08-04 Thread Daniel Sanders via Phabricator via cfe-commits
dsanders created this revision. dsanders added reviewers: JDevlieghere, beanz, bogner. Herald added subscribers: cfe-commits, dang, mgorny. Herald added projects: clang, LLVM. dsanders requested review of this revision. As part of this, a couple tweaks to --dsym-dir have been made. It now starts w

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. This patch updates 101 out 320 test files. Remaining will be posted as a separate patch to ease review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85214/new/ https://reviews.llvm.org/D85214 ___

[PATCH] D82575: [OpenMP] OpenMP Clang tests without 50 version string after upgrading to 5.0

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam abandoned this revision. saiislam added a comment. Abandoning in favor of D85214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82575/new/ https://reviews.llvm.org/D82575 __

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. Next two (independent) parts are: D85150 and D85214 . More to come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D848

[clang] 5e0a9dc - Separate code-block tag with a newline to fix code snippet html output

2020-08-04 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-04T16:36:00+01:00 New Revision: 5e0a9dc0ad7704b7c49995101629010f5ff98cd2 URL: https://github.com/llvm/llvm-project/commit/5e0a9dc0ad7704b7c49995101629010f5ff98cd2 DIFF: https://github.com/llvm/llvm-project/commit/5e0a9dc0ad7704b7c49995101629010f5ff98cd2.diff

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Yonghong Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d6750696400: [clang][BPF] support type exist/size and enum exist/value relocations (authored by yonghong-song). Repository: rG LLVM Github Monore

[clang] 6d67506 - [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Yonghong Song via cfe-commits
Author: Yonghong Song Date: 2020-08-04T08:39:53-07:00 New Revision: 6d6750696400e7ce988d66a1a00e1d0cb32815f8 URL: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8 DIFF: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8.diff

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1841 auto setDeclInfo = [&](bool IsIncompleteArrayType) { -TypeInfo TI = Context.getTypeInfo(D->getType()); -FieldAlign = Context.toCharUnitsFromBits(TI.Align); +auto TI = Context.getT

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. #clang does not have many people. You might need to add people explicitly.. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 +static const char *getAsNeededOption(const ToolChain &TC, bool ignore) { +

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. > This is not ideal, since it makes the calculations char size dependent, and breaks for sizes that are not a multiple of the char size. How can we have a non-bitfield member whose size is not a multiple of the size of a char? Repository: rG LLVM Github Monorepo CHA

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

2020-08-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 282942. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_is_dev

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-08-04 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1058 + /// Add an sterm finalizer to its own llvm.global_dtors entry. + void AddCXXStermFinalizerToGlobalDtor(llvm::Function *StermFinalizer, +

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector). ---

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = &Checker->NullDereferenceBugType; } NoQ wrote: > Wait, i don't understa

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

2020-08-04 Thread Bogdan Serea via Phabricator via cfe-commits
bogser01 created this revision. bogser01 added reviewers: djasper, alexfh. bogser01 added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Skeleton checks generated by clang-tidy add_check.py cause asse

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 282952. yaxunl retitled this revision from "[CUDA][HIP] Support accessing static device variable in host code" to "[CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc". yaxunl edited the summary of this revision. yaxunl added a c

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, JonChesterfield, hliao. Herald added a subscriber: dang. yaxunl requested review of this revision. This is separated from https://reviews.llvm.org/D80858 For -fgpu-rdc mode, static device vars in different TU's may have the same

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector). ---

[clang] 83cb98f - Fix sphinx indentation warnings by adding explicit line breaks to address space hierarchy

2020-08-04 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-04T17:48:54+01:00 New Revision: 83cb98f9e7a57360e137b32b26500fca630df617 URL: https://github.com/llvm/llvm-project/commit/83cb98f9e7a57360e137b32b26500fca630df617 DIFF: https://github.com/llvm/llvm-project/commit/83cb98f9e7a57360e137b32b26500fca630df617.diff

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll planned changes to this revision. simoll added a comment. Thanks for the feedback! Planned change: interpret the `N` in `vector_size(N)` as the number of bytes in the type, such that, for example, a `vector_size(2)` bool vector holds 16 bits Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

2020-08-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 282958. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > I guess with what you're suggesting the bitcast could still be emitted there > but the cast operations could be limited in Sema to cases where ultimately > ConvertType would return a type that requires bitcasting, or are you saying > that could be avoided completely?

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

2020-08-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Sorry, this slipped out of my mind. I've started the process internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commit

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

2020-08-04 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. What is expected to happen to device statics in anonymous name spaces? It may be worth adding them to the tests. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 _

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko added a comment. > This is different than testing whether a type exists or not where we want to > precisely test whether that type exists or not, so we want to preserve > `typedef` type vs. `struct t` type. `typedef t` and `struct t` are also different for field relocations (those t i

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe18c6ef6b41a: [clang] improve diagnostics for misaligned and large atomics (authored by tschuett, committed by jfb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] e18c6ef - [clang] improve diagnostics for misaligned and large atomics

2020-08-04 Thread JF Bastien via cfe-commits
Author: Thorsten Schuett Date: 2020-08-04T11:10:29-07:00 New Revision: e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d URL: https://github.com/llvm/llvm-project/commit/e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d DIFF: https://github.com/llvm/llvm-project/commit/e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d.di

[PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. saugustine added a reviewer: echristo. Herald added a reviewer: JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine requested review of this revision. Such as the one in the darwin-dsymutil.c test. Repository: rG LLV

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

2020-08-04 Thread Nathan Lanza via Phabricator via cfe-commits
lanza added a comment. No problem! Thank you, John! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

2020-08-04 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; rjmccall wrote: > arsenm wrote: > > rjmccall wrote: > > > In principle, this can be `inreg` just as

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = &Checker->NullDereferenceBugType; } vrnithinkumar wrote: > NoQ wrote: > > Wait, i

[PATCH] D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang

2020-08-04 Thread Baptiste Saleil via Phabricator via cfe-commits
bsaleil accepted this revision as: bsaleil. bsaleil added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82675/new/ https://reviews.llvm.org/D82675 ___

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Generally i think this is shaping up nicely, with the couple of minor nits addressed i'm happy to land this. Like, there are a few cornercases that we could address but we could do that in follow-up patches. Folks, do you see anything else here? Comment

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

2020-08-04 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: sanjoy.google, bixia, yaxunl. Herald added a project: clang. tra requested review of this revision. Normally math functions are forwarded to __nv_* counterparts provided by CUDA's libdevice bitcode. However, __nv_ri

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

2020-08-04 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Probably the simplest way to verify return types would be using decltype. (`static_assert(std::is_same_v);`.) For arguments, maybe more complicated. I guess you could write a C++ class with conversion operators for every integer type, mark all of them except one "=

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

2020-08-04 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM, and can we write a test in the test-suite? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85236/new/ https://reviews.llvm.org/D85236 _

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

2020-08-04 Thread Peter Smith via Phabricator via cfe-commits
psmith created this revision. psmith added reviewers: jfb, Shayne, emaste, kristof.beyls, mattdr, ojhunt, probinson, reames, serge-sans-paille, dim. Herald added a subscriber: dexonsmith. psmith requested review of this revision. The Clang -fstack-protector documentation mentions what functions a

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

2020-08-04 Thread Lei Zhang via Phabricator via cfe-commits
antiagainst accepted this revision. antiagainst added a comment. This revision is now accepted and ready to land. LGTM for SPIR-V side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.llvm.org/D84780 __

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

2020-08-04 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Looks okay (one grammar nit), probably worth waiting for someone else to chime in. Comment at: clang/docs/ClangCommandLineReference.rst:2139 -Enable stack protectors for some functions vulnerable to stack smashing. This uses a loose heuristic whic

[clang] 47f7174 - [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

2020-08-04 Thread Dan Gohman via cfe-commits
Author: Dan Gohman Date: 2020-08-04T12:48:40-07:00 New Revision: 47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d URL: https://github.com/llvm/llvm-project/commit/47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d DIFF: https://github.com/llvm/llvm-project/commit/47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d.diff LO

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

2020-08-04 Thread sunfishcode via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47f7174ffa71: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics. (authored by sunfishcode). Changed prior to commit: https://re

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-08-04 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1865 +if (isSpecialLLVMGlobalArrayForStaticInit(&G)) { + if (GlobalUniqueModuleId.empty()) { +GlobalUniqueModuleId = getUniqueModuleId(&M); jasonliu wrote: >

[PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Can you add a test that exercises this code path? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85231/new/ https://reviews.llvm.org/D85231 ___ cfe-commits mailing list cfe-c

  1   2   >