[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM with two nits. Please wait one day or two in case other reviewers want to have a look. Comment at: llvm/include/llvm/Transforms/Instrumentation/DataFlowSanitizer.h:8 +//=

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

rsmith added a comment. This is at best only a partial fix. `Sema::NC_ContextIndependentExpr` is supposed to be used (unsurprisingly) only if we form a context-independent annotation, but here we're forming a context-dependent expression that depends on whether it appears in an unevaluated cont

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 281092. tstellar added a comment. Herald added a subscriber: mstorsjo. Add 64-bit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBu

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. This is the test driver I used for testing. I compared the clang 11 + this patch with gcc 10 and saw no differences: https://gist.github.com/tstellar/80dae2ab8a18d810b10b8e42777f4fe4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. Here is the assembly comparison for the 64-bit test I added between gcc and clang trunk + patch: https://reviews.llvm.org/P8227 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 _

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. This looks much better now. I don't have any other comments. Since this patch is now essentially a clang-only patch, I'll let @ABataev accept it or post comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84422/new/ https://reviews.llvm.org/D84422 __

[clang] 23d6525 - Don't form a 'context-independent expr' reference to a member during

Author: Richard Smith Date: 2020-07-27T19:38:22-07:00 New Revision: 23d6525cbdc9de7cbfe7640d1e9e4f25a0c5dd85 URL: https://github.com/llvm/llvm-project/commit/23d6525cbdc9de7cbfe7640d1e9e4f25a0c5dd85 DIFF: https://github.com/llvm/llvm-project/commit/23d6525cbdc9de7cbfe7640d1e9e4f25a0c5dd85.diff

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

rsmith added a comment. In D80925#2177446 , @rsmith wrote: > I'm going to try to fix this a different way, by fixing the bad case in > `Sema::ClassifyName` instead. Done in llvmorg-12-init-1234-g23d6525cbdc. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2435-2437 +* ``__builtin_memcpy_overloaded(QUAL void *dst, QUAL const void *src, size_t byte_size, size_t byte_element_size = )`` +* ``__builtin_memmove_overloaded(QUAL void *dst, QUAL const void *src, s

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. In D80858#2177159 , @tra wrote: > It's a good point. Perhaps this is one of the cases where we should *not* > follow nvcc. > We can't have our cake (preserve static behavior) and eat it (treat it as > non-static in case something

[PATCH] D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang

amyk updated this revision to Diff 281107. amyk added a comment. - Rebased patch - Updated patch to remove instruction definitions and MC tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82675/new/ https://reviews.llvm.org/D82675 Files: clang

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Thanks for recovering the tests. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84197/new/ https://reviews.llvm.org/D84197 ___

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk added a comment. Could we also elaborate in the description on how we are utilizing the new load instructions for zero extend case but not the sign extend case? Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14197 + + SDValue LoadOps[] = {LD->getChain(), LD->getB

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks updated this revision to Diff 281109. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/bindings/go

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/DataFlowSanitizer.h:11 + +#include "llvm/IR/Function.h" +#include "llvm/IR/Module.h" ychen wrote: > Is Function.h needed? Nope, rem

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

NoQ added a comment. In D84453#2171548 , @njames93 wrote: > I was having issues with this test case under macos in D82188 > . > It would fail for seemingly no apparent reason until I disable a test in a > different transl

[PATCH] D84453: [clang-tidy] Suppress one unittest on macOS.

NoQ updated this revision to Diff 281112. NoQ retitled this revision from "[clang-tidy] Suppress one unittest under ASan." to "[clang-tidy] Suppress one unittest on macOS.". NoQ added a comment. Update comments with the updated investigation details. CHANGES SINCE LAST ACTION https://reviews.

[clang-tools-extra] 8c9241a - [clang-tidy] Suppress one unittest on macOS.

Author: Artem Dergachev Date: 2020-07-27T22:38:53-07:00 New Revision: 8c9241a051fd677cfbfd9c79c6af9d714be7c792 URL: https://github.com/llvm/llvm-project/commit/8c9241a051fd677cfbfd9c79c6af9d714be7c792 DIFF: https://github.com/llvm/llvm-project/commit/8c9241a051fd677cfbfd9c79c6af9d714be7c792.dif

[PATCH] D84453: [clang-tidy] Suppress one unittest on macOS.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c9241a051fd: [clang-tidy] Suppress one unittest on macOS. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

nridge updated this revision to Diff 281123. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84613/new/ https://reviews.llvm.org/D84613 Files: clang/include/clang/AST/ExprConcepts.h clang/test/AST/a

<    1   2   3