[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:96 +} Counter(Request->DebugString()); +return std::forward(Call)( +*Index, ClangdRequest, [&](const StreamType &Item) { sammccall wrote: > I don't

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:96 +} Counter(Request->DebugString()); +return std::forward(Call)( +*Index, ClangdRequest, [&](const StreamType &Item) { kbobyrev wrote: > sammcca

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

vsk added a comment. @phosek I suspect this is causing a cmake error on the lldb standalone bot, would you mind taking a look? http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-standalone/1858/ CMake Error at /Users/buildslave/jenkins/workspace/lldb-cmake-standalone/clang-build/lib/cma

Re: [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Thanks for the heads up, this should be addressed by c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other issues. On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk added a comment. > > @phosek I suspect this is causing a cma

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 280588. guiand added a comment. Update tests to reflect more strict noundef rules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 Files: clang/test/ARCMT/objcmt-instan

Re: [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Thanks, that addressed the issue. > On Jul 24, 2020, at 1:41 PM, Petr Hosek wrote: > > Thanks for the heads up, this should be addressed by > c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other > issues. > > On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator >

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 280622. guiand added a comment. Added an across-the-board test with several different interesting cases. @rsmith, I'm not sure how to test things like VTables/VTTs, since afaik the way they would be exposed to function attributes would be if a struct is being

[clang] 6a75496 - [Driver] Define LinkOption and fix forwarded options to GCC for linking

Author: Fangrui Song Date: 2020-07-25T12:33:18-07:00 New Revision: 6a75496836ea14bcfd2f4b59d35a1cad4ac58cee URL: https://github.com/llvm/llvm-project/commit/6a75496836ea14bcfd2f4b59d35a1cad4ac58cee DIFF: https://github.com/llvm/llvm-project/commit/6a75496836ea14bcfd2f4b59d35a1cad4ac58cee.diff

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280692. xbolva00 added a comment. Updated. Thanks for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSem

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280693. xbolva00 added a comment. More tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 280694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/

[PATCH] D84591: Replace comment by private method

hanneskaeufler created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The comment is better served with a small private method, helping scannability of the code and hiding irrelevant details about the private members. Repository: rG LLVM Github Monorepo

[PATCH] D84591: [clang-tidy] Replace comment by private method

hanneskaeufler updated this revision to Diff 280699. hanneskaeufler added a comment. Fix syntax error (add return type) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84591/new/ https://reviews.llvm.org/D84591 Files: clang-tools-extra/clang-tidy/

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

vabridgers updated this revision to Diff 280700. vabridgers added a comment. Adding negative test case that exposes the original problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83992/new/ https://reviews.llvm.org/D83992 Files: clang/lib/A