[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Use of BuiltinB

[PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > Unlike RecordDecl case which uses DefinitionCompleter to force > completeDefinition we don't seem to have a similar mechanism for > ObjCInterfaceDecl. It is unfortunate that the AST does

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev planned changes to this revision. kbobyrev added a comment. Maybe wait for Debian packages to get updated and then whitelist 1.26.0-4 but fail with anything lower than that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https:/

[clang] 7f00395 - [SystemZ] Implement __builtin_eh_return_data_regno

Author: Ulrich Weigand Date: 2020-07-24T10:28:06+02:00 New Revision: 7f003957bfcd1ed29ded176f04e3cdb55a0c0112 URL: https://github.com/llvm/llvm-project/commit/7f003957bfcd1ed29ded176f04e3cdb55a0c0112 DIFF: https://github.com/llvm/llvm-project/commit/7f003957bfcd1ed29ded176f04e3cdb55a0c0112.diff

[PATCH] D84341: Implement __builtin_eh_return_data_regno for SystemZ

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f003957bfcd: [SystemZ] Implement __builtin_eh_return_data_regno (authored by uweigand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84341/new/ https://re

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

njames93 added a comment. I was having issues with this test case under macos in D82188 . It would fail for seemingly no apparent reason until I disable a test in a different translation unit. This made me think there is a subtle bug in the linker used on macos.

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280365. kbobyrev added a comment. Rebase on top of master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools-extra/clangd/index/remote/Client.cpp clang-tools-extra/clangd/index/remote/se

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong updated this revision to Diff 280368. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79431/new/ https://reviews.llvm.org/D79431 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecke

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84499 Files: clang-tools-extra/clang

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev abandoned this revision. kbobyrev added a comment. In favor of D84499 with clean diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 ___ cfe-commits mail

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added a comment. The first iteration is D83831 but the diffs are clobbered and I can't change the history there :( So, creating a new one is maybe the best solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D83592: [Coverage] Add comment to skipped regions

hans added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) zequanwu wrote: > @hans , can you take a look on this part? I saw `Token

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

c-rhodes added a comment. there's a few places the `getNumElements` calls can be fixed by getting the initial cast right Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5986 case NEON::BI__builtin_neon_vqrdmulh_lane_v: { auto *RTy = cast(Ty); if (BuiltinID == NEON::BI

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong marked 4 inline comments as done. martong added a comment. In D79431#2020951 , @Szelethus wrote: > Sure, this is an improvement because we display more information, but I'd > argue that it isn't really a more readable warning message :) How about

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:323 +std::string("Function argument constraint is not satisfied, ") + +VC->getName().data() + ", ArgN: " + std::to_string(VC->getArgNo()); if (!BT_Inva

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong updated this revision to Diff 280376. martong marked 3 inline comments as done. martong added a comment. - Use Twine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79431/new/ https://reviews.llvm.org/D79431 Files: clang/lib/StaticAnalyzer

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

hans added a comment. Pushed to 11.x as 833f8c958601bb640ba6a25d627c1dc58dad14d2 . Please let me know if there are any follow-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

hokein added a comment. as you mentioned in the description, there are two problems, I'd prefer address them in two different patches. Comment at: clang/include/clang/AST/ExprConcepts.h:132 +// there may not be a template argument list. +return ArgsAsWritten->RAngleLoc

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280381. kbobyrev added a comment. Abstract out the client request into a single function call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-ext

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280383. kbobyrev added a comment. Reset D83831 to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools-extra/

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

balazske updated this revision to Diff 280385. balazske added a comment. Fixed failed tests because change of bug category from "Logic error" to "Memory error". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D844

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev planned changes to this revision. kbobyrev added a comment. Tracer messages for sent and failed to parse items are not correct. Have to figure out how to print them _after_ the callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280391. kbobyrev added a comment. Fix (un)successful message numbers reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-extra/clangd/index

[PATCH] D84508: [clang-tools-extra] Change the default path to find-all-symbols

galou created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the default parameter `binary` in run-find-all-symbols.py to `find-all-symbols`, so that the script works out-of-the box when installed. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D84508: [clang-tools-extra] Change the default path to find-all-symbols

galou added a comment. This is necessary at least on Ubuntu 18.04. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84508/new/ https://reviews.llvm.org/D84508 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1b4a231a4: [CMake] Simplify CMake handling for zlib (authored by phosek). Herald added subscribers: msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mge

[PATCH] D84506: [tools] Add paranthesese for print in Python

galou created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Add paranthesese for print in Python

[PATCH] D84506: [tools] Add paranthesese for print in Python

galou added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add parentheses for print in Python (all Python files where the print statement was used). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84506/new/ htt

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

arichardson created this revision. arichardson added reviewers: vitalybuka, jdoerfert, MaskRay. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Not passing --clang would result in a python exception after this change: (TypeError: expected str, bytes or os.P

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal updated this revision to Diff 280398. steakhal added a comment. - Created the `CStringChecker` subdirectory holding the related files. - `CStringChecker` split up to 4 files: - `CStringChecker.h`: Declaration of the checker class. - `CStringChecker.cpp`: Definitions ONLY of the cstirn

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch clangd does not collect references for main-file symbols if there is no public declaration in preamble. Example:

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus added a comment. I personally preferred the previous diff, the reporting part of the checker and the string length modeling was separated far more cleanly. In D84316#2171267 , @NoQ wrote: > Mmm, none of these benefits sound like they outweigh c

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus added a comment. In D84316#2171270 , @NoQ wrote: > Imagine something like re-using the state trait implementation between > `MallocChecker` and `StreamChecker` because they both model "resources that > can be deallocated twice or leaked" - rega

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280406. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clan

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

jeroen.dobbelaere added a comment. Herald added a subscriber: dang. Found some issue when looking at this code: -ftrapping_math and -fno_trapping_math will never have effect Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3155 + if (Args.hasArg(OPT_ftrapping_math)) { +

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Report undefine

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280415. MForster marked 15 inline comments as done. MForster added a comment. Herald added a reviewer: jdoerfert. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://review

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2162433 , @aaron.ballman wrote: > It's a bit odd that this attribute has an AST node created for it but nothing > is using that AST node elsewhere in the project. Are there other patches > expected for making use of t

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske marked an inline comment as done. balazske added a comment. Not sure if this is a good solution. There are few tests that test the undefined reference case. But the added code should work the same way as in the null pointer case? Comment at: clang/lib/StaticAnalyzer/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a subscriber: doug.gregor. MForster added a comment. @milseman, @doug.gregor, could you please help with the open questions on this review? Specifically: - Is `ns_error_domain` ever needed for something other than an enum? - Why is this designed in the way it is (requiring an ide

[PATCH] D84005: Introduce ns_error_domain attribute.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5344 + if (!S.LookupName(lookupResult, S.TUScope) || + !lookupResult.getAsSingle()) { +S.Diag(IdentLoc->Loc, diag::err_nserrordomain_invalid_decl) Just a note that `LookupResu

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83665/new/ https://reviews.llvm.org/D83665 ___ cfe-commits mailing list

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

ymandel updated this revision to Diff 280424. ymandel added a comment. fixed lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84310/new/ https://reviews.llvm.org/D84310 Files: clang/include/clang/Tooling/Transformer/MatchConsumer.h clang/inc

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

kadircet marked an inline comment as done. kadircet added a comment. thanks, this looks good in general, but it would be nice to make sure we are not blowing the index memory and disk usage. could you grab some numbers for these two before/after this patch? Comment at: clang-

[PATCH] D84506: [tools] Add paranthesese for print in Python

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Seems NFC and towards the right syntax, thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84506/new/ https://reviews.llvm.org/D84

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf428778128f: [libTooling] Add assorted `EditGenerator` combinators. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84310/new/ https:/

[clang] cf42877 - [libTooling] Add assorted `EditGenerator` combinators.

Author: Yitzhak Mandelbaum Date: 2020-07-24T12:51:54Z New Revision: cf428778128fed5eacee884964af53bf4a9f74f2 URL: https://github.com/llvm/llvm-project/commit/cf428778128fed5eacee884964af53bf4a9f74f2 DIFF: https://github.com/llvm/llvm-project/commit/cf428778128fed5eacee884964af53bf4a9f74f2.diff

[PATCH] D84476: Make hip math headers easier to use from C

jdoerfert added a comment. I'm fine with this @yaxunl should accept though. Comment at: clang/lib/Headers/__clang_hip_math.h:561 inline double abs(double __x) { return __ocml_fabs_f64(__x); } +#endif __DEVICE__ Nit: You mix the C and C++ math declarations in

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Only FuzzyFindRequest is implemented via Marshaller even though other requests also follow a similar pat

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83909/new/ https://reviews.llvm.org/D83909 _

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280455. usaxena95 edited the summary of this revision. usaxena95 added a comment. Better formatting in generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814

[PATCH] D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

ymandel updated this revision to Diff 280458. ymandel added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84409/new/ https://reviews.llvm.org/D84409 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h cl

[PATCH] D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

ymandel marked 7 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:337 +// refer to nodes bound by the calling rule. `Rule` is not applied to the node +// itself. +EditGenerator rewriteDescendants(std::string

[PATCH] D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rGc332a984aefc: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node. (authored by ymandel). Changed prior to commit: https://reviews.l

[clang] c332a98 - [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

Author: Yitzhak Mandelbaum Date: 2020-07-24T14:38:17Z New Revision: c332a984aefc6f8a6b44fd3687a5bbce3f8f035c URL: https://github.com/llvm/llvm-project/commit/c332a984aefc6f8a6b44fd3687a5bbce3f8f035c DIFF: https://github.com/llvm/llvm-project/commit/c332a984aefc6f8a6b44fd3687a5bbce3f8f035c.diff

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:457 +"remote-index-address", +cat(Remote), +desc("Address of the remote index server"), not sure whether we need a new category, probably can live in Features? ==

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9840208db698: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 9840208 - [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

Author: Alexey Bataev Date: 2020-07-24T10:48:20-04:00 New Revision: 9840208db6980f690d09b209e6ad6d57133ec5e5 URL: https://github.com/llvm/llvm-project/commit/9840208db6980f690d09b209e6ad6d57133ec5e5 DIFF: https://github.com/llvm/llvm-project/commit/9840208db6980f690d09b209e6ad6d57133ec5e5.diff

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added a comment. In D84005#2171962 , @MForster wrote: > In D84005#2162433 , @aaron.ballman > wrote: > > > It's a bit odd that this attribute has an AST node created for it but > > nothing is using th

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:61 Callback(*Response); + ++Received; } shouldn't we increment this before the `continue` above ? (or rename this to `successful` rather than `received`

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. Thank you so much, you really went out of your way to dig that out! I'll try to patch this somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82598/new/ https://reviews.llvm.org/D82598

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus added a comment. This was accidentally committed as a part of rGb6cbe6cb0399d4671e5384dcc326af56bc6bd122 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82122/new/ htt

[PATCH] D84525: [clangd] Add marshalling code for all request types

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:53 -clangd::FuzzyFindRequest -Marshaller::fromProtobuf(const FuzzyFindRequest *Request) { +namespace { +template nit: move anon namespace to the top

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. Wow, I never realized I accidentally landed that assert (D82122#2172360 ), but I guess its great to have that covered. Would you prefer to have that reverted as I'm looking to fix this for good? Repository: rG LLVM Github M

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

MaskRay added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( The substitution is here just to make a test. Can it be t

[PATCH] D84356: [AIX] remove -u from the clang when invoke aix as assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b61177d7d4: [AIX] remove -u from the clang when invoke aix as assembler (authored by DiggerLin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84356/new/

[clang] 77b6117 - [AIX] remove -u from the clang when invoke aix as assembler

Author: diggerlin Date: 2020-07-24T11:28:17-04:00 New Revision: 77b61177d7d4c4fe8714f8828123f626f4549be1 URL: https://github.com/llvm/llvm-project/commit/77b61177d7d4c4fe8714f8828123f626f4549be1 DIFF: https://github.com/llvm/llvm-project/commit/77b61177d7d4c4fe8714f8828123f626f4549be1.diff LOG

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, yusra.syeda, zarko, xingxue. Xiangling_L added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, jfb, kbarton, hiraditya, nemanjai. Herald added a project: clang. 1. Frontend sid

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, is there any other concern for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___ cfe-commits mailing list cfe-com

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle marked 3 inline comments as done. nhaehnle added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:44 +// use on a 32-bit architecture. +assert(wrapped != (uintptr_t)-1 && wrapped != (uintptr_t)-2); + arsenm wrote: > I fee

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ added a comment. I still wonder what made this statement live in my example. There must have been some non-trivial liveness analysis going on that caused a statement to be live; probably something to do with the C++ destructor elements. In D82598#2172371

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8914 + ASTContext &C = CGF.getContext(); + QualType Int64Ty = C.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/true); + RecordDecl *RD; 1. The second argument must be of inte

[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

amyk accepted this revision as: amyk. amyk added a comment. I think this LGTM now. The file is already upstream, so your tests will need to be added to that file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83955/new/ https://reviews.llvm.org/D8

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

amyk requested changes to this revision. amyk added a comment. This revision now requires changes to proceed. Could you please add back the MC tests for the rightmost load/store instructions, and then add the vector string isolate tests to the end of the file? Repository: rG LLVM Github Mono

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added a comment. I realize it may be possible to open code these, as these functions already exist in altivec.h. Could you look into if this is the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 280474. cchen added a comment. Fix coding style and argument on getIntTypeForBitwidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/Ope

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280476. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-to

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

gribozavr2 added a comment. What is this diff based on? On the left I see, for example, NamespaceNameSpecifier, which is not in the repository yet. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:777 // FIXME: Support Microsoft's __super - return new (allocator(

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55 +template +llvm::Optional> getIDs(MessageT *Message) { + llvm::DenseSet Result; kadircet wrote: > I would make this return an expected instead of an

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. When dereferencing Optional's it makes sense to use ASSERT_TRUE for better test failures readability. Sw

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks! Repository: rG LLVM Github Monorepo C

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2172482 , @cchen wrote: > @ABataev, do I need to wait for the runtime patch to commit this one? If so, > do you have some recommend reviewers for me to add to that patch? I have > pinged several times for that patch but

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( MaskRay

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle updated this revision to Diff 280481. nhaehnle marked an inline comment as done. nhaehnle added a comment. v6: - implement predecessors/successors for all CfgTraits implementations - fix error in unwrapRange - rename toGeneric/fromGeneric into wrapRef/unwrapRef to have naming

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; vitalybuka wrote: > isn't better just create new s

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse updated this revision to Diff 280485. morehouse marked 5 inline comments as done. morehouse added a comment. - Rename flag - Clarify doc example - Use temporary variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/ https://r

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280497. eduucaldas added a comment. - Improve getLocalSourceRange - nested-name-specifier is now a ::-separated list of name-specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://review

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This is needed because the epilogue code inserted before tail calls on x86-64 breaks the handshake between the caller and

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

NoQ added a comment. In D83961#2166903 , @balazske wrote: > Every other test failure comes from RetainCount checker except > //malloc-plist.c//. Aha, ok. So, anyway, for retain count checker we ultimately only care about plist and html reports, not abo

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) hans wrote: > zequanwu wr

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 280504. zequanwu added a comment. Change `newSR.ColumnEnd = 1` to `newSR.ColumnEnd = SR.ColumnStart + 1` to ensure ColumnEnd >= ColumnStart. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/i

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 280507. dokyungs added a comment. Relanding this reverted commit. (See summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

protze.joachim added a comment. This patch breaks compilation of previously working code. I added the following to `openmp/libomptarget/test/offloading/offloading_success.c`: +// RUN: %libomptarget-compile-run-and-check-nvptx64-nvidia-cuda which results in # command stderr: ptxas offloa

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280511. eduucaldas added a comment. - Remove UnknownNameSpecifier, answer to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang/To

[PATCH] D84005: Introduce ns_error_domain attribute.

doug.gregor added a comment. In D84005#2171982 , @MForster wrote: > @milseman, @doug.gregor, could you please help with the open questions on > this review? > > Specifically: > > - Is `ns_error_domain` ever needed for something other than an enum? No, i

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

protze.joachim reopened this revision. protze.joachim added a comment. This revision is now accepted and ready to land. I carefully made sure, that the freshly built clang was used to execute the test. I opened https://bugs.llvm.org/show_bug.cgi?id=46836 to track the issue and made it release bl

[PATCH] D83592: [Coverage] Add comment to skipped regions

hans added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) zequanwu wrote: > hans wrote: > > zequanwu wrote: > > > @hans , can you

[PATCH] D84476: Make hip math headers easier to use from C

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:98 // BEGIN FLOAT +#ifdef _cplusplus __DEVICE__ typo ? Comment at: clang/lib/Headers/__clang_hip_math.h:558 // BEGIN DOUBLE +#ifdef _cplusplus __DEVICE__ ---

  1   2   >