[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:227 continue; + // Ignore tokens in disabled preprocessor sections. + if (Buf.expandedTokens(SM.getMacroArgExpandedLocation(T->location())) ArcsinX wrote: > sam

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster created this revision. MForster added reviewers: gribozavr2, milseman. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is chery-picked from https://github.com/llvm/llvm-project-staging/commit/a14779f504b02ad0e4dbc39d6d10

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 marked 4 inline comments as done. gamesh411 added a comment. I am now experimenting with the suggestions. The other issues are on the worklist. Thanks for these so far. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:50 + if (is

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, I still would appreciate @calixte feedback here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://re

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; Could we try to add a list of subjects here? It seems

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278682. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Refactor marshalling into a class, log errors only on the high level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278683. kbobyrev added a comment. Remove (now empty) Marshalling.h file comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files: clang-tools-extra/clangd/inde

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added a comment. You haven't addressed my earlier inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-co

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. This allows efficiently accessing all expansions (without iterating over each token and searching), and also identifying tokens within a range that are affecte

[clang] bb160e7 - [Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

Author: Cullen Rhodes Date: 2020-07-17T10:06:54Z New Revision: bb160e769dbef25fe0aa130c71458a8f686ccf80 URL: https://github.com/llvm/llvm-project/commit/bb160e769dbef25fe0aa130c71458a8f686ccf80 DIFF: https://github.com/llvm/llvm-project/commit/bb160e769dbef25fe0aa130c71458a8f686ccf80.diff LOG:

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

This revision was automatically updated to reflect the committed changes. c-rhodes marked an inline comment as done. Closed by commit rGbb160e769dbe: [Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute (authored by c-rhodes). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 278703. gamesh411 added a comment. move tests to one file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files: clang/include/clang/StaticAnalyzer/Checkers/Checker

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selectionThis prevents selection of empty preprocessor entities (like #define directives,or text in disabled sections) creating a s

sammccall created this revision. sammccall added reviewers: ArcsinX, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Based on D83508 by Aleksandr Platonov. Repository: rG LL

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. Tried this out in D84012 /D84009 . Works pretty well, and I think the API is a useful and natural addition to TokenBuffer. Maybe this is too much complexity though? (Mostly here i'm worrying about the c

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:228 + Buf.expansionsAffecting(Sel)) { + if (X.Expanded.empty()) { +for (const syntax

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

ArcsinX added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:252 return {}; - assert(Spelled.front().location().isFileID()); - - auto FID = sourceManager().getFileID(Spelled.front().location()); - auto It = Files.find(FID); - assert(It != Files.end());

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:431 +std::vector +TokenBuffer::expansionsAffecting(llvm::ArrayRef Spelled) const { + if (Spelled.empty()) ArcsinX wrote: > Will it be useful to have similar API with FileID/MarkedFi

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

sammccall updated this revision to Diff 278716. sammccall marked 2 inline comments as done. sammccall added a comment. auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84009/new/ https://reviews.llvm.org/D84009 Files: clang/include/clang/Tooli

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

sammccall updated this revision to Diff 278717. sammccall marked 3 inline comments as done. sammccall edited the summary of this revision. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84012/new/ https://

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

ArcsinX added a comment. Thanks. This LGTM, but I think I don't have enough experience to accept revisions and could miss something important. So, may be @kadircet could accept it if its OK for him. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX added a comment. In D83508#2157859 , @sammccall wrote: > Tried this out in D84012 /D84009 > . Works pretty well, and I think the API is > a useful and natural addition to TokenBuff

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. In D83501#2154300 , @dgoldman wrote: > In D83501#2153605 , @sammccall wrote: > > > In D83501#2148671 , @dgoldman > > wrote: > > > > > I implemente

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

kadircet added a comment. thanks, mostly LG with a comment about some edge case. just wanna know what you think. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:281 + std::vector + expansionsAffecting(llvm::ArrayRef Spelled) const; this sounds more

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 278724. MForster marked 4 inline comments as done. MForster added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/i

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done and an inline comment as not done. MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain"

[PATCH] D81728: [InstCombine] Add target-specific inst combining

foad added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:552-555 + /// \returns false to not do anything target specific or true to return the + /// value in \p ResultI from the InstCombiner. It is possible to return null + /// and stop further

[clang] 4fc752b - [CUDA][HIP] Always defer diagnostics for wrong-sided reference

Author: Yaxun (Sam) Liu Date: 2020-07-17T07:51:55-04:00 New Revision: 4fc752b30b9acac73a282cb844a6240e6cb70cca URL: https://github.com/llvm/llvm-project/commit/4fc752b30b9acac73a282cb844a6240e6cb70cca DIFF: https://github.com/llvm/llvm-project/commit/4fc752b30b9acac73a282cb844a6240e6cb70cca.dif

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc752b30b9a: [CUDA][HIP] Always defer diagnostics for wrong-sided reference (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 added a comment. Did your latest update unintentionally drop the test file `clang/test/Analysis/ns_error_enum.m`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 __

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 278727. gamesh411 marked 3 inline comments as done. gamesh411 added a comment. extend test cases add comments to non-obvious cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added a comment. FWIW, this is *really* hard to review because it's not a diff against the trunk and so it's not immediately clear what the actual changes are. The change is missing all of its test coverage. Comment at: clang/include/clang/Basic/Attr.td:1860 +de

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 278728. MForster marked an inline comment as not done. MForster added a comment. Fix diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2158019 , @gribozavr2 wrote: > Did your latest update unintentionally drop the test file > `clang/test/Analysis/ns_error_enum.m`? I'm struggling with arcanist :-). Fixed. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2158029 , @aaron.ballman wrote: > FWIW, this is *really* hard to review because it's not a diff against the > trunk and so it's not immediately clear what the actual changes are. > > The change is missing all of its te

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 added inline comments. Comment at: clang/test/Analysis/sufficient-size-array-indexing-32bit.c:120 + +void test_symbolic_index_handling4(int choice) { + char c; balazske wrote: > Here "is a chance that indexing is correct". So no warning should occur? I

[PATCH] D83979: Port LangOpts option flags to new option parsing system

dang updated this revision to Diff 278729. dang added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/

[clang] a46ef7d - Revert "[CUDA][HIP] Always defer diagnostics for wrong-sided reference"

Author: Yaxun (Sam) Liu Date: 2020-07-17T08:10:56-04:00 New Revision: a46ef7d42dc8aa5083319bef678262bddf299f82 URL: https://github.com/llvm/llvm-project/commit/a46ef7d42dc8aa5083319bef678262bddf299f82 DIFF: https://github.com/llvm/llvm-project/commit/a46ef7d42dc8aa5083319bef678262bddf299f82.dif

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9450 +def err_nserrordomain_not_tagdecl : Error< + "ns_error_domain attribute only valid on " + "%select{enums, structs, and unions|enums, structs, unions, and classes}0">; ---

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83979 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84018 Files: clang/include/clang

[clang] de0c6bd - Add -o /dev/null to make it explicit that we don't care about the

Author: Adrian Kuegel Date: 2020-07-17T14:21:13+02:00 New Revision: de0c6bd56b41081f1b89a1c7a0bf2597fd6d0104 URL: https://github.com/llvm/llvm-project/commit/de0c6bd56b41081f1b89a1c7a0bf2597fd6d0104 DIFF: https://github.com/llvm/llvm-project/commit/de0c6bd56b41081f1b89a1c7a0bf2597fd6d0104.diff

[PATCH] D83822: [clangd] Support config over LSP.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220 CDB->setCompileCommand(File, std::move(New)); ModifiedFiles.insert(File); } kadircet wrote: > nit: maybe

[clang] fd02a86 - [analyzer] Add system header simulator a symmetric random access iterator operator+

Author: Endre Fülöp Date: 2020-07-17T14:36:43+02:00 New Revision: fd02a86260b3fb01361175af9600d53354631fb2 URL: https://github.com/llvm/llvm-project/commit/fd02a86260b3fb01361175af9600d53354631fb2 DIFF: https://github.com/llvm/llvm-project/commit/fd02a86260b3fb01361175af9600d53354631fb2.diff L

[PATCH] D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd02a86260b3: [analyzer] Add system header simulator a symmetric random access iterator… (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; aaron.ballman wrote: > MForster wrote: > > gribozavr2

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Will resolve the comments and add some missing examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 __

[clang] 16a4350 - [MSP430] Actualize the toolchain description

Author: Anatoly Trosinenko Date: 2020-07-17T15:42:12+03:00 New Revision: 16a4350f76d2bead7af32617dd557d2ec096d2c5 URL: https://github.com/llvm/llvm-project/commit/16a4350f76d2bead7af32617dd557d2ec096d2c5 DIFF: https://github.com/llvm/llvm-project/commit/16a4350f76d2bead7af32617dd557d2ec096d2c5.

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

This revision was automatically updated to reflect the committed changes. Closed by commit rG16a4350f76d2: [MSP430] Actualize the toolchain description (authored by atrosinenko). Changed prior to commit: https://reviews.llvm.org/D81676?vs=276693&id=278741#toc Repository: rG LLVM Github Monor

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko added a comment. After a final retesting, this patch was updated a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 ___ cfe-commits mailing list

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske updated this revision to Diff 278742. balazske marked an inline comment as done. balazske added a comment. Fixed some source location changes in tests. Re-added check for empty path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83961/new/

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske added a comment. Big part of the test failures is with the `osx.cocoa.RetainCount` checker. Only a small part of the errors is fixed now. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:369 +} + } if (X.getBugType() != Y.getBugType()) This c

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

paulwalker-arm created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. No real action is taken for a value of scalable but it provides a route to disable an earlier specification and is effectively its default value when omitted. Patch also removes a

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

paulwalker-arm updated this revision to Diff 278744. paulwalker-arm added a comment. Fixed typo to match existing wrapping style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84021/new/ https://reviews.llvm.org/D84021 Files: clang/include/clang

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278747. gamesh411 added a comment. rebase upon hotfix patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190 Files: clang/lib/StaticAnalyzer/Checkers/IteratorModelin

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:281 + std::vector + expansionsAffecting(llvm::ArrayRef Spelled) const; kadircet wrote: > this sounds more like `expansionsAffe

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

sammccall updated this revision to Diff 278748. sammccall added a comment. expansionsAffecting->expansionsOverlapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84009/new/ https://reviews.llvm.org/D84009 Files: clang/include/clang/Tooling/Syn

[clang] 9275e14 - recommit 4fc752b30b9a [CUDA][HIP] Always defer diagnostics for wrong-sided reference

Author: Yaxun (Sam) Liu Date: 2020-07-17T09:14:39-04:00 New Revision: 9275e14379961a4304de559f16fdbac275fb6301 URL: https://github.com/llvm/llvm-project/commit/9275e14379961a4304de559f16fdbac275fb6301 DIFF: https://github.com/llvm/llvm-project/commit/9275e14379961a4304de559f16fdbac275fb6301.dif

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2157957 , @sammccall wrote: > In D83501#2154300 , @dgoldman wrote: > > > In D83501#2153605 , @s

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 278752. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor test and formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 added a comment. It would be nice to see the measurements on llvm as this patch introduced some (IMO reasonable) asserts. Also in the unlikely case, there is an expression like `1 + iter`, there could be more results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske updated this revision to Diff 278755. balazske added a comment. Checking notes in test `f_leak_2`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82845/new/ https://reviews.llvm.org/D82845 Files: clang/lib/StaticAnalyzer/Checkers/StreamC

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

balazske added a comment. Future improvement: Split `ASTImporterTest.cpp` into smaller parts. It is still too large. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83970/new/ https://reviews.llvm.org/D83970 __

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; gribozavr2 wrote: > aaron.ballman wrote: > > MForst

[PATCH] D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

vrnithinkumar updated this revision to Diff 278759. vrnithinkumar marked 11 inline comments as done. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Changes from review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:198 void SmartPtrModeling::handleSwap(const CallEvent &Call, CheckerContext &C) const { vsavchenko wrote: > I think it wo

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! (and loved the choice of `overlapping`) Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:431 +std::vector +TokenBuffer::expansionsAffecting(llvm::ArrayRef Sp

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > > c-rhodes wrote: > > > > aaron.ballman wrote: >

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added reviewers: aaron.ballman, riccibruno, martong. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. In D83174#2156454 , @v.g.vassilev wrote: > >> Also, I would like to add that the current test present in this diff does

[PATCH] D83901: [clang] Disable a few formatting options for test/

aaron.ballman accepted this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good improvement, but you should wait for a few days in case other reviewers have feedback. Repository: rG L

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1252-1253 + "incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'">; +def err_omp_map_type_modifier_wrong_version : Error< + "map type modifier '%0' requires

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:55 IncludeSorter &IncludeInserter::getOrCreate(FileID FileID) { + assert(SourceMgr && "SourceMgr shouldn't be null"); // std::unique_ptr is cheap to construct, so force a

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else + MappedVarSet.insert(nullptr); if (CurBasePointers.empty()) jdenn

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio marked 6 inline comments as done. dnsampaio added a comment. Indeed not all of them. Fixed this time. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) +

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro created this revision. ro added reviewers: clang, rsmith, mehdi_amini, rnk. ro added a project: clang. Herald added a subscriber: fedor.sergeev. `clang` currently requires the native linker on Solaris: - It passes `-C` to `ld` which GNU `ld` doesn't understand. - To use `gld`, one needs to p

[PATCH] D83822: [clangd] Support config over LSP.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220 CDB->setCompileCommand(File, std::move(New)); ModifiedFiles.insert(File); } sammccall wrote: > kadircet wrote: > > nit: maybe just set `ReparseAllFile

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else + MappedVarSet.insert(nullptr); if (CurBase

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1252-1253 + "incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'">; +def err_omp_map_type_modifier_wrong_version : Error< + "map type modifier '%0' requires

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1252-1253 + "incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'">; +def err_omp_map_type_modifier_wrong_version : Error< + "map type modifier '%0' requires

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

Xiangling_L updated this revision to Diff 278777. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Adjust the quesry; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83974/new/ https://reviews.llvm.org/D83974 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/

[PATCH] D84032: [clang] Make clear Sema::CheckForConstantInitializer is for C-only codepath.

hokein created this revision. hokein added reviewers: sammccall, efriedma. Herald added a project: clang. - add an assertion; - remove the changes introduced in https://github.com/llvm/llvm-project/commit/4a962f03bebef9e3c7d501580357a303638b2700, looks like clang can handle that well at the mome

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else + MappedVarS

[PATCH] D84032: [clang] Make clear Sema::CheckForConstantInitializer is for C-only codepath.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11072 // rules there don't matter.) + assert(!getLangOpts().CPlusPlus || getLangOpts().OpenCLCPlusPlus); const Expr *Culprit; openCL for C++ is t

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked 3 inline comments as done. jdenny added a comment. Thanks for the review. Will try to push soon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922 ___ cfe-commits mailing list cfe-commit

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. nit: s/suppoort/support/ (in title) LGTM otherwise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84021/new/ https://reviews.llvm.org/D840

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:654 + unsigned LaneIDBits = + CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size_Log2); return Bld.CreateAShr(getNVPTXThreadID(CGF), LaneID

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83974/new/ https://reviews.llvm.org/D83974 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278787. saiislam added a comment. Removed getNVPTXWarpSize() changes for a separate patch and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files: clang/l

[PATCH] D83822: [clangd] Support config over LSP.

sammccall added a comment. There are lots of choices and overlapping ideas for how the protocol should look, little urgency (it isn't going to make clangd 11), and few concrete use cases to evaluate the options. Let's table this for now and let the ideas sink in and more use cases crop up. I d

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. In D83915#2156346 , @jsji wrote: > In D83915#2155650 , > @hubert.reinterpretcast wrote: > > > Should we indicate planned removal in the Release Notes for version 11 and > > actual removal in

[PATCH] D83901: [clang] Disable a few formatting options for test/

riccibruno added a comment. In D83901#2155127 , @MyDeveloperDay wrote: > clang-format -n warnings before this change in clang/test/Analysis/*.cpp > (clang-format -n *.cpp |& grep warning | wc -l) > > before = 6903 vs after=6595, if it helps I'd say thi

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278799. saiislam added a comment. Corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index: clang/lib/CodeG

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 _

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. The problem with `fgetc` is here that the returned value indicates not only if there was failure or not. In the following (over simplified) example no warning is needed even if there is no check for EOF. Because this case, for such kind of functions any comparison of t

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

paulwalker-arm updated this revision to Diff 278803. paulwalker-arm added a comment. Herald added a subscriber: dang. Sorry for the post acceptance change, but I spotted the help text needed an update also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

njames93 updated this revision to Diff 278807. njames93 marked 5 inline comments as done. njames93 added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83680/new/ https://reviews.llvm.org/D83680 Files: clang-t

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

calixte accepted this revision. calixte added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83680/new/ https://reviews.llvm.org/D83680

[clang] 14dde43 - With MSVC, file needs to be compiled with /BIGOBJ

Author: Adrian McCarthy Date: 2020-07-17T09:43:06-07:00 New Revision: 14dde438d69c81ab4651157a94d32ee804ff URL: https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff DIFF: https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff.dif

[PATCH] D83991: With MSVC, file needs to be compiled with /BIGOBJ

This revision was automatically updated to reflect the committed changes. Closed by commit rG14dde438d69c: With MSVC, file needs to be compiled with /BIGOBJ (authored by amccarth). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// R

[clang] d19f066 - [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

Author: Aleksandr Platonov Date: 2020-07-17T18:49:14+02:00 New Revision: d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7 URL: https://github.com/llvm/llvm-project/commit/d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7 DIFF: https://github.com/llvm/llvm-project/commit/d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7.

  1   2   >