[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

2020-07-15 Thread George Rokos via Phabricator via cfe-commits
grokos added a comment. I tried to build clang with this patch and I get errors like: CGOpenMPRuntime.cpp:9463:38: error: ‘OMPRTL___tgt_target_teams_nowait_mapper’ was not declared in this scope ? OMPRTL___tgt_target_teams_nowait_mapper Where are these `O

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

2020-07-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added reviewers: vsk, rjmccall, ABataev. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes cases where an invoke is emitted, despite the called llvm function being marked nounwind, because `CodeGenModule::

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

2020-07-15 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 278305. yonghong-song added a comment. fix clang-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 Files: clang/include/clang/Basic/DiagnosticSem

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

2020-07-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. In case it wasn't clear, the calls to `mayThrow()` in the test cases are needed to prevent `TryMarkNoThrow` from annotating the functions with nounwind, which would cause a lot of churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-15 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 278310. dgoldman marked an inline comment as done. dgoldman added a comment. SymbolCollector fixes + more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

2020-07-15 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/test/CodeGenObjCXX/os_log.mm:16 // An `invoke` of a `nounwind` callee is simplified to a direct // call by an optimization in llvm. Just

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-15 Thread David Goldman via Phabricator via cfe-commits
dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:614 + +TEST_F(SymbolCollectorTest, ObjCClassExtensions) { + Annotations Header(R"( Here's the ClassExtension that I

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

2020-07-15 Thread David Van Cleve via Phabricator via cfe-commits
davidvancleve added a comment. Thanks for the quick response! Nope, no compile_commands.json files, and they didn't previously contain .clangd files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 _

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

2020-07-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. If the variable is constrcutible, its copy is created by calling a constructor. Such variables are duplicated and thus, must be captured. Repos

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

2020-07-15 Thread Andy Soffer via Phabricator via cfe-commits
asoffer updated this revision to Diff 278315. asoffer marked 2 inline comments as done. asoffer added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ https://reviews.llvm.org/D83820 Files: clang/include/clang/Toolin

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

2020-07-15 Thread Andy Soffer via Phabricator via cfe-commits
asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do so. AnyGenerator Metadata = [](const ast_matchers::MatchFinde

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

2020-07-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 278316. ahatanak marked an inline comment as done. ahatanak added a comment. Update comment in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83906/new/ https://reviews.llvm.org/D83906 Files: clan

[clang] ed6b578 - [CodeGen] Emit a call instruction instead of an invoke if the called

2020-07-15 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-07-15T14:47:45-07:00 New Revision: ed6b578040a85977026c93bf4188f996148f3218 URL: https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218 DIFF: https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218.diff

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

2020-07-15 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed6b578040a8: [CodeGen] Emit a call instruction instead of an invoke if the called llvm… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D83914: [clangd] Plan features for FoldingRanges

2020-07-15 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is not an actual patch, this is an RFC + TDD plan for future RAV implementation. Hopeful

[PATCH] D83914: [clangd] Plan features for FoldingRanges

2020-07-15 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 278327. kbobyrev added a comment. Fix some typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cp

<    1   2   3