grokos added a comment.
I tried to build clang with this patch and I get errors like:
CGOpenMPRuntime.cpp:9463:38: error: ‘OMPRTL___tgt_target_teams_nowait_mapper’
was not declared in this scope
? OMPRTL___tgt_target_teams_nowait_mapper
Where are these `O
ahatanak created this revision.
ahatanak added reviewers: vsk, rjmccall, ABataev.
ahatanak added a project: clang.
Herald added subscribers: ributzka, dexonsmith, jkorous.
This fixes cases where an invoke is emitted, despite the called llvm function
being marked nounwind, because `CodeGenModule::
yonghong-song updated this revision to Diff 278305.
yonghong-song added a comment.
fix clang-format warnings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83242/new/
https://reviews.llvm.org/D83242
Files:
clang/include/clang/Basic/DiagnosticSem
ahatanak added a comment.
In case it wasn't clear, the calls to `mayThrow()` in the test cases are needed
to prevent `TryMarkNoThrow` from annotating the functions with nounwind, which
would cause a lot of churn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
dgoldman updated this revision to Diff 278310.
dgoldman marked an inline comment as done.
dgoldman added a comment.
SymbolCollector fixes + more tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83501/new/
https://reviews.llvm.org/D83501
Files:
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Comment at: clang/test/CodeGenObjCXX/os_log.mm:16
// An `invoke` of a `nounwind` callee is simplified to a direct
// call by an optimization in llvm. Just
dgoldman marked an inline comment as done.
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:614
+
+TEST_F(SymbolCollectorTest, ObjCClassExtensions) {
+ Annotations Header(R"(
Here's the ClassExtension that I
davidvancleve added a comment.
Thanks for the quick response! Nope, no compile_commands.json files, and they
didn't previously contain .clangd files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83099/new/
https://reviews.llvm.org/D83099
_
ABataev created this revision.
ABataev added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, guansong, yaxunl.
Herald added a project: clang.
If the variable is constrcutible, its copy is created by calling a
constructor. Such variables are duplicated and thus, must be captured.
Repos
asoffer updated this revision to Diff 278315.
asoffer marked 2 inline comments as done.
asoffer added a comment.
Typo fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83820/new/
https://reviews.llvm.org/D83820
Files:
clang/include/clang/Toolin
asoffer added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93
+ // Not all transformations will want or need to attach metadata and therefore
+ // sholud not be requierd to do so.
AnyGenerator Metadata = [](const ast_matchers::MatchFinde
ahatanak updated this revision to Diff 278316.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Update comment in test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83906/new/
https://reviews.llvm.org/D83906
Files:
clan
Author: Akira Hatanaka
Date: 2020-07-15T14:47:45-07:00
New Revision: ed6b578040a85977026c93bf4188f996148f3218
URL:
https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218
DIFF:
https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed6b578040a8: [CodeGen] Emit a call instruction instead of
an invoke if the called llvm… (authored by ahatanak).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
This is not an actual patch, this is an RFC + TDD plan for future RAV
implementation. Hopeful
kbobyrev updated this revision to Diff 278327.
kbobyrev added a comment.
Fix some typos.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83914/new/
https://reviews.llvm.org/D83914
Files:
clang-tools-extra/clangd/unittests/SemanticSelectionTests.cp
201 - 216 of 216 matches
Mail list logo