[clang] ac47588 - [Driver] Add negative option for -fkeep-static-consts

Author: Shengchen Kan Date: 2020-06-03T14:59:14+08:00 New Revision: ac47588bc4ff5927a01ed6fcd269ce86aba52a7c URL: https://github.com/llvm/llvm-project/commit/ac47588bc4ff5927a01ed6fcd269ce86aba52a7c DIFF: https://github.com/llvm/llvm-project/commit/ac47588bc4ff5927a01ed6fcd269ce86aba52a7c.diff

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:6158 public: - TypoExpr(QualType T) : Expr(TypoExprClass, T, VK_LValue, OK_Ordinary) { + TypoExpr(QualType T, SourceLocation Start, SourceLocation End) + : Expr(TypoExprClass, T, VK_LValue, OK_Ordina

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice find, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ c

[PATCH] D77168: Add a flag to debug automatic variable initialization

llozano added a comment. In D77168#2070083 , @MaskRay wrote: > In D77168#2070049 , @jcai19 wrote: > > > In D77168#2069783 , @MaskRay wrote: > > > > > Do we have a mechanism b

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81019/new/ https://reviews.llvm.org/D81019

[PATCH] D81040: Split syntax tree tests into more granular ones

hlopko accepted this revision. hlopko added a comment. Thanks for working on this! :) Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066 +int func3b(int *); +int func4(int a, float b); +int func4a(int, float); func4 -> func4a func4a -> func4b? Repos

[clang-tools-extra] 65fa0a9 - [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

Author: Nathan James Date: 2020-06-03T09:23:32+01:00 New Revision: 65fa0a9f7f3e6090e335c14f9edea19358d87613 URL: https://github.com/llvm/llvm-project/commit/65fa0a9f7f3e6090e335c14f9edea19358d87613 DIFF: https://github.com/llvm/llvm-project/commit/65fa0a9f7f3e6090e335c14f9edea19358d87613.diff

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 accepted this revision. njames93 added a comment. LGTM, but I wouldn't say no to a test case using `(Limit) -= 1`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing lis

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazs

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

balazske added a comment. Here is an improved fix for the problem: D81061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 ___

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing ---

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske added a comment. There may be still a problem somewhere else. I think assume of "a" and "a==0" should have the same results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061 _

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 268082. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80366/new/ https://reviews.llvm.org/D80366 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEv

[PATCH] D80877: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fa0a9f7f3e: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + vsavchenko wrote: > Szelethus wrote: > > baloghadamsoftware wrote: >

[clang] b34b769 - Syntax tree: ignore implicit expressions at the top level of statements

Author: Dmitri Gribenko Date: 2020-06-03T10:58:12+02:00 New Revision: b34b7691facd89022e7fee174debdbd2bf7920f3 URL: https://github.com/llvm/llvm-project/commit/b34b7691facd89022e7fee174debdbd2bf7920f3 DIFF: https://github.com/llvm/llvm-project/commit/b34b7691facd89022e7fee174debdbd2bf7920f3.dif

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. A followup of D79938 . Repository: rG LLVM Github Monorepo https://revie

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066 +int func3b(int *); +int func4(int a, float b); +int func4a(int, float); hlopko wrote: > func4 -> func4a > func4a -> func4b? Fixed, thanks. Repository: rG LLVM Gith

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing eduucaldas wrote: > I tho

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This saves something like 20% latency on the AST build with a typical load of clang-

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr updated this revision to Diff 268100. gribozavr added a comment. Refreshing this patch after pushing the patch that this one depends on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/ https://reviews.llvm.org/D81040 Files: cl

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGb34b7691facd: Syntax tree: ignore implicit expressions at the top level of statements (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] d7d5dd3 - Split syntax tree tests into more granular ones

Author: Dmitri Gribenko Date: 2020-06-03T11:17:11+02:00 New Revision: d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a URL: https://github.com/llvm/llvm-project/commit/d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a DIFF: https://github.com/llvm/llvm-project/commit/d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a.dif

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr updated this revision to Diff 268104. gribozavr added a comment. Address code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/ https://reviews.llvm.org/D81040 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 268105. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp cla

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. In D80950#2069733 , @curdeius wrote: > The change seems to me technically sound, but I'm not sure of the scope of > its effects. There might be users that rely on this behavior. On the other > hand, adding an option to kee

[PATCH] D81040: Split syntax tree tests into more granular ones

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7d5dd31fc6f: Split syntax tree tests into more granular ones (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/ https://revi

[clang] e6ba0a5 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2020-06-03T11:12:43+01:00 New Revision: e6ba0a55fd39b600f3f431308f4a7e36e48f91ae URL: https://github.com/llvm/llvm-project/commit/e6ba0a55fd39b600f3f431308f4a7e36e48f91ae DIFF: https://github.com/llvm/llvm-project/commit/e6ba0a55fd39b600f3f431308f4a7e36e48f91ae.diff

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268116. njames93 added a comment. Included more builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTy

[clang-tools-extra] add51e1 - [clang-tidy] add new check readability-use-anyofallof

Author: Matthias Gehre Date: 2020-06-03T12:19:06+02:00 New Revision: add51e152aa6dc3aa7a51901a099b2ebe8cfe377 URL: https://github.com/llvm/llvm-project/commit/add51e152aa6dc3aa7a51901a099b2ebe8cfe377 DIFF: https://github.com/llvm/llvm-project/commit/add51e152aa6dc3aa7a51901a099b2ebe8cfe377.diff

[clang] 8beaba1 - [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

Author: Lucas Prates Date: 2020-06-03T11:39:27+01:00 New Revision: 8beaba13b8a61697008854b82ed3b45377af9d9d URL: https://github.com/llvm/llvm-project/commit/8beaba13b8a61697008854b82ed3b45377af9d9d DIFF: https://github.com/llvm/llvm-project/commit/8beaba13b8a61697008854b82ed3b45377af9d9d.diff

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre updated this revision to Diff 268120. mgehre added a comment. Implemented njames93's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files: clang-tools-extra/clang-tidy/readability/CMakeLi

[PATCH] D81075: [ASTMatchers] Fix crash with HasName and HasAnyName

njames93 created this revision. njames93 added reviewers: klimek, sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes crashes caused by matching fully qualified RecordDecls inside Function bodies. See https://bugs.llvm.org/show_bug.cgi?id=43639. I'm still unsure i

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1108 + std::move(CI), + !CompletingInPreamble ? &(Input.Preamble.Preamble) : nullptr, std::mo

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + baloghadamsoftware wrote: > vsavchenko wrote: > > Szelethus wrote: > > > baloghadamsoftware wrote: > > > > Szelethus wrote: > > > > > Thi

[PATCH] D80876: [clang] Default to windows response files when running on windows

mati865 added a comment. I don't have strong opinion here as I don't know this topic well (things just worked so far). That said if Clang stops working as a drop-in replacement for GCC with commonly used build systems, MSYS2 will have to carry one more patch to bring back old behaviour. Repos

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

This revision was automatically updated to reflect the committed changes. Closed by commit rGadd51e152aa6: [clang-tidy] add new check readability-use-anyofallof (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://r

[clang-tools-extra] fd27401 - attempt to fix build after add51e152aa

Author: Nico Weber Date: 2020-06-03T06:49:50-04:00 New Revision: fd2740143e626ca32432aac0b51b2880a3b1e0bc URL: https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc DIFF: https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc.diff LO

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG8beaba13b8a6: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:369 + Inputs.Index && !BuildDir.getError()) { auto Style = getFormatStyleForFile(Filename, Inputs.Contents, VFS.get()); auto Inserter = std::make_shared( while here,

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 268131. baloghadamsoftware added a comment. Comment fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/include/clan

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + NoQ wrote: > What's the po

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

gribozavr2 added a comment. This change broke the build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/29716. The build is already fixed by https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc. Please always run `ninja check-all` before pushi

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Ping. Furthermore: how can I schedule another CI build with the newest version of the diff? When I go to the failed build from Harbormaster and I click restart, it rebuilds an older version of the diff. Thanks for the info! CHANGES SINCE LAST ACTION https://

[PATCH] D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The name of the option was changed here: https://github.com/llvm/llvm-project/commit/6a30894391ca671bab1

[PATCH] D81079: [clangd] Add std::move() to a return statement to please some compilers.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This has been causing build errors in Swift CI. R

[clang] a2f32bf - [clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions.

Author: Bruno Ricci Date: 2020-06-03T12:35:12+01:00 New Revision: a2f32bfcc7cd6828785011ce90f6e0314d096e89 URL: https://github.com/llvm/llvm-project/commit/a2f32bfcc7cd6828785011ce90f6e0314d096e89 DIFF: https://github.com/llvm/llvm-project/commit/a2f32bfcc7cd6828785011ce90f6e0314d096e89.diff L

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll created this revision. simoll added reviewers: hfinkel, erichkeane, craig.topper, rsandifo-arm, kaz7, k-ishizaka. simoll added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a reviewer: rengolin. simoll updated this revision to Diff 268140. simoll added

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

curdeius added a comment. I would have nothing against if you'd added this option and we kept current behaviour by default. The only drawback is the (bit of) complexity it adds bit that seems justified to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. In D69825#2063979 , @dim wrote: > FWIW, this change causes > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630#c18. > > For some reason, not spawni

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80536/new/ https://reviews.llvm.org/D80536 ___

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:39 +"__builtin_classify_type", +// "__builtin_va_start", +// "__builtin_stdarg_start", I think we may want to keep this one as it's

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + baloghadamsoftware wrote: > NoQ wrote: > > What's the point of overriding one pure virtual met

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:127-129 +// Despite the previous assumptions for non-zero and positiveness, +// this value might be zero or negative. +// At least check for zero again. ---

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. Great! thanks for the review @rsmith . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f32bfcc7cd: [clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions. (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 268140. simoll added a comment. NFC. Undid stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang

[PATCH] D81075: [ASTMatchers] Fix crash with HasName and HasAnyName

njames93 updated this revision to Diff 268142. njames93 added a comment. Fix clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81075/new/ https://reviews.llvm.org/D81075 Files: clang/include/clang/AST/PrettyPrinter.h clang/lib/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

njames93 added a comment. In D80514#2070843 , @bernhardmgruber wrote: > Ping. > > Furthermore: how can I schedule another CI build with the newest version of > the diff? When I go to the failed build from Harbormaster and I click > restart, it rebuilds

[PATCH] D81086: buildkite is open for beta

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81086

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268149. njames93 marked 3 inline comments as done. njames93 added a comment. Add va_start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files: clang-tools-extra/c

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

PiotrFusik marked 2 inline comments as done. PiotrFusik added a comment. > Great! Thanks! Feel free to go ahead and commit this! Thanks. Can someone commit this for me please? Also to 10.0 if possible? > Can you please add a link to the bug describing incorrect optimization to > this review onc

[PATCH] D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20.

mboehme added a comment. Already fixed in https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc Retracting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81080/new/ https://reviews.llvm.org/D81080 __

[PATCH] D81087: Replaced C++2a with C++20 in clang-tools-extra

gribozavr created this revision. gribozavr added a reviewer: hlopko. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81087 Files: clang-tools-extra/

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:40 +// "__builtin_va_start", +// "__builtin_stdarg_start", +"__builtin_assume_aligned", // Documented as variadic to support overloading ---

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

curdeius added a comment. Nice. Should we test other non-C keywords as well? Out of curiosity, where does "@try" come from? Comment at: clang/lib/Format/FormatTokenLexer.cpp:392 + auto &Try = *(Tokens.end() - 2); + auto &Brace = *(Tokens.end() - 1); + if (!Try->is(tok::kw_tr

[clang-tools-extra] c1911fc - Replaced C++2a with C++20 in clang-tools-extra

Author: Dmitri Gribenko Date: 2020-06-03T14:54:10+02:00 New Revision: c1911fcb0664417cbf75b11315bdba39bd6d6390 URL: https://github.com/llvm/llvm-project/commit/c1911fcb0664417cbf75b11315bdba39bd6d6390 DIFF: https://github.com/llvm/llvm-project/commit/c1911fcb0664417cbf75b11315bdba39bd6d6390.dif

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:40 +// "__builtin_va_start", +// "__builtin_stdarg_start", +"__builtin_assume_aligned", // Documented as variadic to support overloading --

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

RKSimon added a comment. @mgehre Please can you take at the remaining buildbot failures here : http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https

[PATCH] D81087: Replaced C++2a with C++20 in clang-tools-extra

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81087/new/ https://reviews.llvm.org/D81087

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; dmgreen wrote: > Do you know what InstName

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 268155. bernhardmgruber added a comment. Reuploaded diff in an attempt to trigger a CI build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTraili

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79237/new/ https://reviews.llvm.org/D79237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay added a comment. > Out of curiosity, where does "@try" come from? Objective C++ I think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80940/new/ https://reviews.llvm.org/D80940 ___ cfe-

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added a comment. We can close this now, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81087: Replaced C++2a with C++20 in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1911fcb0664: Replaced C++2a with C++20 in clang-tools-extra (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81087/new/ https://revie

[clang] 59e0987 - [OPENMP]Fix PR46170: partial mapping for array sections of data members.

Author: Alexey Bataev Date: 2020-06-03T09:10:20-04:00 New Revision: 59e0987a068ca3842dd2b4ddf2edf001fb1de1b5 URL: https://github.com/llvm/llvm-project/commit/59e0987a068ca3842dd2b4ddf2edf001fb1de1b5 DIFF: https://github.com/llvm/llvm-project/commit/59e0987a068ca3842dd2b4ddf2edf001fb1de1b5.diff

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268162. miyuki retitled this revision from "[clang][BFloat] add create/set/get/dup intrinsics" to "[clang][BFloat] Add create/set/get/dup intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Addressed reviewers' comments. CHANGES

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

arsenm added inline comments. Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +^ I would rather just ban si

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein updated this revision to Diff 268164. hokein marked 2 inline comments as done. hokein added a comment. Revert an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81066/new/ https://reviews.llvm.org/D81066 Files: clang-tools-

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81090 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp Index: clang/test/AST/ast-dump-recovery.cpp

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1108 + std::move(CI), + !CompletingInPreamble ? &(Input.Preamble.Preamble) : nullptr, std::move(ContentsBuffer), std::move(VFS), IgnoreDiags); sammccall wrote: >

cfe-commits@lists.llvm.org

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

cfe-commits@lists.llvm.org

LukeGeeson updated this revision to Diff 268165. LukeGeeson added a comment. ran `llvm/utils/update_llc_test_checks.py` on test to get proper `CHECK`s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D81092: Add support for `nullptr` in SyntaxTrees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81092 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay updated this revision to Diff 268163. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80940/new/ https://reviews.llvm.org/D80940 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatTokenLexer.h c

[PATCH] D81037: [OPENMP]Fix PR46170: partial mapping for array sections of data members.

This revision was automatically updated to reflect the committed changes. Closed by commit rG59e0987a068c: [OPENMP]Fix PR46170: partial mapping for array sections of data members. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

MyDeveloperDay updated this revision to Diff 268166. MyDeveloperDay added a comment. Ensure no crash when CurrentToken is nullptr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80933/new/ https://reviews.llvm.org/D80933 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Form

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

joerg added a comment. I don't agree with the justification at all, but it also seems that noone else cares about the build option creep here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80300/new/ https://reviews.llvm.org/D80300

[clang-tools-extra] a3220df - [clangd] Add std::move() to a return statement to please some compilers.

Author: Martin Boehme Date: 2020-06-03T15:40:01+02:00 New Revision: a3220dffcb1da0cfe3e22a336141c76c78d474b7 URL: https://github.com/llvm/llvm-project/commit/a3220dffcb1da0cfe3e22a336141c76c78d474b7 DIFF: https://github.com/llvm/llvm-project/commit/a3220dffcb1da0cfe3e22a336141c76c78d474b7.diff

[clang] 15a1780 - [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

Author: Andrew Wock Date: 2020-06-03T09:45:27-04:00 New Revision: 15a1780a10e3ba4573b8c1e02e24d3f0a785e199 URL: https://github.com/llvm/llvm-project/commit/15a1780a10e3ba4573b8c1e02e24d3f0a785e199 DIFF: https://github.com/llvm/llvm-project/commit/15a1780a10e3ba4573b8c1e02e24d3f0a785e199.diff L

[clang] 007098d - Add support for `nullptr` in SyntaxTrees

Author: Eduardo Caldas Date: 2020-06-03T15:52:33+02:00 New Revision: 007098d7e6b8cf2cf1f1142908840a378d60c545 URL: https://github.com/llvm/llvm-project/commit/007098d7e6b8cf2cf1f1142908840a378d60c545 DIFF: https://github.com/llvm/llvm-project/commit/007098d7e6b8cf2cf1f1142908840a378d60c545.diff

[PATCH] D80900: [clangd] Use different FS in PreambleThread

sammccall added a comment. In D80900#2069566 , @kadircet wrote: > In D80900#2066327 , @sammccall wrote: > > > TL;DR: I think there are three viable paths that we should consider: > > A) minimal change: put the FSPr

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane marked 5 inline comments as done. erichkeane added inline comments. Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

njames93 added a comment. In D80514#2071056 , @bernhardmgruber wrote: > Reuploaded diff in an attempt to trigger a CI build. It's not working, Still no big issue, when its ready to land just the checks locally CHANGES SINCE LAST ACTION https://revi

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

ABataev updated this revision to Diff 268177. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80936/new/ https://reviews.llvm.org/D80936 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/OpenMP/nvptx_NRVO_variable.cp

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Keep in mind I'm not the code owner, I don't know if another approval is required. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80933/new/ https://reviews.llvm.org/D80933

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane updated this revision to Diff 268175. erichkeane added a comment. Apply @hubert.reinterpretcast s spelling. I'd also like to re-enforce, the purpose of this patch is simply to write down the rule that we've been enforcing for years, I don't think we should get novel with the rules/ch

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 268176. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80366/new/ https://reviews.llvm.org/D80366 Files: clang/i

  1   2   3   >