[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2069620 , @rjmccall wrote: > In D79744#2069324 , @arsenm wrote: > > > In D79744#2050498 , @rjmccall > > wrote: > > > > > > For the purpose

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked an inline comment as done. jdoerfert added a comment. I tried to determine why we don't emit such calls for c++11 and stdc++ but I was not successful :( Tracking back from the emission lead to the generic expression codegen without any (obvious) check of the runtime library or s

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

chrish_ericsson_atx added a comment. I reported this issue back in November, as https://bugs.llvm.org/show_bug.cgi?id=44143. This change fixes the bug -- I'll mark it as such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74746/new/ https://revi

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added a comment. Do we have a mechanism bisecting pragmas? If yes, we can let that tool add `#pragma clang attribute push([[clang::uninitialized]], apply_to = variable)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://revi

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2069774 , @arsenm wrote: > I think this is converging to adding a new IR attribute that essentially just > provides the pointee type for ABI purposes. I guess my name ideas for this > would be "indirect", "value", "memo

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 268002. nickdesaulniers added a comment. - handle non top level decls, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangComman

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. Hi, does this look good? or is there any other concern? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 ___ cfe-commits mailing

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Is there any feedback? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 268009. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: efriedma, apazos, zzheng, dexonsmith, rnk. Modify clang::FileManager::FixupRelativePath to use the existing path separator style, if one exists. Prior to this change, if

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: hlopko, eduucaldas. Doing so allows us to increase test coverage by removing unnecessary language restrictions. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[] = { njames93 wrote: >

[PATCH] D80877: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! We can add the `ObjCIVar` docs in a future patch if someone has the expertise there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80954/new/ https://reviews.llvm.org/D80954 _

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. The change description says something about PWD (which makes me worried about build determinism, like amccarth), but I don't see anything about that in the diff. The diff as-is looks fine to me with hans's comment about duplication resolved in some form. Please don't ad

[clang] 8eda716 - [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

Author: Nick Desaulniers Date: 2020-06-02T15:54:14-07:00 New Revision: 8eda71616fecd098cbd7d2447859c8ac1315966f URL: https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f DIFF: https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f.di

[clang] 39fa431 - [Analyzer][NFC] Fix markup in WebKit checkers documentation

Author: Jan Korous Date: 2020-06-02T16:04:23-07:00 New Revision: 39fa431c8ccad45de9ec67e8681da923d0cd28c7 URL: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7 DIFF: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7.diff LO

[clang] 232d348 - [MTE] Convert StackSafety into analysis

Author: Vitaly Buka Date: 2020-06-02T16:08:14-07:00 New Revision: 232d348c6eff8493fc016b1ea8a99db0e5620d81 URL: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81 DIFF: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81.diff L

RE: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

The test failed 7-8 times in a row on the same build machine and then started passing for about 10 runs, and then started failing again for 4 more runs, after which we disabled it. The configuration is nothing special, simply a Release+Asserts build on Windows. We tried to reproduce it by hand o

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8eda71616fec: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. thanks homies, committed as https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 _

[PATCH] D80771: [MTE] Convert StackSafety into analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG232d348c6eff: [MTE] Convert StackSafety into analysis (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llv

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069435 , @ABataev wrote: > In D79972#2069366 , @cchen wrote: > > > In D79972#2069358 , @ABataev wrote: > > > > > In D79972#2069322

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

jdoerfert added a comment. In D79744#2069786 , @arsenm wrote: > In D79744#2069774 , @arsenm wrote: > > > I think this is converging to adding a new IR attribute that essentially > > just provides the pointee type f

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. Do you know how gcc handles this case when running on mingw? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing lis

[clang] 7a6c894 - [SampleFDO] Add use-sample-profile function attribute.

Author: Wei Mi Date: 2020-06-02T17:23:17-07:00 New Revision: 7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 URL: https://github.com/llvm/llvm-project/commit/7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 DIFF: https://github.com/llvm/llvm-project/commit/7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56.diff LOG: [

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033 + "%select{|member |static member }0%2" + "%select{| of %3| of struct %4| of union %4| of class %4" + "| of structured binding %3}1">, InGroup; I wonder if we

[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a6c89427c9b: [SampleFDO] Add use-sample-profile function attribute. (authored by wmi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.ll

[clang] 85fdec9 - [NFC,MTE] Drop unneeded attribute from test

Author: Vitaly Buka Date: 2020-06-02T18:28:45-07:00 New Revision: 85fdec988fc55d56988d57fa88e2b870f6e0e8e9 URL: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9 DIFF: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9.diff L

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 268031. saghir marked an inline comment as done. saghir removed a reviewer: power-llvm-team. saghir added a comment. Herald added a subscriber: kbarton. Addressed nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. In D77168#2069783 , @MaskRay wrote: > Do we have a mechanism bisecting pragmas? If yes, we can let that tool add > `#pragma clang attribute push([[clang::uninitialized]], apply_to = variable)` Not that I am aware of unfortunately

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fdec988fc5: [NFC,MTE] Drop unneeded attribute from test (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80954/new/ https://reviews

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added a comment. In D77168#2070049 , @jcai19 wrote: > In D77168#2069783 , @MaskRay wrote: > > > Do we have a mechanism bisecting pragmas? If yes, we can let that tool add > > `#pragma clang attribute push([

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1578 +unnecessary and otherwise meaningless code. Braces should be used however +in cases where it significantly improves readability, such as when the single +statement is accompanied by a co

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. I believe I have responded to @joerg's comments with rationale to support the current direction. I intend to commit this patch within a week or two. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:301 +TargetCPUName = "pwr4"; + else if (!T.isOSDarwin()) { +

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 268055. Daniel599 added a comment. Added `StringMap::operator!=` and also unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/

[clang] bb1d8bf - [X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc.

Author: Craig Topper Date: 2020-06-02T22:38:51-07:00 New Revision: bb1d8bf2707bdca89c1f5e719057f1000232ccc3 URL: https://github.com/llvm/llvm-project/commit/bb1d8bf2707bdca89c1f5e719057f1000232ccc3 DIFF: https://github.com/llvm/llvm-project/commit/bb1d8bf2707bdca89c1f5e719057f1000232ccc3.diff

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2069970 , @sbc100 wrote: > Do you know how gcc handles this case when running on mingw? It uses the gnu/unix quoting style - so that's the case for wanting clang to preserve compatibility with that behaviour. The fac

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

hokein updated this revision to Diff 268068. hokein marked an inline comment as done. hokein added a comment. use a single location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81008/new/ https://reviews.llvm.org/D81008 Files: clang/include/cl

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

LukasSommerTu added a comment. @jdoerfert: Can you please commit for me, I do not have commit access. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80439/new/ https://reviews.llvm.org/D80439 ___ cfe-commits mailing list cfe-commits@

<    1   2   3