[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

njames93 created this revision. njames93 added reviewers: klimek, hokein, gribozavr, jvikstrom. Herald added a project: clang. Herald added a subscriber: cfe-commits. Force the unittests on c++ code for matchers to specify the correct standard. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

gribozavr2 added a comment. Approving since I think that it is probably too costly for tooling to try to handle such language extensions. We also don't have a principled way to know what "future" C++ feature is supported in a given language mode, so I think we would always have implementation a

[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

gribozavr2 added a comment. This is an interesting question. Since Clang accepts certain constructs in older C++ standard versions as extensions, shouldn't we test AST matchers in those modes as well? I think it could be argued either way. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, mgehre. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Disables the check from warning on some built in vararg functions, Address Clang-tidy should not consider __

[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

njames93 added a comment. In D80884#2065270 , @gribozavr2 wrote: > This is an interesting question. Since Clang accepts certain constructs in > older C++ standard versions as extensions, shouldn't we test AST matchers in > those modes as well? I think it

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[] = { How would we know

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add test coverage for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D8

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[]

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 267497. njames93 added a comment. Remove unnecessary fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Pro

[clang-tools-extra] f23ddbe - clang-tidy and clang-query wont crash with invalid command line options

Author: Nathan James Date: 2020-05-31T16:01:41+01:00 New Revision: f23ddbe3c3ae5f40b99ba272afc3d16b800ba8b9 URL: https://github.com/llvm/llvm-project/commit/f23ddbe3c3ae5f40b99ba272afc3d16b800ba8b9 DIFF: https://github.com/llvm/llvm-project/commit/f23ddbe3c3ae5f40b99ba272afc3d16b800ba8b9.diff

[clang] dfbfdc9 - [utils] update expected strings in tests; NFC

Author: Sanjay Patel Date: 2020-05-31T11:07:22-04:00 New Revision: dfbfdc96f9e15be40c938cde9b159afd028bf4a2 URL: https://github.com/llvm/llvm-project/commit/dfbfdc96f9e15be40c938cde9b159afd028bf4a2 DIFF: https://github.com/llvm/llvm-project/commit/dfbfdc96f9e15be40c938cde9b159afd028bf4a2.diff

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis added a comment. This breaks check-clang-tools on windows: http://45.33.8.238/win/16485/step_8.txt Looks like you need to optionally allow a .exe suffix in the test. Please take a look, and revert if it takes a while until you can fix. (I'm on a phone, else I'd fix myself.) Repository

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267501. njames93 added a comment. Added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQuery.cpp cla

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGf23ddbe3c3ae: clang-tidy and clang-query wont crash with invalid command line options (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang-tools-extra] f4b0ebb - Revert "clang-tidy and clang-query wont crash with invalid command line options"

Author: Nathan James Date: 2020-05-31T16:40:09+01:00 New Revision: f4b0ebb89b3086a2bdd8c7dd1f5d142fa09ca728 URL: https://github.com/llvm/llvm-project/commit/f4b0ebb89b3086a2bdd8c7dd1f5d142fa09ca728 DIFF: https://github.com/llvm/llvm-project/commit/f4b0ebb89b3086a2bdd8c7dd1f5d142fa09ca728.diff

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267504. njames93 added a comment. Hopefully fix windows test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQue

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam added a comment. Thank you @sameerds for the clarification. Sure, I will wait for @arsenm to review it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 __

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 reopened this revision. njames93 added a comment. This revision is now accepted and ready to land. In D80879#2065350 , @thakis wrote: > This breaks check-clang-tools on windows: > http://45.33.8.238/win/16485/step_8.txt > > Looks like you need to

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

thakis accepted this revision. thakis added a comment. Test fix looks good as far as I can tell. Landing and seeing what the bot says is ok. It's fine for some of the bots to be red for a short while as long as it isn't hours. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[] = { njames93 wrote: >

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 added a comment. In D80879#2065364 , @thakis wrote: > Test fix looks good as far as I can tell. Landing and seeing what the bot > says is ok. It's fine for some of the bots to be red for a short while as > long as it isn't hours. Thanks! I'm u

[clang-tools-extra] 5952125 - clang-tidy and clang-query wont crash with invalid command line options

Author: Nathan James Date: 2020-05-31T17:41:29+01:00 New Revision: 5952125691571de9bd817551fb1baabe270e73f9 URL: https://github.com/llvm/llvm-project/commit/5952125691571de9bd817551fb1baabe270e73f9 DIFF: https://github.com/llvm/llvm-project/commit/5952125691571de9bd817551fb1baabe270e73f9.diff

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

njames93 updated this revision to Diff 267505. njames93 added a comment. Actually fix the windows builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80879/new/ https://reviews.llvm.org/D80879 Files: clang-tools-extra/clang-query/tool/ClangQuer

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[]

[PATCH] D80631: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

njames93 added a comment. In D80631#2065168 , @MaskRay wrote: > `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` > `Subscribers:` `Tags:` and the text `Summary:` with the following script: > > arcfilter () { > arc amend >

[PATCH] D80879: clang-tidy and clang-query wont crash with invalid command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rG595212569157: clang-tidy and clang-query wont crash with invalid command line options (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

zinovy.nis created this revision. zinovy.nis added a reviewer: etienneb. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fix for a crash from https://bugs.llvm.org/show_bug.cgi?id=44256 Bug: https://bugs.llvm.org/show_bug.cgi?id=44256 Repository: rG LLVM Githu

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

zinovy.nis updated this revision to Diff 267518. zinovy.nis added a comment. Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang-t

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert created this revision. jdoerfert added reviewers: tra, hfinkel, ABataev, JonChesterfield. Herald added subscribers: sstefan1, guansong, bollu, yaxunl, mgorny. Herald added a project: clang. This simply follows the scheme we have for other wrappers. It resolves the current link problem, e

[clang] c15d5d1 - [Driver] NFC: Use Twine temp to replace std::string local

Author: Hubert Tong Date: 2020-05-31T16:38:10-04:00 New Revision: c15d5d12c625df52bf82828a6af5ef2dfb6b4533 URL: https://github.com/llvm/llvm-project/commit/c15d5d12c625df52bf82828a6af5ef2dfb6b4533 DIFF: https://github.com/llvm/llvm-project/commit/c15d5d12c625df52bf82828a6af5ef2dfb6b4533.diff L

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:452 CmdArgs.push_back("-dynamic-linker"); - CmdArgs.push_back(Args.MakeArgString(Loader)); + CmdArgs.push_back(A

[clang] 77e1181 - [analyzer] Add dumps to CheckerRegistry

Author: Kirstóf Umann Date: 2020-05-31T22:53:02+02:00 New Revision: 77e1181df446b54391acad08512b540e174cf6e6 URL: https://github.com/llvm/llvm-project/commit/77e1181df446b54391acad08512b540e174cf6e6 DIFF: https://github.com/llvm/llvm-project/commit/77e1181df446b54391acad08512b540e174cf6e6.diff

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

vddvss updated this revision to Diff 267529. vddvss marked an inline comment as done. vddvss added a comment. Updated revision to address @steven.zhang's good suggestion on the test case. This also does `clang-format` on `altivec.h` to address the harbormaster failure, although I am inclined to

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. As vfs::FileSystem is not threadsafe, we've introduced a data race when PreambleThread sta

[PATCH] D80901: [analyzer][NFC] Change checker dependency unit tests to check for the registration order

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, martong, balazske, rnkovacs, vsavchenko, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ra

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert updated this revision to Diff 267531. jdoerfert added a comment. Fix tests, add C support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80897/new/ https://reviews.llvm.org/D80897 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Head

[PATCH] D79961: [PGO] Fix computation of fuction Hash

alanphipps added a comment. It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read as v6 rather than v5. Can you double check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 __

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:372 + llvm::opt::ArgStringList &CmdArgs) const { + // Add linker option -u__llvm_profile_runtime to cause runtime + // initialization module to be linked in. ---

[clang] 92448fd - [Driver] Simplify Linux::addProfileRTLibs

Author: Fangrui Song Date: 2020-05-31T17:15:14-07:00 New Revision: 92448fd23daf966fe368eb8523d9c5a31797d5d8 URL: https://github.com/llvm/llvm-project/commit/92448fd23daf966fe368eb8523d9c5a31797d5d8 DIFF: https://github.com/llvm/llvm-project/commit/92448fd23daf966fe368eb8523d9c5a31797d5d8.diff

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

vabridgers created this revision. vabridgers added reviewers: balazske, NoQ, martong, baloghadamsoftware, Szelethus, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Herald added a project: clang. vabri

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

vabridgers added a comment. Not sure this is "correct", but it passes LITs with the new case, and it will at least get the discussion started :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 __

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

vabridgers updated this revision to Diff 267534. vabridgers added a comment. Address some typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 Files: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp

[PATCH] D80800: Add an option to fully qualify classes and structs.

jblespiau marked an inline comment as done. jblespiau added a comment. I did spend a few hours, just building and finding how to run tests :( I have a few additional questions, as I do not really understand what happen. In my initial idea, I wanted to modify the way QualType are printed, not rea

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Szelethus created this revision. Szelethus added reviewers: NoQ, martong, balazske, xazax.hun, rnkovacs, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid

[clang] b6d23f2 - [ASTMatchers] Force c++ unittests to specify correct language standard

Author: Nathan James Date: 2020-06-01T07:52:01+01:00 New Revision: b6d23f2efc64c226d30094bcc4258e0b63029da8 URL: https://github.com/llvm/llvm-project/commit/b6d23f2efc64c226d30094bcc4258e0b63029da8 DIFF: https://github.com/llvm/llvm-project/commit/b6d23f2efc64c226d30094bcc4258e0b63029da8.diff

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

zinovy.nis updated this revision to Diff 267546. zinovy.nis added a comment. Fix and simplify the condition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-ex

[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d23f2efc64: [ASTMatchers] Force c++ unittests to specify correct language standard (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80