[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

tentzen updated this revision to Diff 265672. tentzen added a comment. avoid lint warnings and lint hang on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:435 + /// If the call returns a C++ record type then the region of its return value + // can be retrieved from its construction context. + Optional getReturnValueUnde

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

atanasyan added a reviewer: atanasyan. atanasyan added a comment. 1. Please include as much context as possible with your diff. This instruction helps to do that. 2. Such patch needs test case(s). Maybe it's enoug

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

Quuxplusone added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } rjmccall wrote: > Quuxplusone wrote: > > Is this even supposed to compile? The only valid specializations of `f` > > r

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. In D69764#2050226 , @steveire wrote: > I like the approach of using clang-format to implement this. It's much faster > than a `clang-tidy` approach. > > The broader C++ community has already chosen `East`/`West` and it ha

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

ckandeler added a comment. Thanks for the quick review. I don't have commit access, so can someone please commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. SATest scripts should be

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

dang updated this revision to Diff 265676. dang added a comment. Rebase this on top of the new AST Signature patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80003/new/ https://reviews.llvm.org/D80003 Files: clang/include/clang/Frontend/Compi

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265680. vsavchenko added a comment. Modify forgotten parts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80424/new/ https://reviews.llvm.org/D80424 Files: clang/utils/analyzer/SATestBuild.py clang/utils

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko updated this re

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265682. vsavchenko added a comment. Fix update diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py clang/utils/analyze

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner updated this revision to Diff 265683. cpplearner added a comment. rebase & ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/alias-templates.cpp Index: clang/test/

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 265684. MyDeveloperDay added a comment. Switch to new function name suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/Breakabl

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, dexonsmith, mgorny. Herald added projects: clang, LLVM. These are a collection of small fixes to make LLVM/Clang build with a clang+mingw toolchain to target Windows. The three commits address the follo

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added a parent

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. I get the point about Opt In, and if we are going to add an option it needs to go in ASAP otherwise too many people will then start complaining it was on by default before. To be honest I think the question is do we consider this a bug or a feature, because we D

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added a comment. Super-nitpick: If you want to capitalize mingw, it's MinGW (minimalist gnu for windows) 😛 But as that's rather annoying to type, the all-lowercase version is quite fine as well. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS $

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia added a comment. In D80416#2050250 , @arsenm wrote: > The langref wording makes me think this isn't quite right. This depends on > your definition of floating point contraction. I've always assumed it meant > allow FMA, potentially increasing p

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80294: Add support for vmsumudm

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-comm

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Nice! I guess next time it'd be easier to review if you split up style changes from structural changes. Comment at: clang/utils/analyzer/SATestBuild.py:276 -AllCheckers = C

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sure thanks! Comment at: clang/utils/analyzer/SATestUtils.py:47 +root, ext = os.path.splitext(file_name) +return ext in (".i", ".ii", ".c", ".cpp", ".m", "")

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265691. vsavchenko added a comment. Fix code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py clang/utils

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This one's straightforward too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80427/new/ https://reviews.llvm.org/D80427 __

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: clang/test/CodeGen/ppc64-inline-asm.c:50 +// CHECK-LABEL: void @testZwOff(i8* %addr, i64 %off) +// CHEC: %[[VAL:[^ ]+]] = getelementptr i8, i8* %addr, i64 %off +// CHEC: call void asm sideeffec

[clang] e95ee30 - [SYCL] Prohibit arithmetic operations for incompatible pointers

Author: Alexey Bader Date: 2020-05-22T13:43:24+03:00 New Revision: e95ee300c0530158d86430fd82ffabd36262e862 URL: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862 DIFF: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862.diff

[clang] 7cebfa4 - [analyzer] SATestUtils.py: Refactor and add type annotations

Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 7cebfa4e069265a146186e90bfa0a36135bf8aba URL: https://github.com/llvm/llvm-project/commit/7cebfa4e069265a146186e90bfa0a36135bf8aba DIFF: https://github.com/llvm/llvm-project/commit/7cebfa4e069265a146186e90bfa0a36135bf8aba.d

[clang] 4902ca6 - [analyzer] SATestBuild.py: Refactor and add type annotations

Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 4902ca6da49b10dbc62e8e02109bf84ce96c94b5 URL: https://github.com/llvm/llvm-project/commit/4902ca6da49b10dbc62e8e02109bf84ce96c94b5 DIFF: https://github.com/llvm/llvm-project/commit/4902ca6da49b10dbc62e8e02109bf84ce96c94b5.d

[clang] 5a9aff1 - [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 5a9aff12ff3bc68109f41930ec296b7a19cbe76c URL: https://github.com/llvm/llvm-project/commit/5a9aff12ff3bc68109f41930ec296b7a19cbe76c DIFF: https://github.com/llvm/llvm-project/commit/5a9aff12ff3bc68109f41930ec296b7a19cbe76c.d

[clang] 475d120 - [analyzer] SumTimerInfo.py: Partially modernize

Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 475d1202837071959f3f69d3512c820538d81543 URL: https://github.com/llvm/llvm-project/commit/475d1202837071959f3f69d3512c820538d81543 DIFF: https://github.com/llvm/llvm-project/commit/475d1202837071959f3f69d3512c820538d81543.d

[clang] bf897e6 - Remove superfluous semicolon to stop Wpedantic warning. NFCI.

Author: Simon Pilgrim Date: 2020-05-22T12:05:56+01:00 New Revision: bf897e6ea122c07b8848133beee749fd96895c14 URL: https://github.com/llvm/llvm-project/commit/bf897e6ea122c07b8848133beee749fd96895c14 DIFF: https://github.com/llvm/llvm-project/commit/bf897e6ea122c07b8848133beee749fd96895c14.diff

[clang] 733505a - Replace dyn_cast<> with isa<> to fix unused variable warning. NFCI.

Author: Simon Pilgrim Date: 2020-05-22T12:05:56+01:00 New Revision: 733505abf471b66458a9eab24521dba9a4b6239e URL: https://github.com/llvm/llvm-project/commit/733505abf471b66458a9eab24521dba9a4b6239e DIFF: https://github.com/llvm/llvm-project/commit/733505abf471b66458a9eab24521dba9a4b6239e.diff

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker added a comment. In D71739#2048409 , @rjmccall wrote: > Is there a good reason for this to use the same `llvm.assume` intrinsic as > before? thee hasn't been any discussion i am aware of on this topic. but personally i think keeping the same intri

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 265694. DavidSpickett added a comment. - Addressed comments from nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up. Repository: rG LLVM Github

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe95ee300c053: [SYCL] Prohibit arithmetic operations for incompatible pointers (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80317/new/

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4902ca6da49b: [analyzer] SATestBuild.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9aff12ff3b: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8042

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cebfa4e0692: [analyzer] SATestUtils.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80424/new/

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

This revision was automatically updated to reflect the committed changes. Closed by commit rG475d12028370: [analyzer] SumTimerInfo.py: Partially modernize (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80427/new/ https://rev

[PATCH] D80428: [clang] Optimize getFileIDLocal

melver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Avoid bit operations to compute Offset by removing bitfields. On 64-bit architectures, SLocEntry's size is unchanged. - Provide branch-prediction hints to compiler to generate better code. Re

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#2050623 , @MyDeveloperDay wrote: > I get the point about Opt In, and if we are going to add an option it needs > to go in ASAP otherwise too many people will then start complaining it was on > by default before. > > To be

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, Please instead re-use the code that computes the object un

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks straightforward, thanks! Comment at: clang/test/Analysis/explain-svals.cpp:97 void test_6() { - clang_analyzer_explain(conjure_S()); // expected-warning-re^lazily

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > I d

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > Ana

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Szelethus updated this revision to Diff 265709. Szelethus marked 7 inline comments as done. Szelethus added a comment. Fix according to reviewer comments! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77474/new/ https://reviews.llvm.org/D77474 Files: clang/include/clang/Stati

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:195 +// Say this 3 times fast. +State = State ? State : getState(); +addTransition(State, generateSink(State, getPredecessor())); mart

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 265716. saiislam added a comment. Herald added a subscriber: sstefan1. Added test case to show treatment of specific functions as builtins or functions on the device Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80428: [clang] Optimize getFileIDLocal

melver updated this revision to Diff 265717. melver added a comment. Extra unlikely hint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80428/new/ https://reviews.llvm.org/D80428 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

arsenm added a comment. I think the contract flag needs clarification. I would interpret an instruction with only a contract flag as meaning allow precision increasing FMA formation, and contract+afn to mean combining while reducing precision CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + baloghadamsoftware wrote: > Szelethus wrote: > > This mustn't be serious. `StackFrameContext::getIndex()` has **no > > comments**

[clang] aede24e - [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

Author: Nemanja Ivanovic Date: 2020-05-22T07:59:21-05:00 New Revision: aede24ecaa08db806fb173faf2de9cff95df8cee URL: https://github.com/llvm/llvm-project/commit/aede24ecaa08db806fb173faf2de9cff95df8cee DIFF: https://github.com/llvm/llvm-project/commit/aede24ecaa08db806fb173faf2de9cff95df8cee.di

[clang] 99b94f2 - [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

Author: Artem Dergachev Date: 2020-05-22T16:14:48+03:00 New Revision: 99b94f29ac5dbbce0585d16f631359a66f279ea4 URL: https://github.com/llvm/llvm-project/commit/99b94f29ac5dbbce0585d16f631359a66f279ea4 DIFF: https://github.com/llvm/llvm-project/commit/99b94f29ac5dbbce0585d16f631359a66f279ea4.dif

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta marked 5 inline comments as done. thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mstorsjo wrote: > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam marked 19 inline comments as done. saiislam added inline comments. Comment at: clang/lib/AST/Decl.cpp:3227 + !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) +return 0; + sameerds wrote: > sameerds wrote: > > This needs a tes

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

jroelofs created this revision. jroelofs added reviewers: jyknight, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. See also discussion following: http://lists.llvm.org/pipermail/llvm-dev/2012-May/050098.html Repository: rG LLVM Github Monorepo https://review

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265722. djtodoro retitled this revision from "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "[DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. -Remove the decls only in the case of call-sit

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2050022 , @dblaikie wrote: > In D80369#2048932 , @djtodoro wrote: > > > Still have test failing: > > > > Clang :: Modules/DebugInfoTransitiveImport.m > > Clang :: Modules/Modu

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

krasimir added a comment. Just some thoughts. I agree that `Style.isJavaScript()` is nicer than `Style.Language == FormatStyle::LK_JavaScript`, but overall the tradeoffs about adding convenience methods are not clear to me. C++/ObjC/ObjC++ is special -- because ObjC++ exists I think it is usef

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

This revision was automatically updated to reflect the committed changes. Closed by commit rG99b94f29ac5d: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rGaede24ecaa08: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D77542?vs=255291&id=265730#toc Repository:

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 265728. fhahn marked 4 inline comments as done. fhahn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. In D76791#2048387 , @rjmccall wrote: > Sorry for the slow review; I'm getting

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define __OMP_SIZE_TYPE

[PATCH] D80294: Add support for vmsumudm

amyk accepted this revision. amyk added a comment. Thanks for explaining. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

LukasSommerTu created this revision. LukasSommerTu added reviewers: jdoerfert, Hahnfeld. LukasSommerTu added projects: OpenMP, clang. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Nvidia PTX does not allow `.` to appear in identifiers, so OpenMP variant mangling now uses `$`

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

JakeMerdichAMD added a comment. I'm a fan of the 'like' helpers, but I'm not entirely convinced that having helpers for languages covered by the 'like' is a bad thing-- it just needs to be very explicit that you do mean only that language. For example, an 'isObjCOnly()' would hint to reviewers

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 added a comment. Figured out the actual cause of this bug, `getExceptionSpecRange()` returns a null range if the function has an unknown return type undefined_type throws() throw(); This is the tidy output (where assertions are disabled) warning: dynamic exception specification ''

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2047154 , @fghanim wrote: > In D79675#2045826 , @jdoerfert wrote: > > > In D79675#2045563 , @fghanim wrote: > > > > > So this whole thing

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

asmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2003 +// : Under -EHa, Invoke llvm.eha.scope.begin() right after +// Ctor is emitted and EHStack.pushCleanup Nit - remove name Comment at: clang/lib/CodeGen/C

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > Ana

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Currently, clang will generate fused operation `fmuladd` for expressions like `a*b+c`. However, I can't find anything in the spec that explains this behavior. But clang

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ s/Arguemnt/Argument/ Comment at

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:3 +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// // RUN: -Wl,-bnocdtors \ +// // RUN: -target powerpc-ibm-aix7.1.0.0 \ formatting, align with the line

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

lebedev.ri added a comment. This should likely be at least 3 patches: llvm middle-end, llvm codegen, clang. Langref changes missing for new intrinsics. Please post all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. In D80251#2049975 , @craig.topper wrote: > In D80251#2049418 , @RKSimon wrote: > > > Can we add -Wsign-conve

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() thieta wrote: > mstorsjo wrote: > > If you say this is the same way it's done elsewhere, then sure - although I > > have no idea ab

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ ZarkoCA wrote: > s/Arguemnt/Argumen

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/AST/Expr.cpp:3859 + + auto *SubscriptE = dyn_cast(this); + return SubscriptE rjmccall wrote: > You need to `IgnoreParens()` here. This code is now gone. ===

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart updated this revision to Diff 265748. nagart added a comment. fixing lint issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/inclu

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 265750. fhahn added a comment. Add clarifying comment to ActOnMatrixSubscriptExpr calls in ActOnArraySubscriptExpr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 Files

[PATCH] D80443: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Tasks can crash with many different

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, M.getDataLayout().g

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 265753. stuij marked an inline comment as done. stuij added a comment. no explicit float-abi cmdline arg should default to softfp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/

[clang] a5b2503 - [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

Author: Valeriy Savchenko Date: 2020-05-22T19:15:00+03:00 New Revision: a5b2503a8ab4fb21345fa9e2316530cdfaec1a60 URL: https://github.com/llvm/llvm-project/commit/a5b2503a8ab4fb21345fa9e2316530cdfaec1a60 DIFF: https://github.com/llvm/llvm-project/commit/a5b2503a8ab4fb21345fa9e2316530cdfaec1a60.d

[PATCH] D80443: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Not unreasonable! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80443/new/ https://reviews.llvm.org/D80443

[PATCH] D80443: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b2503a8ab4: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80443/n

[clang-tools-extra] e4bb3e2 - [clang-tidy] Expand the list of functions in bugprone-unused-return-value

Author: Joe Ranieri Date: 2020-05-22T12:57:58-04:00 New Revision: e4bb3e25e4400151133fd3737f4842f2aeda1c1b URL: https://github.com/llvm/llvm-project/commit/e4bb3e25e4400151133fd3737f4842f2aeda1c1b DIFF: https://github.com/llvm/llvm-project/commit/e4bb3e25e4400151133fd3737f4842f2aeda1c1b.diff L

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2050962 , @djtodoro wrote: > In D80369#2050022 , @dblaikie wrote: > > > In D80369#2048932 , @djtodoro > > wrote: > > > > > Still have tes

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij updated this revision to Diff 265764. stuij added a comment. moving 'CartesianProductWith' to more apt patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files: clang/include/clang/Basic/arm_neon

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

vsavchenko added a comment. Hi @Szelethus , it looks like I am a bearer of bad news again :( This patch seems to crash `scan-build` on pretty much every project that I tested. One way to reproduce: git clone https://github.com/postgres/postgres.git cd postgres/ scan-build -plist-html -o .

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4bb3e25e440: [clang-tidy] Expand the list of functions in bugprone-unused-return-value (authored by jranieri-grammatech). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265765. stevewan added a comment. Address comments and fix windows compatibility issues with the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: cl

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

rjmccall added a comment. > there is any IR legality restriction about what combination or number of > bundles can be present in an assume. however there is restrictions about > argument of a given bundle. > having a single "align" bundle is just how the front-end used assume bundles > for its

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

jkorous added inline comments. Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) +return SDError::MalformedDiagnosticRecord; owenv wrote: > owenv wrote:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl added a comment. In D79526#2042680 , @tra wrote: > Reduced test case: > > struct a { > __attribute__((device)) a(short); > __attribute__((device)) operator unsigned() const; > __attribute__((device)) operator int() const; > }; > st

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl created this revision. yaxunl added a reviewer: tra. When implicit HD function calls a function in device compilation, if one candidate is an implicit HD function, current solution rule is: D wins over HD and H HD and H are equal this caused regression when there is an otherwise worse D c

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Szelethus added a comment. This isn't so bad as far as news go, considering you saved a lot of work for me in terms of reproducing this! I'll look into it, thanks! I admit to not use `scan-build` much. :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:9 +// CHECK-LD32-ARG-ORDER-NOT: warning: +// CHECK-LD32-ARG-ORDER: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-ARG-ORDER: "-isysroot" "[[SYSROOT:[^

[clang] 429f030 - Revert "[analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it"

Author: Kirstóf Umann Date: 2020-05-22T20:18:16+02:00 New Revision: 429f03089951d62fb370026905c87f1f25cf220f URL: https://github.com/llvm/llvm-project/commit/429f03089951d62fb370026905c87f1f25cf220f DIFF: https://github.com/llvm/llvm-project/commit/429f03089951d62fb370026905c87f1f25cf220f.diff

  1   2   >