[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp:176-180 if (const auto *DeclReg = Reg->getAs()) { if (isa(DeclReg->getDecl())) Reg = C.getState()->getSVal(SV.castAs()).getAsRegion(); + } else if (const auto *ParamReg

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

labath added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON" JDevlieghere wrote: > phosek wrote:

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 263371. tmsriram marked 5 inline comments as done and an inline comment as not done. tmsriram added a comment. Address reviewer comments: 1. Use Diagnostic instead of errs 2. Move test input to Inputs/ 3. Fix option description. CHANGES SINCE LAST ACTION

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. @Abpostelnicu as you requested changes I need an "Accept" from you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

Abpostelnicu accepted this revision. Abpostelnicu added a comment. This revision is now accepted and ready to land. Sorry, totally forgot about this, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 __

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

Jim created this revision. Jim added reviewers: asb, luismarques, lenary. Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-che

[clang] 40ef427 - get rid of the NDEBUG usage in RecoveryExpr, NFC.

Author: Haojian Wu Date: 2020-05-12T10:19:58+02:00 New Revision: 40ef4274600316ed12a26a73265cf34432e1fbf7 URL: https://github.com/llvm/llvm-project/commit/40ef4274600316ed12a26a73265cf34432e1fbf7 DIFF: https://github.com/llvm/llvm-project/commit/40ef4274600316ed12a26a73265cf34432e1fbf7.diff LO

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

luismarques added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10241-10242 // Pass floating point values via FPRs if possible. - if (IsFixed && Ty->isFloatingType() && FLen >= Size && ArgFPRsLeft) { + if (IsFixed && Ty->isFloatingType() && !Ty->isComplexType

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:362 - return ASTUnit::LoadFromASTFile( - std::string(ASTFilePath), CI.getPCHContainerOperations()->getRawReader(), - ASTUnit::LoadEverything, Diags, CI.getFileSystemOpts()); + aut

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

hokein updated this revision to Diff 263382. hokein marked 2 inline comments as done. hokein added a comment. address comments, and remove the fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79701/new/ https://reviews.llvm.org/D79701 Files:

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:454 + auto T = makeSelectionTree(Code, AST); + // EXPECT_THAT(Tracer.takeMetric("selection"), te

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. FYI This passes all tests on the mergebot. There are some obscure lint suggestions that make it report a failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 _

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, owenpan, jbcoe, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. This is a starting point to improve the handling of concepts in clang-format. There is currently no real formatting of

[clang] d6936be - [SveEmitter] Add builtins for svdup and svindex

Author: Sander de Smalen Date: 2020-05-12T11:02:32+01:00 New Revision: d6936be2ef8ce5d5d85b8a6cdd1477cd79688c3a URL: https://github.com/llvm/llvm-project/commit/d6936be2ef8ce5d5d85b8a6cdd1477cd79688c3a DIFF: https://github.com/llvm/llvm-project/commit/d6936be2ef8ce5d5d85b8a6cdd1477cd79688c3a.di

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon added reviewers: rsmith, void. RKSimon added a comment. Adding some people who know more about this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6936be2ef8c: [SveEmitter] Add builtins for svdup and svindex (authored by sdesmalen). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. (Maybe this will make Phab not show "✅ Accepted"...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity added a comment. Please check the summary of the patch, it seems to contain old information as well. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:210-212 +Preferably the same compilation database should be used when generating the external def

Re: [clang] d82538b - Fix -Wunused compiler warning.

This is neat, fixed in 40ef4274600316ed12a26a73265cf34432e1fbf7, thanks for the suggestion! On Tue, 12 May 2020 at 05:13, Eric Christopher wrote: > Very much so. Also nice all_of use! I'd have never thought about that :) > > -eric > > On Mon, May 11, 2020 at 7:03 PM David Blaikie via cfe-commits

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. In D79704#2029305 , @baloghadamsoftware wrote: > Thank you for quickly looking into this. > > In D79704#2029230 , @Szelethus wrote: > > > - What identifies a `MemRegion`, `TypedValueRegio

[clang] e03394c - [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

Author: Yaxun (Sam) Liu Date: 2020-05-12T08:27:50-04:00 New Revision: e03394c6a6ff5832aa43259d4b8345f40ca6a22c URL: https://github.com/llvm/llvm-project/commit/e03394c6a6ff5832aa43259d4b8345f40ca6a22c DIFF: https://github.com/llvm/llvm-project/commit/e03394c6a6ff5832aa43259d4b8345f40ca6a22c.dif

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

gchatelet added a comment. Thx @craig.topper ! I'm happy to see this effort percolate :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/ https://reviews.llvm.org/D78443 ___ cfe-commits mailing

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rGe03394c6a6ff: [CUDA][HIP] Workaround for resolving host device function against wrong-sided… (authored by yaxunl). Herald added a project: clang. Changed prior to

[clang] 7f2db99 - [PATCH] #pragma float_control should be permitted in namespace scope.

Author: Melanie Blower Date: 2020-05-12T06:10:19-07:00 New Revision: 7f2db993500923a51c0b0aed650a3e0d4241205b URL: https://github.com/llvm/llvm-project/commit/7f2db993500923a51c0b0aed650a3e0d4241205b DIFF: https://github.com/llvm/llvm-project/commit/7f2db993500923a51c0b0aed650a3e0d4241205b.diff

[PATCH] D79565: Add -print-targets to print the registered targets

yaxunl updated this revision to Diff 263410. yaxunl retitled this revision from "Document outputing registered targets with -v in release notes" to "Add -print-targets to print the registered targets". yaxunl added reviewers: MaskRay, thakis, echristo, tra. yaxunl added a comment. add option -pri

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7f2db9935009: [PATCH] #pragma float_control should be permitted in namespace scope. (authored by mibintc). Repository:

[clang] 123bee6 - AMDGPU: Search for new ROCm bitcode library structure

Author: Matt Arsenault Date: 2020-05-12T09:41:07-04:00 New Revision: 123bee602a260150ff55c74287f583a67ee78f36 URL: https://github.com/llvm/llvm-project/commit/123bee602a260150ff55c74287f583a67ee78f36 DIFF: https://github.com/llvm/llvm-project/commit/123bee602a260150ff55c74287f583a67ee78f36.diff

[clang] 14e1845 - HIP: Merge builtin library handling

Author: Matt Arsenault Date: 2020-05-12T09:50:22-04:00 New Revision: 14e184571139ba4c7347ea547074c6d9ec9c7b14 URL: https://github.com/llvm/llvm-project/commit/14e184571139ba4c7347ea547074c6d9ec9c7b14 DIFF: https://github.com/llvm/llvm-project/commit/14e184571139ba4c7347ea547074c6d9ec9c7b14.diff

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79237/new/ https://reviews.llvm.org/D79237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:75 +// The desired structure is (${ROCM_ROOT} or +// ${OPENCL_ROOT})/amdgcn/bitcode/*, so try to detect this layout. yaxunl wrote:

[PATCH] D76957: HIP: Merge builtin library handling

arsenm closed this revision. arsenm added a comment. 14e184571139ba4c7347ea547074c6d9ec9c7b14 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 __

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Device library change submitted. 123bee602a260150ff55c74287f583a67ee78f36 CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] 774acdf - [clangd] Add metrics for selection tree and recovery expressions.

Author: Haojian Wu Date: 2020-05-12T16:14:48+02:00 New Revision: 774acdfb8c46de9b4f8a92d80bbbd96e4d467682 URL: https://github.com/llvm/llvm-project/commit/774acdfb8c46de9b4f8a92d80bbbd96e4d467682 DIFF: https://github.com/llvm/llvm-project/commit/774acdfb8c46de9b4f8a92d80bbbd96e4d467682.diff LO

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4684 return false; case CodeGenOptions::SRCK_InRegs: // -msvr4-struct-return return true; jasonliu wrote: > Xiangling_L wrote: > > I noticed that in patch https://reviews

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added reviewers: jasonliu, erichkeane, RKSimon, jhibbits, ctetreau, george.burgess.iv, efriedma. nigelp-xmos added a comment. Adding code reviewer suggestions from git history. I would be grateful for review and/or reviewer suggestions. Many thanks. Repository: rG LLVM Github Mon

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG774acdfb8c46: [clangd] Add metrics for selection tree and recovery expressions. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D79701?vs=263382&id=263433#toc Repository: rG L

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

erichkeane added a comment. It doesn't seem like it would be much work to move the EmitTargetMetadata function into the TargetInfo object (as a virtual function taking a reference to the collection). Essentially, have this take a reference to the collection instead of the 'D' and 'GV'. I say

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Thanks for the comment, I will look into that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___ cfe-commits mailing list cfe-com

[PATCH] D79788: AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia, svenvh. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. -nogpulib makes sense when there is a host (where -nostdlib would apply) and offload target. Accept nostdlib when there is

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov added a comment. @NoQ , ping. Look please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] ffcaed3 - [Matrix] Check non-dependent elt type before creating DepSizedMatrix.

Author: Florian Hahn Date: 2020-05-12T16:46:37+01:00 New Revision: ffcaed32ef1cf5226cc376b6c911183db690402f URL: https://github.com/llvm/llvm-project/commit/ffcaed32ef1cf5226cc376b6c911183db690402f DIFF: https://github.com/llvm/llvm-project/commit/ffcaed32ef1cf5226cc376b6c911183db690402f.diff

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske updated this revision to Diff 263447. balazske added a comment. Added state split before fread to make warning for error state possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374 Files: cla

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov marked 3 inline comments as done. ASDenysPetrov added a comment. > The measurements I mentioned earlier about runtimes, node count and so on > could help answer some of those questions. I'm looking for an appropriate project to measure performance, since I have some troubles runni

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

michele.scandale added a comment. In D72841#2030707 , @rjmccall wrote: > IIUC, the way within-statement contraction is supposed to work is that there > are supposed to be blocking intrinsics inserted at various places. I don't > remember the details, th

[clang] b56b1e6 - [gcov] Default coverage version to '408*' and delete CC1 option -coverage-exit-block-before-body

Author: Fangrui Song Date: 2020-05-12T09:14:03-07:00 New Revision: b56b1e67e38e5f18318b411587a952bc7c586ac4 URL: https://github.com/llvm/llvm-project/commit/b56b1e67e38e5f18318b411587a952bc7c586ac4 DIFF: https://github.com/llvm/llvm-project/commit/b56b1e67e38e5f18318b411587a952bc7c586ac4.diff

[clang] 25a95f4 - [gcov][test] Fix clang test

Author: Fangrui Song Date: 2020-05-12T09:21:19-07:00 New Revision: 25a95f49b07ff5796f4dfc3d4c05e4c09c6bef4d URL: https://github.com/llvm/llvm-project/commit/25a95f49b07ff5796f4dfc3d4c05e4c09c6bef4d DIFF: https://github.com/llvm/llvm-project/commit/25a95f49b07ff5796f4dfc3d4c05e4c09c6bef4d.diff

[PATCH] D79565: Add -print-targets to print the registered targets

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79565/new/ https://reviews.llvm.org/D79565 ___ cfe-commits mailing list cfe-comm

[clang] 3d49d1c - [WebAssembly] Implement pseudo-min/max SIMD instructions

Author: Thomas Lively Date: 2020-05-12T09:39:01-07:00 New Revision: 3d49d1cfa768c046394b316d838907f2018390b8 URL: https://github.com/llvm/llvm-project/commit/3d49d1cfa768c046394b316d838907f2018390b8 DIFF: https://github.com/llvm/llvm-project/commit/3d49d1cfa768c046394b316d838907f2018390b8.diff

[PATCH] D79742: [WebAssembly] Implement pseudo-min/max SIMD instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d49d1cfa768: [WebAssembly] Implement pseudo-min/max SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79742/new/ https

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. No, if that's how we handle that, then you're absolutely right that we shouldn't set the `contract` flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 ___

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra added a comment. > constexpr variables are compile time constants and implicitly const, therefore > they are safe to emit on both device and host side. Besides, in many cases > they are intended for both device and host, therefore it makes sense > to emit them on both device and host sides

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler updated this revision to Diff 263466. rdwampler added a comment. Fixed indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/conversion-f

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

scanon added a comment. > Prior to this change contract was never generated in the case of in-statement > contraction only, instead clang was emitting llvm.fmuladd to inform the > backend that only those were eligible for contraction. From a correctness > perspective I think this was perfectly

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

+Mr. Smith for visibility. I'm /guessing/ the right path might be to change the implementation of getFullyQualifiedName to use the type printing/pretty printer approach with the extra feature you're suggesting. That way all users get the desired behavior +Sam McCall who (if I understand correct

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. dang added reviewers: Bigcheese, dexonsmith. dang edited the summary of this revision. This is an add-on to the RFC at http://lists.llvm.org/pipermail/cfe-dev/2

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); } michele.scandale wrote: > I'm not con

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

nikic added a comment. This change causes a 0.8% compile-time regression for unoptimized builds . Based on the pipeline test diffs, I expe

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added a comment. In D75936#2032027 , @nikic wrote: > This change causes a 0.8% compile-time regression for unoptimized builds >

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper added a comment. In D75936#2032078 , @sconstab wrote: > In D75936#2032027 , @nikic wrote: > > > This change causes a 0.8% compile-time regression for unoptimized builds > >

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13111 + } + } + return std::make_tuple(false, CharUnits::Zero(), CharUnits::Zero()); rjmccall wrote: > Derived-to-base conversions. Does this

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Hi, thanks for your answer. Just a few remarks: 1. I imagine that we cannot know if people are using getFullyQualifiedName. In particular, people could have developed their own internal tools, thus we cannot be aware of all callers. I do not know Clang's policy, but can we delete or completely c

[clang] 11c8c2a - [analyzer] SATestBuild.py: Fix support for #NOPREFIX.

Author: Artem Dergachev Date: 2020-05-12T22:43:32+03:00 New Revision: 11c8c2a551c53db5ecf8c1f253b1a49d5e98324f URL: https://github.com/llvm/llvm-project/commit/11c8c2a551c53db5ecf8c1f253b1a49d5e98324f DIFF: https://github.com/llvm/llvm-project/commit/11c8c2a551c53db5ecf8c1f253b1a49d5e98324f.dif

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:147 +; CHECK-NEXT: X86 Load Value Injection (LVI) Load Hardening ; CHECK-NEXT: Fixup Statepoint Caller Saved ; CHECK-NEXT: PostRA Machine Sink I'm curious wha

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13111 + } + } + return std::make_tuple(false, CharUnits::Zero(), CharUnits::Zero()); ahatanak wrote: > rjmccall wrote: > > Derived-to-base conversions. > Does this include cases where

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L marked 7 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:691 AddGlobalDtor(Fn); + CXXGlobalDtors.clear(); } ZarkoCA wrote: > I may be missing something but why do we need this now, as oppose

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 263494. MyDeveloperDay added a reviewer: saar.raz. MyDeveloperDay added a subscriber: saar.raz. MyDeveloperDay added a comment. Add additional parsing of concept and require keywords to allow formatting Include some more of @saar.raz examples in the te

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1924 return TT_BinaryOperator; } This change it to resolve the missing gap between `&&` and `Concept2`, clang-f

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 263499. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Updated the warnings to `report_fatal_error`; Update the testcases; Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://review

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre created this revision. tambre added reviewers: rsmith, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a parameter pack is expanded the expanded parameters don't have default values. Thus if a parameter pack is expanded after any arguments with a defau

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. I'm no expert in the pass manager, but given the very targeted applicability of LVI it definitely seems like our goal should be 0% impact for the vast majority of compilations that don't concern themselves with it. Is there a way to require the pass be enabled for the co

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 263502. jasonliu added a comment. Add error report in clang_cc1 for unsupported option on AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/To

[PATCH] D79804: [x86] prevent 64b operands to "r" constrained inline asm for -m32

nickdesaulniers created this revision. nickdesaulniers added reviewers: ahatanak, craig.topper. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. nickdesaulniers added a subscriber: dwmw2. As pointed out by David Woodhouse and Akira Hatanaka in https://bugs.llvm.org

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. Blanket reply! `ParamRegion` is not a `DeclRegion` because it does not necessarily have a corresponding `Decl`. For instance, when calling a function through an unknown function pointer, you don't have the declaration of a function, let alone its parameters. But for paramet

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1305 +if (const auto *CB1 = dyn_cast(I1)) + if (CB1->cannotMerge()) +return Changed; rnk wrote: > It seems inconsiste

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2053 + D, [](OpenMPClauseKind K) -> bool { return K != OMPC_unknown; }, + Level, /*NotLastprivate=*/true) && + !DSAStack->isLoopControlVariable(D, Level).first) { `/*N

[clang] 6c29073 - PR45589: Properly decompose overloaded `&&` and `||` operators in

Author: Richard Smith Date: 2020-05-12T13:45:45-07:00 New Revision: 6c29073efb0c22045868bc3622f8fc27f43fca41 URL: https://github.com/llvm/llvm-project/commit/6c29073efb0c22045868bc3622f8fc27f43fca41 DIFF: https://github.com/llvm/llvm-project/commit/6c29073efb0c22045868bc3622f8fc27f43fca41.diff

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. Ping? I've reopened this one as suggested in D74846 , but apparently it's kept the accepted state, so I'm not sure if this needs another approval or what to do here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. This patch seems to lead to the undefined symbol error we're seeing when building fuchsia: ld.lld: error: relocation refers to a discarded section: __sancov_guards >>> defined in user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o >>> refe

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

ldionne added a comment. Note for posterity in case someone does some archeology and ends up here (as I am doing): the Radar number is 29523281. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27434/new/ https://reviews.llvm.org/D27434 __

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2170 parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.IndentBraces) +if (Style.BraceWrapping.IndentBraces || Style.BraceWrapping.BeforeWhile) addUnwrappedLine

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

On Tue, May 12, 2020 at 12:40 PM Jean-Baptiste Lespiau wrote: > Hi, > > thanks for your answer. > > Just a few remarks: > > 1. I imagine that we cannot know if people are using > getFullyQualifiedName. In particular, people could have developed their own > internal tools, thus we cannot be aware

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

On Tue, May 12, 2020 at 11:11 PM David Blaikie wrote: > On Tue, May 12, 2020 at 12:40 PM Jean-Baptiste Lespiau < > jblesp...@google.com> wrote: > >> Hi, >> >> thanks for your answer. >> >> Just a few remarks: >> >> 1. I imagine that we cannot know if people are using >> getFullyQualifiedName. In

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. So the original commit ( cbc9d22e49b4 ) was reverted at some point, and now you're proposing recommitting it

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

krasimir added a comment. In D79715#2029390 , @jbcoe wrote: > I expect that accepting this patch will need require an update to be made to > https://github.com/google/styleguide. I agree; it would be useful to leave a comment somewhere in this code with

[PATCH] D79804: [x86] prevent 64b operands to "r" constrained inline asm for -m32

craig.topper added a comment. I'm trying to catch up here. It looks like gcc has only started complaining about this from maybe version 7 on? And only as a warning? The LLVM X86 backend used a 32-bit register for 'r' or 'R' on -m32 for 64-bit values. But the backend would fail for 'q' or 'Q' if

[PATCH] D73037: Add a way to set traversal mode in clang-query

steveire updated this revision to Diff 263535. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73037/new/ https://reviews.llvm.org/D73037 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-que

[PATCH] D73037: Add a way to set traversal mode in clang-query

steveire updated this revision to Diff 263536. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73037/new/ https://reviews.llvm.org/D73037 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-que

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 263540. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/SourceL

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

steveire updated this revision to Diff 263541. steveire added a comment. Herald added a subscriber: ASDenysPetrov. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72532/new/ https://reviews.llvm.org/D72532 Files: clang/lib/Analysis/ExprMuta

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

vsapsai updated this revision to Diff 263544. vsapsai added a comment. Make compatibility mode accept correct types per James' Y Knight helpful suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79511/new/ https://reviews.llvm.org/D79511 F

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263543. wxz2020 added a comment. 1. in clang/test/Driver/aarch64-cpus.c, expanded the the same tests for thunderx2t99 to thunderx3t110 2. in llvm/unittest/Support/TargetParserTest.cpp, fix the missing target features So far all the existing issues are fixed

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 263551. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ParentMapContex

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 263552. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ParentMapContex

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 5 inline comments as done. fghanim added a comment. This is a small patch as it is. splitting it any further would make it very very small :D Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:234 __OMP_RTL(__kmpc_critical, false, Void, IdentPtr, Int32,

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM other than two nits here, this is really awesome! Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +&CGAM

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

yaxunl added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a default pragma float_control value"); -

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb22ab740355: Add nomerge function attribute to supress tail merge optimization in simplifyCFG (authored by zequanwu, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D78659?vs=26297

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang created this revision. LukeZhuang added reviewers: RKSimon, phosek, gribozavr, davidxl, chandlerc, pete, jyknight, dblaikie, kuba. LukeZhuang added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya. Add a new builtin-function `__builtin_ex

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2032764 , @fghanim wrote: > This is a small patch as it is. splitting it any further would make it very > very small :D Very small is great, then I can accept it fast, finding enough time to read larger patches is p

  1   2   >