[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

balazske added a comment. The empty signature is used to make add of C API functions easy because only the function name must be specified, not all types of parameters? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79423/new/ https://reviews.llvm.

[PATCH] D79425: [analyzer] StdLibraryFunctionsChecker: Add overload for adding the same summary for different names

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:672 +operator()(Name, S); +} } addToFunctionSummaryMap(ACtx, FunctionSummaryMap); Theoretically it is possible to have a //multiple names//

[PATCH] D79472: [X86] Remove support some inline assembly constraints that are no longer supported by gcc.

craig.topper created this revision. craig.topper added reviewers: rnk, echristo, RKSimon, spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This removes the Y0, Yi, Yt, Y2, Ym, and Y constraints. Repository: rG LLVM Github Monorepo https://reviews.l

[clang-tools-extra] 3adaa97 - Fix ForRangeCopyCheck not triggering on iterators returning elements by value in C++17.

Author: Dmitri Gribenko Date: 2020-05-06T09:42:13+02:00 New Revision: 3adaa97f0157e9d274c4d4e69b733db75b963574 URL: https://github.com/llvm/llvm-project/commit/3adaa97f0157e9d274c4d4e69b733db75b963574 DIFF: https://github.com/llvm/llvm-project/commit/3adaa97f0157e9d274c4d4e69b733db75b963574.dif

[PATCH] D79276: [FileCheck] Support comment directives

jhenderson added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1928 static const char *DefaultCheckPrefixes[] = {"CHECK"}; +static const char *DefaultCommentPrefixes[] = {"COM", "RUN"}; jdenny wrote: > jhenderson wrote: > > Similar to what I ment

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. In D76066#2022025 , @samparker wrote: > Ah, yes, good point. Then I have nothing else, but definitely worth waiting > to see if Eli has further comments. Yes I'll wait for Eli's feedback and update the other patches. Thanks for t

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @mgehre I think we need to adjust `denormalize(const IO &)` method here to convert \n back properly. It seems I missed it in my patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 _

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

balazske added a comment. An empty signature means really that the whole signature is "irrelevant"? It is like all types and number of arguments is irrelevant. Probably that would be a better name, instead of `empty` use `isIrrelevant`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697 if (auto *FD = dyn_cast(D)) { - if (S.matchesSignature(FD)) { + if (S.Sign.matches(FD) && S.validate(FD)) { auto Res = Map.inse

[PATCH] D79473: [clang] Fix a crash on invalid auto.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The crash is triggered on accessing a null InitExpr. For group declaration, e.g. `auto c = a, &d = {a};`, what's happening: 1. each VarDecl is built separately during the parsing stage. 2. perform th

[PATCH] D79440: Fix ForRangeCopyCheck not triggering on iterators returning elements by value in C++17.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3adaa97f0157: Fix ForRangeCopyCheck not triggering on iterators returning elements by value… (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D79440?vs=262202&id=262307#toc Re

[PATCH] D79465: Fix line lengths w/ comments in align

MyDeveloperDay added a comment. I don't seem to be able to reproduce the original problem (either will your test case or the bad.h) It would be good if the PR had the exact .clang-format file being used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

xazax.hun added a comment. Overall looks good to me, I have one question inline. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1013 +addToFunctionSummaryMap( +"__buf_size_arg_constraint_mul", +Summary(ArgTypes{ConstVoidPtrTy,

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

xazax.hun added a comment. I am a bit unsure what the purpose of these `Max` summaries are? As far as I understand the `Max` represents the largest value for the type of the formal parameter. Do we really ever need to specify this in a summary? Isn't it always an error to pass a value that is

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

xazax.hun added a comment. I think testing summaries this way can be really hard to manage in the future. I see two possible ways forward to make this easier: a) Make something like https://reviews.llvm.org/D78118 that will also dump the actual summary in a textual form, not only the fact that a

[PATCH] D79420: [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

xazax.hun added a comment. > If a given parameter in a FunctionDecl has a nonull attribute then the > NonNull constraint in StdCLibraryFunctionsChecker has the same effect as > NonNullParamChecker. Wait, where the diagnostic is coming from? My point is, the user should be able to turn `apiMode

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

xazax.hun added a comment. Also, I see no tests :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79431/new/ https://reviews.llvm.org/D79431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

ztamas updated this revision to Diff 262316. ztamas marked an inline comment as done. ztamas added a comment. Documentation fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79334/new/ https://reviews.llvm.org/D79334 Files: clang-tools-extra/c

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:629-630 + auto &One = BV.getValue(1, T); + const RangeSet TrueRangeSet(F, One, One); + const RangeSet FalseRangeSet(F, Zero

[PATCH] D79425: [analyzer] StdLibraryFunctionsChecker: Add overload for adding the same summary for different names

xazax.hun added a comment. I'd prefer to have this functionality committed together its first actual use with tests. I also agree with @balazske, we should diagnose the cases when we have multiple summaries for the same function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

xazax.hun added a comment. This is cool! Some questions: 1. Have you reported those bugs to CppCheck devs? It might be useful for us as well, as they can also double-check who is right. 2. This is a really large number of summaries. At this point, I wonder if it would be worth have a separate

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

xazax.hun added a comment. I am a bit unsure about this change. C libraries might be consumed in C++ projects and C++ projects might be free to overload those functions. Does the effort needed to specify the signatures justify not supporting that (probably unintentional) name collisions in C++?

[clang] d5ea89f - Quiet some -Wdocumentation warnings.

Author: Benjamin Kramer Date: 2020-05-06T11:23:13+02:00 New Revision: d5ea89f8914fcf7e5f637202c6972cb14617d93d URL: https://github.com/llvm/llvm-project/commit/d5ea89f8914fcf7e5f637202c6972cb14617d93d DIFF: https://github.com/llvm/llvm-project/commit/d5ea89f8914fcf7e5f637202c6972cb14617d93d.dif

[PATCH] D78035: [PoC][RISCV] enable LTO/ThinLTO on RISCV

khchen updated this revision to Diff 262322. khchen added a comment. update testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78035/new/ https://reviews.llvm.org/D78035 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/lib/Driv

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov added a comment. Guys, @xazax.hun, @Charusso, @steakhal, @vsavchenko, @NoQ, @baloghadamsoftware, please, tell something. What do you think of this improvement? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 _

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4574df52fd: [docs] Regenerate DiagnosticsReference.rst (authored by rsandifo-arm). Changed prior to commit: https://r

[clang] c6e1fd7 - [clang] Fix a crash on invalid auto.

Author: Haojian Wu Date: 2020-05-06T11:47:03+02:00 New Revision: c6e1fd70fb24d52daff4ec3fca1a89adfe7c2a0b URL: https://github.com/llvm/llvm-project/commit/c6e1fd70fb24d52daff4ec3fca1a89adfe7c2a0b DIFF: https://github.com/llvm/llvm-project/commit/c6e1fd70fb24d52daff4ec3fca1a89adfe7c2a0b.diff LO

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262324. kadircet added a comment. - Try to fix windows builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-extra/clangd/Headers.cpp clang-too

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

uabelho added a comment. Hi @mibintc , I think I'm seeing some oddities with this patch (current trunk, 0054c46095 ). With clang -S -Xclang -emit-llvm bbi-42553.c -o - on the input float rintf(float x); #pragma STDC FE

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. In email Wei asked for help about he following error message: error message from tblgen Included from /home/wei/project/tx3/llvm-project/llvm/lib/Target/AArch64/AArch64.td:439: /home/wei/project/tx3/llvm-project/llvm/lib/Target/AArch64/AArch64InstrInfo.td:9

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:152-158 /// Get the value of the stream argument out of the passed call event. /// The call should contain a function that is described by Desc. SVal getStreamArg(const FnDescriptio

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added a comment. In D78933#2022288 , @ASDenysPetrov wrote: > Guys, > @xazax.hun, @Charusso, @steakhal, @vsavchenko, @NoQ, @baloghadamsoftware, > please, tell something. What do you think of this improvement? Sorry, I will definitely take a l

[PATCH] D79473: [clang] Fix a crash on invalid auto.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e1fd70fb24: [clang] Fix a crash on invalid auto. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79473/new/ https://reviews.llvm.org/D

[clang] e959931 - [Sema] Put existing warning under -Wexcess-initializers

Author: Richard Sandiford Date: 2020-05-06T11:28:40+01:00 New Revision: e959931092d54330ce33f0c1a8479c978d39f655 URL: https://github.com/llvm/llvm-project/commit/e959931092d54330ce33f0c1a8479c978d39f655 DIFF: https://github.com/llvm/llvm-project/commit/e959931092d54330ce33f0c1a8479c978d39f655.d

[clang-tools-extra] fedd526 - [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

Author: Tamás Zolnai Date: 2020-05-06T12:36:01+02:00 New Revision: fedd52682ec70fd13b08eeac99ee0954292af9da URL: https://github.com/llvm/llvm-project/commit/fedd52682ec70fd13b08eeac99ee0954292af9da DIFF: https://github.com/llvm/llvm-project/commit/fedd52682ec70fd13b08eeac99ee0954292af9da.diff

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:478 + + // FIXME: Check for stream in EOF state? + Szelethus wrote: > balazske wrote: > > Szelethus wrote: > > > Will that

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

balazske added a comment. The checker or at least the source file should be split somehow, adding of summaries should be separated from the other parts, otherwise the file will be too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79433/new/

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

uabelho added a comment. It seems to be this change in SemaStmt.cpp that makes the FENV-pragma have some effect regardless of the warning saying that the pragma doesn't have any effect: index aa0d89ac09c3..f76994a6dab3 100644 @@ -394,6 +394,11 @@ StmtResult Sema::ActOnCompoundStmt(SourceLo

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe959931092d5: [Sema] Put existing warning under -Wexcess-initializers (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/ h

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfedd52682ec7: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse. (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79334

[clang-tools-extra] 4f7917c - [clangd] Handle PresumedLocations in IncludeCollector

Author: Kadir Cetinkaya Date: 2020-05-06T13:06:49+02:00 New Revision: 4f7917c269d65cd3c85eddee19385861c4b8390c URL: https://github.com/llvm/llvm-project/commit/4f7917c269d65cd3c85eddee19385861c4b8390c DIFF: https://github.com/llvm/llvm-project/commit/4f7917c269d65cd3c85eddee19385861c4b8390c.dif

[PATCH] D79477: [clang-tidy] Add --color-diagnostics option to control colors in diagnostics

hyd-dev created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. hyd-dev edited projects, added clang-tools-extra; removed clang. Herald added a project: clang. hyd-dev removed a project: clang. Herald added a project: clang. This patch add `--color-d

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. In D78129#2022307 , @joelkevinjones wrote: > In email Wei asked for help about he following error message: > > error message from tblgen > Included from > /home/wei/project/tx3/llvm-project/llvm/lib/Target/AArch64/AArch6

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f7917c269d6: [clangd] Handle PresumedLocations in IncludeCollector (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https:/

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGba8cda989cf8: [analyzer] Stability improvement for IteratorModeling (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78289/new/ ht

[clang-tools-extra] 9b509bc - Revert "[clangd] Handle PresumedLocations in IncludeCollector"

Author: Kadir Cetinkaya Date: 2020-05-06T13:17:08+02:00 New Revision: 9b509bca858cbc37ab8e36383f2550d5e2f8a312 URL: https://github.com/llvm/llvm-project/commit/9b509bca858cbc37ab8e36383f2550d5e2f8a312 DIFF: https://github.com/llvm/llvm-project/commit/9b509bca858cbc37ab8e36383f2550d5e2f8a312.dif

[clang] ba8cda9 - [analyzer] Stability improvement for IteratorModeling

Author: Denys Petrov Date: 2020-05-06T14:16:39+03:00 New Revision: ba8cda989cf884d53596099dc38a0e5a2c351074 URL: https://github.com/llvm/llvm-project/commit/ba8cda989cf884d53596099dc38a0e5a2c351074 DIFF: https://github.com/llvm/llvm-project/commit/ba8cda989cf884d53596099dc38a0e5a2c351074.diff

[clang] 69ab8b4 - [Sema][SVE] Fix handling of initialisers for built-in SVE types

Author: Richard Sandiford Date: 2020-05-06T12:24:27+01:00 New Revision: 69ab8b46b84daa42f334ea2dc7a097f7b81bae77 URL: https://github.com/llvm/llvm-project/commit/69ab8b46b84daa42f334ea2dc7a097f7b81bae77 DIFF: https://github.com/llvm/llvm-project/commit/69ab8b46b84daa42f334ea2dc7a097f7b81bae77.d

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 262274. erichkeane marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h clang/lib/Basic/Targets/AMDGPU.h clang/lib/Basic/Targets/A

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 262299. pdhaliwal added a comment. Added more context to diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: clang/lib/Basic/CMakeLists.txt lld/Common/CM

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. In D79400#2021255 , @scott.linder wrote: > Can you provide more context in the diff? Looking at the current `master` > locally it seems like this patch changes the behavior of the > `llvm_vcsrevision_h` target when `logs/HEAD`

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 ___ cfe-commits mailing list cf

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Szelethus added a comment. I'm not familiar enough with `DynamicSize.cpp` to judge the changes there, but aside from a few nits, this LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:249-250 + // cannot apply the constraint. Actually, ot

[PATCH] D79478: [CodeGen][SVE] Lowering of shift operations with scalable types

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, ctetreau, huihuiz. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent revision: D78812: [SVE][

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG69ab8b46b84d: [Sema][SVE] Fix handling of initialisers for built-in SVE types (authored by rsandifo-arm). Changed prior to commit: https://reviews.llvm.org/D76689?vs=261483&id=262342#toc Repository:

[PATCH] D79480: [SveEmitter] Add builtins for SVE2 Polynomial arithmetic

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. This patch adds builtins for: - sveorbt - sveortb - svpmul - svpmullb, svpmullb_pair - svpmullt, svpmullt_pair The svpmullb and svpmullt bui

[PATCH] D79456: [clangd] Complete filenames after < / ".

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1922 + Line.consume_front("include") || Line.consume_front("import") || + Line.consume_front("import_next"); + Line = Line.ltrim(); Did you mean include_next? Also, this w

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added a comment. Thanks for working on this, I do believe the analyzer would greatly profit from better constraint solving capabilities. Unfortunately, we had some troubles in the past trying to improve upon the current status and we had to revert multiple patches. This is why the com

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:478 + + // FIXME: Check for stream in EOF state? + balazske wrote: > balazske wrote: > > Szelethus wrote: > > > balazske wrote: > > > > Szelethus wrote: > > > > > Wi

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:588 + // AnyX2 means that two expressions marked as `Any` are met in code, + // and there is a special column for that, for example: + // if (x >= y) I have r

[PATCH] D79472: [X86] Remove support some inline assembly constraints that are no longer supported by gcc.

spatel added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:154-156 +BasicBlock::iterator It(New); +while (isa(*It) || isa(*It)) + ++It; Unrelated diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! I do agree that the warning message is not the best but it is not horrible either :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available

mboehme created this revision. mboehme added a project: clang. Herald added a subscriber: cfe-commits. These are needed for C++ interop in Swift. See this Swift forum discussion for details: https://forums.swift.org/t/calling-c-constructors-looking-for-feedback-on-my-approach/34787/4?u=mboehme

[clang] 3483cdc - [Sema] Silence warnings when targeting x86 with VS2019 16.5.4

Author: Alexandre Ganea Date: 2020-05-06T09:11:59-04:00 New Revision: 3483cdc8344d9c2c08c3f12490df54cfa63b6838 URL: https://github.com/llvm/llvm-project/commit/3483cdc8344d9c2c08c3f12490df54cfa63b6838 DIFF: https://github.com/llvm/llvm-project/commit/3483cdc8344d9c2c08c3f12490df54cfa63b6838.dif

[PATCH] D79487: [clangd] NFC: Use deprecated grpc++ headers for compatibility

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Ubuntu 18.04 and older versions do not provide latest gRCP packages and the ones that are in

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Still no change with a windows or s390x machine, but i could reproduce the/a problem systematically on linux by enabling sanitizer. In this case, initializing ConditionalsLevel to 0 in constructor does index fix this issue (and initializing to 1 ensures the issue happens, t

[PATCH] D79337: Silence warnings when compiling x86 with latest MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3483cdc8344d: [Sema] Silence warnings when targeting x86 with VS2019 16.5.4 (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D79337?vs=261848&id=262356#toc Repository: rG LLVM

[clang-tools-extra] 3197873 - [clangd] Do not offer "Add using" tweak in header files.

Author: Adam Czachorowski Date: 2020-05-06T15:50:54+02:00 New Revision: 319787315dd65f05aea562760cf57ac486bd2812 URL: https://github.com/llvm/llvm-project/commit/319787315dd65f05aea562760cf57ac486bd2812 DIFF: https://github.com/llvm/llvm-project/commit/319787315dd65f05aea562760cf57ac486bd2812.d

[clang] 8a1c999 - Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

Author: Erich Keane Date: 2020-05-06T06:52:18-07:00 New Revision: 8a1c999c9b0817d4de778a62965b4af86416e4b7 URL: https://github.com/llvm/llvm-project/commit/8a1c999c9b0817d4de778a62965b4af86416e4b7 DIFF: https://github.com/llvm/llvm-project/commit/8a1c999c9b0817d4de778a62965b4af86416e4b7.diff L

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2022354 , @uabelho wrote: > It seems to be this change in SemaStmt.cpp that makes the FENV-pragma have > some effect regardless of the warning saying that the pragma doesn't have > any effect: > > index aa0d89ac09c3.

[PATCH] D79488: [clangd] Do not offer "Add using" tweak in header files.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. This revision is now accepted and ready to land. adamcz updated

[PATCH] D79488: [clangd] Do not offer "Add using" tweak in header files.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:181 + const auto FileName = SM.getFileEntryForID(SM.getMainFileID())->getName(); + if (FileName.

[PATCH] D79488: [clangd] Do not offer "Add using" tweak in header files.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2471 + EXPECT_UNAVAILABLE(Header + "void fun() { one::two::f^f(); }"); + FileName = "test.hpp"; + EXPECT_UNAVAILABLE(Header + "void fun() { one::two::f^f(); }"); sammcc

[PATCH] D79488: [clangd] Do not offer "Add using" tweak in header files.

adamcz updated this revision to Diff 262364. adamcz marked 2 inline comments as done. adamcz added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79488/new/ https://reviews.llvm.org/D79488 Files: clang-tools-e

[PATCH] D79488: [clangd] Do not offer "Add using" tweak in header files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG319787315dd6: [clangd] Do not offer "Add using" tweak in header files. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong updated this revision to Diff 262366. martong added a comment. - Fix file descriptor params to have proper range value - usleep 100 -> 99 - Fix fstat family Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79433/new/ https://reviews.ll

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262374. kadircet added a comment. - use basename in tests as having unescaped backslashes breaks windows build bots. going to address that separetely in line directive generation logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong added a comment. In D79433#2022353 , @balazske wrote: > The checker or at least the source file should be split somehow, adding of > summaries should be separated from the other parts, otherwise the file will > be too long. Yes, I've been think

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong added a comment. In D79433#2022244 , @xazax.hun wrote: > This is cool! Hi Gabor, thanks for the reviews! :) > Some questions: > > 1. Have you reported those bugs to CppCheck devs? It might be useful for us > as well, as they can also double-ch

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov marked 5 inline comments as done. ASDenysPetrov added a comment. @xazax.hun, many thanks for looking at the patch. > Did you do some measurements on some projects how the run-time changes? I have never run them before. How I can do this? What project to use as a sample? > [1]: ht

[PATCH] D79420: [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

martong added a comment. In D79420#2022237 , @xazax.hun wrote: > > If a given parameter in a FunctionDecl has a nonull attribute then the > > NonNull constraint in StdCLibraryFunctionsChecker has the same effect as > > NonNullParamChecker. > > Wait, wher

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. > It is okay'ish to set `CompleteModel = 0` if you're not interested in > describing all instructions. The other way is of course to add the missing > instruction to the model. We are trying to describe all instructions. The issue Wei is having is that the point

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added a comment. In D78933#2022684 , @ASDenysPetrov wrote: > I have never run them before. How I can do this? What project to use as a > sample? Unfortunately, we do not really have a well-defined set of benchmarks. But as a first step, you

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:588 + // AnyX2 means that two expressions marked as `Any` are met in code, + // and there is a special column for that, for example: + // if (x >= y) xazax.hu

[PATCH] D79465: Fix line lengths w/ comments in align

JakeMerdichAMD added a comment. Mind looking again? They did add one later on I think. It helped a lot since the exact settings and whitespace to trigger this are really finicky (though reproducible). You're right that it won't reproduce without it. Here's a run log of the failing test I added,

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:340-345 +// TODO #2: We didn't go into the nested expressions before, so it +// might cause us spending much more time doing the inference. +// This can be a problem for de

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong added a comment. In D79430#202 , @xazax.hun wrote: > I am a bit unsure what the purpose of these `Max` summaries are? As far as I > understand the `Max` represents the largest value for the type of the formal > parameter. Yes, that's right.

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked an inline comment as done. wxz2020 added a comment. I tried to set CompleteModel = 0 on line 25 in file llvm/lib/Target/AArch64/AArch64SchedThunderX3T110.td The same error is still there. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet updated this revision to Diff 262381. kadircet added a comment. - Escape backslashes and quotes while generating line directive for filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/ https://reviews.llvm.org/D78743 Files:

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong added a comment. In D79423#2022167 , @balazske wrote: > An empty signature means really that the whole signature is "irrelevant"? It > is like all types and number of arguments is irrelevant. Probably that would > be a better name, instead of `em

[clang] c355bec - Add support for #pragma clang fp reassociate(on|off)

Author: Melanie Blower Date: 2020-05-06T08:05:44-07:00 New Revision: c355bec749e94c601a42e435f6c98b956f3965ac URL: https://github.com/llvm/llvm-project/commit/c355bec749e94c601a42e435f6c98b956f3965ac DIFF: https://github.com/llvm/llvm-project/commit/c355bec749e94c601a42e435f6c98b956f3965ac.diff

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar added a comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 262383. DerWaschbar marked 7 inline comments as done. DerWaschbar added a comment. - Removed unnecessary empty lines. - Added double back-ticks to highlight language constructs. - Indented code in documentation. Repository: rCTE Clang Tools Extra CH

[PATCH] D79494: [clang-tidy] Exclude function calls in std namespace for bugprone-argument-comment.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79494 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extr

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong added a comment. In D79423#2022251 , @xazax.hun wrote: > I am a bit unsure about this change. C libraries might be consumed in C++ > projects and C++ projects might be free to overload those functions. I don't think that could be a concern. Actu

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus updated this revision to Diff 262387. Szelethus added a comment. Make the solution handle dependencies from plugins as well via `CheckerRegistry`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78126/new/ https://reviews.llvm.org/D78126 Files: clang/include/clang/StaticAnal

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warn

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2126-2130 + + const CheckerRegistry &Registry = ErrorNode->getState() +->getAnalysisManager() +

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. I should have commit access now. Is there any documentation on how exactly to do a merge? Do I just add the commit to master and push? I apologize if this seems obvious, I just want to make sure I'm not inadvertently breaking something. CHANGES SINCE LAST ACTION

  1   2   3   >