[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + tra wrote: > rjmccall wrote: > > erichkeane wrote: > > > yaxunl wrote: > > > > echristo wrote: > > > > > rjmcc

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:723 +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); +return; pfultz2 wro

[PATCH] D78733: [OPENMP]Use new interface for task reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. One nit below. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:170 ArrayRef ReductionOps); - /// Emits lvalue for a reduction item. + /// Em

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane created this revision. erichkeane added a reviewer: craig.topper. After speaking with Craig Topper about some recent defects, he pointed out that _ExtInts should be passed indirectly if larger than the largest int register, and like ints when smaller than that. This patch implements th

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259796. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaC

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#2000237 , @nikic wrote: > Okay, I'm basically fine with that, if it is our stance that SmallVector > should always be preferred over std::vector. Not really related to this > revision, but it would probably help to d

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

Quuxplusone added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2804 +return; + } + Asking silly questions because I don't stand a chance of understanding either the code or the tests... In the x86-64 ABI, an ordinary 16-byte `struct` would

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

On Thu, 2020-04-23 at 17:46 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, sent out an ugly fix > at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build > bots running. > Nice, thanks! Now our buildbots went silent again. /Mikael > Will change the testing scheme for a proper fix. >

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

craig.topper added a comment. I think you're missing a check for ExtInt in X86_64ABIInfo::getIndirectReturnResult Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-comm

[PATCH] D78629: [clangd] Look for compilation database in `build` subdirectory of parents.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry this fell of my radar. LGTM. As discussed offline i am a little bit worried about regressing the case when there's a `build` in a subdirectory, and a (merged) compilation database o

<    1   2   3