[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258432. DiggerLin added a comment. handle getSymbol returning a function descriptor symbol after rebase on the D78045 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

NathanielMcVicar added a comment. I believe this change pushes clang\lib\Sema\SemaTemplateDeduction.cpp over the 16-bit COFF section limit for Windows Debug builds. Could you please resolve it or add /bigobj to the CMakeFile file for MSVC (see clang\lib\CodeGen\CMakeLists.txt). ERROR C1128

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. NVCC is not always right. > Is there a specific use case for this, other than matching nvcc bug-for-bug? I don't think I've seen the answer to my question above. > However, user can turn

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan added a comment. > Okay, sure, if there are already offsets in bytes already in the AST-level > layout, I agree that we should be able to compute all of the byte offsets at > that level. > > How are you planning to handle alignments here? Currently alignment doesn't > affect the l

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added subscribers: tamur, cmtice, JDevlieghere, labath, probinson, aprantl. dblaikie added a comment. In D76801#1989641 , @sammccall wrote: > Sorry about the problems here, and thanks for letting me know... > > In D76801#1989421

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 258442. DiggerLin added a comment. I think I address all the comments. thanks hubert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolCh

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 258444. browneee added a comment. Rebase to latest HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: llvm/include/llvm/ADT/SmallVector.h llvm/lib/Suppor

[PATCH] D77168: Add a flag to debug automatic variable initialization

llozano added a comment. In D77168#1988138 , @srhines wrote: > In D77168#1988122 , @jfb wrote: > > > In D77168#1988049 , @srhines wrote: > > > > > `pragma clang attribute` is

[clang] 50511a4 - Add SemaTemplateDeduction.cpp to /bigobj

Author: Erich Keane Date: 2020-04-17T16:33:07-07:00 New Revision: 50511a406df4475984e5c51feadada2c92aaf97a URL: https://github.com/llvm/llvm-project/commit/50511a406df4475984e5c51feadada2c92aaf97a DIFF: https://github.com/llvm/llvm-project/commit/50511a406df4475984e5c51feadada2c92aaf97a.diff L

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1989857 , @NathanielMcVicar wrote: > I believe this change pushes clang\lib\Sema\SemaTemplateDeduction.cpp over > the 16-bit COFF section limit for Windows Debug builds. Could you please > resolve it or add /bigobj

[PATCH] D73307: Unique Names for Functions with Internal Linkage

erichkeane added a comment. In D73307#1989740 , @rnk wrote: > In D73307#1978140 , @tmsriram wrote: > > > In D73307#1972388 , @rnk wrote: > > > > > Regarding the alias attribu

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dexonsmith closed this revision. dexonsmith added a comment. In D77621#1979769 , @browneee wrote: > GIT_COMMITTER_NAME=Andrew Browne > GIT_COMMITTER_EMAIL=brown...@google.com > > This would be my second commit. I will request access next time - thanks >

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

NathanielMcVicar added a comment. In D73967#1989932 , @erichkeane wrote: > I didn't see that on any of the buildbots, where did you see it? Thanks so much! It's funny that you say that because we just had that exact discussion this morning. I saw it in

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258447. zbrid added a comment. Update documentation based on Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

broadwaylamb added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: I'm not sure we need a new feature if

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. Automatic narrowing of bugs is indeed compelling, so I'd support that as long as it: - Allows bracketing as John suggested (lower / upper bounds where to stop / start). - Is implemented in a way which makes it really hard to regress the security mitigation. Maybe this requ

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

morehouse accepted this revision. morehouse added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:23 +How to build + Nit: "How to build libc++" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. In D73307#1989924 , @erichkeane wrote: > In D73307#1989740 , @rnk wrote: > > > In D73307#1978140 , @tmsriram > > wrote: > > > > > In D73307#1972388

[PATCH] D77168: Add a flag to debug automatic variable initialization

hubert.reinterpretcast added a comment. In D77168#1989973 , @jfb wrote: > I'd also like to see the pragma attribute approach, as well as byte-pattern > variability as I described. I don't think auto-narrowing is the only approach > we should push people

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258462. zbrid added a comment. Update nit from Matt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst libcxx/CMakeLists.txt li

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: broa

[PATCH] D73307: Unique Names for Functions with Internal Linkage

erichkeane added a comment. > Thanks for the comments! I was one of the authors of the GCC multiversioning > patch, and if I recall correctly from years ago, one of the reasons for > naming the target clones of multi-versioned foo as foo, foo.sse, etc. was so > that c++filt works nicely on t

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

rsmith added a comment. Thanks! Is this really the only case we were getting wrong? If so, great! We should make sure we have test coverage for all the cases affected by P0692R1. Please add some complementary tests for the cases where diagnostics should still be produced. For example, in additi

[PATCH] D77598: Integral template argument suffix printing

rsmith added a comment. Is is feasible to check whether the corresponding template parameter either has a deduced type or is a parameter of a function template? If not, we don't need to clarify the type of the template argument and could leave off the suffix to shorten the printed argument.

[clang] c8248dc - Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just UBSan.

Author: Richard Smith Date: 2020-04-17T22:37:30-07:00 New Revision: c8248dc3bb36bea61ac6d87bd02c39c6a781b011 URL: https://github.com/llvm/llvm-project/commit/c8248dc3bb36bea61ac6d87bd02c39c6a781b011 DIFF: https://github.com/llvm/llvm-project/commit/c8248dc3bb36bea61ac6d87bd02c39c6a781b011.diff

[PATCH] D77753: Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just UBSan.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8248dc3bb36: Change deprecated -fsanitize-recover flag to apply to all sanitizers, not just… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] fc76b4a - Rename IsMissingRequirement to IsUnimportable and set it for shadowed

Author: Richard Smith Date: 2020-04-17T22:48:56-07:00 New Revision: fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 URL: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73 DIFF: https://github.com/llvm/llvm-project/commit/fc76b4ad3da3c1f5fdc34370a55d613b3ca7af73.diff

[clang] 6bc7502 - When making modules transitively visible, don't take into account

Author: Richard Smith Date: 2020-04-17T22:49:58-07:00 New Revision: 6bc7502385cc2a06954082a7d0e6418e610d35f4 URL: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4 DIFF: https://github.com/llvm/llvm-project/commit/6bc7502385cc2a06954082a7d0e6418e610d35f4.diff

<    1   2