[clang] 96c4ec8 - Remove extra whitespace. NFC.

Author: Michael Liao Date: 2020-04-10T03:22:01-04:00 New Revision: 96c4ec8fdbd95048114cf058679bd8fc08ab76b3 URL: https://github.com/llvm/llvm-project/commit/96c4ec8fdbd95048114cf058679bd8fc08ab76b3 DIFF: https://github.com/llvm/llvm-project/commit/96c4ec8fdbd95048114cf058679bd8fc08ab76b3.diff

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

dblaikie added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTree.h:32 #include "llvm/ADT/SmallVector.h" +#include "llvm/IR/CFGDiff.h" #include "llvm/Support/CFGUpdate.h" mehdi_amini wrote: > This looks like a layering violation to me here: I

[clang] 0445c64 - [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

Author: Alina Sbirlea Date: 2020-04-10T07:38:53Z New Revision: 0445c64998d14b81f0d3a3182011fc5eae47fa71 URL: https://github.com/llvm/llvm-project/commit/0445c64998d14b81f0d3a3182011fc5eae47fa71 DIFF: https://github.com/llvm/llvm-project/commit/0445c64998d14b81f0d3a3182011fc5eae47fa71.diff LOG:

[clang] bbeeb35 - Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

Author: Mehdi Amini Date: 2020-04-10T07:44:06Z New Revision: bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1 URL: https://github.com/llvm/llvm-project/commit/bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1 DIFF: https://github.com/llvm/llvm-project/commit/bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1.diff LOG: R

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

mehdi_amini added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTree.h:32 #include "llvm/ADT/SmallVector.h" +#include "llvm/IR/CFGDiff.h" #include "llvm/Support/CFGUpdate.h" dblaikie wrote: > mehdi_amini wrote: > > This looks like a layering

[PATCH] D77682: [clang-format] Always break line after enum opening brace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77682/new/ https://reviews.llvm.org/D77682 ___

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

mehdi_amini added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTree.h:32 #include "llvm/ADT/SmallVector.h" +#include "llvm/IR/CFGDiff.h" #include "llvm/Support/CFGUpdate.h" mehdi_amini wrote: > dblaikie wrote: > > mehdi_amini wrote: > > > Th

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko marked 4 inline comments as done. vsavchenko added a comment. In D77806#1973616 , @NoQ wrote: > We're doing much more here than just fixing the CFError behavior; we're > actually making the whole analyzer respect these annotations in top frame.

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao updated this revision to Diff 256518. hliao added a comment. Fix a clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUD

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256521. mwyman added a comment. Added struct member reference from local variable, per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571/new/ https://reviews.llvm.org/D77571 Files: clang-too

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

nikic added a comment. This change causes a 2.5% compile-time regression across the board, see http://llvm-compile-time-tracker.com/compare.php?from=37bcf2df01cfa47e4509a5d225a23e2ca95005e6&to=a90374988e4eb8c50d91e11f4e61cdbd5debb235&stat=instructions. Can you please try to find a cheaper way to

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

nikic added a comment. This change causes a ~0.5% compile-time regressions: http://llvm-compile-time-tracker.com/compare.php?from=5b18b6e9a84d985c0a907009fb71de7c1943bc88&to=60c642e74be6af86906d9f3d982728be7bd4329f&stat=instructions This is quite a lot as these things go, so it would be great if

[libunwind] 9107594 - [libunwind] add hexagon support

Author: Brian Cain Date: 2020-04-10T04:24:10-05:00 New Revision: 9107594f376e37e99c71881404c686b306f93ad2 URL: https://github.com/llvm/llvm-project/commit/9107594f376e37e99c71881404c686b306f93ad2 DIFF: https://github.com/llvm/llvm-project/commit/9107594f376e37e99c71881404c686b306f93ad2.diff LO

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256530. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1971420 , @ASDenysPetrov wrote: > @thakis > > > 'perl' is not recognized as an internal or external command, > > I think you got another problem, that Perl isn't just presented in your PATH. > It is not the case for buil

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. If I add scan-build to clang/test/CMakeLists.txt and undo my other changes, the test passes for me. I guess you always build that target, which is why you didn't see this problem. But I wonder why this isn't needed on non-Windows. Repository: rG LLVM Github Monorepo

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. (Also, that dep should only be added if CLANG_INSTALL_SCANBUILD isn't set to OFF, and I suppose the tests should only run if it isn't off too.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76768/new/ https://reviews.llvm.o

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65 + + void reply(llvm::json::Value ID, + llvm::Expected V) override { sammccall wrote: > kadircet wrote: > > put methods before fields > Done - I don't care

[clang] 1bd70bc - [gn build] add scan-build target

Author: Nico Weber Date: 2020-04-10T06:18:41-04:00 New Revision: 1bd70bcd50be3c55e714350e3aadfd48040581f1 URL: https://github.com/llvm/llvm-project/commit/1bd70bcd50be3c55e714350e3aadfd48040581f1 DIFF: https://github.com/llvm/llvm-project/commit/1bd70bcd50be3c55e714350e3aadfd48040581f1.diff LO

[clang] 562bc30 - [Driver] Improve help message for -ffixed-xX flags

Author: Simon Cook Date: 2020-04-10T11:30:24+01:00 New Revision: 562bc307c03de86dc083a019f358cd36c48488b0 URL: https://github.com/llvm/llvm-project/commit/562bc307c03de86dc083a019f358cd36c48488b0 DIFF: https://github.com/llvm/llvm-project/commit/562bc307c03de86dc083a019f358cd36c48488b0.diff LO

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk updated this revision to Diff 256546. tuktuk added a comment. I was indeed able to run the test again after changing its name to //.cpp//, thank you for your help. I have restored XFAIL lines from the original //sanitizer_coverage_no_prune.cpp// that I should not have deleted. Now the te

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, xazax.hun, rnkovacs, dcoughlin, martong, balazske. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

kadircet added a comment. should we also have a unittest for checking ast caching works as expected? ClangdServer::getUsedBytesPerFile should allow us to do that. We can set cache size to one, send 3 updates in respective order to foo, bar and baz, we record usedbytesperfile. Then we perform ad

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal updated this revision to Diff 256551. steakhal added a comment. - rewritten the `RangeSet::compare` function and checked the assumptions on WolframAlpha - moved the `RangeSet::compare` function to a cpp file - added comments to the `RangeSet::compare` function - fixed the comment in `Ran

Re: [PATCH] D63194: [clangd] Link and initialize target infos

Hi Kadir, Can you fix the target_info.test clangd test you committed in this revision, please? I see you've tried fixing it later by adding `REQUIRES: x86-registered-target`, but now it's never running because that feature isn't (ever) set. Here's a buildbot run showing it as unsupported (x86 targ

[PATCH] D77385: [clangd] Add index export to dexp

mnauw updated this revision to Diff 256557. mnauw edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77385/new/ https://reviews.llvm.org/D77385 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp Index: clang-tools-extra/clangd/index/dex/dexp/Dexp.

[PATCH] D77385: [clangd] Add index export to dexp

mnauw added a comment. As suggested, I will provide the YAMLSerialization changes in a separate patch. Regarding test for that, I was thinking of some running some "simple/mock YAML data" through some load and save cycle(s). I presume a separate YAML file (in e.g. test/Inputs) is best for tha

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk updated this revision to Diff 256556. tuktuk added a comment. I forgot to apply //clang-format// on //clang/lib/Driver/SanitizerArgs.cpp//, now it should be OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.o

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1974044 , @thakis wrote: > If I add scan-build to clang/test/CMakeLists.txt and undo my other changes, > the test passes for me. I guess you always build that target, which is why > you didn't see this problem. But I won

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: ostannard, t.p.northover. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a reviewer: rengolin. Herald added a project: clang. LukeGeeson added a parent revision: D77540: [PATCH] [ARM]: Armv8.6-a

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. @thakis Let me explain what works for me. This is in my **PATH**: - C:\Perl\c\bin - C:\Perl\perl\site\bin - C:\Perl\perl\bin - D:\llvm-project\buildn\bin This is what in D:\llvm-project\buildn\bin (all this is a product of ninja+gcc): - clang.exe - FileCheck.exe -

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics. LukeGeeson ad

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D77874: [AArch32] Armv8.6a Matrix Mul Assembly. This patch upstreams support for the

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. Hi folks, Thank you for your help, I have split the patches up as follows: 1. https://reviews.llvm.org/D77871 [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics 2. https://reviews.llvm.org/D77872 [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics 3. https://rev

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. @NoQ , sorry for the late response, was working on other patch. > Why are we getting a compound value here? We are getting **nonloc::SymbolVal** here, not a compound value, since //* *ptr// result is unknown after //*ptr = foo();// (look at the test sample). The

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei added a comment. In D77632#1974015 , @nikic wrote: > This change causes a ~0.5% compile-time regressions: > http://llvm-compile-time-tracker.com/compare.php?from=5b18b6e9a84d985c0a907009fb71de7c1943bc88&to=60c642e74be6af86906d9f3d982728be7bd4329f&s

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson added a comment. Harbourmaster now biulds, and unit tests pass, errors related to linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___ cfe-com

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson added a comment. Removed reliance on parent revision, harbormaster now builds with unit tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/ https://reviews.llvm.org/D77871 __

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson added a comment. harbour master builds, unit tests passing, failures down to linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 ___ cfe-commits

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson added a comment. In D77632#1974363 , @wenlei wrote: > In D77632#1974015 , @nikic wrote: > > > This change causes a ~0.5% compile-time regressions: > > http://llvm-compile-time-tracker.com/compare.php?from

[clang-tools-extra] 89f1321 - [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

Author: Michael Wyman Date: 2020-04-10T08:51:21-07:00 New Revision: 89f1321fe4ef203a4674213280b430a274dc2001 URL: https://github.com/llvm/llvm-project/commit/89f1321fe4ef203a4674213280b430a274dc2001 DIFF: https://github.com/llvm/llvm-project/commit/89f1321fe4ef203a4674213280b430a274dc2001.diff

[PATCH] D77880: get scan-view executable from environment

asmar created this revision. asmar added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. Fixes "Use of uninitialized value $ScanView in exec" error on systems with scan-view executable not located in the expected place. Currently when scan-build i

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG89f1321fe4ef: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that… (authored by mwyman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D77682: [clang-format] Always break line after enum opening brace

osandov added a comment. Thank you! I don't have commit access. How can I get this committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77682/new/ https://reviews.llvm.org/D77682 ___ cfe-commits ma

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

steakhal added a comment. It took me some time to understand what you were doing. Probably a bit ASCII-art would have had help (eg. about the wrapping behavior). By the same token, I wouldn't mind more tests, especially exercising the implemented behavior. Probably `unit-tests` would fit better

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. > ! In D77545#1973765 , @sepavloff > wrote: > >> ! In D77545#1973169 , @rjmccall >> wrote: >> all of which will just do the wrong thing if they don't preserve and pass >> down the right

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JonasToth. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. Abpostelnicu edited the summary of this revision. Ab

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm created this revision. arsenm added reviewers: yaxunl, b-sumner, hliao. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. The current install situation is a mess, but I'm working on fixing it. Search for the target layout instead of one of the N o

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm updated this revision to Diff 256598. arsenm added a comment. Forgot to commit part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77885/new/ https://reviews.llvm.org/D77885 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/Inputs/rocm-device-libs/amdgcn/bitcode

[clang] 4593e41 - AMDGPU: Teach toolchain to link rocm device libs

Author: Matt Arsenault Date: 2020-04-10T13:37:32-04:00 New Revision: 4593e4131affa84e61d7b6844be409ba46d29f11 URL: https://github.com/llvm/llvm-project/commit/4593e4131affa84e61d7b6844be409ba46d29f11 DIFF: https://github.com/llvm/llvm-project/commit/4593e4131affa84e61d7b6844be409ba46d29f11.diff

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm closed this revision. arsenm added a comment. 4593e4131affa84e61d7b6844be409ba46d29f11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 __

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 _

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGbef187c75090: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist`… (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a comment. In D7#1972720 , @hliao wrote: > In D7#1972349 , @tra wrote: > > > The patch could use a more detailed description. Specifically, it does not > > describe the purpose of these changes. >

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 256611. ctetreau added a comment. Address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGe

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. In D76768#1974255 , @ASDenysPetrov wrote: > @thakis > Let me explain what works for me. > This is in my **PATH**: > > - C:\Perl\c\bin > - C:\Perl\perl\site\bin > - C:\Perl\perl\bin > - D:\llvm-project\buildn\bin ^ This is not u

[PATCH] D77257: Clean up usages of asserting vector getters in Type

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 256621. browneee added a comment. Change to suggested approach: size and capacity type conditionally larger for small element types. Also incorporate https://reviews.llvm.org/D77601 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dblaikie added a comment. Please update the patch description/subject line. @dexonsmith I'll leave this to you for final approval, since it was your idea/you've been touching things here. But looks like about the right direction. Comment at: llvm/include/llvm/ADT/SmallVector.

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao added a comment. In D7#1974672 , @tra wrote: > In D7#1972720 , @hliao wrote: > > > In D7#1972349 , @tra wrote: > > > > > The patch could use a more detailed

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

thakis added a comment. test fails on win: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/15191/steps/stage%201%20check/logs/stdio CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 __

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

rnk added a comment. In D75903#1963382 , @pratlucas wrote: > In regards to the compatibility with other compilers, I'm not sure that > following what seems to be an uncompliant behavior would be the best way to > proceed. @rnk and @ostannard, what would

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. As I mentioned before. As long as the type is not "used" you can treat it as a sequence of bytes just as well. So we can lower `__float128` to `char [16]` with the right alignment. SPIRV will never see unsupported types and the code works because we never access it as

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77903 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/C

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256648. mibintc added a comment. I finally decided that combining BinaryOperator and CompoundAssignOperator was too difficult, this patch uses the trailing object approach similar to that used in CallExpr. @rjmccall thank you once again for all your reviews

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a comment. In D7#1974849 , @hliao wrote: > >> NVVM IR spec is for nvidia's own compiler. It's based on LLVM, but it does >> not impose direct constraints on LLVM's design choices. > > It would be an advantage and, sometimes, desirable t

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

sbc100 created this revision. Herald added subscribers: cfe-commits, jfb, arphaman, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added a project: clang. Since this feature is now merged into the upstream wasm spec it makes sense to enable it by default, at least for the `default

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre added a comment. Thanks @njames93, this is a good examples which I did not consider yet. I agree that only transforming the second loop would make the code worse. I would argue that a human seeing a warning on the second loop might also realize that the first loop can be transformed in a

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

tlively added a comment. Do we have tests that check that passing `-nontrapping-fptoint` to llc (or clang) successfully disables the feature? Comment at: clang/lib/Basic/Targets/WebAssembly.h:33 - bool HasNontrappingFPToInt = false; + bool HasNontrappingFPToInt = true;

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77903/new/ https://reviews.llvm.org/D77903 ___

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao added a comment. In D7#1974988 , @tra wrote: > In D7#1974849 , @hliao wrote: > > > > > > > > >> NVVM IR spec is for nvidia's own compiler. It's based on LLVM, but it does > >> not impose direct constr

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

njames93 added a comment. Right now it would be a great candidate for this - http://lists.llvm.org/pipermail/cfe-dev/2020-March/064980.html, however in its current state I wouldn't say its ready to get the green light right now. No point worrying about the fix-its yet, but when it is time, could

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia. Herald added subscribers: danielkiss, kerbowa, kristof.beyls, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This doesn't seem to be that useful, since it doesn't change any device side functions. Report it since

[clang] 1e93b3d - Disable test on windows

Author: Matt Arsenault Date: 2020-04-10T18:48:18-04:00 New Revision: 1e93b3d8a75638c2268df58e44a8738845df3ed5 URL: https://github.com/llvm/llvm-project/commit/1e93b3d8a75638c2268df58e44a8738845df3ed5 DIFF: https://github.com/llvm/llvm-project/commit/1e93b3d8a75638c2268df58e44a8738845df3ed5.diff

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, ABataev, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. This was reported as PR45231 but occurs even without `cmath` in C++17 mode if we have an expression involving unsupported

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a subscriber: majnemer. tra added a comment. In D7#1975178 , @hliao wrote: > the 1st argument in `llvm.nvvm.texsurf.hande.internal` or the 2nd one in > `llvm.nvvm.texsurf.handle` must be kept as an immediate or constant value, > i.e. that g

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a comment. Also, if I read PTX docs correctly, it should be OK to pass texture handle address via an intermediate variable: https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#texture-sampler-and-surface-types > Creating pointers to opaque variables using mov, e.g., mov.u

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl, scott.linder. Herald added subscribers: kerbowa, hiraditya, nhaehnle, wdng, jvesely. Some of the device specific standard predefines were missing. __IMAGE_SUPPORT__ was only hardcoded for SPIR. __OPENCL_VERSION__ was

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. @craig.topper can you please update/rebase this stack to remove the early LVI CFI work that ended up landed in https://reviews.llvm.org/D76812 instead? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 __

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

mattdr added a comment. I accidentally spent time reviewing this, only to cross-reference something in the LLVM code and find another diff (https://reviews.llvm.org/D76812) was written to answer Zola's request and has already been submitted. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:33 - bool HasNontrappingFPToInt = false; + bool HasNontrappingFPToInt = true; bool HasSignExt = false; tlively wrote: > It seems strange to change the default here. x86 initial

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

sbc100 updated this revision to Diff 256712. sbc100 marked 7 inline comments as done. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77908/new/ https://reviews.llvm.org/D77908 Files: clang/lib/Basic/Targets/WebAss

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

craig.topper abandoned this revision. craig.topper added a comment. This was superceded by D76812 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 ___ cfe-commits mai

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

sbc100 updated this revision to Diff 256713. sbc100 added a comment. err.. arc diff did something funny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77908/new/ https://reviews.llvm.org/D77908 Files: clang/lib/Basic/Targets/WebAssembly.cpp cl

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese updated this revision to Diff 256722. Bigcheese added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: clang/include/clang/Basic/FileManager.h clang/lib/Basic/Fi

[clang] ed03d94 - Revert "[TLI] Per-function fveclib for math library used for vectorization"

Author: Mehdi Amini Date: 2020-04-11T01:05:01Z New Revision: ed03d9485eb5b502708f8a21ce34fa6da05a9ca5 URL: https://github.com/llvm/llvm-project/commit/ed03d9485eb5b502708f8a21ce34fa6da05a9ca5 DIFF: https://github.com/llvm/llvm-project/commit/ed03d9485eb5b502708f8a21ce34fa6da05a9ca5.diff LOG: R

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

mehdi_amini created this revision. mehdi_amini added a reviewer: tejohnson. Herald added subscribers: cfe-commits, haicheng, hiraditya, eraman. Herald added a project: clang. mehdi_amini added a reviewer: wenlei. tejohnson accepted this revision. tejohnson added a comment. This revision is now acce

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao added a comment. In D7#1975406 , @tra wrote: > In D7#1975178 , @hliao wrote: > > > the 1st argument in `llvm.nvvm.texsurf.hande.internal` or the 2nd one in > > `llvm.nvvm.texsurf.handle` must be kept

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77925/new/ https://reviews.llvm.org/D77925 _

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

mehdi_amini added a comment. The existing TLI provides a very convenient way to define a VecLib without LLVM knowing about it ahead of time. This feature is important for any embedded use of LLVM as a library out-of-tree (I'll add a unit-test in-tree). I don't think it is a big change to this pa

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

rjmccall accepted this revision. rjmccall added a comment. LGTM. I'm somewhat surprised that this is the implementation design for integer overflow diagnostics, but since it is, I see no reason not to adopt it for fixed-point as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. Okay, that's fine, it's definitely a simpler change to not mess with the basic node hierarchy. The one problem I see is that you've (accidentally?) set up the `FPOptions` methods so that you can't call them on a `BinaryOperator` that's actually a `CompoundAssignOperat

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

This revision was automatically updated to reflect the committed changes. Closed by commit rGed03d9485eb5: Revert "[TLI] Per-function fveclib for math library used for vectorization" (authored by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

rjmccall added a comment. This is a weird point to allow further ABI customization of. I understand why you want to customize this, but I wonder if it's actually worthwhile to make a `virtual` function for it vs. just checking some sort of flag in the builder. Isn't there quite a lot of struc

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao added a comment. In D7#1975440 , @tra wrote: > Also, if I read PTX docs correctly, it should be OK to pass texture handle > address via an intermediate variable: > > https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#texture-sam

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

rjmccall added a comment. Some minor requests, but otherwise this LGTM. Comment at: include/clang/Serialization/ASTBitCodes.h:1637 + /// A FixedPointLiteral record. + EXPR_FIXEDPOINT_LITERAL, + rjmccall wrote: > ebevhan wrote: > > I'm unsure if this i

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. Scanned through the first bit. Comment at: clang/docs/LanguageExtensions.rst:500 +Clang provides a matrix extension, which is currently being implemented. See +:ref:`matrixsupport` for more details. + This should include just a bit mor

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

yaxunl added a comment. I am not so sure whether compiler should always report this. I thought it depends on platform and should let runtime to add it when it is really supported. But on the other hand, we could report it by default if it is the most case, and let runtime to disable it if it i

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. It appears I can crash clang with some texture code: https://godbolt.org/z/5vdEwC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 ___ cfe-

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a comment. In D7#1975628 , @hliao wrote: > In D7#1975440 , @tra wrote: > > > Also, if I read PTX docs correctly, it should be OK to pass texture handle > > address via an intermediate variable: >

  1   2   >