[PATCH] D77311: clang-format: [JS] detect C++ keywords.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I think this LGTM and brings more clarity as its much easier to look for things in the positive than the negative Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77311/new/ https

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77311/new/ https://reviews.llvm.org/D77311 _

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#1951346 , @bbassi wrote: > @MyDeveloperDay Can you please share your thoughts on my comment above? I'm tempted to agree that perhaps having as an enumeration `BreakBeforeClosingBracket` with various options mig

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. > I personally say fuck backwards compatibility when maintaining it requires > ever more workarounds to fix an obviously flawed abstraction, but I'm just > some dude and AFAIK the guys in charge support the status quo. When LLVM itself isn't prepared to run cla

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

krasimir added inline comments. Comment at: clang/lib/Format/FormatToken.h:913 bool IsJavaScriptIdentifier(const FormatToken &Tok) const { -return Tok.is(tok::identifier) && - JsExtraKeywords.find(Tok.Tok.getIdentifierInfo()) == - JsExtraKeywords.en

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

mprobst marked 2 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/FormatToken.h:913 bool IsJavaScriptIdentifier(const FormatToken &Tok) const { -return Tok.is(tok::identifier) && - JsExtraKeywords.find(Tok.Tok.getIdentifierInfo

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

andrewng added a comment. The following patch fixes my issues on Windows, but I haven't tested that it doesn't break anything else: diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake index 91bec7d8081..f630af211fd 100644 --- a/llvm/cmake/modules/AddLLVM.cmake

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

andwar added a comment. Btw, could you also add some negative tests? (e.g. out-of-range immediate) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 ___ cfe-commi

[clang] 146d685 - clang-format: [JS] detect C++ keywords.

Author: Martin Probst Date: 2020-04-03T14:23:56+02:00 New Revision: 146d685cd657399a4698015f16cc5910cc828728 URL: https://github.com/llvm/llvm-project/commit/146d685cd657399a4698015f16cc5910cc828728 DIFF: https://github.com/llvm/llvm-project/commit/146d685cd657399a4698015f16cc5910cc828728.diff

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rG146d685cd657: clang-format: [JS] detect C++ keywords. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D77311?vs=254741&id=254763#toc R

[clang] a46e7d7 - [AMDGPU] Allow AGPR in inline asm

Author: Yaxun (Sam) Liu Date: 2020-04-03T09:08:13-04:00 New Revision: a46e7d7a5f60b452340eb8ebc873538659c73e78 URL: https://github.com/llvm/llvm-project/commit/a46e7d7a5f60b452340eb8ebc873538659c73e78 DIFF: https://github.com/llvm/llvm-project/commit/a46e7d7a5f60b452340eb8ebc873538659c73e78.dif

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

hokein added a comment. In D76831#1952425 , @sammccall wrote: > I like the idea, but it seems to regress quite a lot of diagnostics... e.g. > where we fail to deduce auto and then say it's not a pointer. > > Also this is regressing things in the -fno-reco

[PATCH] D77385: [clangd] Add index inspection helper tool

mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Add a standalone executable that can read indexed data and out

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 254761. danielkiss added a comment. The patched is rebased and the hopefully the logic is now simpler. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/Cod

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 254765. baloghadamsoftware added a comment. Lots of things seem to work now. However, I have a question: what to do with the return values of non-inlined calls? It may also be a `LazyCompoundVal`, but non-inlined calls do not have `StackFrameConte

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. Output of /home/edmbalo/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/ssd/edmbalo/llvm-project/build/lib/clang/11.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -setup-static-analyzer -std=c++11 -analyzer-checker=core,cplusplus

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

sammccall updated this revision to Diff 254769. sammccall added a comment. Store NumElements in the bitfield after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/new/ https://reviews.llvm.org/D77335 Files: clang/include/clang/AST/Type.

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/AST/Type.h:3236 QualType ElementType; + unsigned NumElements; fhahn wrote: > I think you could keep NumElements in VectorTypeBitfields (just remove

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rGa46e7d7a5f60: [AMDGPU] Allow AGPR in inline asm (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D77329?vs=254668&id=254772#toc Repository: rG LL

[clang-tools-extra] 164ed7b - [clangd] Enable some nice clang-tidy checks by default.

Author: Sam McCall Date: 2020-04-03T15:40:07+02:00 New Revision: 164ed7b1d0446400123189c9cd168df5448e4233 URL: https://github.com/llvm/llvm-project/commit/164ed7b1d0446400123189c9cd168df5448e4233 DIFF: https://github.com/llvm/llvm-project/commit/164ed7b1d0446400123189c9cd168df5448e4233.diff LO

[clang] b72fce1 - Fix __builtin_amdgcn_workgroup_size_x/y/z return type

Author: Yaxun (Sam) Liu Date: 2020-04-03T09:56:30-04:00 New Revision: b72fce1ffd0a0de5b46b486c7030d54cc5d8c225 URL: https://github.com/llvm/llvm-project/commit/b72fce1ffd0a0de5b46b486c7030d54cc5d8c225 DIFF: https://github.com/llvm/llvm-project/commit/b72fce1ffd0a0de5b46b486c7030d54cc5d8c225.dif

[PATCH] D77390: Fix __builtin_amdgcn_workgroup_size_x/y/z return type

yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm accepted this revision. This revision is now accepted and ready to land. https://reviews.llvm.org/D77390 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, martong, balazske, steakhal, xazax.hun, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepe

[PATCH] D77385: [clangd] Add index inspection helper tool

kadircet added a comment. Thanks for the patch! We already have one introspection tool called `dexp` have you give it a try? It can read both RIFF and YAML and allows you to run queries on the index. If it is not enough for your use case, can you describe it a little more? Maybe it would be ea

[PATCH] D77348: [clangd] Enable some nice clang-tidy checks by default.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:695 +auto EmptyDefaults = tidy::ClangTidyOptions::getDefaults(); +EmptyDefaults.Checks.reset(); // So we can tell if checks were ever set.

[PATCH] D77392: [clangd] Make signatureHelp work with stale preambles

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This is achieved by calculating newly added includes and implicitly parsing t

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

hokein accepted this revision. hokein added a comment. still LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/new/ https://reviews.llvm.org/D77335 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus updated this revision to Diff 254780. Szelethus marked 2 inline comments as done. Szelethus added a comment. Herald added a subscriber: mgorny. - Add `PostStmt` - Add PostCall for `CXXDeallocatorCall` - Add a unittest, which is kind of pointless as-is, but I realized only later that mos

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus requested review of this revision. Szelethus added a comment. Since this change had a few blocking issues, I'm placing it back to review for greater visibility. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:67 CE_CXXAllocator, + CE

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

sdesmalen added a comment. In D76680#1959217 , @SjoerdMeijer wrote: > Looks good to me, but just one question about the tests. If I haven't > overlooked anything, I don't see tests that check the new diagnostics: > "argument should be the value 90 or 27

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

grimar added a comment. In D77184#1959351 , @andrewng wrote: > The following patch fixes my issues on Windows, but I haven't tested that it > doesn't break anything else: > > diff --git a/llvm/cmake/modules/AddLLVM.cmake > b/llvm/cmake/modules/AddLLVM.

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau created this revision. pgousseau added reviewers: craig.topper, probinson, filcab. Herald added a project: clang. Herald added a subscriber: cfe-commits. Warnings in emmintrin.h and xmmintrin.h are reported by -fsanitize=implicit-integer-sign-change Repository: rG LLVM Github Monore

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

sammccall updated this revision to Diff 254786. sammccall marked 5 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77355/new/ https://reviews.llvm.org/D77355 Files: clang-tools-e

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:69 struct Foo { - int [[b^ar]]; + char [[b^ar]]; }; kadircet wrote: > any reason for changing these from int to char

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:239 + + auto It = llvm::partition_point(F.Mappings, [SpelledI](const Mapping &M) { +return M.BeginSpelled <= SpelledI; It would be great to add an is_sorted assertion to the bu

[PATCH] D77348: [clangd] Enable some nice clang-tidy checks by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG164ed7b1d044: [clangd] Enable some nice clang-tidy checks by default. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77348?vs=254650&id=254789#toc Repository: rG LLVM Git

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:69 struct Foo { - int [[b^ar]];

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein edited the summary of this revision. hokein edited the summary of this revision. hokein added a reviewer: sammccall. hokein retitled this revision from "[AST] Dont invalide VarDecl even the

[PATCH] D77398: [cuda][hip] Fix `RegisterVar` function prototype.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `RegisterVar` has `void` return type and `size_t` in its variable size parameter in HIP or CUDA 9.0+. Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Rename test file to x86-header-warnings.c or something similarly specific? Comment at: clang/test/Headers/warn-cleanup.c:10 +#include +#include + Use x8intrin.h directly so its easier to expand in th

[PATCH] D77398: [cuda][hip] Fix `RegisterVar` function prototype.

yaxunl added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77398/new/ https://reviews.llvm.org/D77398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D77390: Fix __builtin_amdgcn_workgroup_size_x/y/z return type

b-sumner added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77390/new/ https://reviews.llvm.org/D77390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 88fbadd - [AST] clang::VectorType supports any size (that fits in unsigned)

Author: Sam McCall Date: 2020-04-03T17:30:31+02:00 New Revision: 88fbadd0f5d50ea1d310fb63da6da15b82a9be05 URL: https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05 DIFF: https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05.diff LO

[PATCH] D73245: Avoid using std::max_align_t in pre-C++11 mode

joerg added a comment. ping2 Louis, did I answer your questions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. (Only if their definitions are visible and they have no other docs) Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

Szelethus updated this revision to Diff 254816. Szelethus marked 2 inline comments as done. Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. Inlines addressed, rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75431/new/ https://reviews.llvm.org/D75431 Files:

[PATCH] D77410: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

martong created this revision. martong added reviewers: NoQ, Szelethus, gamesh411, baloghadamsoftware. Herald added subscribers: cfe-commits, ASDenysPetrov, danielkiss, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, kristof.beyls, xazax.hun, whisperity. Hera

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

This revision was automatically updated to reflect the committed changes. Closed by commit rG88fbadd0f5d5: [AST] clang::VectorType supports any size (that fits in unsigned) (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 254827. pgousseau added a comment. Renaming test and including x86intrin.h instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

aaron.ballman added a comment. In D70265#1954925 , @vingeldal wrote: > After looking more closely at the code I think the issue is within > hasLocalStorage() which is called in hasGlobalStorage(). My expectation would > be that anything inside of functio

[PATCH] D77411: [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

martong created this revision. martong added reviewers: Szelethus, baloghadamsoftware, gamesh411, steakhal, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: cl

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

tamas.petz added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1827-1828 + + auto RASignKind = getLangOpts().getSignReturnAddressScope(); + if (RASignKind != LangOptions::SignReturnAddressScopeKind::None) { +FuncAttrs.addAttribute("sign-return-address",

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen updated this revision to Diff 254832. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Updated encode functions to take/return uint64_t instead of unsigned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://reviews.llvm.org/D76617 Files:

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:229 + // Returns the SVETypeFlags for a given value and mask. + unsigned encodeFlag(unsigned V, StringRef MaskName) const { +auto It = FlagTypes.find(MaskName); SjoerdMeijer wr

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

sdesmalen added a comment. In D76679#1957399 , @SjoerdMeijer wrote: > I think the float16 discussion is an interesting one, but doesn't necessarily > need to be done here. I am asking some questions offline, but if we ever come > to a different opinion

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 254834. yroux added a comment. Here is an update of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/includ

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" sam

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStac

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

aaron.ballman added a comment. Thank you for working on this, I think it's going to be a very useful interface! Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName <

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl updated this revision to Diff 254840. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Se

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-default-member-init.cpp:436 + +struct PR45363 { + // Ensure

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. I agree that the Clang AST is a bit surprising, but not so surprising that I could definitely call it a bug. Comment at: clang-to

[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Hover.cpp:376 +llvm::Optional fieldName(const Expr *E) { + const auto *ReturnedMember = llvm::dyn_cast(E->IgnoreCasts(

[clang] b952d79 - [cuda][hip] Fix `RegisterVar` function prototype.

Author: Michael Liao Date: 2020-04-03T12:57:09-04:00 New Revision: b952d799cacdb7efd44c1c9468bb11471cc16874 URL: https://github.com/llvm/llvm-project/commit/b952d799cacdb7efd44c1c9468bb11471cc16874 DIFF: https://github.com/llvm/llvm-project/commit/b952d799cacdb7efd44c1c9468bb11471cc16874.diff

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 254846. DiggerLin marked 7 inline comments as done. DiggerLin added a comment. 1. address comment 2. add two new test cases. 3. split a bit test case into three small test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert created this revision. jdoerfert added reviewers: mikerice, kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim, aaron.ballman. Herald added subscribers: guansong, bollu, hiraditya, yaxunl. Herald added a project: clang. By defa

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" aaron.b

[PATCH] D75364: [clang-format] Handle macros in function params and return value

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:164 + /// Parses CPP qualified function names. + bool parse_function_qname(FormatToken *Tok) const { +while (Tok && Tok->isOneOf(tok::coloncolon, tok::identifier)) { your

[PATCH] D77398: [cuda][hip] Fix `RegisterVar` function prototype.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb952d799cacd: [cuda][hip] Fix `RegisterVar` function prototype. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77398/new/ https://review

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); yaxunl wrote

[clang] ae044c5 - [CMAKE] Plumb include_directories() into tablegen()

Author: Stephen Neuendorffer Date: 2020-04-03T10:38:25-07:00 New Revision: ae044c5b0caa095602b6ef4cca40d57efc26a8f6 URL: https://github.com/llvm/llvm-project/commit/ae044c5b0caa095602b6ef4cca40d57efc26a8f6 DIFF: https://github.com/llvm/llvm-project/commit/ae044c5b0caa095602b6ef4cca40d57efc26a8f

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.cpp:21 + Finder->addMatcher( + decl(hasParent(translationUnitDecl()), unless(linkageSpecDecl())) + .bind("child_of_translation_unit"), ---

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + rjmccall wrote: > sepavloff wrote: > > erichkeane wrote: > > > rjmccall wrote: > > > > erichkeane wrote: > > > > > rjmccall wrote: > > > > > > rjmcc

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin added inline comments. Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:48 +Symbol->setStorageClass(XCOFF::C_WEAKEXT); +Symbol->setExternal(true); +break; jasonliu wrote: > Maybe we should just move `Symbol->setExternal(true);` outside of the swi

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

This revision was automatically updated to reflect the committed changes. Closed by commit rGae044c5b0caa: [CMAKE] Plumb include_directories() into tablegen() (authored by stephenneuendorffer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77156/new/

[clang] f288c21 - Revert "[CMAKE] Plumb include_directories() into tablegen()"

Author: Stephen Neuendorffer Date: 2020-04-03T10:47:36-07:00 New Revision: f288c216875d6cba6465230cbb0677e839775cd9 URL: https://github.com/llvm/llvm-project/commit/f288c216875d6cba6465230cbb0677e839775cd9 DIFF: https://github.com/llvm/llvm-project/commit/f288c216875d6cba6465230cbb0677e839775cd

[PATCH] D77385: [clangd] Add index inspection helper tool

mnauw added a comment. Thanks for having a look at this patch. My use-case/goal would be to have a way to run/do a command that reads some index and dumps it (in e.g. YAML) to (e.g.) stdout. That way it can be inspected/viewed all at once by plain viewer. And not only symbols, refs, but also

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" sam

[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: jfb. Herald added a project: clang. This revision simplifies the representation of edits in rewrite rules. The simplified form is more general, allowing the user more flexibility in building custom edit

[PATCH] D77411: [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77411/new/ https://reviews.llvm.org/D77411 _

[PATCH] D75364: [clang-format] Handle macros in function params and return value

mitchell-stellar added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7359 verifyIndependentOfContext("bool a = f() && final.f();"); + verifyFormat("int f(M(x) *p1 = nullptr, M(x) *p2, volatile M(x) *p3);"); + verifyFormat("M(x) *foo();"); ---

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + sepavloff wrote: > rjmccall wrote: > > sepavloff wrote: > > > erichkeane wrote: > > > > rjmccall wrote: > > > > > erichkeane wrote: > > > > > > rjmcc

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

stephan.dollberg created this revision. stephan.dollberg added a reviewer: chandlerc. Herald added a project: clang. devtoolset-9 has been out for a while so also look for it. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77420 Files: clang/lib/Driver/ToolChains/Gnu.cpp I

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254861. fhahn added a comment. Specify that standard conversion rules do not apply to assignments for matrix types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files

[clang] 0c0831f - [CMAKE] Plumb include_directories() into tablegen()

Author: Stephen Neuendorffer Date: 2020-04-03T11:23:38-07:00 New Revision: 0c0831f74b7181268a777a39ee087c9337ffa0c5 URL: https://github.com/llvm/llvm-project/commit/0c0831f74b7181268a777a39ee087c9337ffa0c5 DIFF: https://github.com/llvm/llvm-project/commit/0c0831f74b7181268a777a39ee087c9337ffa0c

[clang-tools-extra] 2c7ea1c - [clang-tidy] Address false positive in modernize-use-default-member-init

Author: Nathan James Date: 2020-04-03T19:43:46+01:00 New Revision: 2c7ea1c4c5f7dde562bac684a59ad67f1f062726 URL: https://github.com/llvm/llvm-project/commit/2c7ea1c4c5f7dde562bac684a59ad67f1f062726 DIFF: https://github.com/llvm/llvm-project/commit/2c7ea1c4c5f7dde562bac684a59ad67f1f062726.diff

[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:376 +llvm::Optional fieldName(const Expr *E) { + const auto *ReturnedMember = llvm::dyn_cast(E->IgnoreCasts()); + const auto *Field = kad

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

stephenneuendorffer edited the summary of this revision. stephenneuendorffer updated this revision to Diff 254867. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77156/new/ https://reviews.llvm.org/D77156 Files: clang/cmake/modules/AddClang.cmake

[PATCH] D73245: Avoid using std::max_align_t in pre-C++11 mode

ldionne accepted this revision. ldionne added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D77385: [clangd] Add index inspection helper tool

sammccall added a comment. Yeah, I think adding a dump/export command to dexp would be nice. We'd have to make dexp keep the parsed input file around, or just the path and reopen it when the command is issued, but that seems OK to me. (One of the costs of adding a new binary is you have to at le

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. In D66490#1958747 , @aeubanks wrote: > In D66490#1638708 , @hfinkel wrote: > > > In D66490#1638162 , @rupprecht > > wrote: > > > > > We already

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77054/new/ https://reviews.llvm.org/D77054 ___ cfe-commits mailing list cfe-commi

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

njames93 updated this revision to Diff 254870. njames93 added a comment. - Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77199/new/ https://reviews.llvm.org/D77199 Files: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberIni

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. I'm fine with this. I would hope a C/C++/Clang person will also take a look though. Comment at: llvm/docs/LangRef.rst:1398 +This attribute is similar to ``alwaysinline``, but also applies recursively to +all inlined function calls. ``builti

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7ea1c4c5f7: [clang-tidy] Address false positive in modernize-use-default-member-init (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

leonardchan added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ nemanjai wrote: > ne

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

lebedev.ri added a comment. In D70366#1960300 , @jdoerfert wrote: > I'm fine with this. I would hope a C/C++/Clang person will also take a look > though. This is missing clang codegen test[s]. Seems to look fine to me otherwise. CHANGES SINCE LAST ACT

[clang] ba87430 - [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

Author: Andrew Wock Date: 2020-04-03T14:59:33-04:00 New Revision: ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf URL: https://github.com/llvm/llvm-project/commit/ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf DIFF: https://github.com/llvm/llvm-project/commit/ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf.diff L

[clang] d7a0516 - Fix typo in test.

Author: Kevin P. Neal Date: 2020-04-03T15:23:49-04:00 New Revision: d7a0516ddcfe373bb780d6fc19d76fe74ecc0061 URL: https://github.com/llvm/llvm-project/commit/d7a0516ddcfe373bb780d6fc19d76fe74ecc0061 DIFF: https://github.com/llvm/llvm-project/commit/d7a0516ddcfe373bb780d6fc19d76fe74ecc0061.diff

  1   2   3   >