[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Swift would like to use clang's abis to emit protocol declarations. It needs to a hook to register when inherited protocols are emitted. This commits adds the public API: emitProtocolDecl

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

ldionne added a comment. In D68165#1950357 , @Szelethus wrote: > Ugh, I squashed my local commits and pushed, it seems like for some reason it > made you the author... it has happened to me before (always with you, for > some reason), but was able to not

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Fri, Mar 27, 2020 at 5:16 PM Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 ! > > David: You are correct, the bug in function_ref appeared only when > constructing from `const function_ref&&`. When I

[clang] 24485ae - [clang analysis] Make mutex guard detection more reliable.

Author: Eli Friedman Date: 2020-03-30T11:46:02-07:00 New Revision: 24485aec4750255574a9a8211b3aef1ce00e83b6 URL: https://github.com/llvm/llvm-project/commit/24485aec4750255574a9a8211b3aef1ce00e83b6 DIFF: https://github.com/llvm/llvm-project/commit/24485aec4750255574a9a8211b3aef1ce00e83b6.diff

[PATCH] D77056: RFC: [Sema][SVE] Allow non-member operators for SVE types

rsandifo-arm added a comment. In D77056#1950358 , @efriedma wrote: > I'm concerned we're going to run into trouble if two people define different > SVE "libraries", and you try to link both of them into the same program. If > you're not careful, you end

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Szelethus added a comment. In D68165#1950451 , @ldionne wrote: > Always with me? Maybe you should double-check that you don't have something > weird in your git config, aliases or other? I don't know *why* it would be me > in particular, but the fact tha

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked 3 inline comments as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1159 + + auto MayContainThrowingOrExitingCall = [&](Instruction *RVal, + Instruction *RInst) {

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#1945084 , @srhines wrote: > In D76452#1945029 , @MaskRay wrote: > > > To cross build ELF object on macOS, another alternative is a wrapper named > > `ld` which invokes `lld -fla

[PATCH] D76943: [clang analysis] Make mutex guard detection more reliable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24485aec4750: [clang analysis] Make mutex guard detection more reliable. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D76943?vs=253253&id=253657#toc Repository: rG LLVM G

[clang] defd95e - [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

Author: Vince Bridgers Date: 2020-03-30T14:13:08-05:00 New Revision: defd95ef45171252ee8491729d3f3c863bbfe530 URL: https://github.com/llvm/llvm-project/commit/defd95ef45171252ee8491729d3f3c863bbfe530 DIFF: https://github.com/llvm/llvm-project/commit/defd95ef45171252ee8491729d3f3c863bbfe530.diff

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen I would call this `emitObjCProtocolObject` or something

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. DONOTSUBMIT: Uploading for feedback on approach, still have test failures: Failing Tests (1): Clang :: CXX/class.access/p4.cpp In the MS C++ ABI, complete destructors for classes with

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:220 /// Source range/offset of a preprocessed entity. struct DeclOffset { + /// Raw source location. The unsigned i.e.

[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

tra added a reviewer: echristo. tra accepted this revision. tra added a subscriber: echristo. tra added a comment. This revision is now accepted and ready to land. + @echristo who OK'ed the idea conditional on the actual patch. :-) LGTM overall. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77070: [SemaObjC] Add a warning for declarations of BOOL:1 when BOOL is a signed char

rjmccall added a comment. This feels like it's going to bite a lot of people, but maybe it's the best option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77070/new/ https://reviews.llvm.org/D77070 ___ cfe-commits mailing list cfe-commits

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

efriedma added a comment. I can understand why you might want the new intrinsics as a temporary measure, but I don't see the point of removing the already working support for llvm.sadd. etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77054/new/

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. This is needed for OpenMP as well. Does it make sense to include it in this patch or in another one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___

[PATCH] D77056: RFC: [Sema][SVE] Allow non-member operators for SVE types

efriedma added a comment. > One option would to be wait until there's at least one type that > isSizelessBuiltinType but isn't an SVE type. Another would be to introduce it > when a feature seems too SVE-specific Probably not a big deal either way, as long as we document the intent in the code

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

This revision was automatically updated to reflect the committed changes. Closed by commit rGdefd95ef4517: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHA

[clang] ced99a1 - Fix comment for CLANG_SYSTEMZ_DEFAULT_ARCH

Author: Jonas Hahnfeld Date: 2020-03-30T21:36:18+02:00 New Revision: ced99a1a6368b117384935957e2329ec4ba7784b URL: https://github.com/llvm/llvm-project/commit/ced99a1a6368b117384935957e2329ec4ba7784b DIFF: https://github.com/llvm/llvm-project/commit/ced99a1a6368b117384935957e2329ec4ba7784b.diff

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:613 + + // Add padding bits in case of over-sized bit-field. + // "The first sizeof(T)*8 bits are used to hold the value of the bit-field, The existing code in ConstantAggregat

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

rnk added a comment. In D75903#1914715 , @ostannard wrote: > This means that `stk1` should be passed as a copy with alignment 16 bytes, > putting it at `sp+16`. GCC does this, clang without this patch passes it at > `sp+8`, and clang with this patch pass

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 added a comment. njames93 added a project: clang-tools-extra. This pretty much nulls out (clang-tidy) Warn on inva

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

yaxunl added a comment. In D76937#1950077 , @rjmccall wrote: > Can you explain what exactly the emission/semantic model is for variables? > Normal code-generation absolutely triggers the emission of many variables > lazily (e.g. internal-linkage globals

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. This pretty much nulls out (clang-tidy) Warn on invalid "case" configurations for readability-identifier-naming I have moved that into a follow up patch that can be submitted now if you'd like. Repository: rG LLVM Github Monorepo

[clang] a4f74f3 - [OPENMP50]Do not imply lvalue as base expression in array shaping

Author: Alexey Bataev Date: 2020-03-30T17:07:08-04:00 New Revision: a4f74f377b7c42d38a230a19996e3a7fa5a328c7 URL: https://github.com/llvm/llvm-project/commit/a4f74f377b7c42d38a230a19996e3a7fa5a328c7 DIFF: https://github.com/llvm/llvm-project/commit/a4f74f377b7c42d38a230a19996e3a7fa5a328c7.diff

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer added a comment. > Can you explain the need for the callback? Are you expecting to use this for > Swift-declared protocols by synthesizing an ObjC protocol declaration for > them? I can see why you'd need a callback in that case. The objective C protocol references other protocols

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

xnox added a comment. Sorry for being too slow =) I like all the fixes done to move the define into a more natural config.h location, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75914/new/ https://reviews.llvm.org/D75914 __

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253703. tlively marked 3 inline comments as done. tlively added a comment. - Prefix identifiers with `__` - Use specific bit-widths where possible - Do not change semantics under -funsigned-char Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 253704. anna added a comment. addressed review comments. Added two test cases: deref value being different, inlined callee body better optimized compared to callee. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked 3 inline comments as done. anna added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1175 + continue; +// Sanity check that the cloned return instruction exists and is a return +// instruction itself. anna wrote

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen rj

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 253712. aschwaighofer added a comment. - Change API name to emitObjCProtocolObject. - Make stuff compile on current ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253713. tlively added a comment. - Use header guard macro instead of pragma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/ https://reviews.llvm.org/D76959 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253715. rnk added a comment. - add def data bit - add tests - fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files: clang/include/clang/AST/CXXRecordDeclDefinit

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. PTAL, here's how I imagine this is supposed to look, but the definition data bit name could probably be improved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass if the target has divergent branches

arsenm added a comment. Commit message should say only if? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

NoQ added inline comments. Comment at: clang/test/Analysis/iterator-modelling.cpp:434 + //expected-note@-1 0-1{{Calling 'next}} + //expected-note@-2 0-1{{Passing the value 1 via 2nd parameter 'n'}} + //expected-note@Inputs/system-header-simulator-cxx.h:814 0-1{{Iterator 'it'

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:959-963 + /// Indicates if the complete destructor has been implicitly declared + /// yet. Only relevant in the Microsoft C++. + bool definedImplicitCompleteDestructor() const { +return data().Defi

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan added a comment. In D76389#1951135 , @arsenm wrote: > Commit message should say only if? Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 ___

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively added a comment. I believe all the feedback has now been addressed. Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16), __aligned__(16))); +typedef unsigned long long __u64x2 +__attribute__((__vector_size__

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added a comment. In D73307#1942838 , @tmsriram wrote: > In D73307#1942805 , @MaskRay wrote: > > > In D73307#1932131 , @rnk wrote: > > > > > At a higher level, should

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

aemerson added a comment. Sorry, forgot to add cfe-commits to the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77103/new/ https://reviews.llvm.org/D77103 ___ cfe-commits mailing list cf

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

aemerson created this revision. aemerson added reviewers: paquette, arsenm, qcolombet, bogner. aemerson added a project: LLVM. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls, wdng. Herald added a project: clang. aemerson added a comment. Sorry, forgot to add cfe-commits to the or

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1165 const auto *ND = cast(GD.getDecl()); + std::string MangledName = getMangledNameImpl(*this, GD, ND); Delete this unrelated cosmetic change. CHANGES SINCE LAST ACTION http

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk marked 2 inline comments as done. rnk added a comment. Thanks for the feedback, I'm going to investigate if we can use the `used` destructor bit to do this. Comment at: clang/include/clang/AST/DeclCXX.h:959-963 + /// Indicates if the complete destructor has been implicitl

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. Cool, LGTM, with optional suggestion for signed char below: Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16),

[clang] 5074776 - [WebAssembly] Import wasm_simd128.h from Emscripten

Author: Thomas Lively Date: 2020-03-30T17:04:18-07:00 New Revision: 5074776de478a114ece3f82668aa1363b2f17c92 URL: https://github.com/llvm/llvm-project/commit/5074776de478a114ece3f82668aa1363b2f17c92 DIFF: https://github.com/llvm/llvm-project/commit/5074776de478a114ece3f82668aa1363b2f17c92.diff

[clang] 3308732 - Fix crash if base specifier parsing hits an invalid type annotation.

Author: Richard Smith Date: 2020-03-30T17:21:40-07:00 New Revision: 330873230071ffc2aebc0fe74db55e7a530c2f1b URL: https://github.com/llvm/llvm-project/commit/330873230071ffc2aebc0fe74db55e7a530c2f1b DIFF: https://github.com/llvm/llvm-project/commit/330873230071ffc2aebc0fe74db55e7a530c2f1b.diff

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively marked an inline comment as done. tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16), __aligned__(16))); +typedef unsigned long long __u64x2 +__attribute__((__vector_size__(16),

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. @MyDeveloperDay Can you please share your thoughts on my comment above? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rG5074776de478: [WebAssembly] Import wasm_simd128.h from Emscripten (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/ https://re

[clang] 764f54b - Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

Author: Yaxun (Sam) Liu Date: 2020-03-30T20:29:50-04:00 New Revision: 764f54bb857b0fbc6742f306b09f640e0043791d URL: https://github.com/llvm/llvm-project/commit/764f54bb857b0fbc6742f306b09f640e0043791d DIFF: https://github.com/llvm/llvm-project/commit/764f54bb857b0fbc6742f306b09f640e0043791d.dif

[PATCH] D73307: Unique Names for Functions with Internal Linkage

wmi added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:5 +// RUN: %clang_cc1 -triple x86_64 -x c++ -S -emit-llvm -funique-internal-linkage-names -o - < %s | FileCheck %s --check-prefix=UNIQUE + +static int glob; MaskRay wrote

[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

yaxunl added a comment. In D76987#1950366 , @gregrodgers wrote: > This was discussed on llvm-dev three years ago. Here is the thread. > > http://lists.llvm.org/pipermail/llvm-dev/2017-February/109930.html > > The last name discussed was "-- offload-arch".

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. Can this be revived? Changing the enum to a string still sounds good to me Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 ___ cfe-commits mai

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 253751. njames93 added a comment. - Fix assertions failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp c

[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

This revision was automatically updated to reflect the committed changes. Closed by commit rG764f54bb857b: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

Re: [clang] 499b2a8 - PR45294: Fix handling of assumed template names looked up in the lexical

I have not found which of the few commits on Friday having to do with template-ids is responsible, but this now produces a crash (trace is below): struct A; struct B : A {}; Richard, would you take a look? Thanks, Hubert Tong :2:12: error: unknown template name 'A' struct B : A {};

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:5 +// RUN: %clang_cc1 -triple x86_64 -x c++ -S -emit-llvm -funique-internal-linkage-names -o - < %s | FileCheck %s --check-prefix=UNIQUE +

Re: [clang] 499b2a8 - PR45294: Fix handling of assumed template names looked up in the lexical

Already fixed in llvmorg-11-init-7209-g33087323007 :) On Mon, 30 Mar 2020 at 18:30, Hubert Tong via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I have not found which of the few commits on Friday having to do with > template-ids is responsible, but this now produces a crash (trace is below

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16008-16013 +// In the MS ABI, the complete destructor is implicitly defined, +// even if the base destructor is user defined. +CXXRe

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

jdoerfert created this revision. jdoerfert added reviewers: lebedev.ri, JonChesterfield, ABataev. Herald added subscribers: jfb, guansong, bollu, hiraditya. Herald added a project: clang. jdoerfert added a reviewer: fghanim. Move the listing of allowed clauses per OpenMP directive to the new macro

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:17 +call void @llvm.va_start(i8* nonnull %0) +call void @llvm.va_copy(i8* nonnull %0, i8* nonnull %0) +%argp.cur = load i8*, i8** %arg,

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Charusso added a comment. In D73521#1923693 , @NoQ wrote: > Or is each test run updating the repo? Can we simply make the script do `cat > DummyChecker.cpp | sed s/DummyChecker/$NAME/g > $NAME.cpp` and store the > checker only once? It was updating, ye

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 253774. ZarkoCA added a comment. Rebased to include byval changes. Fixed name of array. Fixed up test case as per comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 253776. ZarkoCA added a comment. Fixed test cases to use builtins again, set no soft float abi for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/l

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( jasonliu

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Charusso updated this revision to Diff 253777. Charusso marked 3 inline comments as done. Charusso added a comment. Herald added a subscriber: ASDenysPetrov. - Remove the test of creating a live checker, instead copy over the live checker when the script runs. - Simplify the script by adding the

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen aschwaighofer wrote: > rjmccall wrote: > > I would call

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

rjmccall added a comment. In D76937#1950764 , @yaxunl wrote: > In D76937#1950077 , @rjmccall wrote: > > > Can you explain what exactly the emission/semantic model is for variables? > > Normal code-generation absol

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added a comment. I made a suggestion in the other patch about restructuring things out of `visitUsedDecl`. I'll review this when that's done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 __

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned DiagID); + Fznamznon wrote: >

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

sbc100 created this revision. Herald added subscribers: cfe-commits, jfb, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added reviewers: alexcrichton, sunfish. Fixes: https://bugs.llvm.org/show_bug.cgi?id=45362 Repository: rG LLVM Github Monorep

[PATCH] D77116: temp tests

oontvoo created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77116 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocessor.h clang/include/clang/Serialization

[PATCH] D76182: [AVR] Support aliases in non-zero address space

dylanmckay added a comment. I think we should add a test, it shouldn't be too hard I think. Look in `clang/tests`, grep for `alias`. Look like it is `extern const int __mod_usb_device_table __attribute__ ((alias("wacom_usb_ids")));`. If you copy paste a new test (use `clang/test/CodeGen/alias.c

[PATCH] D76182: [AVR] Support aliases in non-zero address space

dylanmckay added a comment. Nice patch by the way, the code looks fine, if we can get a basic test in here then it's good to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D76182 ___

<    1   2