[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. @ebevhan Thanks again for the testcase. I've added a reduced version in 47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6 to ensure this is fixed on re-land. This particular case can be fixed by marking the

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:143 + if (llvm::sys::path::is_relative(SysRoot)) { +// Prepend InstalledDir if SysRoot is relative Does this return `true` or `false` when sysroot is empty? Comment at

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall updated this revision to Diff 252906. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663 Files: clang

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 marked 3 inline comments as done. sbc100 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:143 + if (llvm::sys::path::is_relative(SysRoot)) { +// Prepend InstalledDir if SysRoot is relative phosek wrote: > Does this return `true` or `fa

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:452 + const HighlightingToken *Last = nullptr; + for (const HighlightingToken &Tok : Tokens) { +Result.emplace_back(); hokein wrote: > note that we don't calculat

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 updated this revision to Diff 252909. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 Files: clang/CMakeLists.txt clang/lib/Driver/Driver.cpp Index: clang/lib/D

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall updated this revision to Diff 252917. sammccall marked 13 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 Files: clang

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall added a comment. Thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4905 + // A requires(){...} lets us infer members from each requirement. + for (const concepts::Requirement *Req : RE->getRequirements()) { +if (!Req->isDependent()) ---

[clang] 6a9ad5f - [cuda][hip] Add CUDA builtin surface/texture reference support.

Author: Michael Liao Date: 2020-03-26T14:44:52-04:00 New Revision: 6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6 URL: https://github.com/llvm/llvm-project/commit/6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6 DIFF: https://github.com/llvm/llvm-project/commit/6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6.diff

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76856/new/ https://reviews.llvm.org/D76856

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74324: Tools emit the bug report URL on crash

leonardchan added a comment. Hi. This patch seems to cause the undefined symbol error we're seeing when linking clang: FAILED: bin/clang-11 : && /b/s/w/ir/k/cipd/bin/clang++ --sysroot=/b/s/w/ir/k/cipd/linux-amd64 -I/b/s/w/ir/k/recipe_cleanup/clangzmv99P/zlib_install/include -fPIC -fvisib

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 ___

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1944272 , @tra wrote: > LGTM. Next step is to figure out what various > __nv_tex_surf_handler(...) maps to for various strings (there are > ~110 of them in CUDA-10.2) and implement its replacement. I think we should > be

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9ad5f3f4ac: [cuda][hip] Add CUDA builtin surface/texture reference support. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D76365?vs=252828&id=252929#toc Repository: rG LLVM

[clang] 8099e0f - [OPENMP50]Add basic support for inscan reduction modifier.

Author: Alexey Bataev Date: 2020-03-26T14:51:09-04:00 New Revision: 8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5 URL: https://github.com/llvm/llvm-project/commit/8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5 DIFF: https://github.com/llvm/llvm-project/commit/8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5.diff

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. > In D76696#1944014 , > @hubert.reinterpretcast wrote: > >> We have also encountered crashes in downstream testing caused by this using >> just the vanilla source from trunk. When there is a proposed fix, please le

[PATCH] D76452: Use LLD by default for Android.

danalbert reclaimed this revision. danalbert added a comment. This revision is now accepted and ready to land. It seems I'd goofed something in my testing earlier (I think I still had `-fuse-ld=lld` force on in my build system). While Clang will find `ld` in the driver directory and prefer it, L

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a default value for `-fuse-ld=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452 __

[clang] f9e71f4 - Revert "[OPENMP50]Add basic support for inscan reduction modifier."

Author: Alexey Bataev Date: 2020-03-26T15:57:19-04:00 New Revision: f9e71f4d9d39871390da48207d7fd6b116e370dc URL: https://github.com/llvm/llvm-project/commit/f9e71f4d9d39871390da48207d7fd6b116e370dc DIFF: https://github.com/llvm/llvm-project/commit/f9e71f4d9d39871390da48207d7fd6b116e370dc.diff

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym updated this revision to Diff 252950. sidneym added a comment. update for new tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 Files: clang/include/clang/Basic/TargetInfo.h clang/lib

[PATCH] D76452: Use LLD by default for Android.

srhines added a comment. In D76452#1944733 , @MaskRay wrote: > Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a default > value for `-fuse-ld=`. How does that work for Darwin builds? Is lld fully supported for MachO at this point, o

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. In D76696#1944625 , @hubert.reinterpretcast wrote: > All of them appear to have unresolved names in constexpr evaluation. It is > likely to be the same issue. The general scheme is probably common: unresolved expr -> ??? -> a

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D76696#1944784 , @sammccall wrote: > The general scheme is probably common: unresolved expr -> ??? -> an > expression is dependent but not marked as such -> constant evaluation crashes. > > But the ??? matters, a

[clang] 0731372 - [clang] Allow -DDEFAULT_SYSROOT to be a relative path

Author: Sam Clegg Date: 2020-03-26T13:48:57-07:00 New Revision: 0731372ee25c8db93e0d976db4be4ffb7c7329c5 URL: https://github.com/llvm/llvm-project/commit/0731372ee25c8db93e0d976db4be4ffb7c7329c5 DIFF: https://github.com/llvm/llvm-project/commit/0731372ee25c8db93e0d976db4be4ffb7c7329c5.diff LOG

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Hey Richard - could you help try to diagnose what's happening here? I reverted this patch in: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb But that did actually cause buildbot failures, such as these ones: http://lab.llvm.org:8011/builders/clang-ppc64be-linu

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. arsenm added parent revisions: D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs, D76862: HIP: Ensure new denormal mode attributes are set. This

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. @MyDeveloperDay Is someone working on fixing the breaking tests and merging it? I need this feature so if someone isn't working on it already, I can take it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. In D76696#1944825 , @hubert.reinterpretcast wrote: > In D76696#1944784 , @sammccall wrote: > > > The general scheme is probably common: unresolved expr -> ??? -> an > > expression is dep

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM. thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4984 +if (Q && isApprox(Q->getAsType(), T)) + addType(NNS->getAsIdentifier()); + } ---

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

This revision was automatically updated to reflect the committed changes. sbc100 marked an inline comment as done. Closed by commit rG0731372ee25c: [clang] Allow -DDEFAULT_SYSROOT to be a relative path (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 2a43a16 - [OPENMP50]Fix the checks for the nesting of scan directives.

Author: Alexey Bataev Date: 2020-03-26T17:30:02-04:00 New Revision: 2a43a1610db335afcccd1a179a33a0886a5a2c4d URL: https://github.com/llvm/llvm-project/commit/2a43a1610db335afcccd1a179a33a0886a5a2c4d DIFF: https://github.com/llvm/llvm-project/commit/2a43a1610db335afcccd1a179a33a0886a5a2c4d.diff

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252978. arsenm retitled this revision from "WIP: AMDGPU: Teach toolchain to link rocm device libs" to "AMDGPU: Teach toolchain to link rocm device libs". arsenm edited the summary of this revision. Herald added a subscriber: Anastasia. CHANGES SINCE LAST ACTIO

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. In D76452#1944786 , @srhines wrote: > In D76452#1944733 , @MaskRay wrote: > > > Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a > > default value for `-fuse-ld=`. > > >

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

I'm not sure, but I do see that the call stack contains a call to bool llvm::function_ref::callback_fn const>(long, clang::Expr*&, bool) Notice that this is function_ref::callback_fn instantiated with T=function_ref itself; i.e., we do have a function_ref to a function_ref. This is the thing I wa

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sunfish added a comment. Instead of creating a new LLVM-IR-level attribute here, could you have clang translate the attribute to "wasm-export-name", to keep the LLVM-IR level simpler? Also, I myself would be more comfortable with this change if it were restricted to Emscripten for now. `export

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added a comment. @bbassi, I don't have plans to address this, and am supportive of you finishing it up. The plan was to move this as one of the options in the `BracketAlignmentStyle` configuration (value of `AlwaysBreakWithDanglingParenthesis`) rather than have it be a brand new conf

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4984 +if (Q && isApprox(Q->getAsType(), T)) + addType(NNS->getAsIdentifier()); + } kadircet wrote: > sammccall wrote

[PATCH] D76452: Use LLD by default for Android.

srhines added a comment. In D76452#1945029 , @MaskRay wrote: > In D76452#1944786 , @srhines wrote: > > > In D76452#1944733 , @MaskRay wrote: > > > > > Another approach will b

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 added a comment. What about your idea of using the `default` keyword rather than adding a new clang attr? I quite liked that approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76547/new/ https://reviews.llvm.org/D76547

[clang] b0da094 - [Hexagon] Add support for Linux/Musl ABI (part 2)

Author: Sid Manning Date: 2020-03-26T17:19:46-05:00 New Revision: b0da094983948c8a82f1a26eaa0702920c2b2b36 URL: https://github.com/llvm/llvm-project/commit/b0da094983948c8a82f1a26eaa0702920c2b2b36 DIFF: https://github.com/llvm/llvm-project/commit/b0da094983948c8a82f1a26eaa0702920c2b2b36.diff L

[clang] 5db37f3 - Make PS4 use -fno-use-init-array only as the ABI does not support .init_array.

Author: Douglas Yung Date: 2020-03-26T15:45:40-07:00 New Revision: 5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2 URL: https://github.com/llvm/llvm-project/commit/5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2 DIFF: https://github.com/llvm/llvm-project/commit/5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2.diff

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#1944919 , @bbassi wrote: > @MyDeveloperDay Is someone working on fixing the breaking tests and merging > it? I need this feature so if someone isn't working on it already, I can take > it. as @stringham isn't w

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 added a comment. I was thinking of dropping the new clang attr in favor of the `default` keyword in the current attr, but actually keeping the llvm attr, since it corresponds quite nicely to the existing EXPORTED symbol attribute in the binary format and avoid duplication in the `.ll`, `

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 252995. fhahn added a comment. Update according to comments on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/LanguageExtensions.rst clang

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0da09498394: [Hexagon] Add support for Linux/Musl ABI (part 2) (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75638?vs=252950&id=253000#toc Repository: rG LLVM Github Mono

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 253004. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files: clang-tools-ext

[PATCH] D74324: Tools emit the bug report URL on crash

probinson added a comment. Hi @leonardchan Owen is on UK time so I took a look. I think Owen inadvertently put the new API in a place that is guarded by `#if ENABLE_BACKTRACES` and I'm guessing that your build has that turned off. I've posted D76893 because so

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 253005. nridge added a comment. Finish an incomplete variable extraction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files: clang-tools-extra/clang-tidy/ClangTidyD

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge requested review of this revision. nridge added a comment. Thanks for the suggested simplification. As the change is not completely trivial, could you have one more look before landing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer wrote: > I'm not sure, but I do see that the call stack contains a call to > > bool llvm::function_ref bool)>::callback_fn > const>(long, clang::Expr*&, bool) > > Notice that this is function_ref::callback_fn instantiated with > T=function_ref itsel

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75779/new/ https://reviews.llvm.org/D75779 _

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/297 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76896 Files: clang-too

[clang] 64fe841 - Fix typo, targetFeature should be lowercase.

Author: Zakk Chen Date: 2020-03-26T19:40:04-07:00 New Revision: 64fe84185602b59c2e07c142b9772c6e855153cb URL: https://github.com/llvm/llvm-project/commit/64fe84185602b59c2e07c142b9772c6e855153cb DIFF: https://github.com/llvm/llvm-project/commit/64fe84185602b59c2e07c142b9772c6e855153cb.diff LOG

[PATCH] D76757: Fix typo, targetFeature should be lowercase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64fe84185602: Fix typo, targetFeature should be lowercase. (authored by khchen, committed by Zakk Chen ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 819e540 - Use llvm_unreachable after a fully covered/always-returning switch

Author: David Blaikie Date: 2020-03-26T20:09:57-07:00 New Revision: 819e540208d5d62e7841d0dbdef3580eecc2c2b6 URL: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6 DIFF: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6.diff

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the swi

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Thanks for catching that. On Thu, Mar 26, 2020 at 11:14 PM David Blaikie wrote: > > Usually this sort of thing is addressed with llvm_unreachable, rather than a > return statement that's not expected to be reached by any valid execution of > LLVM (it'd require a carefully hand-crafted CPU kind

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer > wrote: > >> I'm not sure, but I do see that the call stack contains a call to >> >> bool llvm::function_ref> bool)>::callback_fn >> const>(long, cla

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 11:49 PM Richard Smith wrote: > On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer >> wrote: >> >>> I'm not sure, but I do see that the call stack contains a call to >>> >>

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

chatwyn added a comment. Hi: we're in the process of testing with Clang 10 and noticed a behavior change caused by this commit. Consider the following piece of code: @protocol P @end @protocol Q @end @interface I @end void a() { void (^genericBlockWithParam)(id );

<    1   2