[clang] 86bba6c - [Sema] Use the canonical type in function isVector

Author: Akira Hatanaka Date: 2020-03-13T13:08:48-07:00 New Revision: 86bba6c6410c31e669b10f182c6d1a03f704555a URL: https://github.com/llvm/llvm-project/commit/86bba6c6410c31e669b10f182c6d1a03f704555a DIFF: https://github.com/llvm/llvm-project/commit/86bba6c6410c31e669b10f182c6d1a03f704555a.diff

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. In D69585#1922108 , @dblaikie wrote: > Does this still have an OpenMP special case? The production code changes > don't seem to mention OpenMP anymore, but there's still a lot of test updates > for OpenMP - what are they for? It

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

thakis added a comment. Do you think this could cause errors like in https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885934379148608192/+/steps/compile/0/stdout?format=raw ? (see also https://bugs.chromium.org/p/chromium/issues/detail?id=1061535) Repository: r

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

rsmith added a comment. In D76096#1921842 , @nickdesaulniers wrote: > > The performance implications of deleting those lines is the complicated > > part. > > Where does compile time performance suffer from this? I guess if we have > massive array initia

[PATCH] D76100: Debug Info: Store the SDK in the DICompileUnit.

aprantl closed this revision. aprantl added a comment. 842ea709e4ed881c2bc59155af5df910eccda9c6 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76100/new/ https://reviews.llvm.org/D76100

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

aganea added a comment. @thakis: Wasn't that issue fixed by rG18eae3312297cb197a3131f3ad9ca2bebb217415 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76099/new/ https://reviews

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. > Removing those two LangOpt checks isn't enough for the test cases to run. Removing those two checks should unblock const-eval for structs in general. I wasn't thinking about whether there something else for global variables specifically, though. It looks like there

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] 42b7827 - [clangd] Add json::Object->Value conversion workaround for older compilers

Author: Jan Korous Date: 2020-03-13T14:01:33-07:00 New Revision: 42b782747ed78d1fc68a2b47d1057713189c URL: https://github.com/llvm/llvm-project/commit/42b782747ed78d1fc68a2b47d1057713189c DIFF: https://github.com/llvm/llvm-project/commit/42b782747ed78d1fc68a2b47d1057713189c.diff LO

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

aganea added a comment. Looks like the latest build passed: https://ci.chromium.org/p/chromium/builders/ci/ToTLinux%20%28dbg%29/11585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76099/new/ https://reviews.llvm.org/D76099 _

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:86 + OS << "#ifndef __cplusplus\n"; + OS << "#include \n"; + OS << "#endif\n\n"; sdesmalen wrote

[PATCH] D73638: [AST] Move dependence computations into a separate file

sammccall added a comment. So this patch makes me pretty nervous - it moves a lot of logic, it necessarily changes the way it's structured, the domain is subtle. I wouldn't be terribly surprised if we were missing some tests here. So this all points to resisting the urge to improve things in thi

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers updated this revision to Diff 250319. nickdesaulniers added a comment. - add support for compile time arrays Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/new/ https://reviews.llvm.org/D76096 Files: clang/lib/AST/Expr.cpp

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers added a comment. In D76096#1922239 , @rsmith wrote: > it's substantially more efficient for CodeGen to walk the AST representation > (the `InitListExpr`) and directly generate an IR constant than it is to > create an `APValue` representat

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. > Isn't that what my patch is doing? (Codegen walking the AST/InitListExpr, > generating Constants)? Yes. The issue is we we don't really want to duplicate the logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/ne

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. Yep, it is still an open issue. I am actually unsure of how to do that, and I'd love some pointers. As far as default(private) goes, I am also unsure of how to do it without retaining the prior values of the variables. I will take a look over this weekend and see if

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

jdoerfert added a comment. My questions are answered, as you have the clang people in the reviewer list and I was only added by my OpenMP hook, I would them to OK this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://revie

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

rnk added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:6682 + /// The outermost level of selector sets. + llvm::SmallVector Sets; + This is not a good data structure choice. You have three levels of small vector nesting, so sizeof OMPTra

[PATCH] D76169: [WIP][AST] Allow ExprConstant to evaluate structs in C.

efriedma created this revision. efriedma added a reviewer: nickdesaulniers. Herald added a project: clang. Just a proof of concept to show this works. Handles all the examples from D76096 , as far as I can tell. Repository: rG LLVM Github Monorepo https://re

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:6682 + /// The outermost level of selector sets. + llvm::SmallVector Sets; + rnk wrote: > This is not a good data structure choice. Y

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

fghanim added a comment. @jdoerfert To answer your question as to why it is being codegened as shared, codegen doesn't handle `default` clause- at least I didn't come across such a thing- and if you think about it, it shouldn't need to. You either have `none` or `shared`: - `none` is largly to

[clang] 44c3a63 - PR45063: Fix crash on invalid processing an elaborated class template-id

Author: Richard Smith Date: 2020-03-13T18:53:49-07:00 New Revision: 44c3a63c74dddeef17e424ec76bd90c8582d8a3c URL: https://github.com/llvm/llvm-project/commit/44c3a63c74dddeef17e424ec76bd90c8582d8a3c DIFF: https://github.com/llvm/llvm-project/commit/44c3a63c74dddeef17e424ec76bd90c8582d8a3c.diff

[clang] 810794c - PR44992 Don't crash when a defaulted <=> is in a class declared in a

Author: Richard Smith Date: 2020-03-13T19:30:49-07:00 New Revision: 810794ce882850a11baca35aa4ef107ee8ee7f53 URL: https://github.com/llvm/llvm-project/commit/810794ce882850a11baca35aa4ef107ee8ee7f53 DIFF: https://github.com/llvm/llvm-project/commit/810794ce882850a11baca35aa4ef107ee8ee7f53.diff

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya added a comment. One last kind ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D76173: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

jdoerfert created this revision. jdoerfert added a reviewer: rnk. Herald added subscribers: guansong, bollu. Herald added a project: clang. See rational here: https://reviews.llvm.org/D71830#1922656 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76173 Files: clang/include/cl

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

jdoerfert added a comment. In D75001#1891284 , @Hahnfeld wrote: > In D75001#1887876 , @jdoerfert wrote: > > > I like this way better. I was hoping we could do it in our cmake only :) > > > > Give others a day or so

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. D75779 is the proper implementation of the OpenMP standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 __

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert abandoned this revision. jdoerfert added a comment. D75779 is the proper implementation of the OpenMP standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71241/new/ https://reviews.llvm.org/D71241

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:6682 + /// The outermost level of selector sets. + llvm::SmallVector Sets; + jdoerfert wrote: > rnk wrote: > > This is not a good dat

<    1   2