[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. In D75682#1917257 , @Szelethus wrote: > Could you please add the warning we discussed? That would be a great > demonstration of this patch's capabilities, and wouldn't deserve its own > patch. Was it this warning? if (feof(

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249856. njames93 added a comment. Herald added a subscriber: mgorny. - Moved escape/unescape impl to source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files:

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249857. njames93 added a comment. - Small tidy of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang/include/clang/Tooling/ReplacementsYaml.h clang/

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249860. njames93 added a comment. - Fix test case not being ran Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang/include/clang/Tooling/ReplacementsYaml.h

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/unittests/Tooling/ReplacementsYamlTest.cpp:68 + ASSERT_EQ(Doc.Replacements.size(), NewDoc.Replacements.size()); + if (Doc.Replacements.size() == NewDoc.Replacements.size()) { +for (

[PATCH] D76053: [clangd] Redirect documentation to clangd.llvm.org.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall updated this revision to Diff 249870. sammccall added a comment. sammccall updated th

[PATCH] D76053: [clangd] Redirect documentation to clangd.llvm.org.

sammccall updated this revision to Diff 249870. sammccall added a comment. also use template for clangd.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76053/new/ https://reviews.llvm.org/D76053 Files: clang-tools-extra/docs/_templates/clangd_

[PATCH] D76053: [clangd] Redirect documentation to clangd.llvm.org.

sammccall updated this revision to Diff 249871. sammccall added a comment. Fix accidental capitalization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76053/new/ https://reviews.llvm.org/D76053 Files: clang-tools-extra/docs/_templates/clangd_red

[clang] b720543 - [AST] Respect shouldTraversePostOrder when traversing type locs

Author: Marcel Hlopko Date: 2020-03-12T11:08:33+01:00 New Revision: b720543926c7cda94662ae99182ba63bc23a8ff1 URL: https://github.com/llvm/llvm-project/commit/b720543926c7cda94662ae99182ba63bc23a8ff1 DIFF: https://github.com/llvm/llvm-project/commit/b720543926c7cda94662ae99182ba63bc23a8ff1.diff

[clang-tools-extra] 57e81a2 - [clangd] Redirect documentation to clangd.llvm.org.

Author: Sam McCall Date: 2020-03-12T11:45:40+01:00 New Revision: 57e81a2f649099229e1d50b36aeee5eb1b9e3d49 URL: https://github.com/llvm/llvm-project/commit/57e81a2f649099229e1d50b36aeee5eb1b9e3d49 DIFF: https://github.com/llvm/llvm-project/commit/57e81a2f649099229e1d50b36aeee5eb1b9e3d49.diff LO

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249875. njames93 added a comment. - Fix broken dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/clang-apply-replacements/CMakeLi

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 added a comment. Test cases will follow, just time constrained for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76054/new/ https://reviews.llvm.org/D76054 ___ cfe-commits mailing list cf

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, AlexanderLanin. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 added a comment. Test cases will follow, just time constrained for now. clang-apply-replacements currently deduplic

[PATCH] D72072: [AST] Respect shouldTraversePostOrder when traversing type locs

gribozavr2 closed this revision. gribozavr2 added a comment. Superseded by https://reviews.llvm.org/D76001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72072/new/ https://reviews.llvm.org/D72072 ___

[PATCH] D76053: [clangd] Redirect documentation to clangd.llvm.org.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. woohoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76053/new/ https://reviews.llvm.org/D76053

[PATCH] D76001: [AST] Respect shouldTraversePostOrder when traversing type locs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb720543926c7: [AST] Respect shouldTraversePostOrder when traversing type locs (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D76053: [clangd] Redirect documentation to clangd.llvm.org.

This revision was automatically updated to reflect the committed changes. Closed by commit rG57e81a2f6490: [clangd] Redirect documentation to clangd.llvm.org. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76053/new/ https://

[clang] d608fee - [ARM, MVE] Fix user-namespace violation in arm_mve.h.

Author: Simon Tatham Date: 2020-03-12T11:13:50Z New Revision: d608fee8399a9fa6f2819076131c6ac30cc16eef URL: https://github.com/llvm/llvm-project/commit/d608fee8399a9fa6f2819076131c6ac30cc16eef DIFF: https://github.com/llvm/llvm-project/commit/d608fee8399a9fa6f2819076131c6ac30cc16eef.diff LOG:

[clang] 3f8e714 - [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

Author: Simon Tatham Date: 2020-03-12T11:13:50Z New Revision: 3f8e714e2f9f2dc3367d2f3fc569abfaf28f314c URL: https://github.com/llvm/llvm-project/commit/3f8e714e2f9f2dc3367d2f3fc569abfaf28f314c DIFF: https://github.com/llvm/llvm-project/commit/3f8e714e2f9f2dc3367d2f3fc569abfaf28f314c.diff LOG:

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1916309 , @djtodoro wrote: > In D73534#1916291 , @djtodoro wrote: > > > In D73534#1915048 , @mstorsjo > > wrote: > > > > > This broke com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1918890 , @manojgupta wrote: > Hi, > > I see another crash with this change when building gdb. > > Reduced test case: > struct type *a(type *, type *, long, long); > enum b {}; > static int empty_array(type *, int c) {

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Hi, I see another crash with this change when building gdb. Reduced test case: struct type *a(type *, type *, long, long); enum b {}; static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); } long e; b f() { empty_array(0, e); } Repros with: clang -

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

mstorsjo added a comment. In D73534#1918818 , @djtodoro wrote: > In D73534#1916309 , @djtodoro wrote: > > > In D73534#1916291 , @djtodoro > > wrote: > > > > > Thanks for rep

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1918940 , @dstenb wrote: > In D73534#1918890 , @manojgupta > wrote: > > > Hi, > > > > I see another crash with this change when building gdb. > > > > Reduced test case: > > struct

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein added a comment. In D75443#1917351 , @mibintc wrote: > I ran into an obstacle trying to add Trailing storage onto binary operator. > it will probably take me longer. sure, no worries, and thanks for your help. It is not super urgent for us at th

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

SjoerdMeijer added a comment. > I'm still not sure why __fp16, which is a storage-only type, is used for the > element type of float16x4_t if we want to avoid promotion to a float vector > type. About the types: `__fp16` this is the older, storage-only type. So, just historically, I think this

[PATCH] D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd608fee8399a: [ARM,MVE] Fix user-namespace violation in arm_mve.h. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75997/new/ http

[PATCH] D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f8e714e2f9f: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D75998?vs=249641&id=249896#toc Repository: rG

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

pratlucas added a comment. The clang-format pre-merge check keeps wanting me to update the indentation for the entire `ARMSIMDIntrinsicMap` and `AArch64SIMDIntrinsicMap` maps due to the change in their first entries. I believe, though, that this change would not only be out of the scope of this

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, though please run clang-format over the patch (some of the formatting looks to have gone weird in places). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. @vvereschaka very interesting. I've downloaded CMake 3.10.2 and finally been able to reproduce the issue locally. So it //is// a CMake bug which does not appear in the latest versions. I'll update this patch to use `CMAKE_CURRENT_LIST_DIR` and add a comment. Repo

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware updated this revision to Diff 249897. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75514/new/ https://reviews.llvm.org/D75514 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp cl

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. In D75514#1917450 , @Szelethus wrote: > The code from in `ExprInspectionChecker.cpp` is duplicated from D75677 > , isn't it? It is.

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. d5edcb90643104d6911da5c0ff44c4f33fff992f , looking forward to seeing better error recovery. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/ https://reviews.

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske updated this revision to Diff 249904. balazske added a comment. Rebased, added handling of UnknownError. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://reviews.llvm.org/D75851 Files: clang/lib/StaticAnalyzer/Checkers/S

[clang-tools-extra] 966cad0 - [clangd] Add README pointing to docs, bugtracker etc. NFC

Author: Sam McCall Date: 2020-03-12T14:00:08+01:00 New Revision: 966cad0c65d796d8824524c7bee62c86d1594d3d URL: https://github.com/llvm/llvm-project/commit/966cad0c65d796d8824524c7bee62c86d1594d3d DIFF: https://github.com/llvm/llvm-project/commit/966cad0c65d796d8824524c7bee62c86d1594d3d.diff LO

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:937 +case AQ_goto: return "goto"; +case AQ_unspecified:; + } nickdesaulniers wrote: > aaron.ballman wrote: > > This looks wrong to me -- it flows through to an unreachable

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! Anyone else have feedback? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 ___ cfe-commits mailing list cfe-comm

[clang] 592cec7 - [OpenCL] Add missing get_image_array_size builtins

Author: Sven van Haastregt Date: 2020-03-12T13:43:51Z New Revision: 592cec7087d8ea60b7a517d4354eab8d5c7b012c URL: https://github.com/llvm/llvm-project/commit/592cec7087d8ea60b7a517d4354eab8d5c7b012c DIFF: https://github.com/llvm/llvm-project/commit/592cec7087d8ea60b7a517d4354eab8d5c7b012c.diff

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

bader added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } erichkeane wrote: > Anastasia wrote: > > We don't seem to add namespace for other OpenCL types, althoug

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, craig.topper, rjmccall. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, dexonsmith, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson edited the summary of this revision. LukeGeeson

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249916. broadwaylamb added a comment. Use `CMAKE_CURRENT_LIST_DIR` instead of `CMAKE_SOURCE_DIR` for locating the llvm-project directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://r

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. Thank you for the long and detailed explanation. It's been of great help! I've gone with the approach of trying the architectures in the most recent non-deprecated order – sm_52, sm_30. A problem with bumping the default architecture would have been that there are alre

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko created this revision. hlopko added a reviewer: gribozavr. hlopko added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72073?id=235842, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } Anastasia wrote: > erichkeane wrote: > > Anastasia wrote:

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } erichkeane wrote: > Anastasia wrote: > > erichkeane wrote

[clang] dbde39e - Fix static analyzer null dereference warning. NFCI.

Author: Simon Pilgrim Date: 2020-03-12T14:56:51Z New Revision: dbde39e485b5c00b9ad809d169e1650aa2104114 URL: https://github.com/llvm/llvm-project/commit/dbde39e485b5c00b9ad809d169e1650aa2104114 DIFF: https://github.com/llvm/llvm-project/commit/dbde39e485b5c00b9ad809d169e1650aa2104114.diff LOG:

[clang] 5f9fcfb - Replace getAs with castAs to fix null dereference static analyzer warnings.

Author: Simon Pilgrim Date: 2020-03-12T14:56:50Z New Revision: 5f9fcfb29e4e30932909ce648ad556a3890e6dce URL: https://github.com/llvm/llvm-project/commit/5f9fcfb29e4e30932909ce648ad556a3890e6dce DIFF: https://github.com/llvm/llvm-project/commit/5f9fcfb29e4e30932909ce648ad556a3890e6dce.diff LOG:

[clang] 7c2b3c9 - Replace getAs with castAs to fix null dereference static analyzer warnings.

Author: Simon Pilgrim Date: 2020-03-12T14:56:51Z New Revision: 7c2b3c9dda37ab25a6849a3670f1bfda6aa17e5e URL: https://github.com/llvm/llvm-project/commit/7c2b3c9dda37ab25a6849a3670f1bfda6aa17e5e DIFF: https://github.com/llvm/llvm-project/commit/7c2b3c9dda37ab25a6849a3670f1bfda6aa17e5e.diff LOG:

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/DeclTest.cpp:125 + auto StarLoc = TL.getStarLoc().printToString(SM); + ASSERT_EQ(StarLoc, "input.cc:3:12"); +}

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux created this revision. yroux added reviewers: t.p.northover, efriedma, paquette, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Enables Machine Outlining support on ARM for ARM and Thum

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. ping @aaron.ballman - does that look right to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 ___ cfe-commits mailing list

[PATCH] D76071: [Tooling] Recognize angle brackets for main header

drdanz created this revision. drdanz added a reviewer: ioeric. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format does not recognize as main header an include that uses angle brackets. This is a common practice used in many projects. This patch removes the initial

[clang] 6999335 - ObjCMethodDecl::findPropertyDecl - fix static analyzer null dereference warnings. NFCI.

Author: Simon Pilgrim Date: 2020-03-12T15:36:49Z New Revision: 69993350aeed08b6392f614c510697579302a39b URL: https://github.com/llvm/llvm-project/commit/69993350aeed08b6392f614c510697579302a39b DIFF: https://github.com/llvm/llvm-project/commit/69993350aeed08b6392f614c510697579302a39b.diff LOG:

[clang-tools-extra] 2c9cf9f - [clang-tidy] New check: bugprone-suspicious-include

Author: Jonathan Roelofs Date: 2020-03-12T09:59:28-06:00 New Revision: 2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 URL: https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 DIFF: https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5.di

[clang] 7420f96 - [TableGen] Move generated *Attr class methods out of line

Author: Reid Kleckner Date: 2020-03-12T09:07:57-07:00 New Revision: 7420f96924a3889af628c851ff1940aae614f3f3 URL: https://github.com/llvm/llvm-project/commit/7420f96924a3889af628c851ff1940aae614f3f3 DIFF: https://github.com/llvm/llvm-project/commit/7420f96924a3889af628c851ff1940aae614f3f3.diff

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs added a comment. re-landed in https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 ___

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk added a comment. In D76040#1919170 , @aaron.ballman wrote: > LGTM as well, though please run clang-format over the patch (some of the > formatting looks to have gone weird in places). Thanks, done. I undid some of its more questionable reformatting

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 249954. MarcusJohnson91 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

This revision was automatically updated to reflect the committed changes. Closed by commit rG7420f96924a3: [TableGen] Move generated *Attr class methods out of line (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D76040?vs=249817&id=249956#toc Repository: rG LLVM Github

[clang] fa80803 - [AST][SVE] Add new Type queries for sizeless types

Author: Richard Sandiford Date: 2020-03-12T16:30:50Z New Revision: fa8080376e739e2148aa53715dc93e5406f53fd2 URL: https://github.com/llvm/llvm-project/commit/fa8080376e739e2148aa53715dc93e5406f53fd2 DIFF: https://github.com/llvm/llvm-project/commit/fa8080376e739e2148aa53715dc93e5406f53fd2.diff

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

sdesmalen added a comment. In D75298#1918489 , @efriedma wrote: > Changing the way we expose the builtins isn't going to affect most of the > code related to the SVE intrinsics. I'm fine sticking with a known working > approach, and trying to address th

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa8080376e73: [AST][SVE] Add new Type queries for sizeless types (authored by rsandifo-arm). Changed prior to commit: https://reviews.llvm.org/D75570?vs=248125&id=249961#toc Repository: rG LLVM Githu

[clang] 7bfc3bf - Replace getAs/dyn_cast with castAs/cast to fix null dereference static analyzer warnings.

Author: Simon Pilgrim Date: 2020-03-12T16:50:50Z New Revision: 7bfc3bf39b6d279657b480963e72b6c08191b2f2 URL: https://github.com/llvm/llvm-project/commit/7bfc3bf39b6d279657b480963e72b6c08191b2f2 DIFF: https://github.com/llvm/llvm-project/commit/7bfc3bf39b6d279657b480963e72b6c08191b2f2.diff LOG:

[clang] f09c7d6 - [Sema][SVE] Add tests for valid and invalid type usage

Author: Richard Sandiford Date: 2020-03-12T16:56:13Z New Revision: f09c7d642afa932a1e2b66bdcd15e779f8bc5d4e URL: https://github.com/llvm/llvm-project/commit/f09c7d642afa932a1e2b66bdcd15e779f8bc5d4e DIFF: https://github.com/llvm/llvm-project/commit/f09c7d642afa932a1e2b66bdcd15e779f8bc5d4e.diff

[clang] eb2ba2e - [CUDA] Warn about unsupported CUDA SDK version only if it's used.

Author: Artem Belevich Date: 2020-03-12T10:04:10-07:00 New Revision: eb2ba2ea953b5ea73cdbb598f77470bde1c6a011 URL: https://github.com/llvm/llvm-project/commit/eb2ba2ea953b5ea73cdbb598f77470bde1c6a011 DIFF: https://github.com/llvm/llvm-project/commit/eb2ba2ea953b5ea73cdbb598f77470bde1c6a011.diff

[clang] 39969c7 - [Sema][SVE] Reject sizeof and alignof for sizeless types

Author: Richard Sandiford Date: 2020-03-12T17:06:53Z New Revision: 39969c7d3a6da8a60ac3ac7d10f471dea87cfca5 URL: https://github.com/llvm/llvm-project/commit/39969c7d3a6da8a60ac3ac7d10f471dea87cfca5 DIFF: https://github.com/llvm/llvm-project/commit/39969c7d3a6da8a60ac3ac7d10f471dea87cfca5.diff

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

spatel added a subscriber: mibintc. spatel added a comment. In D72675#1917844 , @wristow wrote: > Revisiting this patch. I think that before fixing the `-ffp-contract=off` > problem I originally raised here, there are two questions that have come up > i

[PATCH] D76076: [HIP] Mark kernels with uniform-work-group-size=true

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. https://reviews.llvm.org/D76076 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUDA/amdgpu-kernel-attrs.cu Index: clang/test/CodeGenCUDA/amdgpu-kernel-attrs.cu =

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

sdesmalen updated this revision to Diff 249966. sdesmalen added a comment. - Updated license header for the arm_sve.h file to use the LLVM license instead of MIT. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75298/new/ https://reviews.llvm.org/D75298 Files: clang/include/clang/AST/

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added inline comments. Comment at: clang/docs/LTOVisibility.rst:45 +build system, and the binary will not dlopen any libraries deriving from the +binary’s classes. This is useful in situations where it is not safe to specify +``-fvisibility=hidden`` at compile time. -

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, efriedma, cameron.mcinally, c-rhodes. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett, mgorny. Herald added a reviewer: rengolin. Herald added a project: LLVM. Creates the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, stuij, rjmccall, rsmith, liutianle, RKSimon, craig.topper. Herald added subscribers: cfe-commits, danielkiss, arphaman, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D76062: [PATCH] [ARM

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

This revision was automatically updated to reflect the committed changes. rsandifo-arm marked an inline comment as done. Closed by commit rGf09c7d642afa: [Sema][SVE] Add tests for valid and invalid type usage (authored by rsandifo-arm). Changed prior to commit: https://reviews.llvm.org/D75571?v

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG39969c7d3a6d: [Sema][SVE] Reject sizeof and alignof for sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75572/new/

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb2ba2ea953b: [CUDA] Warn about unsupported CUDA SDK version only if it's used. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/

[clang] 627b5c1 - [Sema][SVE] Reject aligned/_Alignas for sizeless types

Author: Richard Sandiford Date: 2020-03-12T17:12:40Z New Revision: 627b5c12068cc90b476a9121862a481e1d57be85 URL: https://github.com/llvm/llvm-project/commit/627b5c12068cc90b476a9121862a481e1d57be85 DIFF: https://github.com/llvm/llvm-project/commit/627b5c12068cc90b476a9121862a481e1d57be85.diff

[clang] adb290d - [Sema][SVE] Reject atomic sizeless types

Author: Richard Sandiford Date: 2020-03-12T17:20:23Z New Revision: adb290d97482aa9311ee4b4b5917a0f2ece55b30 URL: https://github.com/llvm/llvm-project/commit/adb290d97482aa9311ee4b4b5917a0f2ece55b30 DIFF: https://github.com/llvm/llvm-project/commit/adb290d97482aa9311ee4b4b5917a0f2ece55b30.diff

[clang] f8700db - [Sema][SVE] Don't allow static or thread-local variables to have sizeless type

Author: Richard Sandiford Date: 2020-03-12T17:39:29Z New Revision: f8700db7f150287b71453e4ae10dea79a2e4fb03 URL: https://github.com/llvm/llvm-project/commit/f8700db7f150287b71453e4ae10dea79a2e4fb03 DIFF: https://github.com/llvm/llvm-project/commit/f8700db7f150287b71453e4ae10dea79a2e4fb03.diff

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. linux/musl will use init arrays by default. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76079 Files: clang/lib/Driver/

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

pratlucas updated this revision to Diff 249979. pratlucas added a comment. Adding example to call_mangled description comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74618/new/ https://reviews.llvm.org/D74618 Files: clang/include/clang/Ba

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:55-71 + if (const auto *Reference = + Result.Nodes.getNodeAs("reference_to_non-const")) { +diag(Reference->getLocation(), + "va

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal updated this revision to Diff 249980. vingeldal marked 6 inline comments as done. vingeldal added a comment. Made example code in documentation legal C++ Changed implementation according to comments so that both the pointer matcher and the reference matcher now bind to the same id Rep

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. In D72675#1919685 , @spatel wrote: > In D72675#1917844 , @wristow wrote: > > > Revisiting this patch. I think that before fixing the `-ffp-contract=off` > > problem I originally raised her

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. This patch, which hasn't been committed, contains modifications to the UserManual with many details concerning 'floating point semantic modes" and the relation to floating point command line options. This is from a discussion that @andrew.w.kaylor initiated on the discu

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

jyknight added a comment. I suspect we also need to support saving/loading some of this information in the serialized AST, e.g. clang/lib/Serialization/ASTWriter.cpp has code to save the HeaderInfo data, around line 1650. And around line 2174, code to save the macros per submodule. We'll also n

[PATCH] D75734: [Sema][SVE] Reject atomic sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rGadb290d97482: [Sema][SVE] Reject atomic sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75734/new/ https://reviews.

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG627b5c12068c: [Sema][SVE] Reject aligned/_Alignas for sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75573/new/ ht

[PATCH] D75736: [Sema][SVE] Don't allow static or thread-local variables to have sizeless type

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8700db7f150: [Sema][SVE] Don't allow static or thread-local variables to have sizeless type (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[libunwind] c53c205 - Cache uwnind frame headers as they are found.

Author: Sterling Augustine Date: 2020-03-12T10:53:33-07:00 New Revision: c53c2058ffb8ff877702bb2dded31c85c1dfe66d URL: https://github.com/llvm/llvm-project/commit/c53c2058ffb8ff877702bb2dded31c85c1dfe66d DIFF: https://github.com/llvm/llvm-project/commit/c53c2058ffb8ff877702bb2dded31c85c1dfe66d.

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:548 + + bool UseInitArrayDefault = (getTriple().isMusl()) ? true : false; The ternary is unnecessary. ``` bool UseInitArrayDefault = getTriple().isMusl(); ``` Repository:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:69 + Bfloat16Width = Bfloat16Align = 16; + Bfloat16Format = &llvm::APFloat::IEEEhalf(); + Doesn't Bfloat16 have a different number of mantissa and exponent bits than IEEEhalf?

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

rjmccall added a comment. I don't understand why you wouldn't add a new IR type for this; doing so should be totally mechanical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 __

[PATCH] D35732: Update system_error tests for more platforms.

danalbert updated this revision to Diff 249989. danalbert changed the repository for this revision from rL LLVM to rG LLVM Github Monorepo. danalbert added a project: libc++. danalbert added a comment. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. PTAL Repository:

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache added a comment. Friendly ping! `OverloadCandidate` has uninitialized members and so can cause UB if used incorrectly in another part of the compiler, so I feel this is a fairly straightforward patch: prevent UB by initializing all members. But I'd like some review to confirm. @rsmith

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1919793 , @mibintc wrote: > In D72675#1919685 , @spatel wrote: > > > In D72675#1917844 , @wristow wrote: > > > > > Revisiting this patch. I

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

rjmccall added a comment. Note that we have an IR type for the PPC double-double format, which isn't even hardware-supported. This is literally just an IEEE floating-point format with non-standard parameters, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

  1   2   3   >