[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

ABataev added a comment. In D74262#1876835 , @grokos wrote: > In D74262#1867245 , @ABataev wrote: > > > Partial linking may lead to some incorrect results with global > > constructors. How are you going to handle t

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. > We normally default to `-ffp-contract=on ` only for -O3 and above (for legacy > compilers XL/gcc on PowerPC). Correction: XL on PowerPC default to generate FMA at -O0 as well. The corresponding option is -qfloat=maf. https://www.ibm.com/support/knowledgecenter/SSXVZZ_16

RE: [PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

Thanks Melanie. I have pushed one fix to test-suite to explicitly add -ffp-contract=off to unblock our internal buildbot for now. https://github.com/llvm/llvm-test-suite/commit/c04a7178a3a50fe919964df59b041c5671db50f7 Our buildbot are OK now. I think you can proceed as long as the change is inte

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244728. dgoldman added a comment. - Fix parameter abbreviation for ParamVarDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files: clang/lib/Serialization/ASTWri

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1874826 , @erik.pilkington wrote: > In D74417#1874747 , @dgoldman wrote: > > > Added but it's still failing due to a different assertion failure, do you > > think this could be

[PATCH] D74634: Remove "ELF Only" restriction from section flags

rnk created this revision. rnk added reviewers: hans, aaron.ballman. Herald added subscribers: sunfish, aheejin. Herald added a project: clang. -ffunction-sections and -fdata-sections are well supported by many object file formats: - ELF - COFF - XCOFF - wasm Only MachO ignores this flag. While

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. It turns out that having the warning message also affects the C_SUPPORTS_FPIC test in `cmake/modules/HandleLLVMOptions.cmake`. As a result, `cmake` thinks that `-fPIC` is not supported. Eventually, it leads to error in `libclang-cpp.so`. ../../lib/CodeGen/CMakeFiles

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1876952 , @kkwli0 wrote: > It turns out that having the warning message also affects the C_SUPPORTS_FPIC > test in `cmake/modules/HandleLLVMOptions.cmake`. As a result, `cmake` thinks > that `-fPIC` is not supported.

[clang] 87e80e5 - fix some comment typos to cycle bots

Author: Nico Weber Date: 2020-02-14T15:18:50-05:00 New Revision: 87e80e5e289249cb9c1b6ed0f9502434375335a9 URL: https://github.com/llvm/llvm-project/commit/87e80e5e289249cb9c1b6ed0f9502434375335a9 DIFF: https://github.com/llvm/llvm-project/commit/87e80e5e289249cb9c1b6ed0f9502434375335a9.diff LO

[PATCH] D74602: Fix standalone build interaction with compiler extension

Keruspe accepted this revision. Keruspe added a comment. This revision is now accepted and ready to land. Fixes the regression introduced in D74464 when running cmake inside the clang directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 244737. compositeprimes added a comment. Updated to serialize the ranges in yaml. This required making a few abstractions around the representation of CharSourceRange. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. > I am not sure I understand. Do we need to modify stuff outside of `/openmp`? > I was hoping it is our CMake that can be adjusted to make this work as > described earlier. TBH, he warning is even not my biggest problem. As long as > we get a libomptarget.bc we should be

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

sfertile added a comment. 1. We should probably update the COMDAT section of the lang ref to mention XCOFF doens't support COMDATS. 2. Will we report an error somewhere in the backend if we encounter a COMDAT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

shafik created this revision. shafik added reviewers: martong, teemperor, balazske, a_sidorin. Herald added a subscriber: rnkovacs. This fixed is based on the assert in `LinkageComputer::getLVForDecl(…)` which assumes that all the decls in a redecl chain have the same linkage. This change was tr

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

shafik added a comment. I would love to have a minimal test case for this but every approach I tried has failed, so I would appreciate if there are ideas here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74639/new/ https://reviews.llvm.org/D74639 __

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files: clang/lib/Parse/ParseTentative.c

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes The syntax rules

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added a comment. In D73755#1874962 , @plotfi wrote: > @MadCoder Could there be a way to mark objc_direct methods as something like > __attribute__((visibility("default"))) or __declspec(dllexport) to denote > that a given method should be direct

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder updated this revision to Diff 244773. MadCoder marked 10 inline comments as done. MadCoder added a comment. @erik.pilkington review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://reviews.llvm.org/D73755 Files: clang/include/clang/Basic/Attr.td cl

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added inline comments. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:1630-1637 + if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic && + PIDecl->getPropertyDecl() && + PIDecl->getPropertyDecl()->isDirectProperty()) { +Diag(PropertyL

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

Xiangling_L added a comment. In D74631#1876995 , @sfertile wrote: > > Will we report an error somewhere in the backend if we encounter a COMDAT? I hit this when I was doing my static init patch as well: `error in backend: COMDAT not yet supported by

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a comment. In D74436#1875315 , @nemanjai wrote: > > You're right, -O0 shouldn't generate FMA. I'm preparing to revert this now > > -- just verifying the build. > > Perhaps this should be > `off` with no optimization > `on` with `-O

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. >> Perhaps we can also see what the defaults are for GCC and unify with those? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I haven't forgotten about this, even though it's been two months. Hopefully I get to it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471

[clang] 859654c - [FIX] Add missing InGroup to warning introduced as part of D71830

Author: Johannes Doerfert Date: 2020-02-14T17:22:40-06:00 New Revision: 859654c065583a320d3621d22a09cad89abfc3e9 URL: https://github.com/llvm/llvm-project/commit/859654c065583a320d3621d22a09cad89abfc3e9 DIFF: https://github.com/llvm/llvm-project/commit/859654c065583a320d3621d22a09cad89abfc3e9.d

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:2436 + if (!GetterMethod) { +if (const ObjCCategoryDecl *CatDecl = dyn_cast(CD)) { +

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. Another friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 244790. vsk added a comment. Rebase. Sorry this hasn't seen any update: at this point in our release cycle I've had to put this on the back burner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files: clan

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

jdoerfert added a comment. This is great, thanks a lot! I only have two comments where I am not sure I understand the code/change. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134 // TODO: Replace with a generic helper function for emitting body auto BodyGenCB =

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1877000 , @kkwli0 wrote: > > I am not sure I understand. Do we need to modify stuff outside of > > `/openmp`? I was hoping it is our CMake that can be adjusted to make this > > work as described earlier. TBH, he warni

[clang] 577c9b0 - [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

Author: Atmn Patel Date: 2020-02-15T00:38:12-06:00 New Revision: 577c9b02ab572b7767420a34b4de8d5e19347117 URL: https://github.com/llvm/llvm-project/commit/577c9b02ab572b7767420a34b4de8d5e19347117 DIFF: https://github.com/llvm/llvm-project/commit/577c9b02ab572b7767420a34b4de8d5e19347117.diff LO

[clang] 5313abd - [OpenMP][NFC] Update OpenMPSupport table

Author: Johannes Doerfert Date: 2020-02-15T00:40:39-06:00 New Revision: 5313abdbca802d842ba1d27729420d186f653a2d URL: https://github.com/llvm/llvm-project/commit/5313abdbca802d842ba1d27729420d186f653a2d DIFF: https://github.com/llvm/llvm-project/commit/5313abdbca802d842ba1d27729420d186f653a2d.d

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG577c9b02ab57: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang (authored by atmnpatel, committed by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D74513?vs=244334&id=244815#toc R

[clang] 7438059 - [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

Author: Fady Ghanim Date: 2020-02-15T01:15:45-06:00 New Revision: 7438059a90326d4fe46377bf1833180333b48fff URL: https://github.com/llvm/llvm-project/commit/7438059a90326d4fe46377bf1833180333b48fff DIFF: https://github.com/llvm/llvm-project/commit/7438059a90326d4fe46377bf1833180333b48fff.diff L

[clang-tools-extra] 803ad31 - [FIX] Repair clang-tidy check after D72304

Author: Johannes Doerfert Date: 2020-02-15T01:15:45-06:00 New Revision: 803ad3137b6b81afca487e6b661460e05089699b URL: https://github.com/llvm/llvm-project/commit/803ad3137b6b81afca487e6b661460e05089699b DIFF: https://github.com/llvm/llvm-project/commit/803ad3137b6b81afca487e6b661460e05089699b.d

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7438059a9032: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. (authored by fghanim, committed by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D72304?vs=244249

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

MaskRay added a comment. `test/CodeGen/opt-record-1.c` triggers an assertion failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing li

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. I did run clang-format on the OMPIRBuilder files and replaced tabs with spaces. I think you need to teach your editor to use spaces in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.

[PATCH] D74634: Remove "ELF Only" restriction from section flags

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74634/new/ https://reviews.llvm.org/D74634

<    1   2