[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

nicolas17 added a comment. In D74385#1872298 , @serge-sans-paille wrote: > Sure, can you just confirm that you're this guy: https://github.com/nicolas17 > (I need that for proper email attribution) Yes that's me :) Repository: rG LLVM Github Monore

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

dmajor added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersionArgs(Args, CmdArgs); arphama

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

aganea created this revision. aganea added reviewers: thakis, rnk, hans, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/test/Driver/cc1-spawnprocess.c:9

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

thakis added a comment. That landed in 17b77418121139c4e8cfb050d82ead3f29db7132 . Sounds like there's more SFINAE to be fixed here, but my build is happy again. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/test/Driver/cc1-spawnprocess.c:9 -// RUN: %clang_cl -fintegrated-cc1 -### -- %s 2>&1 \ +// RUN: %clang_cl -fintegrated-cc1 -c -### -- %s 2>&1 \ // RUN: | FileCheck %s --check-prefix=YE

[PATCH] D74222: [AArch64][SVE] Add mul/mla/mls lane & dup intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74222/new/ https://reviews.llvm.org/D74222

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. Ah, yes, we're laxer about these things in C than we are in C++. If we do this, we'll need to go through `DiagnoseAssignmentResult` and make sure that everything (except `Compatible`, which we'll never pass) triggers an error in C++ mode. Is there a good reason to ju

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/Driver/cc1-spawnprocess.c:9 -// RUN: %clang_cl -fintegrated-cc1 -### -- %s 2>&1 \ +// RUN: %clang_cl -fintegrated-cc1 -c -### -- %s 2>&1 \ // RUN:

[clang] fa7cd54 - clang: Guess at some platform FTZ/DAZ default settings

Author: Matt Arsenault Date: 2020-02-12T12:09:26-05:00 New Revision: fa7cd549d604bfd8f9dce5d649a19720cbc39cca URL: https://github.com/llvm/llvm-project/commit/fa7cd549d604bfd8f9dce5d649a19720cbc39cca DIFF: https://github.com/llvm/llvm-project/commit/fa7cd549d604bfd8f9dce5d649a19720cbc39cca.diff

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm closed this revision. arsenm added a comment. fa7cd549d604bfd8f9dce5d649a19720cbc39cca CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 __

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton reopened this revision. Clayton added a comment. This revision is now accepted and ready to land. Re-opening to fix windows tests failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 ___

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton updated this revision to Diff 244204. Clayton added a comment. Making paths in markdown files be posix style. This fixes the tests on windows hosts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 Files: clang-tools-extra/clang-doc/HT

[clang] f6a3ac1 - Fix `-Wunused-variable` warning. NFC.

Author: Michael Liao Date: 2020-02-12T12:45:14-05:00 New Revision: f6a3ac150b8d9f3458f526cf76ebcd545bfc1898 URL: https://github.com/llvm/llvm-project/commit/f6a3ac150b8d9f3458f526cf76ebcd545bfc1898 DIFF: https://github.com/llvm/llvm-project/commit/f6a3ac150b8d9f3458f526cf76ebcd545bfc1898.diff

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I think these odd shuffle then extend patterns might come up in codegen too, so this looks like a nice change. LGTM, if the test is just a test case problem. Comment at:

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: clang/include/clang/Driver/Job.h:87 + /// Whether to print the input filenames when executing. + bool PrintInputFilenames; + I forgot to put back the default value(s) here, I'll

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

luismarques updated this revision to Diff 244211. luismarques added a comment. Correct paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74399/new/ https://reviews.llvm.org/D74399 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/fedora_31_riscv64_tree/usr/lib

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM, i guess Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

aaron.ballman added a comment. In D71830#1871838 , @JonChesterfield wrote: > Procedural note - adding someone as a blocking reviewer to someone else's > patch isn't great. What if the new reviewer never gets around to looking at > the patch? > > I've ad

[clang] 53fba65 - [ARCMT][NFC] Reduce #include dependencies

Author: Nicolás Alvarez Date: 2020-02-12T19:10:46+01:00 New Revision: 53fba65d220499ebc380755aca2da41a5eb33f02 URL: https://github.com/llvm/llvm-project/commit/53fba65d220499ebc380755aca2da41a5eb33f02 DIFF: https://github.com/llvm/llvm-project/commit/53fba65d220499ebc380755aca2da41a5eb33f02.dif

[clang] 5dcffdf - Fix fp-model flag test failure on linux

Author: Matt Arsenault Date: 2020-02-12T10:14:29-08:00 New Revision: 5dcffdf58a33b51028f6b52e44c4af25b5d159aa URL: https://github.com/llvm/llvm-project/commit/5dcffdf58a33b51028f6b52e44c4af25b5d159aa DIFF: https://github.com/llvm/llvm-project/commit/5dcffdf58a33b51028f6b52e44c4af25b5d159aa.diff

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

nickdesaulniers added a comment. Doesn't GCC also support multiple different levels of this warning for all kinds of different spellings? https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ I have concerns about the performance of this warning. We're going to parse ev

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rG53fba65d2204: [ARCMT][NFC] Reduce #include dependencies (authored by nicolas17, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:28 +// 2. it is immutable, the way it was constructed it will stay. +template class ImmutableSmartSet { + ArrayRef Vector; "Smart" is not a descriptive term.

[clang] 3833316 - Completely ignore strict FP model and denormal-fp-math interaction

Author: Matt Arsenault Date: 2020-02-12T13:26:46-05:00 New Revision: 38333164fc7dfc9d4cbf93e443e74809022ed78e URL: https://github.com/llvm/llvm-project/commit/38333164fc7dfc9d4cbf93e443e74809022ed78e DIFF: https://github.com/llvm/llvm-project/commit/38333164fc7dfc9d4cbf93e443e74809022ed78e.diff

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a comment. This also fixes https://bugs.llvm.org/show_bug.cgi?id=44886 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

rnk accepted this revision. rnk added a comment. lgtm The fix looks like what Richard asked for, so I feel comfortable approving this. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 __

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a subscriber: hans. smeenai added a comment. CC @hans for the 10.0 branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a test coverage request. Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.c:26-30 + if (list_c.next == NULL

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

MaskRay accepted this revision. MaskRay added a comment. @rsmith Does `clang/test/utils/` (a new directory) look appropriate to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:355 + collectOperands(Operands.second, AllOper

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

aganea created this revision. aganea added reviewers: rnk, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. When running on Windows under the following locale: D:\llvm-project>python Python 3.8.0 (tags/v3.8.0:fa919fd, Oct 14 2019, 19:37:50) [MSC v.1916

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. Thanks! I'll push it shortly. Just running a final ninja check-all after updating workspace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-commits mailing list cf

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added subscribers: erik.pilkington, ahatanak. vsk added a comment. + Erik and Akira for IRgen expertise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

aganea updated this revision to Diff 244246. aganea added a comment. Better fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74498/new/ https://reviews.llvm.org/D74498 Files: clang-tools-extra/test/clang-tidy/check_clang_tidy.py Index: clang-tools-extra/test/clang-tidy/check_clan

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 244249. fghanim added a comment. Remove unnecessary preservation of builder insertion point in `emitCommonDirectiveExit` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304

[clang] e26c24b - Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

Author: Erik Pilkington Date: 2020-02-12T12:26:46-08:00 New Revision: e26c24b849211f35a988d001753e0cd15e4a9d7b URL: https://github.com/llvm/llvm-project/commit/e26c24b849211f35a988d001753e0cd15e4a9d7b DIFF: https://github.com/llvm/llvm-project/commit/e26c24b849211f35a988d001753e0cd15e4a9d7b.dif

[Diffusion] rG0e3a48778408: PR12350: Handle remaining cases permitted by CWG DR 244.

lebedev.ri added subscribers: cfe-commits, rsmith, vsk, lebedev.ri. lebedev.ri added a comment. Post-commit review, although i'm not sure this is the commit that is the problem. BRANCHES master /clang/lib/AST/NestedNameSpecifier.cpp:485-487 Was this change intentional? It seems, http://lab

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

arsenm created this revision. arsenm added reviewers: spatel, cameron.mcinally, andrew.w.kaylor. Herald added subscribers: llvm-commits, kerbowa, dexonsmith, nhaehnle, wdng, jvesely. Herald added a project: LLVM. The IR hasn't switched the default yet, so explicitly add the ieee attributes. htt

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. Actually I just noticed it still says 'Needs review' above. I'm not sure what the protocol is. Can I push the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a comment. I'm not sure why Phabricator is still showing Needs Review, but @rnk's approval should make this count as accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-c

[clang] a58017e - Fix type-dependency of bitfields in templates

Author: Elizabeth Andrews Date: 2020-02-12T13:31:41-08:00 New Revision: a58017e5cae5be948fd1913b68d46553e87aa622 URL: https://github.com/llvm/llvm-project/commit/a58017e5cae5be948fd1913b68d46553e87aa622 DIFF: https://github.com/llvm/llvm-project/commit/a58017e5cae5be948fd1913b68d46553e87aa622.d

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked 14 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/Attr.td:185 +// An argument of type \p type with name \p name. +class GenericPointerArgument : Argument { + string Type = type; aaron.ballman wrot

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. In D72242#1873017 , @smeenai wrote: > I'm not sure why Phabricator is still showing Needs Review, but @rnk's > approval should make this count as accepted. Ok. Thank you. I've pushed the patch. CHANGES SINCE LAST ACTION htt

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa58017e5cae5: Fix type-dependency of bitfields in templates (authored by eandrews). Herald added a project: clang. Reposi

[clang] 60cba34 - [Clang] When -ftime-trace is used, clean CompilerInstance::OutputFiles before exiting cc_main()

Author: Alexandre Ganea Date: 2020-02-12T17:02:57-05:00 New Revision: 60cba345ca395ea991d7f2596c4a93439fbf9924 URL: https://github.com/llvm/llvm-project/commit/60cba345ca395ea991d7f2596c4a93439fbf9924 DIFF: https://github.com/llvm/llvm-project/commit/60cba345ca395ea991d7f2596c4a93439fbf9924.dif

[clang] 20f1abe - [Clang] Limit -fintegrated-cc1 to only one TU

Author: Alexandre Ganea Date: 2020-02-12T17:02:57-05:00 New Revision: 20f1abe306d030e99f56185a3aa077ffadf59b8a URL: https://github.com/llvm/llvm-project/commit/20f1abe306d030e99f56185a3aa077ffadf59b8a DIFF: https://github.com/llvm/llvm-project/commit/20f1abe306d030e99f56185a3aa077ffadf59b8a.dif

[clang] 67f4e00 - [CMake][Fuchsia] Enable in-process cc1

Author: Petr Hosek Date: 2020-02-12T14:05:24-08:00 New Revision: 67f4e0011d318f446354ac3481e2382cd797e9a0 URL: https://github.com/llvm/llvm-project/commit/67f4e0011d318f446354ac3481e2382cd797e9a0 DIFF: https://github.com/llvm/llvm-project/commit/67f4e0011d318f446354ac3481e2382cd797e9a0.diff LO

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f1abe306d0: [Clang] Limit -fintegrated-cc1 to only one TU (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D74490?vs=244197&id=244276#toc Repository: rG LLVM Github Monorepo

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. Hello @plotfi and @hctim -- rG20f1abe306d0 should solve the initial issues you were seeing, please let me know if it doesn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

nicolas17 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:484 +const NoteTag *ChangeTag = + getChangeTag(C, "shrinked from the right by 1 position", ContReg, ContE); // For vector-like and deque-like containers invalidate t

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org/D74372 __

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

erik.pilkington added a comment. This looks good, but please add a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 ___ cfe-commits mailing list cfe-co

[clang] 77b2ffc - Fix a reentrance bug with deserializing ObjC type parameters.

Author: John McCall Date: 2020-02-12T18:44:19-05:00 New Revision: 77b2ffc498e92cce7546d191f6712a3046300501 URL: https://github.com/llvm/llvm-project/commit/77b2ffc498e92cce7546d191f6712a3046300501 DIFF: https://github.com/llvm/llvm-project/commit/77b2ffc498e92cce7546d191f6712a3046300501.diff L

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347 _

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This swaps out the OpenMPDefaultClauseKind enum with a llvm::omp::DefaultKind enum which is stored in OMPConsta

[clang] 8a56d64 - [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

Author: Johannes Doerfert Date: 2020-02-12T17:55:01-06:00 New Revision: 8a56d64d7620b3764f10f03f3a1e307fcdd72c2f URL: https://github.com/llvm/llvm-project/commit/8a56d64d7620b3764f10f03f3a1e307fcdd72c2f DIFF: https://github.com/llvm/llvm-project/commit/8a56d64d7620b3764f10f03f3a1e307fcdd72c2f.d

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a56d64d7620: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/ne

[clang] 3aac953 - Revert "[OpenMP][IRBuilder] Perform finalization (incl. outlining) late"

Author: Johannes Doerfert Date: 2020-02-12T18:50:43-06:00 New Revision: 3aac953afa34885a72df96f2b703b65f85cbb149 URL: https://github.com/llvm/llvm-project/commit/3aac953afa34885a72df96f2b703b65f85cbb149 DIFF: https://github.com/llvm/llvm-project/commit/3aac953afa34885a72df96f2b703b65f85cbb149.d

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

smeenai added a comment. It looks like our behavior still differs from gcc in the case of a `static inline __attribute__((gnu_inline))` function: https://gcc.godbolt.org/z/cY9-HQ. We emit it and gcc doesn't. I don't think that combination makes a lot of sense, but I ran into it in some internal

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1005-1006 def err_objc_direct_duplicate_decl : Error< - "%select{|direct }0method declaration conflicts " - "with previous %select{|direct }1declaration of method %2">; + "%sel

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Could this have caused a new ubsan failure? clang/lib/AST/NestedNameSpecifier.cpp:485:23: runtime error: null pointer passed as argument 2, which is declared to never be null http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38698/steps/check-clang%20ubsan/logs/stdio On Fri, F

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert added a comment. One question (below) otherwise this looks good. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:358 +__OMP_DEFAULT_KIND(shared, 3) +__OMP_DEFAULT_KIND(unknown, 4) + Why 2, 3, 4? Do we really need to specify the value here?

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

efriedma added a comment. > https://gcc.godbolt.org/z/cY9-HQ gcc's behavior for your testcase makes no sense. We have to emit the definition of a static function: it can't be defined in any other translation unit because it's impossible to name in any other translation unit. Note the "_ZL" p

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

smeenai added a comment. In D67414#1873445 , @efriedma wrote: > > https://gcc.godbolt.org/z/cY9-HQ > > gcc's behavior for your testcase makes no sense. We have to emit the > definition of a static function: it can't be defined in any other translation >

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

efriedma added a comment. I agree, it doesn't make sense to warn on static functions; the behavior didn't change, and there's only one reasonable result. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67414/new/ https://reviews.llvm.org/D67414 _

[clang] 70cac41 - Reapply "[OpenMP][IRBuilder] Perform finalization (incl. outlining) late"

Author: Johannes Doerfert Date: 2020-02-12T22:29:07-06:00 New Revision: 70cac41a2b7e4a7a28c36a544c9813c833d494bb URL: https://github.com/llvm/llvm-project/commit/70cac41a2b7e4a7a28c36a544c9813c833d494bb DIFF: https://github.com/llvm/llvm-project/commit/70cac41a2b7e4a7a28c36a544c9813c833d494bb.d

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vvereschaka added a comment. Hello @jdoerfert, `OpenMPIRBuilderTest.ParallelCancelBarrier` is failed on Windows builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/11242/steps/test-check-llvm-unit/logs/stdio http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/buil

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vvereschaka added a comment. it also gets failed on the Linux builders http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/2843 http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/11581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

plotfi added a comment. Could this be reverted for the time being so that bots can go green? There appear to be an awful lot of commits piling up on top of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel updated this revision to Diff 244334. atmnpatel added a comment. Removes specified values in favor of defaults in the DefaultKind enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 Files: cla

[clang] 3f3ec9c - [OpenMP][FIX] Collect blocks to be outlined after finalization

Author: Johannes Doerfert Date: 2020-02-13T00:42:22-06:00 New Revision: 3f3ec9c40b2574929b41b93ac38484081b49837b URL: https://github.com/llvm/llvm-project/commit/3f3ec9c40b2574929b41b93ac38484081b49837b DIFF: https://github.com/llvm/llvm-project/commit/3f3ec9c40b2574929b41b93ac38484081b49837b.d

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert added a comment. In D74372#1873623 , @plotfi wrote: > Could this be reverted for the time being so that bots can go green? There > appear to be an awful lot of commits piling up on top of this one. Should be fixed by now but you should revert

[PATCH] D74499: Remove clang::ast_type_traits namespace in favor of clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74499/new/ https://reviews.llvm.org/D74499

<    1   2