[clang] 7ae1b4a - Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-07 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-07T11:47:37-08:00 New Revision: 7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49 URL: https://github.com/llvm/llvm-project/commit/7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49 DIFF: https://github.com/llvm/llvm-project/commit/7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49.diff

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

2020-02-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7ae1b4a0ce9c: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] b03c3d8 - Revert "Support -fstack-clash-protection for x86"

2020-02-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-02-07T14:49:38-05:00 New Revision: b03c3d8c62096af1e27b23480fa4623bb64bfab9 URL: https://github.com/llvm/llvm-project/commit/b03c3d8c62096af1e27b23480fa4623bb64bfab9 DIFF: https://github.com/llvm/llvm-project/commit/b03c3d8c62096af1e27b23480fa4623bb64bfab9.diff LO

[clang] 42efd35 - [cxx_status] Fix status of P1766R to not bleed into adjacent cells.

2020-02-07 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-07T11:54:48-08:00 New Revision: 42efd35ba04daa2b74f69a05877927af0a8fcbb0 URL: https://github.com/llvm/llvm-project/commit/42efd35ba04daa2b74f69a05877927af0a8fcbb0 DIFF: https://github.com/llvm/llvm-project/commit/42efd35ba04daa2b74f69a05877927af0a8fcbb0.diff

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Reverted in b03c3d8c620 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Sorry about the delayed response, I was traveling. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + gchatelet wrote: > efriedma wrote: > > This is in the wrong section of the documentation. We cou

[PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-07 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Also got failed clang tests on Arm/Aarch64 builders http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4295 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4277 - FAIL: Clang::stack-clash-protection.c - FAIL: Clang::stack-clash-protect

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-07 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list cfe-commi

[clang] e8e05de - [OPENMP50]Add codegen for acq_rel clause in atomic|flush directives.

2020-02-07 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-02-07T15:05:09-05:00 New Revision: e8e05de08bea1931420da19462533a8caa4b0e26 URL: https://github.com/llvm/llvm-project/commit/e8e05de08bea1931420da19462533a8caa4b0e26 DIFF: https://github.com/llvm/llvm-project/commit/e8e05de08bea1931420da19462533a8caa4b0e26.diff

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

2020-02-07 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 243241. aganea marked 2 inline comments as done. aganea edited the summary of this revision. aganea added a comment. Simplified patch after landing previous incremental changes mentioned above . @arichardson If you hav

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

2020-02-07 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 243272. dgoldman added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

Re: [PATCH] D68720: Support -fstack-clash-protection for x86

2020-02-07 Thread Serge Guelton via cfe-commits
On Fri, Feb 07, 2020 at 07:12:39PM +, Nico Weber via Phabricator wrote: > thakis added a comment. > > This breaks check-clang on mac and win: > http://45.33.8.238/mac/7485/step_7.txt http://45.33.8.238/win/7753/step_7.txt > > Please revert and then investigate asynchronously, unless the fix

[clang] fafc6e4 - [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-07 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-02-07T14:39:31-08:00 New Revision: fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 URL: https://github.com/llvm/llvm-project/commit/fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 DIFF: https://github.com/llvm/llvm-project/commit/fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402.dif

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2229 +* ``memcpy`` * ``memchr`` efriedma wrote: > Not sure putting "memcpy" in this list makes sense. We did add support for > constant-evaluating memcpy, but it was separately fr

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet updated this revision to Diff 243289. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Remove unrelated memcpy in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D735

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2020-02-07 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added a comment. Thx a lot ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] d65bbf8 - [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Guillaume Chatelet via cfe-commits
Author: Guillaume Chatelet Date: 2020-02-07T23:55:26+01:00 New Revision: d65bbf81f8be3ff806b86776cf95b001a4cf43ad URL: https://github.com/llvm/llvm-project/commit/d65bbf81f8be3ff806b86776cf95b001a4cf43ad DIFF: https://github.com/llvm/llvm-project/commit/d65bbf81f8be3ff806b86776cf95b001a4cf43ad.

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

2020-02-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd65bbf81f8be: [clang] Add support for __builtin_memcpy_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://revi

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-07 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") JDevlieghere wrote: > kschwarz wrote: > > Hi @JDevlieghere,

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-07 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") kschwarz wrote: > Hi @JDevlieghere, we've noticed that with

[PATCH] D74260: Change default relocation model for hexagon when triple includes musl

2020-02-07 Thread Sid Manning via Phabricator via cfe-commits
sidneym created this revision. sidneym added reviewers: kparzysz, bcain, martell, dalias. Herald added a project: clang. Herald added a subscriber: cfe-commits. Right now if the triple includes musl, saying something like: "--target=x86_64--linux-musl" then the default relocation model is pic. W

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

2020-02-07 Thread Logan Smith via Phabricator via cfe-commits
logan-5 updated this revision to Diff 243307. logan-5 marked an inline comment as done. logan-5 added a comment. Changed `Whitelist` to `AllowedIdentifiers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-07 Thread George Rokos via Phabricator via cfe-commits
grokos created this revision. grokos added reviewers: hfinkel, jdoerfert, ABataev, mdtoguchi, kbobrovs, sdmitriev. grokos added a project: clang. Herald added a subscriber: Anastasia. This is the bundler-side patch for enabling static library support in clang. The scheme has been discussed exten

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-07 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > kiranchandramohan wrote: > > jdoerfert wrote: > >

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-02-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I don't see any changes to the constant evaluator here. You need to properly handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or you'll miscompile floating-point

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

2020-02-07 Thread Simon Cook via Phabricator via cfe-commits
simoncook updated this revision to Diff 243325. simoncook added a comment. Add support for Z extensions also under this scheme. In order to support these I've had to tweak the multi-letter extension parsing a little. The net result is that error messages printed regarding version numbers are no

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-02-07 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. @thakis I got sidetracked by some other things and had not made more progress, if progress is not made yes I think -emit-interface-stubs should imply -fno-integrated-cc1 if that seems like the right thing to do to you. @erichkeane Thanks for filing the bugzilla bug. I wa

[clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-07 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-02-07T18:40:41-08:00 New Revision: 0e3a48778408b505946e465abf5c77a2ddd4918c URL: https://github.com/llvm/llvm-project/commit/0e3a48778408b505946e465abf5c77a2ddd4918c DIFF: https://github.com/llvm/llvm-project/commit/0e3a48778408b505946e465abf5c77a2ddd4918c.diff

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-02-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D69272#1865266 , @rsmith wrote: > I don't see any changes to the constant evaluator here. You need to properly > handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or > you'll miscompile floating-point oper

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + kiranchandramohan wrote: > jdoerf

[clang-tools-extra] dac21fd - [clang-doc] Improving Markdown Output

2020-02-07 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-02-07T19:17:03-08:00 New Revision: dac21fdd5923730342a4bc9abc0858fb56ff8d52 URL: https://github.com/llvm/llvm-project/commit/dac21fdd5923730342a4bc9abc0858fb56ff8d52 DIFF: https://github.com/llvm/llvm-project/commit/dac21fdd5923730342a4bc9abc0858fb56ff8d52.diff LO

[PATCH] D72954: [clang-doc] Improving Markdown Output

2020-02-07 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdac21fdd5923: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/

[clang-tools-extra] 7b627bb - Revert "[clang-doc] Improving Markdown Output"

2020-02-07 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-02-07T19:43:47-08:00 New Revision: 7b627bb6e019b5457aa64ea19debefe307f68a19 URL: https://github.com/llvm/llvm-project/commit/7b627bb6e019b5457aa64ea19debefe307f68a19 DIFF: https://github.com/llvm/llvm-project/commit/7b627bb6e019b5457aa64ea19debefe307f68a19.diff LO

[PATCH] D72954: [clang-doc] Improving Markdown Output

2020-02-07 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. This is failing on Windows: ../../clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp(77): error: Expected: Expected Which is: "# namespace Namespace\n\n\n\n## Namespaces\n\n* [ChildNamespace](../ChildNamespace/index.md)\n\n\n## Records\n\n* [Child

[clang] 8d4fe86 - [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds after 305bf5b21dbdb2345ef86b5700285e42d992c954

2020-02-07 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-07T22:28:45-08:00 New Revision: 8d4fe864c4bdc53b3e6a2df43112520cb646afcf URL: https://github.com/llvm/llvm-project/commit/8d4fe864c4bdc53b3e6a2df43112520cb646afcf DIFF: https://github.com/llvm/llvm-project/commit/8d4fe864c4bdc53b3e6a2df43112520cb646afcf.diff

[clang] 70e0935 - [Driver][test] Refactor LLVMgold tests

2020-02-07 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-07T22:37:11-08:00 New Revision: 70e0935256fc173fbc57c7333727ab222af476eb URL: https://github.com/llvm/llvm-project/commit/70e0935256fc173fbc57c7333727ab222af476eb DIFF: https://github.com/llvm/llvm-project/commit/70e0935256fc173fbc57c7333727ab222af476eb.diff

[clang] 8aa3f50 - [Driver] Don't pass -plugin LLVMgold.so when the linker is ld.lld

2020-02-07 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-07T22:53:14-08:00 New Revision: 8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a URL: https://github.com/llvm/llvm-project/commit/8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a DIFF: https://github.com/llvm/llvm-project/commit/8aa3f507c38a2ccd8ed7cb33d02a6f645cdbc03a.diff

[clang] 6589a29 - [Driver][test] Create empty file Inputs/basic_cross_linux_tree/usr/x86_64-unknown-linux-gnu/bin/ld.lld

2020-02-07 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-07T23:30:54-08:00 New Revision: 6589a2914762eb6c2a1181c6b71edbb5d09130b2 URL: https://github.com/llvm/llvm-project/commit/6589a2914762eb6c2a1181c6b71edbb5d09130b2 DIFF: https://github.com/llvm/llvm-project/commit/6589a2914762eb6c2a1181c6b71edbb5d09130b2.diff

<    1   2