[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader accepted this revision. bader added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241356. gchatelet added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Bui

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. @efriedma would you mind having a look? It should be my last patch on that matter :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 241364. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Che

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

bader added a comment. @lebedev.ri, thanks for the suggestion. We will investigate this option when we ready to upload clang diagnostics patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362 ___

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 updated this revision to Diff 241374. njames93 added a comment. - Streamline fixits - Add documentation about double pointers, maybe a follow up patch to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org

[clang] a156a0e - [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

Author: Nathan James Date: 2020-01-30T10:16:04Z New Revision: a156a0e28df4751f812c84437321339c2eb33af3 URL: https://github.com/llvm/llvm-project/commit/a156a0e28df4751f812c84437321339c2eb33af3 DIFF: https://github.com/llvm/llvm-project/commit/a156a0e28df4751f812c84437321339c2eb33af3.diff LOG:

[PATCH] D73562: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGa156a0e28df4: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb planned changes to this revision. broadwaylamb added a comment. In D72717#1848509 , @ldionne wrote: > It's weird to mix Clang and libc++ test options because they test > fundamentally different things. But I don't mind about this patch since

[clang-tools-extra] 9b71ec8 - [clangd][vscode] Get rid of the deprecated vscode module in the extension.

Author: Haojian Wu Date: 2020-01-30T11:36:08+01:00 New Revision: 9b71ec899a1554210ec66756681c047a52866d39 URL: https://github.com/llvm/llvm-project/commit/9b71ec899a1554210ec66756681c047a52866d39 DIFF: https://github.com/llvm/llvm-project/commit/9b71ec899a1554210ec66756681c047a52866d39.diff LO

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b71ec899a15: [clangd][vscode] Get rid of the deprecated vscode module in the extension. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 7fd7a9a - [clangd] Bump vscode-clangd v0.0.20

Author: Haojian Wu Date: 2020-01-30T11:45:54+01:00 New Revision: 7fd7a9a6365f8026d84a89ec3e73d328a63742a0 URL: https://github.com/llvm/llvm-project/commit/7fd7a9a6365f8026d84a89ec3e73d328a63742a0 DIFF: https://github.com/llvm/llvm-project/commit/7fd7a9a6365f8026d84a89ec3e73d328a63742a0.diff LO

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: - @llvm.aarch

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62275 tests passed, 1 failed and 827 were skipped. failed: Clang.CodeGenOpenCL/amdgpu-features.cl {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please forma

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak added a comment. In D73629#1847750 , @NoQ wrote: > We should add a test for this (cf. `test/Analysis/vfork.c`). There is already a test to check if the whitelist works by making sure that call to `execl` doesn't generate the warning. I think t

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp:109 "execvpe", + "execve", nullptr xazax.hun wrote: > Well, this is not the case now, but I wonder if it would also make sense to > sort this list

[clang-tools-extra] 4fb1adc - [clangd] Log directory when a CDB is loaded

Author: Kadir Cetinkaya Date: 2020-01-30T12:15:04+01:00 New Revision: 4fb1adcde22c06d421598ed1925ee3c7c835abc4 URL: https://github.com/llvm/llvm-project/commit/4fb1adcde22c06d421598ed1925ee3c7c835abc4 DIFF: https://github.com/llvm/llvm-project/commit/4fb1adcde22c06d421598ed1925ee3c7c835abc4.dif

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

kadircet updated this revision to Diff 241388. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73628/new/ https://reviews.llvm.org/D73628 Files: clang-tools-ex

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb1adcde22c: [clangd] Log directory when a CDB is loaded (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73628/new/ https://reviews.l

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241391. awpandey marked 7 inline comments as done. awpandey added a comment. Hi @dblaikie, I have incorporated your suggestions (renaming variables, test case modification). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey marked an inline comment as done and an inline comment as not done. awpandey added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1808-1809 Record.push_back(VE.getMetadataOrNullID(N->getType())); + if (M.getDwarfVersion() >= 5) +Record.pus

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73690 Files: clang-tools-extra/clangd/XRef

[clang-tools-extra] 827f49e - [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

Author: Haojian Wu Date: 2020-01-30T12:49:30+01:00 New Revision: 827f49e3faf59f99082d0085de06dcbc09be8ba3 URL: https://github.com/llvm/llvm-project/commit/827f49e3faf59f99082d0085de06dcbc09be8ba3 DIFF: https://github.com/llvm/llvm-project/commit/827f49e3faf59f99082d0085de06dcbc09be8ba3.diff LO

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/address-spaces-conversions-cl2.0.cl:521 +#else +// expected-error@-5 {{assigning to '__generic int *__generic *' from incompatible type '__local int *__local *__private

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG827f49e3faf5: [clangd] Make go-to-def jumps to overriden methods on `final` specifier. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62305 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73667: Speed up compilation of ASTImporter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the patch! Looks good to me! Comment at: clang/lib/AST/ASTImporter.cpp:192 + // Don't attempt to import nodes if we hit an error earlier. + if (Err) +

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz added a comment. In D69221#1848425 , @ldionne wrote: > Do you have commit access? No. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___ cfe-comm

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added a comment. Thanks for this patch too! However, I have a minor concern with this new approach: If `importSeq` fails then a `ToSomething` still holds a value from the "From" context. This could cause problems if it is used later in creating the new AST node. Normally, this should not

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added a subscriber: gamesh411. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1152 + if (Error E = importSeq(ToElementType, ToSizeExpr)) +return std::move(E); Quuxplusone wrote: > As the author of [P1155 "More Implicit Mov

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, kristof.beyls. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73693 Files: clang-tools-extra/clangd/unitte

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. Currently template parameters has symbolkind `Unknown`. This patch introduces a new kind `Templat

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio updated this revision to Diff 241421. dnsampaio added a comment. Herald added a subscriber: jfb. - Moved computation of volatile accesses to the record layout builder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://review

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62337 tests passed, 1 failed and 838 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red}

[clang] f9f0919 - [clang-format] Improve support for multiline C# strings

Author: Jonathan Coe Date: 2020-01-30T13:45:48Z New Revision: f9f0919db7ea033a205c87eb08c81c4baaecd846 URL: https://github.com/llvm/llvm-project/commit/f9f0919db7ea033a205c87eb08c81c4baaecd846 DIFF: https://github.com/llvm/llvm-project/commit/f9f0919db7ea033a205c87eb08c81c4baaecd846.diff LOG:

[PATCH] D73622: [clang-format] Improve support for multiline C# strings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9f0919db7ea: [clang-format] Improve support for multiline C# strings (authored by Jonathan Coe ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D73622: [clang-format] Improve support for multiline C# strings

MyDeveloperDay added a comment. these are great patches you are making... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73622/new/ https://reviews.llvm.org/D73622 ___ cfe-commits mailing list cfe-commi

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. > I created D73680 to place the patch label > after BTI. > > @hans Is there still time to cherry pick the patch to release/10.x? See > above, Linux developers really want the Clang release to have compatible > behavior with GCC. Yes, t

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock created this revision. blastrock added reviewers: rjmccall, hliao. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=44368 I don't know why the comment said that we should take the linkage of the outer

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 241431. antiagainst marked 16 inline comments as done. antiagainst added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/i

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:182 + // Perform the group reduction operation. + Value groupOperation = rewriter.create( + loc, originalInputType.getElementType(), spirv::Scope::Subgroup,

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added a comment. In D73242#1847051 , @evgeny777 wrote: > > This is an enabler for upcoming enhancements to indirect call promotion, > > for example streamlined promotion guard sequences that compare ag

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1152 + if (Error E = importSeq(ToElementType, ToSizeExpr)) +return std::move(E); martong wrote: > Quuxplusone wrote: > > As the author of [P1155 "More Implicit Move"](https://wg21

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[clang] 601687b - [analyzer] DynamicSize: Remove 'getExtent()' from regions

Author: Charusso Date: 2020-01-30T16:05:18+01:00 New Revision: 601687bf731a33364a7de0ece7acd1c17c9dd60d URL: https://github.com/llvm/llvm-project/commit/601687bf731a33364a7de0ece7acd1c17c9dd60d DIFF: https://github.com/llvm/llvm-project/commit/601687bf731a33364a7de0ece7acd1c17c9dd60d.diff LOG:

[PATCH] D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73551/new/ https://reviews.llvm.org/D73551 _

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1116 + LLVMMatchType<0>, + llvm_i32_ty], +[IntrNoMem]>; missing ImmArg Comment at: llvm/include/llvm/IR/Intri

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG601687bf731a: [analyzer] DynamicSize: Remove 'getExtent()' from regions (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69540?vs=227013&id=241447#toc Repository: rG LLVM Gi

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

f00kat marked 4 inline comments as done. f00kat added a comment. I have changed the code to work with tagDecl. It`s work fine on simple test cases such as typedef enum { ea, eb } EnumT; But not work with #include typedef enum { ea, eb } EnumT; It is not related with new tagDecl matcher

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

f00kat updated this revision to Diff 241448. f00kat added a comment. 1. Apply new tagDecl matcher 2. Trying to fix some bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73090/new/ https://reviews.llvm.org/D73090 Files: clang-tools-extra/clang-t

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 241449. njames93 added a comment. - Aggressive dependent lookup option added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugp

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev added a comment. @ABataev, do you have any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62329 tests passed, 0 failed and 838 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[clang] af3d0d1 - [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Author: Charusso Date: 2020-01-30T16:51:48+01:00 New Revision: af3d0d16286aecdd19356a3505d4a87f54a2f7e9 URL: https://github.com/llvm/llvm-project/commit/af3d0d16286aecdd19356a3505d4a87f54a2f7e9 DIFF: https://github.com/llvm/llvm-project/commit/af3d0d16286aecdd19356a3505d4a87f54a2f7e9.diff LOG:

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin added a comment. We could do that for loads. For example on Mips32r5 (where we need most instructions) for intrinsic **ldr_d** instead of: lwr $1, 16($5) lwl $1, 19($5) lwr $2, 20($5) lwl $2, 23($5) fill.w $w0, $1 insert

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3d0d16286a: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69599?vs=227546&id=241460#toc Repository: rG L

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 241459. njames93 added a comment. - Fix clang tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdent

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso abandoned this revision. Charusso marked an inline comment as done. Charusso added a comment. Let us say, we do not need this patch. In case we would need it, I will reopen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726

[clang] 38ab3b8 - [analyzer] CheckerContext: Make the Preprocessor available

Author: Charusso Date: 2020-01-30T17:05:52+01:00 New Revision: 38ab3b876baaa899b92dda9113a4d1d4b56c2e79 URL: https://github.com/llvm/llvm-project/commit/38ab3b876baaa899b92dda9113a4d1d4b56c2e79 DIFF: https://github.com/llvm/llvm-project/commit/38ab3b876baaa899b92dda9113a4d1d4b56c2e79.diff LOG:

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62329 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73715: - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/.clang-tidy:23 + - key: readability-identifier-naming.IgnoreMainLikeFunctions +value: 1 Although identifier-naming is disabled, its still a g

[PATCH] D73715: - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

njames93 created this revision. njames93 added reviewers: alexfh, hokein. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/.clang-tidy:23

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

This revision was automatically updated to reflect the committed changes. Closed by commit rG38ab3b876baa: [analyzer] CheckerContext: Make the Preprocessor available (authored by Charusso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69731/new/ ht

[clang] c53cb2b - [Clang][Bundler] Reduce fat object size

Author: Sergey Dmitriev Date: 2020-01-30T08:21:39-08:00 New Revision: c53cb2bdc78ee3d3eec8c30821480b390b0eb145 URL: https://github.com/llvm/llvm-project/commit/c53cb2bdc78ee3d3eec8c30821480b390b0eb145 DIFF: https://github.com/llvm/llvm-project/commit/c53cb2bdc78ee3d3eec8c30821480b390b0eb145.dif

[PATCH] D73715: - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62329 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

This revision was automatically updated to reflect the committed changes. Closed by commit rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 241478. balazske added a comment. Adding a new implementation. Now the conditions itself are checked, not the constraints. The appearance of the value to check is detected and tested if it is inside an error check-looking construct. The location of the error

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. In D70172#1812749 , @rjmccall wrote: > In D70172#1812664 , @yaxunl wrote: > > > In D70172#1812631 , @rjmccall > > wrote: > > > > > Most uses of the d

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio updated this revision to Diff 241477. dnsampaio added a comment. - Do not generate special volatile access if the record alignment is smaller than the bit-field declared type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https

[PATCH] D73719: [AArch64][SVE] Add SVE2 intrinsics for widening DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, cameron.mcinally. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: - @ll

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. In addition to the roundtrip test, can you please also add a .bc file test containing a DITemplateTypeParameter / DITemplateValueParameter produced by today's llvm to test the bitcode upgrade code added to MetadataLoader? You'll find examples if you search for .bc files

[clang] 4697874 - [OPENMP50]Handle lastprivate conditionals passed as shared in inner

Author: Alexey Bataev Date: 2020-01-30T11:35:23-05:00 New Revision: 4697874c28eda11ce29266f3c6188280809b6b36 URL: https://github.com/llvm/llvm-project/commit/4697874c28eda11ce29266f3c6188280809b6b36 DIFF: https://github.com/llvm/llvm-project/commit/4697874c28eda11ce29266f3c6188280809b6b36.diff

[PATCH] D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields

dnsampaio updated this revision to Diff 241486. dnsampaio added a comment. - Added flag to allow user to opt-in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67399/new/ https://reviews.llvm.org/D67399 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

sberg updated this revision to Diff 241485. sberg added a comment. Minimal reproducer is template struct S; template void operator <=>(S, S); template void f(T x) { decltype(x <=> x) v; } Added a corresponding test to clang/test/SemaCXX/cxx2a-three-way-comparison.cpp. CHANGES SINCE LAST

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15201 +namespace { +class LocatorChecker final : public StmtVisitor { + OMPClauseMappableExprCommon::MappableExprComponentList Components; Seems to me, you're skipping many expressions, whi

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Container operations such as `push_back()`, `po

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao added a comment. + rsmith Comment at: clang/lib/AST/Decl.cpp:1416-1417 return getLVForClosure( - OuterMostLambda->getDeclContext()->getRedeclContext(), - OuterMostLambda->getLambdaContextDecl(), computation); + R

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert, hfinkel. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. With OpenMP offloading host compilation is done in two phases to capture host IR that is passed to all device compilations as in

[clang-tools-extra] 3ae11b4 - [NFC] small refactor on RenamerClangTidyCheck.cpp

Author: Nathan James Date: 2020-01-30T17:32:06Z New Revision: 3ae11b42818363f70b3c6b0246bb617e35709c58 URL: https://github.com/llvm/llvm-project/commit/3ae11b42818363f70b3c6b0246bb617e35709c58 DIFF: https://github.com/llvm/llvm-project/commit/3ae11b42818363f70b3c6b0246bb617e35709c58.diff LOG:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 241492. Charusso marked 8 inline comments as done. Charusso added a comment. - Change to 4-column space standard. - Simplify obtaining the Clang include directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D6

[PATCH] D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. I'm happy with this change since it's opt-in. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67399/new/ https://reviews.llvm.org/D67399

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added a comment. Thanks for the reviews! Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; NoQ wrote: > I'll be perfectly happy with removin

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 241493. Charusso edited the summary of this revision. Charusso added a comment. - Rename the script from `check_analyzer_fixit.py` to `check-analyzer-fixit.py` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Default args might exist but be unparsed or uninstantiated. getDefaultArg asserts on those. This patch ma

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

rjmccall added a comment. Is there no follow-up code when actually emitting the failure diagnostic which tries to figure out a more specific cause of failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360 ___

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73721/new/ https://reviews.llvm.org/D73721 ___

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17183 + class DeferredDiagnosticsEmitter + : public EvaluatedExprVisitor { +Sema &S; Is there any way to share most of the visitation logic here with the visitor we use in `MarkDec

[clang] 36bfdb7 - [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

Author: Sergey Dmitriev Date: 2020-01-30T10:16:41-08:00 New Revision: 36bfdb7096cfe1925448e408ec72f1a6bdc4cd2c URL: https://github.com/llvm/llvm-project/commit/36bfdb7096cfe1925448e408ec72f1a6bdc4cd2c DIFF: https://github.com/llvm/llvm-project/commit/36bfdb7096cfe1925448e408ec72f1a6bdc4cd2c.dif

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bfdb7096cf: [Clang][Driver] Disable llvm passes for the first host OpenMP offload… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik updated this revision to Diff 241508. shafik marked 4 inline comments as done. shafik added a comment. Address comments by not special casing the `___Z` case, this requires setting both the Name and Linkage name because DWARF requires subroutines to have a `DW_AT_name`. We discovered this

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); dbl

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D69746: [analyzer] FixItHint:

[clang] c83d9be - [Concept] Fix incorrect check for containsUnexpandedParameterPack in CSE

Author: Saar Raz Date: 2020-01-30T20:45:44+02:00 New Revision: c83d9bedc0cc430dc620e7a807daeb985d390325 URL: https://github.com/llvm/llvm-project/commit/c83d9bedc0cc430dc620e7a807daeb985d390325 DIFF: https://github.com/llvm/llvm-project/commit/c83d9bedc0cc430dc620e7a807daeb985d390325.diff LOG:

[clang] a424ef9 - [Concepts] Add check for dependent RC when checking function constraints

Author: Saar Raz Date: 2020-01-30T20:46:32+02:00 New Revision: a424ef99e7b9821ec80564af3d3a8f091323a38c URL: https://github.com/llvm/llvm-project/commit/a424ef99e7b9821ec80564af3d3a8f091323a38c DIFF: https://github.com/llvm/llvm-project/commit/a424ef99e7b9821ec80564af3d3a8f091323a38c.diff LOG:

[clang] 60f5da7 - [Concepts] Add 'this' context to instantiation of member requires clause

Author: Saar Raz Date: 2020-01-30T20:47:59+02:00 New Revision: 60f5da79e3de49b2074446e656a72970499a8d78 URL: https://github.com/llvm/llvm-project/commit/60f5da79e3de49b2074446e656a72970499a8d78 DIFF: https://github.com/llvm/llvm-project/commit/60f5da79e3de49b2074446e656a72970499a8d78.diff LOG:

  1   2   >