[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240110. serge-sans-paille added a comment. Formatting nits + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineRefere

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 240111. balazske added a comment. Using check::DeadSymbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files: clang/include/clang/StaticAnalyzer/Checkers/Checke

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62153 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62155 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1804 // "&

[PATCH] D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1804 // "&&(" is quite unlikely to be two successive unary "&". -if (Tok.is(tok::ampamp) && NextToken && NextToken->is(tok::l_paren)) +if (Tok

[clang] c83602f - Recommit "[DWARF5][clang]: Added support for DebugInfo generation for auto return type for C++ member functions."

Author: Awanish Pandey Date: 2020-01-24T14:50:17+05:30 New Revision: c83602fdf51b2692e3bacb06bf861f20f74e987f URL: https://github.com/llvm/llvm-project/commit/c83602fdf51b2692e3bacb06bf861f20f74e987f DIFF: https://github.com/llvm/llvm-project/commit/c83602fdf51b2692e3bacb06bf861f20f74e987f.diff

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

sammccall updated this revision to Diff 240121. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73218/new/ https://reviews.llvm.org/D73218 Files: clang-tools-e

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:383 + +llvm::json::Value toJSON(const WorkDoneProgressBegin &P) { + llvm::json::Object Result{ kadircet wrote: > why not have a single struct with that has a required `kind` fiel

[PATCH] D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62136 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D67537: [clangd] Client-side support for inactive regions

hokein added a comment. > Do you mean naming the scope something like `clangd.meta.disable` to make it > clear it's a clangd extension? > > (In that case, we might as well make it something more descriptive, like > `clangd.preprocessor.inactive`. `meta` doesn't convey much information.) yes, t

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 8 errors and 12 warnings . 12 of them are added as revi

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin marked 2 inline comments as done. aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/reference-types.ll:4 +; This currently only tests if the command line argument for reference types +; feature is accepted by llc. + sbc100 wrote: >

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240124. aheejin marked an inline comment as done. aheejin added a comment. - Test target feature section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240125. aheejin added a comment. - Remove a stray attribute number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebAssembly.cpp cl

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

awpandey updated this revision to Diff 240122. awpandey marked 29 inline comments as done. awpandey added a comment. Hi @probinson, I have changed the patch according to your comments. Is it necessary to use DIFlags? I am willing to do that but generally, it is not welcomed because we have a lim

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

gribozavr2 added a reviewer: gribozavr2. gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.h:9 +/// +/// \file This file declares clang-tidy tool main

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240127. aheejin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebAssembly.cpp clang/lib/Basic/Targets/WebAs

[clang] b3b68c0 - [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.

Author: Sam McCall Date: 2020-01-24T11:03:46+01:00 New Revision: b3b68c0f802ebd9892f66bec0e7be96b3fb06e86 URL: https://github.com/llvm/llvm-project/commit/b3b68c0f802ebd9892f66bec0e7be96b3fb06e86 DIFF: https://github.com/llvm/llvm-project/commit/b3b68c0f802ebd9892f66bec0e7be96b3fb06e86.diff LO

[PATCH] D73320: [WebAssembly] Add reference types target feature

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62151 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73320: [WebAssembly] Add reference types target feature

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62151 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73334: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b68c0f802e: [Format] Fix 'auto x(T&&, T &&)->F' with PAS_Left. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73334/new/ https://r

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

nsz added a comment. In D7#1837536 , @MaskRay wrote: > A -DLLVM_ENABLE_ASSERTIONS=on build is required to trigger the assertion > failure. My `make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- HOSTGCC=gcc > CC=~/llvm/ReleaseAssert/bin/clang LD=~/llvm/

[clang] 326c39b - [clang][NFC] Remove redundant cast

Author: Raphael Isemann Date: 2020-01-24T11:07:33+01:00 New Revision: 326c39b569e385b35cc117a31a3b20919c799352 URL: https://github.com/llvm/llvm-project/commit/326c39b569e385b35cc117a31a3b20919c799352 DIFF: https://github.com/llvm/llvm-project/commit/326c39b569e385b35cc117a31a3b20919c799352.dif

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:84 + if (llvm::none_of(Files, [](const auto &KV) { +return llvm::StringRef(KV.second).contains("error-ok"); + })) { ---

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.cpp:383 + +llvm::json::Value toJSON(const WorkDoneProgressBegin &P) { + llvm::json::Object Result{ sam

[PATCH] D73320: [WebAssembly] Add reference types target feature

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62156 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3260bf5b2f7: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D73199?vs=239594&id=240129#toc Re

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240130. aheejin added a comment. Herald added a subscriber: jfb. Fix test comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebA

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin updated this revision to Diff 240132. aheejin added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. rebase + test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://reviews.

[PATCH] D73320: [WebAssembly] Add reference types target feature

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62156 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. clang-format currently always wraps the body of non-empty arrow functions: const x = () => { z(); }; This change implements support for the `AllowShortLambdasOnASingleLine` style options, an

[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently 🡺 is used in hover response to represent return types, but it is not widely available. Changi

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62155 tests passed, 6 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. I am still unsure about how this checker works if the function to check is "modeled" or evaluated by another checker. Then the function may have already a constrained value at the PostCall event (for example if a `malloc` fails) and the basic idea of this checker that

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst added a comment. FYI I've started a conversation on whether `SLS_All` should be the default Google style. But the option I think is useful in either case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73335/new/ https://reviews.llvm.org/D7

[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62133 tests passed, 5 failed and 807 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73097: [AArch64][SVE] Add intrinsics for FFR manipulation

kmclaughlin added a comment. Thanks for your input on this @efriedma, I will submit this patch for now and we will revisit the modelling of the FFR as also discussed in D71698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D73097: [AArch64][SVE] Add intrinsics for FFR manipulation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c4861b577cb: [AArch64][SVE] Add intrinsics for FFR manipulation (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73097/new/ https:/

[clang-tools-extra] 7d20e80 - [clangd] Show background index status using LSP 3.15 work-done progress notifications

Author: Sam McCall Date: 2020-01-24T12:21:08+01:00 New Revision: 7d20e80225b3e4f3f5a8c57929061bef55f3d855 URL: https://github.com/llvm/llvm-project/commit/7d20e80225b3e4f3f5a8c57929061bef55f3d855 DIFF: https://github.com/llvm/llvm-project/commit/7d20e80225b3e4f3f5a8c57929061bef55f3d855.diff LO

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d20e80225b3: [clangd] Show background index status using LSP 3.15 work-done progress… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] ba545c8 - [Sema] Try 2: Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

Author: Roman Lebedev Date: 2020-01-24T14:42:45+03:00 New Revision: ba545c814bc19c3b1ec9ce88a7f13575e0e4ce1d URL: https://github.com/llvm/llvm-project/commit/ba545c814bc19c3b1ec9ce88a7f13575e0e4ce1d DIFF: https://github.com/llvm/llvm-project/commit/ba545c814bc19c3b1ec9ce88a7f13575e0e4ce1d.diff

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

This revision was automatically updated to reflect the committed changes. Closed by commit rGba545c814bc1: [Sema] Try 2: Attempt to perform call-size-specific `__attribute__((alloc_align… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

gchatelet updated this revision to Diff 240148. gchatelet added a comment. - rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGObjCMac.c

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

This revision was automatically updated to reflect the committed changes. Closed by commit rG805c157e8aee: [Alignment][NFC] Deprecate Align::None() (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llv

[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b996faa1575: [clangd][Hover] Change arrow in return type back to → (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73336/new/ https:/

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/263 Repository: rG LLVM Github Monorepo https

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. Could you merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:22 + +/// This represents an abstract memory location that is used in the lifetime +/// contract representation. gribozavr2 wrote: >

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaron.ballman added a comment. In D73007#1837621 , @rtrieu wrote: > I'm in favor of splitting the warning into subgroups, then deciding which > ones should be in -Wall. We've done this with other warnings such as the > conversion warnings and tautologic

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. In D72906#1837905 , @craig.topper wrote: > In D72906#1826849 , @uweigand wrote: > > > In D72906#1826122 , @craig.topper > > wrote: > > > > > In D7

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + "constrained mode"); +FMulAdd = Builder.CreateCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, craig.topper wrote: > Doesn't this

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

njames93 updated this revision to Diff 240163. njames93 added a comment. - Small edge case tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73203/new/ https://reviews.llvm.org/D73203 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticCons

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This reflects its current function better and avoids confusion with clang::Diagn

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

sammccall updated this revision to Diff 240165. sammccall added a comment. Document new interface and threading model of existing functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73346/new/ https://reviews.llvm.org/D73346 Files: clang-to

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added a comment. > Is it necessary to use DIFlags? I am willing to do that but generally, it is > not welcomed because we have a limited number of DIFlags and most of them are > currently in use. Are there any flags within `DIFlags` that could be applied only to functions? If so, we s

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can you file a new bug or modify the upstream one to audit existing uses of getTemplateInstantiationPattern() (and maybe related functions)? getSpecializedTemplate() is used with no null

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62126 tests passed, 5 failed and 807 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73335: clang-format: [JS] options for arrow functions.

krasimir added a comment. > FYI I've started a conversation on whether SLS_All should be the default > Google style. But the option I think is useful in either case. If that's the case, consider adding the option to the style in a follow-up patch: GoogleStyle.AllowShortLambdasOnASingleLine =

[PATCH] D73347: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic

kmclaughlin created this revision. kmclaughlin added reviewers: dancgr, efriedma, sdesmalen, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Implements the following intrinsics: - addp - smaxp, sminp, umaxp & uminp - sadalp &

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62158 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.h:76 +/// May be called concurrently for separate files, not for a single file. +virtual void onFileUpdated(Path

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62158 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72467: Remove "mask" operand from shufflevector.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM, but should get a 2nd opinion since I'm not familiar with some of the parts. Also, please update the related LangRef text for shufflevector in or alongside this patch. Could add some asc

[clang] 0a002f6 - [Sema] Try 2: Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

Author: Roman Lebedev Date: 2020-01-24T16:56:39+03:00 New Revision: 0a002f679be4a9d363e6f21b707493c18158930b URL: https://github.com/llvm/llvm-project/commit/0a002f679be4a9d363e6f21b707493c18158930b DIFF: https://github.com/llvm/llvm-project/commit/0a002f679be4a9d363e6f21b707493c18158930b.diff

[PATCH] D72994: [Sema] Sanity-check alignment requested via `__attribute__((assume_aligned(imm)))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a002f679be4: [Sema] Try 2: Sanity-check alignment requested via `__attribute__… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7299

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7711-7713 +isa(Next->getAssociatedExpression()) || +isa(Next->getAssociatedExpression()) || +isa(Next->getAssociatedExpression())) &&

[clang] 1d0972f - [Sema] Introduce MaximumAlignment value, to be used instead of magical constants

Author: Roman Lebedev Date: 2020-01-24T17:49:17+03:00 New Revision: 1d0972ff5eab544579c400ee674d5c9c60391ee1 URL: https://github.com/llvm/llvm-project/commit/1d0972ff5eab544579c400ee674d5c9c60391ee1 DIFF: https://github.com/llvm/llvm-project/commit/1d0972ff5eab544579c400ee674d5c9c60391ee1.diff

[PATCH] D73350: Small StreamChecker refactoring (NFC).

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73350 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp Index: clang/lib/StaticAnalyzer

[PATCH] D72467: Remove "mask" operand from shufflevector.

sdesmalen added a comment. Thanks @efriedma for working on this. The overall approach seems good to me! Mostly added some nits, with the exception of one question on what to do with a shufflevector with fixed-width mask and scalable source vectors. Comment at: llvm/include/llv

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

probinson added a comment. In D73261#1838552 , @djtodoro wrote: > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > is not welcomed because we have a limited number of DIFlags and most of > > them are currently in use. > > A

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:76 +/// May be called concurrently for separate files, not for a single file. +virtual void onFileUpdated(PathRef File, const TUStatus &Status)

[clang-tools-extra] 6ef1cce - [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

Author: Sam McCall Date: 2020-01-24T15:59:32+01:00 New Revision: 6ef1ccecf7aea94fb38fc8d891f0097829b9228e URL: https://github.com/llvm/llvm-project/commit/6ef1ccecf7aea94fb38fc8d891f0097829b9228e DIFF: https://github.com/llvm/llvm-project/commit/6ef1ccecf7aea94fb38fc8d891f0097829b9228e.diff LO

[PATCH] D73346: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it optional

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG6ef1ccecf7ae: [clangd] Rename DiagnosticsConsumer -> ClangdServer::Callbacks, and make it… (authored by sammccall). Changed prior to commit: https://reviews.l

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added a comment. I agree, we must pay attention and address the bitcode compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.org/D73261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 76fa5d5 - [clangd] Remove pesky ;. NFC

Author: Sam McCall Date: 2020-01-24T16:12:00+01:00 New Revision: 76fa5d50f3d18cc159afe3206e4d69721ae7db07 URL: https://github.com/llvm/llvm-project/commit/76fa5d50f3d18cc159afe3206e4d69721ae7db07 DIFF: https://github.com/llvm/llvm-project/commit/76fa5d50f3d18cc159afe3206e4d69721ae7db07.diff LO

[clang] a8c3608 - [Sema] Provide declarations for MaximumAlignment, MaxAlignmentExponent variables

Author: Roman Lebedev Date: 2020-01-24T18:18:15+03:00 New Revision: a8c3608a27a82cf1c66f33b96a06423fe0e708fc URL: https://github.com/llvm/llvm-project/commit/a8c3608a27a82cf1c66f33b96a06423fe0e708fc DIFF: https://github.com/llvm/llvm-project/commit/a8c3608a27a82cf1c66f33b96a06423fe0e708fc.diff

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/LangOptions.def clang/in

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

davezarzycki added a comment. I understand not wanting to have trivial dependencies on IR for values like this, but what about creating `llvm/Support/InternalLimits.h` to hold values like this, and then *either* have `llvm::Value::MaximumAlignment` derive from the constant in the new file, or `

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst created this revision. mprobst added reviewers: krasimir, MyDeveloperDay. Herald added a project: clang. This change adds an option to insert trailing commas into container literals. For example, in JavaScript: const x = [ a, b, ^ inserted if missing. ] This is imple

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst added a comment. This is required by JavaScript style, but this change as is optimistically runs the tool for any language. I think that's probably not what we want here initially, just throwing it out there. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware updated this revision to Diff 240192. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ https://reviews.llvm.org/D73270 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:186 +} + } + gribozavr2 wrote: > baloghadamsoftware wrote: > > gribozavr2 wrote: > > > I th

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240194. mprobst added a comment. - - only run comma insertion for JavaScript. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354 Files: clang/include/clang/Format/Format

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware updated this revision to Diff 240195. baloghadamsoftware added a comment. Minor fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ https://reviews.llvm.org/D73270 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test

[clang] 80fd37f - [analyzer] PthreadLock: Fix return value modeling for XNU lock functions.

Author: Artem Dergachev Date: 2020-01-24T18:43:23+03:00 New Revision: 80fd37f9d66e49994eb06e2613a29a6d7016df6d URL: https://github.com/llvm/llvm-project/commit/80fd37f9d66e49994eb06e2613a29a6d7016df6d DIFF: https://github.com/llvm/llvm-project/commit/80fd37f9d66e49994eb06e2613a29a6d7016df6d.dif

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. Actually there's an issue with the code. It doesn't compile in shared_library mode. ld.lld: error: undefined symbol: clang::Sema::MaximumAlignment >>> referenced by SemaChecking.cpp:5397 (/redacted/llvm-project/clang/lib/Sema/SemaChecking.cpp:5397) >>>

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 240196. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://reviews.llvm.org/D73020 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExprCX

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri added a comment. In D72998#1838760 , @davezarzycki wrote: > I understand not wanting to have trivial dependencies on IR for values like > this, but what about creating `llvm/Support/InternalLimits.h` to hold values > like this, and then *eith

[PATCH] D37806: [analyzer] PthreadLock: Fix return values of XNU lock functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG80fd37f9d66e: [analyzer] PthreadLock: Fix return value modeling for XNU lock functions. (authored by dergachev.a). Herald added subscribers: Charusso, dkrupp, donat.nagy, jfb, Szelethus, mikhail.ramalho,

[PATCH] D37812: [analyzer] PthreadLock: Escape the pointers.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdd22be1e3d98: [analyzer] PthreadLock: Implement mutex escaping. (authored by dergachev.a). Herald added subscribers: Charu

[PATCH] D37963: [analyzer] PthreadLock: Don't track dead regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1484d0f12add: [analyzer] PthreadLock: Implement dead region cleanup. (authored by dergachev.a). Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, rnkovacs, szepet, balogh

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

lebedev.ri added a comment. In D72998#1838811 , @gchatelet wrote: > Actually there's an issue with the code. It doesn't compile in shared_library > mode. > >ld.lld: error: undefined symbol: clang::Sema::MaximumAlignment > >>> referenced by SemaCheck

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. In D72998#1838834 , @lebedev.ri wrote: > Is that still an issue after a8c3608a27a82cf1c66f33b96a06423fe0e708fc > ? > http://lab.llvm.org:8011/builders/clang-

[PATCH] D73354: clang-format: insert trailing commas into containers.

krasimir added a comment. General comment: I think this is useful and could also be useful for other languages too (some folks have asked for this for some C++ code). As this is a non-whitespace only change, it's a bit more risky than whitespace-only changes. I think we need to establish a pol

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst updated this revision to Diff 240202. mprobst added a comment. - Disable arrow functions on single lines by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73335/new/ https://reviews.llvm.org/D73335 Files: clang/lib/Format/Format.

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62174 tests passed, 5 failed and 813 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst added a comment. > If that's the case, consider adding the option to the style in a follow-up > patch: > > GoogleStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; > > > that would have an advantage of making clear which test case diffs are result > of the implementatio

[PATCH] D73356: [ARM,MVE] Add intrinsics for vdupq.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. The unpredicated case of this is trivial: the clang codegen just makes a v

  1   2   3   >