[clang] 82923c7 - [analyzer] Add Fuchsia Handle checker

Author: Gabor Horvath Date: 2019-12-20T12:33:16-08:00 New Revision: 82923c71efa57600d015dbc281202941d3d64dde URL: https://github.com/llvm/llvm-project/commit/82923c71efa57600d015dbc281202941d3d64dde DIFF: https://github.com/llvm/llvm-project/commit/82923c71efa57600d015dbc281202941d3d64dde.diff

[PATCH] D69876: Allow output constraints on "asm goto"

void marked an inline comment as done. void added inline comments. Comment at: clang/test/CodeGen/asm-goto.c:91 + return 1; +} nickdesaulniers wrote: > Thanks for adding this test. I think it doesn't test that `addr` is > *clobbered* though? The `+` modifier i

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. I've gone ahead and landed the patch so that we can iterate in tree. See commit 14fc20ca62821b5f85582bf76a467d412248c248 . I've also landed a couple of follow up patches to address issues which would

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

This revision was automatically updated to reflect the committed changes. xazax.hun marked 2 inline comments as done. Closed by commit rG82923c71efa5: [analyzer] Add Fuchsia Handle checker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70470?vs=233691&id=234948#toc

[clang] 59878ec - [analyzer] Add path notes to FuchsiaHandleCheck.

Author: Gabor Horvath Date: 2019-12-20T12:40:41-08:00 New Revision: 59878ec8092bef656a71d22261fd3b70651e8318 URL: https://github.com/llvm/llvm-project/commit/59878ec8092bef656a71d22261fd3b70651e8318 DIFF: https://github.com/llvm/llvm-project/commit/59878ec8092bef656a71d22261fd3b70651e8318.diff

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) + return true; So

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234950. ABataev added a comment. Removed check for isArrow() + added requested test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/Op

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG59878ec8092b: [analyzer] Add path notes to FuchsiaHandleCheck. (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70725?vs=231996&id=234952#toc Repository: rG LLVM Github Mon

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:480 =yes yes yes yes -:? yes -- -- -- +:?[*]_ yes -- yes -- sizeo

[clang] 44b4b83 - Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

Author: Adrian Prantl Date: 2019-12-20T13:11:17-08:00 New Revision: 44b4b833ad76fc61e43473c581a557f72a4ed8f4 URL: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4 DIFF: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4.diff

[clang] 494b131 - Customize simplified dumping and matching of LambdaExpr

Author: Stephen Kelly Date: 2019-12-20T21:13:23Z New Revision: 494b1318ca77927e919bbf9a61749a58553d738c URL: https://github.com/llvm/llvm-project/commit/494b1318ca77927e919bbf9a61749a58553d738c DIFF: https://github.com/llvm/llvm-project/commit/494b1318ca77927e919bbf9a61749a58553d738c.diff LOG:

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61072 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

thakis added a comment. Looks like this might break tests: http://45.33.8.238/linux/6150/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71680/new/ https://reviews.llvm.org/D71680 ___ cfe-comm

[PATCH] D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rG44b4b833ad76: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG494b1318ca77: Customize simplified dumping and matching of LambdaExpr (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71680?vs=234636&id=234968#toc Repository: rG LLVM

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 234966. herzka added a comment. Herald added a reviewer: jdoerfert. change flags in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files: clang/lib/Frontend/Com

[clang] 0378f3a - Revert "Customize simplified dumping and matching of LambdaExpr"

Author: Stephen Kelly Date: 2019-12-20T21:33:31Z New Revision: 0378f3a90341d990236c44f297b923a32b35fab1 URL: https://github.com/llvm/llvm-project/commit/0378f3a90341d990236c44f297b923a32b35fab1 DIFF: https://github.com/llvm/llvm-project/commit/0378f3a90341d990236c44f297b923a32b35fab1.diff LOG:

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234972. sylvestre.ledru added a comment. alias => aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-tidy/checks/list

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech marked 4 inline comments as done. jranieri-grammatech added inline comments. Comment at: clang/test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:35-36 +{ + int løçål = 0; + /* ☃ */ return 1 / løçål; // expected-warning {{Division by zero}} +} -

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech updated this revision to Diff 234971. jranieri-grammatech added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70689/new/ https://reviews.llvm.org/D70689 Files: clang/lib/StaticAnalyzer/Co

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

rsmith added a comment. This seems reasonable to me, and matches GCC 10's behavior; `$` is not in the basic source character set, so encoding it with a UCN should be permitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71758/new/ https://revie

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane marked 13 inline comments as done. erichkeane added a comment. New patch coming as soon as my build finishes. Comment at: clang/docs/LanguageExtensions.rst:480 =yes yes yes yes -:? yes --

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc added a comment. Any further feedback or thoughts on this? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70270/new/ https://reviews.llvm.org/D70270 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 234976. poelmanc added a comment. Address most of the feedback, I'll comment individually. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 Files: clang-tools-extra/cl

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1, hasNoSch

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane updated this revision to Diff 234977. erichkeane marked 4 inline comments as done. erichkeane added a comment. @aaron.ballman s comments done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 Files: clang/docs/LanguageExtensions.rst

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. @rsmith Could you take a look at this patch when you have some time? This is the last C++17 sequencing rule which is missing from `SequenceChecker` and is very similar to the other already accepted patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want vsk wrote: >

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

efriedma added a comment. > and it seems to involve a lot of AST traversal I was thinking we'd just call into SemaChecking in appropriate places. I guess there's a little AST traversal to figure whether an expression forms an array address. Your idea seems simpler. > remove elements from the

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Herald added a subscriber: arichardson. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-comm

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. @MaskRay I will mail you off-list with one question. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list c

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

leonardchan added a comment. Hi! This seems to be causing some test failures on our bots: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8893521019883752048 : 'RUN: at line 553'; /b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/clang -### -target hexagon-unknown-el

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2068-2069 if (ParseAsmAttributesAfterDeclarator(D)) return nullptr; rsmith wrote: > We should check with GCC to see which side of the requires-clause they expect > this. > > F

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added a comment. In D70157#1793280 , @reames wrote: > I've gone ahead and landed the patch so that we can iterate in tree. See > commit 14fc20ca62821b5f85582bf76a467d412248c248 >

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

xazax.hun created this revision. xazax.hun added reviewers: Szelethus, NoQ. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, rnkovacs. The branches protecting the static initializers have a `DeclStmt` as last `Stmt`. Since it is not an expressi

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

Charusso added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5923 + if (isa(Cond) || isa(Cond)) return nullptr; What about the following?: ```lang=c if (const auto *E = dyn_cast(StmtElem->getStmt())) return E->IgnoreParens(); return nullptr; `

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[clang] bab67ba - fix a doc typo to cycle bots

Author: Nico Weber Date: 2019-12-20T21:39:01-05:00 New Revision: bab67ba6a3c451fbadd6b8b38c5043ef7e316d56 URL: https://github.com/llvm/llvm-project/commit/bab67ba6a3c451fbadd6b8b38c5043ef7e316d56 DIFF: https://github.com/llvm/llvm-project/commit/bab67ba6a3c451fbadd6b8b38c5043ef7e316d56.diff LO

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

annita.zhang added a comment. In D70157#1793280 , @reames wrote: > I've gone ahead and landed the patch so that we can iterate in tree. See > commit 14fc20ca62821b5f85582bf76a467d412248c248 >

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks, Vlad! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234998. 0x8000- added a comment. Add a test file for expected failures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp clang-

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:9 +{ + if (((int)4) > ProcessSomething(10)) + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: 4 is a magic nu

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov added a comment. @NoQ Could you commit, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71746/new/ https://reviews.llvm.org/D71746 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. > Will it make sense to say "I don't want hyper-threads" ? Not sure I remember correctly, but I believe one motivation behind avoiding "hyper-threads" and other virtual cores was that while they improve slightly the performance, they also increase the peak memory re

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. Also: using heavyweight_hardware_concurrency() in the linker but having multiple linker jobs schedules by the build system was another reason (I think LLVM CMake default to 2 parallel link jobs when using ThinLTO for instance). Repository: rG LLVM Github Monorepo

<    1   2