[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet planned changes to this revision. courbet added a comment. I'm going to remove the `&&` warning from the check and keep only the `const` one, as I think these is a consensus on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet added a comment. In D70390#1751751 , @Quuxplusone wrote: > that sounds like a big non-local change whose correctness would be very > difficult to verify. Agreed. That's why I did not make this check suggest a fixit, because it's too easy to cli

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet updated this revision to Diff 230202. courbet added a comment. Remove && warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal &Val) { if (auto Reg = Val.getAsRegion()) { Reg = Reg->getMostDerivedObjectRegion(); -

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1f95a6e077: Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag" (authored by djtodoro). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Git

[clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

Author: Djordje Todorovic Date: 2019-11-20T10:08:07+01:00 New Revision: ce1f95a6e077693f93d8869245f911aff3eb7e4c URL: https://github.com/llvm/llvm-project/commit/ce1f95a6e077693f93d8869245f911aff3eb7e4c DIFF: https://github.com/llvm/llvm-project/commit/ce1f95a6e077693f93d8869245f911aff3eb7e4c.d

[PATCH] D70441: [clangd] Speed up when building rename edit.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:54 +/// Use of UTF-16 may be overridden by kCurrentOffsetEncoding. +llvm::Expected byteOffset(StringRef LineCode, int LSPCharacter); + How this is different from `positionToOff

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Previously, xrefs has inconsistent behavior when the reference is inside macro body: - AST-based xrefs (for main file) us

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet updated this revision to Diff 230211. kadircet marked 4 inline comments as done. kadircet added a comment. - Add support for non-namespace decl contexts. - Add an overload for "textual namespace" handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60164 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet updated this revision to Diff 230213. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments - Rebase - Get rid of string literals inside macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69033/new/ http

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:196 //~ -> we need to qualify Bar not x. -if (!ND->getDeclContext()->isNamespace()) +if (!ND->getLexicalDeclContext()->isNamespace()) retu

[PATCH] D70481: [clangd] Fix a crash in expected types

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70481 Files: clang-tools-extra/clangd/ExpectedTypes.cpp

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:201 +std::tie(StateRetNotNull, StateRetNull) = +CM.assumeDual(StateStreamNull, RetVal); +if (StateRetNull) {

[PATCH] D70481: [clangd] Fix a crash in expected types

merge_guards_bot added a comment. Build result: pass - 60077 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

simon_tatham created this revision. simon_tatham added reviewers: ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This commit adds the `vpselq` intrinsics which take an MVE predicate word and sele

[clang-tools-extra] e18ab2a - [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

Author: Sam McCall Date: 2019-11-20T13:06:57+01:00 New Revision: e18ab2a0b801e75ee39bb8ba30584c69b4c6e577 URL: https://github.com/llvm/llvm-project/commit/e18ab2a0b801e75ee39bb8ba30584c69b4c6e577 DIFF: https://github.com/llvm/llvm-project/commit/e18ab2a0b801e75ee39bb8ba30584c69b4c6e577.diff LO

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 230249. hokein marked 3 inline comments as done. hokein added a comment. add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 Files: clang-tools-extra/clang

[PATCH] D50147: clang-format: support external styles

sammccall added a comment. In D50147#1751198 , @Typz wrote: > >> In our case, we actually have more than one "standard" style, a > >> combination of various OS (linux, windows, macos), and not a very strong > >> control on user computers. So we cannot re

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainFileID()

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10076 +def warn_sycl_kernel_num_of_template_params : Warning< + "'sycl_kernel' attribute only applies to template functions with at least" + " two template parameters">, InGroup; -

[PATCH] D70441: [clangd] Speed up when building rename edit.

hokein updated this revision to Diff 230242. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70441/new/ https://reviews.llvm.org/D70

[PATCH] D70481: [clangd] Fix a crash in expected types

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70481/new/ https://reviews.llvm.org/D70481 ___

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

baloghadamsoftware marked an inline comment as done and an inline comment as not done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer created this revision. bkramer added a reviewer: spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. Applies nnan, ninf and nsz. This allows more instructions to be folded away even with no fast math flags, e.g. (int)x * (b ? 1.0 : 0.0) -> b ? x :

[PATCH] D70441: [clangd] Speed up when building rename edit.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:54 +/// Use of UTF-16 may be overridden by kCurrentOffsetEncoding. +llvm::Expected byteOffset(StringRef LineCode, int LSPCharacter); + ilya-biryukov wrote: > How this is different fro

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) +CC1Main = Driver::CC1Main; aganea wrote: > hans wrote: > > Now that we'

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds the references for macros to the SymbolCollector (used for static index). Enabled if `CollectM

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: pass - 60166 tests passed, 0 failed and 730 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60164 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + PP->addPPCallbacks(std::make_unique(PP, this)); +} twarda

[clang] b80e483 - Update tests after change to llvm-cxxfilt's underscore stripping behaviour.

Author: Tim Northover Date: 2019-11-20T13:10:55Z New Revision: b80e483c4205d216f6648d7e217183694fe9a55e URL: https://github.com/llvm/llvm-project/commit/b80e483c4205d216f6648d7e217183694fe9a55e DIFF: https://github.com/llvm/llvm-project/commit/b80e483c4205d216f6648d7e217183694fe9a55e.diff LOG:

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer updated this revision to Diff 230245. bkramer added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/ https://reviews.llvm.org/D70488 Files: clang/test/CodeGen/builtins-systemz-zvector.c llvm/lib/Transfo

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Can you rebase it and add a release note in docs/ReleaseNote.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14382 + verifyFormat("if ( !a )\n return;", Spaces); + verifyFormat("if ( a )\n return;", Spaces); + verifyFormat("if constexpr ( a )\n return;", Spaces); show "else if"

[clang] e23d6f3 - NeonEmitter: remove special case on casting polymorphic builtins.

Author: Tim Northover Date: 2019-11-20T13:20:02Z New Revision: e23d6f3184d365a9e72a67870d98e80f998d URL: https://github.com/llvm/llvm-project/commit/e23d6f3184d365a9e72a67870d98e80f998d DIFF: https://github.com/llvm/llvm-project/commit/e23d6f3184d365a9e72a67870d98e80f998d.diff LOG:

[PATCH] D50147: clang-format: support external styles

MyDeveloperDay added a comment. I tend to agree, I'm not keen on the silent searching for the files.. this happens too much as it is, with Microsoft releasing VisualStudio with a clang-format.exe (v5.0), I suddenly find that binary is in my path, then all of a sudden all the 5.0 bugs we fixed

[PATCH] D70441: [clangd] Speed up when building rename edit.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:453 + auto Offset = [&](const Position &P) -> llvm::Expected { +Position Shifted = { +

[PATCH] D70489: [clangd] Add xref for macro to static index.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374 +Roles & static_cast(index::SymbolRole::Definition) || +Roles & static_cast(index::SymbolRole::Reference))) return true; I think we should avoid

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

kadircet added a comment. also could you rename the revision so that it reflects the fact that, this is a change to clang-format and has nothing to do with clang-tidy ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.o

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

kadircet added a comment. The changes are not directly related to clang-tidy, so could you get rid of that clang-tidy some-checker-specific tests and put some unittests into clang/unittests/Format/CleanupTest.cpp ? Comment at: clang/include/clang/Basic/CharInfo.h:196 +/// R

[clang] db73bcd - ARM-NEON: separate soon-to-be conflicting f16 patterns. NFC.

Author: Tim Northover Date: 2019-11-20T13:20:02Z New Revision: db73bcd98ef4ffbe91405a5adfcfdcd83bc007f4 URL: https://github.com/llvm/llvm-project/commit/db73bcd98ef4ffbe91405a5adfcfdcd83bc007f4 DIFF: https://github.com/llvm/llvm-project/commit/db73bcd98ef4ffbe91405a5adfcfdcd83bc007f4.diff LOG:

[PATCH] D70446: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18ab2a0b801: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70144/new/ https://reviews.llvm.org/D70144 _

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14386 + verifyFormat("while ( a )\n return;", Spaces); + verifyFormat("while ( (a && b) )\n return;", Spaces); + verifyFormat("do {\n} while ( 1 != 0 );", Spaces); is thi

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

sammccall added a comment. My apologies if the revert was incorrect. I asked for advice after seeing breakages and heard that llvm-c should be kept ABI compatible. But it looks like that's too strong: https://llvm.org/docs/DeveloperPolicy.html#c-api-changes says we make a best effort to maintai

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

t.p.northover closed this revision. t.p.northover marked 2 inline comments as done. t.p.northover added a comment. Thanks. Pushed it with those suggestions: To github.com:llvm/llvm-project.git c34478f5f6c7..3f91705ca54b master -> master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D70441: [clangd] Speed up when building rename edit.

hokein updated this revision to Diff 230261. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70441/new/ https://reviews.llvm.org/D70441 Files: clang-tools-extra/cla

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:153 + + return HNM.matchesNode(*dyn_cast(D)); +} zturner wrote: > aaron.ballman wrote: > > This should probably use `cast<>` if it's going to assume the re

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Diagnostic locations were broken when it was result of a macro expansion. This patch fixes it by using exp

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Nice, LGTM! Thanks for fixing this in the presence of `CLANG_DEFAULT_RTLIB`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 __

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

aaron.ballman added a comment. In D70411#1750690 , @Charusso wrote: > Somehow the `MallocBugVisitor` is broken in the wild - it does not catch the > allocation, and we need to support a lot more to call it non-alpha (see the > `FIXME`s). I do not want to

[PATCH] D70441: [clangd] Speed up when building rename edit.

hokein updated this revision to Diff 230264. hokein added a comment. update the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70441/new/ https://reviews.llvm.org/D70441 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extr

[clang-tools-extra] b5135a8 - [clangd] Fix a crash in expected types

Author: Ilya Biryukov Date: 2019-11-20T16:40:28+01:00 New Revision: b5135a86e04761577494c70e7c0057136cc90b5b URL: https://github.com/llvm/llvm-project/commit/b5135a86e04761577494c70e7c0057136cc90b5b DIFF: https://github.com/llvm/llvm-project/commit/b5135a86e04761577494c70e7c0057136cc90b5b.diff

[PATCH] D70481: [clangd] Fix a crash in expected types

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5135a86e047: [clangd] Fix a crash in expected types (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70481/new/ https://reviews.l

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

merge_guards_bot added a comment. Build result: pass - 60059 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov updated this revision to Diff 230270. ilya-biryukov added a comment. - Do not correct typos when creating recovery expr - Simplify StmtPrinter::VisitRecoveryExpr - Add -Wno-used and remove extra expect-warning directives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

Re: [PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

Hello Michael, Very sorry for the late reply, we had exams and assignments this week and I had to read about _builtin_assume_aligned as I didn't come across this. #pragma clang loop vectorize_assume_alignment(32) > for(int i = 0;i < n; i++){ > a[i] = b[i] + i*i; > } > for this all-access inside t

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. @rsmith, could you also take a look at D65591 ? It's really important to have the `containsError()` check in this patch that marks decls with undeduced types as invalid. Otherwise, they

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh updated this revision to Diff 230278. svenvh added a comment. Incorporate suggestions from @rjmccall and add a test for the pointer case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https://reviews.llvm.org/D69810 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Co

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 230281. bader marked 5 inline comments as done. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/includ

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a subscriber: erichkeane. bader added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def warn_sycl_kernel_invalid_template_param_type : Warning< + "template parameter of template functions with 'sycl_kernel' attribute must"

Re: [PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

Am Mi., 20. Nov. 2019 um 10:21 Uhr schrieb HAPPY Mahto : >> #pragma clang loop vectorize_assume_alignment(32) >> for(int i = 0;i < n; i++){ >> a[i] = b[i] + i*i; >> } > > for this all-access inside the loop will be aligned to 32bit, > ex IR >> >> for.cond:

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, andreil99. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. The comment was slightly misleading. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70499

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 230285. twardakm added a comment. Fix style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://reviews.llvm.org/D69855 Files: clang-tools-extra/clang-tidy/readability/NamespaceCommentCh

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked 9 inline comments as done. twardakm added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + PP->addPPCallbacks(std::make_unique(

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https://reviews.llvm.org/D69810 ___ cfe-commits mailing list cfe-comm

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked an inline comment as done. bader added inline comments. Comment at: clang/test/Misc/pragma-attribute-supported-attributes-list.test:134 // CHECK-NEXT: ReturnsTwice (SubjectMatchRule_function) +// CHECK-NEXT: SYCLKernel (SubjectMatchRule_function) // CHECK-NEXT: Sco

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks for catching and fixing this, Sergej! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 _

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230287. xazax.hun marked 10 inline comments as done. xazax.hun added a comment. - Explicitly model "maybe" states. - Fix some escaping issues. - Address most review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

troyj added a comment. I ran into this same problem and would like to see this patch or a similar one land. Note that there is also a -Og option to consider, which currently has the same problem. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/ https:/

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/ https://reviews.llvm.org/D69089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish created this revision. sunfish added reviewers: sbc100, dschuff, aheejin. Herald added subscribers: dexonsmith, steven_wu, hiraditya, jgravelle-google, inglorion, aprantl, mehdi_amini. Herald added a project: clang. When the WASM_OPT environment variable is set, run the wasm-opt tool to

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked 3 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let Subjects = SubjectList<[Function, ParmVar], ErrorDiag>; + let Documentation = [AcquireHandleDocs];

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 230294. xazax.hun added a comment. - Check trivial cases when the acquire_handle attribute is not on an output parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added inline comments. Herald added a subscriber: ormris. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added a comment. This is also missing tests for all the Sema handling (that the attributes only appertain to the specified subjects, accept no arguments, etc). Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

spatel added reviewers: cameron.mcinally, mcberg2017, arsenm. spatel added a comment. Herald added a subscriber: wdng. I like the idea, but I'd be more comfortable reviewing the diffs in stages, so we know that the test coverage for the value tracking calls is good. So I'd prefer if we split thi

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman added a reviewer: arphaman. aaron.ballman added a subscriber: arphaman. aaron.ballman added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def warn_sycl_kernel_invalid_template_param_

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

lenary added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:130 + foreach(target x86_64;aarch64) # Set the per-target runtimes options. I don't know what's preventing you from enabling compiling the runtimes. I made a cmake config t

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const SourceManage

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3450 +def UseHandle : InheritableParamAttr { + let Spellings = [Clang<"use_handle">]; + let Documentation = [UseHandleDocs]; xazax.hun wrote: > aaron.ballman wrote: > > Should th

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. Please update the go bindings and include a release note that this API is changing & why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

phosek marked 2 inline comments as done. phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:130 + foreach(target x86_64;aarch64) # Set the per-target runtimes options. lenary wrote: > I don't know what's preventing you from

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s"; -

[PATCH] D70481: [clangd] Fix a crash in expected types

thakis added a comment. This broke clangd tests on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/12324 We now have clangd tests running on main llvm bots (namely, on http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/). Do they not send mail? Repository: rG

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

mcberg2017 added a comment. For us this would be an impediment as we have math models that want ieee behavior while relaxing precision. Adding nnan or ninf would obstruct those choices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/ ht

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230302. ptaylor added a comment. - fix package.json whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/clients/clangd-vscode/p

[PATCH] D70481: [clangd] Fix a crash in expected types

thakis added a comment. Reverted for now in 6de45772e0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70481/new/ https://reviews.llvm.org/D70481 __

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230301. ptaylor added a comment. - add package.json entry to contribute cuda language id - remove extra cuda file patterns, update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://revie

[clang-tools-extra] 6de4577 - Revert "[clangd] Fix a crash in expected types"

Author: Nico Weber Date: 2019-11-20T14:38:35-05:00 New Revision: 6de45772e0910bf7fa626e5493a2798b071eb26c URL: https://github.com/llvm/llvm-project/commit/6de45772e0910bf7fa626e5493a2798b071eb26c DIFF: https://github.com/llvm/llvm-project/commit/6de45772e0910bf7fa626e5493a2798b071eb26c.diff LO

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

vvereschaka accepted this revision. vvereschaka added a comment. Thank you Sergej. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list

[clang] fd8d915 - Fix parser bug that permitted 'private' as a (no-op) decl-specifier even outside OpenCL.

Author: Richard Smith Date: 2019-11-20T11:59:58-08:00 New Revision: fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe URL: https://github.com/llvm/llvm-project/commit/fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe DIFF: https://github.com/llvm/llvm-project/commit/fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe.diff

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 230310. bader added a comment. Applied code review comments from Aaron. Allow template template parameters for function templates marked with `sycl_kernel` attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb added a comment. Can you commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. Kinds seems like two different changes here. But lgtm. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137 + getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple + + "/llvm-lto"); +} -

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137 + getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple + + "/llvm-lto"); +} ---

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

jkz added a comment. In D70416#1750978 , @joerg wrote: > This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See > `tools::addOpenMPRuntime`. `-Bstatic`/`-Bdynamic` wrapping does seem to be more common, but that will change the li

  1   2   >