[PATCH] D19031: [clang-format] Flexible line endings

MyDeveloperDay added a comment. In D19031#1746705 , @STL_MSFT wrote: > MSVC's STL currently uses CRLF (DOS) line endings, not LF (Unix). I wrote a > validator, > https://github.com/microsoft/STL/blob/58bb49d63d92e7a0346a05af29816aeea6b4cf0f/tools/validat

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file', pattern : '**/*.

[clang] 87054ec - [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

Author: Sam McCall Date: 2019-11-15T10:40:38+01:00 New Revision: 87054ec07bd57719b9f66bf0548d7ac8019799f5 URL: https://github.com/llvm/llvm-project/commit/87054ec07bd57719b9f66bf0548d7ac8019799f5 DIFF: https://github.com/llvm/llvm-project/commit/87054ec07bd57719b9f66bf0548d7ac8019799f5.diff LO

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87054ec07bd5: [AST] Use written names instead of `type-param-0-0` in more cases when printing… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

hans added a comment. Thanks for the update! I think calling ExecuteCC1Tool instead of main is an improvement (there's no need to think about "re-entering" the process, it's really just a function call). I still don't see why it needs to go through a function pointer. I was hoping the code coul

[clang] 902e845 - [ARM, MVE] Add intrinsics for 'administrative' vector operations.

Author: Simon Tatham Date: 2019-11-15T09:53:43Z New Revision: 902e84556a51c70d95088aaa059ab9c494ab3516 URL: https://github.com/llvm/llvm-project/commit/902e84556a51c70d95088aaa059ab9c494ab3516 DIFF: https://github.com/llvm/llvm-project/commit/902e84556a51c70d95088aaa059ab9c494ab3516.diff LOG:

[clang] 9e37892 - [ARM,MVE] Add intrinsics for vector get/set lane.

Author: Simon Tatham Date: 2019-11-15T09:53:58Z New Revision: 9e37892773c0954a15f84b011223da1e707ab3bf URL: https://github.com/llvm/llvm-project/commit/9e37892773c0954a15f84b011223da1e707ab3bf DIFF: https://github.com/llvm/llvm-project/commit/9e37892773c0954a15f84b011223da1e707ab3bf.diff LOG:

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG902e84556a51: [ARM,MVE] Add intrinsics for 'administrative' vector operations. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7013

[PATCH] D70188: [ARM,MVE] Add intrinsics for vector get/set lane.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e37892773c0: [ARM,MVE] Add intrinsics for vector get/set lane. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70188/new/ https:/

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added a comment. looks like you forgot to upload the latest patch. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test;

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector &getSkippedRanges() const { +return SkippedRanges; hokein wrote: > Instead of adding new member and methods in `ParsedAST`, I think we can do it > in `C

[clang] 1643734 - [clang] Remove the DIFlagArgumentNotModified debug info flag

Author: Djordje Todorovic Date: 2019-11-15T11:10:19+01:00 New Revision: 1643734741d2f2957206774a50960ba335a36a0c URL: https://github.com/llvm/llvm-project/commit/1643734741d2f2957206774a50960ba335a36a0c DIFF: https://github.com/llvm/llvm-project/commit/1643734741d2f2957206774a50960ba335a36a0c.d

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1643734741d2: [clang] Remove the DIFlagArgumentNotModified debug info flag (authored by djtodoro). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 229485. lewis-revill added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/test/Driv

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:278 // Add CFI directives for callee-saved registers. - const std::vector &CSI = MFI.getCalleeSavedInfo(); - // Iterate over list of callee-saved registers and emit .cfi_restore - /

[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein added a parent revision: D70235: [clangd] Add isHeaderFile helper.. The helper is more correct to detec

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1745766 , @rjmccall wrote: > In D69938#1745737 , @Anastasia wrote: > > > In D69938#1742354 , @rjmccall > > wrote: > > > > > In D69938#17

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229492. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Uploading latest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-t

[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 41d6ad6 - Revert "[clang] Remove the DIFlagArgumentNotModified debug info flag"

Author: Djordje Todorovic Date: 2019-11-15T12:16:44+01:00 New Revision: 41d6ad6efddadbb905bd14c53c2731b75f30cca7 URL: https://github.com/llvm/llvm-project/commit/41d6ad6efddadbb905bd14c53c2731b75f30cca7 DIFF: https://github.com/llvm/llvm-project/commit/41d6ad6efddadbb905bd14c53c2731b75f30cca7.d

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro reopened this revision. djtodoro added a comment. This revision is now accepted and ready to land. After landing this, I see one LLDB test depends on this. I made a workaround to avoid testing it at the moment. I will remove the workaround when landing the D68209

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro updated this revision to Diff 229495. djtodoro added a comment. -Add the workaround in the LLDB test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/te

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes created this revision. Herald added a project: clang. Fixes pr/43700. Also simplify another call, and make the CGF member a const pointer since it is public but only assigned in the constructor. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70302 Files: clang/lib/