[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228960. nridge marked 11 inline comments as done. nridge added a comment. Address one minor remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: cl

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Re

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

Meinersbur added a comment. Sorry for the delay, for some reason I did not see a notification for the update. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306 +// Imply vectorize.enable when it is not already disabled/enabled. +Args.push_back( +MDNode::get(

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

cchen added a comment. Not sure how to test this change since the issue only happens after I add more implicit-behaviors for extended defaultmap. Now `ActOnOpenMPDefaultmapClause` is doing `M != OMPC_DEFAULTMAP_MODIFIER_tofrom`, so even the modifier is set to be "scalar", the code is still rig

[clang] 9740f9f - Add -Wtautological-compare to -Wall

Author: Weverything Date: 2019-11-12T14:36:57-08:00 New Revision: 9740f9f0b6e5d7d5104027aee7edc9c5202dd052 URL: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052 DIFF: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052.diff L

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

This revision was automatically updated to reflect the committed changes. Closed by commit rG9740f9f0b6e5: Add -Wtautological-compare to -Wall (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D69292?vs=228361&id=228970#toc Repository: rG

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( jd

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea updated this revision to Diff 228971. aganea edited the summary of this revision. aganea added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Using `SmallVector` as requested. The change in SmallVector.h is to support things such as `Opts.AddPluginActions

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Re

[PATCH] D70149: [C-index] Fix annotate-deep-statements test in Debug target

aganea created this revision. aganea added reviewers: rsmith, aaron.ballman, rnk. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. As per title: previously, running the test `clang/test/Index/annotate-deep-statements.cpp` used to fail because of stack exhaustion (D

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk added a subscriber: dblaikie. rnk added a comment. For reference, this is the code sequence that needs the SmallVector change: https://github.com/llvm/llvm-project/blob/99e2cba219aea80b3f11de2aa4e0192b28852de4/clang/lib/Frontend/CompilerInvocation.cpp#L1872 Comment at: clan

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( jd

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:750-752 // The constraint manager has not been cleaned up yet, so clean up now. CheckerState = getConstraintManager().removeDeadBindings(Ch

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ marked an inline comment as done. N

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764 // generate a transition to that state. ProgramStateRef CleanedCheckerSt = StateMgr.getPersistentStateWithGDM(CleanedState, Checker

[clang] e278c13 - [Sema] Add MacroQualified case for FunctionTypeUnwrapper

Author: Leonard Chan Date: 2019-11-12T16:22:13-08:00 New Revision: e278c138a937a68f3e6c89df8eaeffa913f9b0f7 URL: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7 DIFF: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7.diff

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGe278c138a937: [Sema] Add MacroQualified case for FunctionTypeUnwrapper (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ h

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764 // generate a transition to that state. ProgramStateRef CleanedCheckerSt = StateMgr.getPersistentStateWithGDM(CleanedState, Checker

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

efriedma added a comment. It wouldn't be that hard to add an equivalent flag to opt; just a matter of calling the API on TargetLibraryInfo. -disable-simplify-libcalls already exists, but I guess that's not quite what you want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5ad6f27 - Don't assume that the clang binary's resolved name includes the string

Author: Richard Smith Date: 2019-11-12T16:37:05-08:00 New Revision: 5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb URL: https://github.com/llvm/llvm-project/commit/5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb DIFF: https://github.com/llvm/llvm-project/commit/5ad6f279f26cd6ce77e4fa6b8df2b23be73d7beb.diff

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Re

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

jdoerfert added a comment. One style comment, patch looks conceptually fine to me otherwise. I'll wait to accept on how we fall on the test issue: I'd opt for an `opt` test if possible. Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:370 +: nullp

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113 move::MoveDefinitionSpec Spec; - Spec.Names = {Names.begin(), Names.end()}; + Spec.Names = (std::vector &)Names; Spec.OldHeader = OldHeader; rnk wrote: > Conve

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. In D69970#1742575 , @vsk wrote: > @dblaikie do you need more time to investigate? fwiw I didn't uncover any new > failures in a stage2 build with this patch applied. I haven't figured this out yet, sorry - bit inundated with a

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. I can confirm we still have the same internal failure with this revised/updated patch. Trying to reduce/reproduce it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___ c

[PATCH] D69978: Separately track input and output denormal mode

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1822 ``"denorm-fp-mode"`` + This indicates the subnormal handling that may be assumed for the I don't like the definition of this attribute. It's not reader-friendly. The comma-separat

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. So I /think/ what's happening here is the extra addresses needed for the call_site low_pcs are creating new basic blocks (or whatever the logic is in the backend that says "use line zero at the start of each basic block-like thing" - possible that logic is overly conse

[PATCH] D65184: [Sema] Thread Safety Analysis: Make negative capability typeless.

aaronpuchert added a comment. > This is a larger effort so it will take a little bit more time on me. This is fine, but could you add a "Plan changes" action then? This will make the revision disappear from the active review queue. Repository: rL LLVM CHANGES SINCE LAST ACTION https://rev

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( AB

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( jd

[clang] bc4bc5a - Add 8548 CPU definition and attributes

Author: Justin Hibbits Date: 2019-11-12T20:34:34-06:00 New Revision: bc4bc5aa0d84413e4e3f082dee0d30cf839fb7ea URL: https://github.com/llvm/llvm-project/commit/bc4bc5aa0d84413e4e3f082dee0d30cf839fb7ea DIFF: https://github.com/llvm/llvm-project/commit/bc4bc5aa0d84413e4e3f082dee0d30cf839fb7ea.diff

[PATCH] D67787: Add 8548 CPU definition and attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4bc5aa0d84: Add 8548 CPU definition and attributes (authored by chmeee). Changed prior to commit: https://reviews.llvm.org/D67787?vs=228589&id=228995#toc Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added reviewers: MaskRay, jyknight. craig.topper added a comment. Adding some others who may be be more familiar with the Fragments in the MC layer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D701

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added reviewers: mclow.lists, ldionne, EricWF, rsmith. kristina added a comment. Herald added a subscriber: dexonsmith. Added libcxx maintainers, would like one of them to sign off on this. I presume this is NFCI for Linux so it should be covered by existing regression tests?

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

NoQ created this revision. NoQ added reviewers: dcoughlin, aprantl. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, kristof.beyls, xazax.hun. Herald added a project: clang. NoQ marked 2 inline co

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:225 -14 -16 -17 +26 +30 `26` is the new `10`. Comment at: clang/test/Ana

[PATCH] D70157: Align branches within 32-Byte boundary

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { We rarely put function definition at *.h, if putting

[PATCH] D70157: Align branches within 32-Byte boundary

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { xiangzhangllvm wrote: > We rarely put function defini

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { xiangzhangllvm wrote: > xiangzhangllvm wrote: > > We ra

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3905 +categories, or extensions (for the latter two it applies the attribute +to all methods declared in the category/implementation), + Editing error? Comment at

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { +switch (Opcode) { craig.topper wrote: > xi

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

davezarzycki abandoned this revision. davezarzycki added a comment. Okay. I'm going to abandon this patch on the assumption that Apple has an internal bug tracking this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69841/new/ https://reviews.llvm

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey updated this revision to Diff 229013. awpandey marked 3 inline comments as done. awpandey added a comment. Herald added a reviewer: deadalnix. @aprantl Thanks for the suggestion. Based on your suggestion I have done the following changes 1. I have added alignment value as a check in th

[PATCH] D70164: [JSONCompilationDatabase] Fix backslash escaping on Windows

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet. Herald added a project: clang. We should always use `TokenizeWindowsCommandLine` on Windows. When compiling clangd with `MinGW-W64`, `Triple.

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-align.cpp:8 + +// CHECK: DIDerivedType(tag: DW_TAG_typedef, {{.*}}, align: + aprantl wrote: > Do we need to hardcode the target here? Could we check for the specific align > va

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229015. MadCoder marked 16 inline comments as done and an inline comment as not done. MadCoder added a comment. Handled a bunch of comments (marked done). will update again to implement the deeper requested change around `objc_direct_members` and some more

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder marked an inline comment as not done. MadCoder added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3909 +called directly. It can also be used on Objective-C Categories and Extensions, +in which case it applies to all methods declared in such an ``@in

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2169 +// Direct methods will synthesize the proper `_cmd` internally, + // so just don't bother with setting the `_cmd` argument. +assert(!IsSuper); jeez will fix the indent

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc created this revision. poelmanc added reviewers: alexfh, djasper. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. In addition to adding `override` wherever possible, clang-tidy's `modernize-use-override` nicely removes `virtual` when `override` or `final` is

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

6yearold added a comment. Bump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

davezarzycki added subscribers: libcxx-commits, davezarzycki. davezarzycki added a comment. This broke the libcxx test suite: FAIL: libc++ :: libcxx/debug/containers/db_sequence_container_iterators.multithread.pass.cpp (50769 of 59296) TEST 'libc++ :: libcxx/debug/cont

<    1   2