[PATCH] D69363: [www] Change URLs to HTTPS.

2019-10-23 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. Thanks for updating all these links! LGTM :) Comment at: clang/www/cxx_status.html:78 Rvalue references - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n2118.html";>N2118 + https://wg21.link/n2118";>N2118 Clang 2.9 --

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

2019-10-23 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points you brought up. One last thing I'm not quite sure is the caching of `-fthin-link-bitcode`. It is a `-cc1` option since it is a kind of implementation of ThinLTO, right? I'm a little hesitant to beg

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

2019-10-23 Thread Kuan Hsu Chen via Phabricator via cfe-commits
khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > I think this line is the issue: where someone doesn't specify `-march`, y

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

2019-10-23 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. In D69327#1719411 , @ychen wrote: > Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points > you brought up. One last thing I'm not quite sure is the caching of > `-fthin-link-bitcode`. It is a `-cc1` option

<    1   2