Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc /tmp/vectorize.cc:1:6: error: loop not interleaved: the optimi

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

jfb added a comment. In D66046#1717229 , @thakis wrote: > Mr Trieu, what do you think about adding some or all of the > Wtautological-compare warnings to Wall It's addressed in the patch description: https://reviews.llvm.org/D66046?id=214484#inline-591

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; andrew.w.kaylor wrote: > rjmccall wrote: > > What's the purpose of this restriction? Whether `

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. That comment explains why this is not by default (= without any -W flag) but does not explain why this is not part of -Wall (if user enables -Wall, he/she cares about warnings) [you asked about default ignore]. We have many warnings flagged as DefaultIgnore but they ar

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

On 10/21/19 4:00 PM, Jordan Rupprecht via cfe-commits wrote: There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 225955. ajpaverd marked 3 inline comments as done. ajpaverd added a comment. Formatting fixes for CFGuard patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761 Files:

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

> On Mon, Oct 21, 2019 at 9:18 AM Hans Wennborg via cfe-commits > wrote: >> >> As expected, this broke the Chromium build again (but it seems only at >> -Oz this time). > > > To be clear, is the desired behavior that the vectorization is performed even > at -Oz? I suspect that it is, but I just

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Hi Volodymyr, This broke the Chrome build in an interesting way. Here's a reduced repro: $ cat /tmp/a.mm #import void f(int width, int height) { FourCharCode best_fourcc = kCMPixelFormat_422YpCbCr8_yuvs; NSDictionary* videoSettingsDictionary = @{ (id)kCVPixelBufferPixelFormatTypeKey :

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8161 + "bitwise or with non-zero value always evaluates to true">, + InGroup, DefaultIgnore; def warn_tautological_overlap_comparison : Warning< rtrieu wrote: > jfb wrote: > >

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule created this revision. jdemeule added a reviewer: klimek. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Last year, I made some suggestion to improve conflict reporting in clang-apply-replacements (https://reviews.llvm.org/D43764). I have a very simple impleme

[PATCH] D69012: [Headers] Fix compatibility between arm_acle.h and intrin.h

rnk accepted this revision. rnk added a comment. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69012/new/ https://reviews.llvm.org/D69012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

r375466 - [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics.

Author: mspencer Date: Mon Oct 21 15:51:13 2019 New Revision: 375466 URL: http://llvm.org/viewvc/llvm-project?rev=375466&view=rev Log: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics. This is a recommit of r375322 and r375327 with a fi

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. In D67723#1710134 , @probinson wrote: > FTR, since @rnk has mentioned my years-ago writings, what Sony has internally > nowadays is a little different than what I said back then. We have an option > spelled `-gno-inlined-scopes` wh

r375468 - Fix -fuse-init-array decision logic on NetBSD

Author: joerg Date: Mon Oct 21 16:35:33 2019 New Revision: 375468 URL: http://llvm.org/viewvc/llvm-project?rev=375468&view=rev Log: Fix -fuse-init-array decision logic on NetBSD For NetBSD 9 and later, it is the default. On older versions, only ARM and AArch64 use it by default. Modified: cf

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. In D67723#1717416 , @rnk wrote: > In D67723#1710134 , @probinson wrote: > > > FTR, since @rnk has mentioned my years-ago writings, what Sony has > > internally nowadays is a little differen

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via cfe-commits : > There's also a curious failure caused by this patch (confirmed passing > @r374287, failing @r374288): It's a warning, not a failure. > $ cat /tmp/vectorize.cc > void a() { > #pragma clang loop vectorize(disable) >

[PATCH] D69186: Refactor DependencyScanningTool to its own file

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with style nit. I like that this decouples `DependencyScanningTool` from printing the results. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:105-107 +

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a comment. The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

Re: r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

That error looks strange and confusing to me too. My guess is that my change exposed some bug with literals. I’ve tried NSDictionary* videoSettingsDictionary2 = [NSDictionary dictionaryWithObject:@(best_fourcc) forKey:(id)kCVPixelBufferPixelFormatTypeKey]; and @interface GenericTest :

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

MaskRay added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:43 ArgumentsAdjuster getClangStripOutputAdjuster() { - return [](const CommandLineArguments &Args, StringRef /*unused*/) { + return [](const CommandLineArguments &Args, StringRef /*unused*/, St

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

rtrieu created this revision. Per https://reviews.llvm.org/D66046, patch to move -Wtautological-compare to -Wmost, which also adds it to -Wall. Some warnings in -Wtautological-compare and its diagnostic sub-groups are DefaultIgnore, so making them visible in -Wall will make them more discovera

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

rtrieu added a comment. In D66046#1717229 , @thakis wrote: > Mr Trieu, what do you think about adding some or all of the > Wtautological-compare warnings to Wall I thought -Wtautological-compare was already part of -Wall, so I'm all for adding it. I m

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + - 1 is to exclude the \n I'd assume

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. Review / feedback ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 114de1e - Minor coding style fix. NFC.

Author: Michael Liao Date: 2019-10-22T04:32:30Z New Revision: 114de1eab29c06ac097c0e97feb713d616798f7a URL: https://github.com/llvm/llvm-project/commit/114de1eab29c06ac097c0e97feb713d616798f7a DIFF: https://github.com/llvm/llvm-project/commit/114de1eab29c06ac097c0e97feb713d616798f7a.diff LOG:

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

On Mon, Oct 21, 2019 at 5:12 PM Michael Kruse wrote: > Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via > cfe-commits : > > There's also a curious failure caused by this patch (confirmed passing > @r374287, failing @r374288): > > It's a warning, not a failure. > True. We build with

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted on or after 22:30 PM PDT. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk updated this revision to Diff 225994. kousikk added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScan

[PATCH] D69186: Refactor DependencyScanningTool to its own file

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb042b094fda: Refactor DependencyScanningTool to its own file (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://review

[clang] fb042b0 - Refactor DependencyScanningTool to its own file

Author: Kousik Kumar Date: 2019-10-22T05:05:18Z New Revision: fb042b094fda351b59f1b00fe6235fc55d0f79b9 URL: https://github.com/llvm/llvm-project/commit/fb042b094fda351b59f1b00fe6235fc55d0f79b9 DIFF: https://github.com/llvm/llvm-project/commit/fb042b094fda351b59f1b00fe6235fc55d0f79b9.diff LOG:

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + klimek wrote: > - 1 is to exclude the \n I'd assume? corr

<    1   2