[PATCH] D69137: [profile] Do not cache __llvm_profile_get_filename result

2019-10-18 Thread Vedant Kumar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG937241b0d9e8: [profile] Do not cache __llvm_profile_get_filename result (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLV

r375304 - DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

2019-10-18 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Fri Oct 18 16:58:34 2019 New Revision: 375304 URL: http://llvm.org/viewvc/llvm-project?rev=375304&view=rev Log: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization Differential Revision: https:/

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

2019-10-18 Thread David Blaikie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9fdd09a4ccd0: DebugInfo: Render the canonical name of a class template specialization, even… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D63031?vs=203639&id=225718#toc Rep

r375305 - [c++20] Add CXXRewrittenBinaryOperator to represent a comparison

2019-10-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 18 17:04:38 2019 New Revision: 375305 URL: http://llvm.org/viewvc/llvm-project?rev=375305&view=rev Log: [c++20] Add CXXRewrittenBinaryOperator to represent a comparison operator that is rewritten as a call to multiple other operators. No functionality change yet: noth

r375306 - [c++20] Add rewriting from comparison operators to <=> / ==.

2019-10-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 18 17:04:43 2019 New Revision: 375306 URL: http://llvm.org/viewvc/llvm-project?rev=375306&view=rev Log: [c++20] Add rewriting from comparison operators to <=> / ==. This adds support for rewriting <, >, <=, and >= to a normal or reversed call to operator<=>, for rewri

r375308 - [analyzer] Specify the C++ standard in more tests.

2019-10-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 18 17:08:17 2019 New Revision: 375308 URL: http://llvm.org/viewvc/llvm-project?rev=375308&view=rev Log: [analyzer] Specify the C++ standard in more tests. Makes life easier for downstream developers with different default standard. Modified: cfe/trunk/test/Ana

r375309 - [hip][cuda] Fix the extended lambda name mangling issue.

2019-10-18 Thread Michael Liao via cfe-commits
Author: hliao Date: Fri Oct 18 17:15:19 2019 New Revision: 375309 URL: http://llvm.org/viewvc/llvm-project?rev=375309&view=rev Log: [hip][cuda] Fix the extended lambda name mangling issue. Summary: - HIP/CUDA host side needs to use device kernel symbol name to match the device side binaries. Wi

r375310 - [clang][driver] Print compilation phases with indentation.

2019-10-18 Thread Michael Liao via cfe-commits
Author: hliao Date: Fri Oct 18 17:17:00 2019 New Revision: 375310 URL: http://llvm.org/viewvc/llvm-project?rev=375310&view=rev Log: [clang][driver] Print compilation phases with indentation. Reviewers: tra, sfantao, echristo Subscribers: cfe-commits Tags: #clang Differential Revision: https://

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

2019-10-18 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd7a487adfedb: [clang][driver] Print compilation phases with indentation. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

2019-10-18 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG243ebfba17da: [hip][cuda] Fix the extended lambda name mangling issue. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68818?vs=225678&id=225720#toc Repository: rG LLVM Github

r375313 - Sema: Create a no-op implicit cast for lvalue function conversions.

2019-10-18 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Oct 18 17:34:54 2019 New Revision: 375313 URL: http://llvm.org/viewvc/llvm-project?rev=375313&view=rev Log: Sema: Create a no-op implicit cast for lvalue function conversions. This fixes an assertion failure in the case where an implicit conversion for a function call involv

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

2019-10-18 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG766f15814a01: Sema: Create a no-op implicit cast for lvalue function conversions. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/

r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

2019-10-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

[clang-tools-extra] r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

2019-10-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

r375318 - New tautological warning for bitwise-or with non-zero constant always true.

2019-10-18 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Oct 18 17:57:23 2019 New Revision: 375318 URL: http://llvm.org/viewvc/llvm-project?rev=375318&view=rev Log: New tautological warning for bitwise-or with non-zero constant always true. Taking a value and the bitwise-or it with a non-zero constant will always result in a no

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

2019-10-18 Thread Richard Trieu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0d14a8f0cc: New tautological warning for bitwise-or with non-zero constant always true. (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D66046?vs

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

2019-10-18 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl marked 8 inline comments as done. aprantl added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:843 +return Val.getValue(); + Val = nullptr; + rjmccall wrote: > Why did this logic need to change? I don't have a satisfying answer for this

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

2019-10-18 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl updated this revision to Diff 225727. aprantl added a comment. Addressed most of the feedback, explained the rest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

2019-10-18 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl updated this revision to Diff 225729. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/Analysis/BodyFarm.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/Cod

[PATCH] D68891: Remove unnecessary triple from test

2019-10-18 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

2019-10-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:191 -10 14 It looks like the body farm for the property accessor has stopped working

r375322 - [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics.

2019-10-18 Thread Michael J. Spencer via cfe-commits
Author: mspencer Date: Fri Oct 18 18:36:37 2019 New Revision: 375322 URL: http://llvm.org/viewvc/llvm-project?rev=375322&view=rev Log: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics. Differential Revision: https://reviews.llvm.org/D68

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

2019-10-18 Thread Michael Liao via Phabricator via cfe-commits
hliao abandoned this revision. hliao added a comment. revised change is already committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164 ___ cfe-commits maili

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

2019-10-18 Thread Michael Spencer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG14a3f77ba103: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D68528?vs=225326&id=225731#toc

r375326 - Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"

2019-10-18 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Oct 18 18:47:49 2019 New Revision: 375326 URL: http://llvm.org/viewvc/llvm-project?rev=375326&view=rev Log: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" Extend -Wparentheses to cover mixing bitwise-and and bitwise-or with the conditional o

r375327 - [Docs] Fix header level.

2019-10-18 Thread Michael J. Spencer via cfe-commits
Author: mspencer Date: Fri Oct 18 18:48:57 2019 New Revision: 375327 URL: http://llvm.org/viewvc/llvm-project?rev=375327&view=rev Log: [Docs] Fix header level. Modified: cfe/trunk/docs/Modules.rst Modified: cfe/trunk/docs/Modules.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/M

r375328 - [analyzer] Fix a crash on tracking Objective-C 'self' as a control dependency.

2019-10-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 18 18:50:43 2019 New Revision: 375328 URL: http://llvm.org/viewvc/llvm-project?rev=375328&view=rev Log: [analyzer] Fix a crash on tracking Objective-C 'self' as a control dependency. 'self' was previously never tracked, but now it can be tracked because it may be p

r375329 - [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor.

2019-10-18 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 18 18:50:46 2019 New Revision: 375329 URL: http://llvm.org/viewvc/llvm-project?rev=375329&view=rev Log: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor. Patch by Kristóf Umann! Differential Revision: https://reviews.llvm.org/D68591 Modified:

[PATCH] D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:")

2019-10-18 Thread Richard Trieu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG637af4cc3780: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" (authored by rtrieu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D66043

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

2019-10-18 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4a5df7312ec2: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

2019-10-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Decided to commit myself in order to hurry things up^^ Also rC375328 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68591/new/ https://reviews.llvm.org/D68591 _

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

2019-10-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this fails on win: http://45.33.8.238/win/841/step_6.txt Ptal! Maybe just cat'ing all files instead of echoing the first and piping into cat works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528/new/ https

[PATCH] D69213: Avoid appending the source directory to an absolute path

2019-10-18 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added reviewers: JDevlieghere, davide. aprantl added a project: debug-info. When building a precompiled header in `-fmodule-format=obj` (i.e., `-gmodules) in an absolute path, the locig in CGDebugInfo::createCompileUnit would unconditionally append the sour

<    1   2