[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. Thanks for clearing it up! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, reames, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki. Herald added a reviewer: bollu. Herald added a reviewer: jdoerfert. Herald add

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, reames, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Parse

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk created this revision. kousikk added reviewers: arphaman, dexonsmith, Bigcheese, jkorous. kousikk added a project: clang. kousikk edited the summary of this revision. Clang's -M mode includes these extra dependencies in its output and clang-scan-deps should have equivalent behavior, so ad

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. The now that constexpr destructors are legal. The code in this patch need to be adapted, I have question about the following code. struct A { constexpr ~A() {} }; consteval A f() { return A{}; } void test() { A a; a = f(); // <-- here

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk updated this revision to Diff 225375. kousikk added a comment. Fix tests now that output is in ascending order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69090/new/ https://reviews.llvm.org/D69090 Files: clang/lib/Tooling/DependencySc

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:345 if (WarnFormat && !NoWarnFormat) { +ArrayRef> Ranges; for (const auto &R : Replaces) { Looks unused? Comment at: clang/tools/clang-format/ClangFo

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Comment at: clang/tools/clang-format/ClangFormat.cpp:345 if (WarnFormat && !NoWarnFormat) { +ArrayRef> Ranges; for (const auto &R : Replaces) { klimek wrote: > Looks u

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:351 + SourceLocation LineBegin = Sources.translateFileLineCol( + FileEntryPtr.get(), PLoc.getLine() - 1, 0); + SourceLoca

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

mantognini added a comment. Shouldn't this page be referenced from `clang/docs/index.rst`? In the long run, how would this page differ from https://releases.llvm.org/9.0.0/tools/clang/docs/LanguageExtensions.html#opencl-features and https://releases.llvm.org/9.0.0/tools/clang/docs/UsersManual.

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler added a comment. Ping? I already spotted the line in CommandFlags.inc needs formatting with a couple of breaks. Also the help text in Options.td could be clearer. In particular, -gno-dwarf-frame shouldn't suggest .debug_frame won't be generated at all (since -g might still emit it). I

[PATCH] D69094: [WIP] Add override relationship.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69094 Files: clang-tools-extra/clangd/index/Relation.cpp clang-tools-extra/clangd/index/

r375094 - Reland: Dead Virtual Function Elimination

Author: ostannard Date: Thu Oct 17 02:58:57 2019 New Revision: 375094 URL: http://llvm.org/viewvc/llvm-project?rev=375094&view=rev Log: Reland: Dead Virtual Function Elimination Remove dead virtual functions from vtables with replaceNonMetadataUsesWith, so that CGProfile metadata gets cleaned up

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia added a comment. In D69072#1712473 , @mantognini wrote: > Shouldn't this page be referenced from `clang/docs/index.rst`? Oops, yes! Sure. I will update. Thanks! > In the long run, how would this page differ from > https://releases.llvm.org/9.

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

ostannard added a comment. I don't like the idea of adding a `-gno-dwarf-frame` option which doesn't always disable emission of `.debug_frame`. Since it doesn't make sense to emit other debug info without `.debug_frame`, maybe we should just not have a negative option? CHANGES SINCE LAST ACTI

[PATCH] D69043: [RFC] Adding time-trace to LLD?

ruiu added a comment. This seems useful. Can I see an example output? Speaking of the output file, I'd make --time-trace option to take an output filename, as an output executable doesn't always have an extension (On Windows it's almost always .exe, but on Unix, extension is usually omitted).

r375097 - SemaDeclObjC - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 17 03:35:29 2019 New Revision: 375097 URL: http://llvm.org/viewvc/llvm-project?rev=375097&view=rev Log: SemaDeclObjC - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cas

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia updated this revision to Diff 225391. Anastasia edited the summary of this revision. Anastasia added a comment. Herald added a subscriber: arphaman. Added OpenCLSupport page into index. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69072/new/ https://reviews.llvm.org/D69072 F

r375101 - SemaExprCXX - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 17 04:12:31 2019 New Revision: 375101 URL: http://llvm.org/viewvc/llvm-project?rev=375101&view=rev Log: SemaExprCXX - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these case

[clang-tools-extra] r375102 - clang-tidy - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 17 04:12:53 2019 New Revision: 375102 URL: http://llvm.org/viewvc/llvm-project?rev=375102&view=rev Log: clang-tidy - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases

r375104 - Include leading attributes in DeclStmt's SourceRange

Author: sberg Date: Thu Oct 17 04:20:21 2019 New Revision: 375104 URL: http://llvm.org/viewvc/llvm-project?rev=375104&view=rev Log: Include leading attributes in DeclStmt's SourceRange Differential Revision: https://reviews.llvm.org/D68581 Modified: cfe/trunk/lib/Parse/ParseStmt.cpp cfe/

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Alright, thanks for the explanation. LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69072/new/ https://reviews.llvm.org/D69072 ___

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3957ec215d: Include leading attributes in DeclStmt's SourceRange (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D68581?vs=224823&id=225397#toc Repository: rG LLVM Github Mon

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { ilya-biryukov wrote: > This should return `SmallVector` now, some declarations can > have both dec

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225398. hokein marked 14 inline comments as done. hokein added a comment. address comments: - remove the confusing IsDeclRef - use getQualifier from AST.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:528 + /// AST. + AllRefs annotateReferencesInMainAST(llvm::StringRef Code) { +TestTU TU; hokein wrote: > ilya-biryukov wrote: > > Why do we need this? Ca

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { hokein wrote: > ilya-biryukov wrote: > > This should return `SmallVector` now, some declarat

[PATCH] D68403: [OpenCL] PR43145: preserve addrspace for class accesses

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68403/new/ https://reviews.llvm.org/D68403 ___

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:846 + // the underlying FunctionDecl. we should report just one. + void $12^$13^F() {} + )cpp", Could we avoid adding this te

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:110 + +static bool isAnonymous(const DeclarationName &N) { + return N.isIdentifier() && !N.getAsIdentifierInfo(); could you move this one back above `getQualifierLoc` ? ==

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:438 D->getTargetNameLoc(), + /*IsDecl=*/true, {D->getAliasedNamespace()}}; This one is a **not** a

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { kadircet wrote: > ilya-biryukov wrote: > > hokein wrote: > > > ilya-biryukov wrote: > > > >

Re: r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

On 09/10/2019 04:04, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 8 19:04:54 2019 New Revision: 374135 URL: http://llvm.org/viewvc/llvm-project?rev=374135&view=rev Log: [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue whose value is not ignored. We don't

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a comment. Ping @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

sberg marked 2 inline comments as done. sberg added inline comments. Comment at: clang/test/AST/sourceranges.cpp:155 + +#if __cplusplus >= 201703L + void cpp17() { aaron.ballman wrote: > Why is this guarded on C++17? `[[maybe_unused]]` is supported in every > l

r375111 - [OpenCL] Add doc to describe OpenCL support

Author: svenvh Date: Thu Oct 17 05:56:02 2019 New Revision: 375111 URL: http://llvm.org/viewvc/llvm-project?rev=375111&view=rev Log: [OpenCL] Add doc to describe OpenCL support The idea of this page is to document work in progress functionality and also describe the plan of future development wor

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e962e8d7dc7: [OpenCL] Add doc to describe OpenCL support (authored by svenvh). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D69072?vs=225391&id=225413#toc Repositor

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet updated this revision to Diff 225416. kadircet marked an inline comment as done. kadircet added a comment. - Handle using directives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69033/new/ https://reviews.llvm.org/D69033 Files: clang-t

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9508-9510 + // FIXME: We should really be doing this in SemaDeclAttr.cpp::handleNoBuiltin + // but there is a bug with FunctionDecl::isThisDeclarationADefinition() which + // always returns false befo

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet marked 5 inline comments as done. kadircet added a comment. In D69033#1710955 , @ilya-biryukov wrote: > We seem to have trouble only in presence of using declarations and using > namespace directives. > I wonder how complicated it would be to t

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 225418. saar.raz added a comment. Address CR comments by rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: clang/include/clang/AST/ASTConcept.h clang/

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

luismarques added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:97 RISCVABI::ABI getTargetABI() const { return TargetABI; } + bool isRegisterReservedByUser(size_t i) const { +return UserReservedRegister[i]; This should take a `Regist

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop added a comment. In D69043#1712542 , @ruiu wrote: > This seems useful. Can I see an example output? Thanks. Here's an example from Building clang with ThinLTO: F10296420: clang-10.json Using linker f

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:850 + "1: targets = {Foo::Foo}, decl\n" + "2: targets = {Foo::~Foo}, decl\n" + "3: targets = {Foo}\n" ilya-biryukov wrote: > Could we av

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225420. hokein marked 6 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 Files: clang-tools-extra/cla

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. This actually depends on another Diff : https://reviews.llvm.org/D32478 That other change introduces the ability to "unindent operator", which is required here; however, it also changes AlignOperands to have more than 2 modes, which does not seem to be acceptable. Before m

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar accepted this revision. mitchell-stellar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits mailing list cfe

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added a comment. Mostly NITs from my side, the change LG, thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:422 + // "using namespace" declaration doesn't have a name. + Refs.push_back({D->getQualifierLoc(), + D->getIdentLo

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

hans added a comment. > I can't wait for @hans next Windows Snapshot, this is my gate for rolling > into our builds and CI system, after that, I'm gonna catch every single > person who tries to build/check in unclang-formatted. As it happens, there's a new snapshot out today :-) Repository:

[clang-tools-extra] r375117 - [clangd] Use our own relation kind.

Author: hokein Date: Thu Oct 17 07:08:28 2019 New Revision: 375117 URL: http://llvm.org/viewvc/llvm-project?rev=375117&view=rev Log: [clangd] Use our own relation kind. Summary: Move the RelationKind from Serialization.h to Relation.h. This patch doesn't introduce any breaking changes. Reviewers

r375118 - [OpenCL] Preserve addrspace in CGClass (PR43145)

Author: svenvh Date: Thu Oct 17 07:12:51 2019 New Revision: 375118 URL: http://llvm.org/viewvc/llvm-project?rev=375118&view=rev Log: [OpenCL] Preserve addrspace in CGClass (PR43145) PR43145 revealed two places where Clang was attempting to create a bitcast without considering the address space of

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > hokein wrote: > > > > ilya-

[PATCH] D69043: [RFC] Adding time-trace to LLD?

aganea added inline comments. Comment at: lld/ELF/Driver.cpp:515 + + if (llvm::timeTraceProfilerEnabled()) { +SmallString<128> path(config->outputFile); Could you possibly move this block (and the init block above) into a new file in `lld/Common/` so we can

[PATCH] D68981: [clangd] Use our own relation kind.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e3f43ab514: [clangd] Use our own relation kind. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D6

[PATCH] D68403: [OpenCL] PR43145: preserve addrspace for class accesses

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6248cbb9e7: [OpenCL] Preserve addrspace in CGClass (PR43145) (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D68403?vs=223037&id=225426#toc Repository: rG LLVM Github Monore

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:2280 } -EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls)); +EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls)) +<< File.code(); --

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225428. hokein marked 7 inline comments as done. hokein added a comment. address remaining nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 Files: clang-tools-ext

r375119 - [OPENMP]Fix thread id passed to outlined region in sequential parallel

Author: abataev Date: Thu Oct 17 07:36:43 2019 New Revision: 375119 URL: http://llvm.org/viewvc/llvm-project?rev=375119&view=rev Log: [OPENMP]Fix thread id passed to outlined region in sequential parallel regions. The real global thread id must be passed to the outlined region instead of the zero

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3600 "attribute">; +def err_attribute_no_builtin_invalid_builtin_name : Error< + "'%0' is not a valid builtin name for %1">; aaron.ballman wrote: > I think this shou

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225435. gchatelet marked 13 inline comments as done. gchatelet added a comment. Herald added subscribers: s.egerton, simoncook, aheejin, dschuff. - Address comments - Fix missing rename - Address comments - Add warning category Repository: rG LLVM Github

r375124 - [ObjC] Add some additional test cases around pointer conversions.

Author: jyknight Date: Thu Oct 17 08:18:59 2019 New Revision: 375124 URL: http://llvm.org/viewvc/llvm-project?rev=375124&view=rev Log: [ObjC] Add some additional test cases around pointer conversions. This is especially important for Objective-C++, which is entirely missing this testing at the mo

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c982af05997: [ObjC] Add some additional test cases around pointer conversions. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D67982?vs=221586&id=225439#toc Repository: rG

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3416 + +def NoBuiltin : InheritableAttr { + let Spellings = [Clang<"no_builtin">]; I think we do not want this to be an inheritable attribute, but just `Attr` instead, because th

r375125 - [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object

Author: jyknight Date: Thu Oct 17 08:27:04 2019 New Revision: 375125 URL: http://llvm.org/viewvc/llvm-project?rev=375125&view=rev Log: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types. For example, in Objective-C mode, the initialization of 'x' in: ``` @implement

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccc4d83cda16: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer… (authored by jyknight). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1698399 , @xbolva00 wrote: > Current solution does not work > /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: > error: redefinition of ‘BImemccpy’ > > #define BUILTIN(ID, TYPE, ATTRS)

Re: r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

On Thu, 17 Oct 2019, 05:17 Stephan Bergmann via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > On 09/10/2019 04:04, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Tue Oct 8 19:04:54 2019 > > New Revision: 374135 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=374135&v

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

greened accepted this revision. greened added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67550/new/ https://reviews.llvm.org/D67550 ___ cfe-commits mailing list cfe-commit

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler added a comment. I added the negative option more as a way to disable the flag, since I'm currently looking at cases where it may want to be turned on by default (and a negative option would then allow you to only get .eh_frame in cases where you'd get both .debug_frame/.eh_frame). Th

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

DarkShadow44 added a comment. @akhuang Thanks for looking into this! I've found something else, I've written a small dumper to demonstrate. Pardon the long comment please. Program: typedef int* __ptr32 PINT32; typedef int* PINT64; struct s1 { PINT32 i32; PINT64 i64;

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225452. hliao added a comment. Force numbering on all lambdas in CUDA/HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h cl

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225455. MyDeveloperDay added a comment. Update out by one errors and unused variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 Files: clang/tools/clang-format/CMakeLists.txt clang/tools/cla

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1712863 , @hans wrote: > > I can't wait for @hans next Windows Snapshot, this is my gate for rolling > > into our builds and CI system, after that, I'm gonna catch every single > > person who tries to build/check

r375134 - [OPENMP]Improve use of the global tid parameter.

Author: abataev Date: Thu Oct 17 10:12:03 2019 New Revision: 375134 URL: http://llvm.org/viewvc/llvm-project?rev=375134&view=rev Log: [OPENMP]Improve use of the global tid parameter. If we can determined, that the global tid parameter can be used in the function, better to use it rather than call

[PATCH] D69088: [Lex] #pragma clang transform

ABataev added a comment. Why not try to improve the existing #pragma clang loop rather than add a new pragma with almost the same behavior? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 __

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225462. serge-sans-paille added a comment. Moved the implementation to a specialization of `emitStackProbeInline` that used to be Windows-centric. Provide a generic implementation that generates inline assembly instead. that way we don't clutter ex

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Extra note: an older version of the patch has been tested by the firefox team without much performance impact, (and no test failure), see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively reclaimed this revision. tlively added a comment. I'm re-opening this revision. After discussion on https://github.com/WebAssembly/simd/issues/118, there is clear consensus that we do not want to break WebAssembly's abstraction and consider underlying platforms, so shuffles should not b

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk created this revision. kousikk added reviewers: arphaman, Bigcheese, jkorous, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. kousikk edited the summary of this revision. kousikk edited the summary of this revision. If -resource-dir is not specified as pa

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilation, a tree representation is more intuitive. Even though there are cross-subtree edges, they are rare and also noted in the corresponding action

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao created this revision. hliao added reviewers: tra, sfantao, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilat

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. Could you give an example of before/after output? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https://reviews.llvm.org/D69124 ___ cfe-commits mailing list cfe-commits@

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

jkorous added a comment. I think you could've just used `CHECK-DAG` to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too. https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive Using `std::set` here sounds reasonable to me

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c ~/dummy.cpp 0: input, "/home/michliao/dummy.cpp", cud

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? For HIP $ clang -x hip -ccc-print-phases --cuda-gpu-arch=gfx900 --cuda-gpu-arch=gfx906 -c ~/dummy.cpp 0: input, "/home/michliao/dummy.c

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Sometimes a global var is replaced by a different llvm value. clang use GetAddrOfGlobalVar to get the original llvm global variable. For most targets, GetAddrOfGlobalV

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. This is... rather oddly-structured output. My brain refuses to accept that the most-indented phase is the input. Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give us something like this (withMaxIdent=9), which is somewhat easier to grok, IMO:

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:594 }; + struct CNSInfo { +TemplateArgumentList *TemplateArgs; Please add a documentation comment.

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

jkim added a comment. Ping... @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

r375167 - [OPENMP]Dow not emit warnings for uninitialized loop counters.

Author: abataev Date: Thu Oct 17 13:35:08 2019 New Revision: 375167 URL: http://llvm.org/viewvc/llvm-project?rev=375167&view=rev Log: [OPENMP]Dow not emit warnings for uninitialized loop counters. In OpenMP constructs all counters are initialized and we should not emit warnings about uninitialize

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. @Meinersbur, if I remember correctly, there was an RFC discussion on this topic, right? If yes, would you post the pointer to that? I need a refresher on what has been discussed/settled in the past. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713147 , @ABataev wrote: > Why not try to improve the existing #pragma clang loop rather than add a new > pragma with almost the same behavior? The behavior and syntax is different. #pragma clang loop ignores the o

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been discussed/settled

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225521. stevewan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.c

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69140 Files: clang/test/Driver/clang-offload-wrapper.

[PATCH] D69144: [Format] Add format check for throwing negative numbers

jonathoma created this revision. jonathoma added a reviewer: modocache. jonathoma added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathoma edited the summary of this revision. jonathoma added reviewers: sammccall, Quuxplusone. The code `throw

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc updated this revision to Diff 225523. poelmanc edited the summary of this revision. poelmanc added a comment. In D68682#1707764 , @alexfh wrote: > cleanupAroundReplacements is not used by clang-format itself. I believe, it's > a part of clang-for

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69140/new/ https://reviews.llvm.org/D69140 ___

r375177 - [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

Author: sdmitriev Date: Thu Oct 17 14:55:39 2019 New Revision: 375177 URL: http://llvm.org/viewvc/llvm-project?rev=375177&view=rev Log: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test Differential Revision: https://reviews.llvm.org/D69140 Modified: cfe/trunk/test

r375179 - [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

Author: efriedma Date: Thu Oct 17 14:57:28 2019 New Revision: 375179 URL: http://llvm.org/viewvc/llvm-project?rev=375179&view=rev Log: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3 It's completely impossible to check that I've actually found all the issues, due to the use of mac

  1   2   >