[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1697857 , @mitchell-stellar wrote: > I don't care for the command line switches that try to emulate compiler > flags. I am also of the opinion that external scripts should be used for this > functionality. git f

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1696864 , @MyDeveloperDay wrote: > I logged the original bug and I like it! > > I think the warning is better than mutating with a prefix, Thank you. > > I'll let the code owners approve it, but you have my vote! gla

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

ilya-biryukov added a comment. In D67536#1697825 , @sammccall wrote: > So I don't think clients will/should prefer that - for best rendering they > should know this is a line highlight. I have actually seen clients that just make the text gray and it lo

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1098-1099 + + if (D->hasAttr()) +D->dropAttr(); + aaron.ballman wrote: > gchatelet wrote: > > gchatelet wrote: > > > aaron.ballman wrote:

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. @steakhal Thanks for this patch. I tried it on Firefox and it found a bunch of stuff we improved. Some examples: https://hg.mozilla.org/integration/autoland/rev/db24db8f5f549ff446d1c3c69799187bcc2409e2 https://hg.mozilla.org/integration/autoland/rev/5de53dab979a40

r374032 - Remove an useless allocation (from by clang-analyzer/scan-build)

Author: sylvestre Date: Tue Oct 8 02:17:46 2019 New Revision: 374032 URL: http://llvm.org/viewvc/llvm-project?rev=374032&view=rev Log: Remove an useless allocation (from by clang-analyzer/scan-build) https://llvm.org/reports/scan-build/report-TargetInfo.cpp-detectFPCCEligibleStruct-9-1.html#EndPa

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

MyDeveloperDay added a comment. > I saw this issue when I submitted mine > (https://bugs.llvm.org/show_bug.cgi?id=43306) which for now seems to be a > harder fix, still looking for a solution there. oh boy!...are you gonna have to look at every variable/macro in scope and compare? Reposito

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. I'd like to assess where we are at with this revision, despite our concerns over additional complexity of clang-format, I don't think this is adding too much (I've seen far worse patches) It appears to me that these changes are mainly in mustBreak,canBreak etc...

[PATCH] D68630: [clangd] Disable expand auto on decltype(auto)

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Applying it produces incorrect code at the moment. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

jrtc27 updated this revision to Diff 223823. jrtc27 added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/div-sizeof-array.cpp Ind

r374035 - [Diagnostics] Silence -Wsizeof-array-div for character buffers

Author: jrtc27 Date: Tue Oct 8 04:34:02 2019 New Revision: 374035 URL: http://llvm.org/viewvc/llvm-project?rev=374035&view=rev Log: [Diagnostics] Silence -Wsizeof-array-div for character buffers Summary: Character buffers are sometimes used to represent a pool of memory that contains non-charact

[PATCH] D68630: [clangd] Disable expand auto on decltype(auto)

kuhnel added a comment. as the automatic build report did not work: Failing Tests (1): LLVM :: tools/llvm-ar/mri-utf8.test http://results.llvm-merge-guard.org/Phabricator-23/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68630/new/ https:

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

martong created this revision. martong added reviewers: a_sidorin, balazske, dkrupp, vbridgers. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. This way some CTU f

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f542aba72f: [Diagnostics] Silence -Wsizeof-array-div for character buffers (authored by jrtc27). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/

r374013 - [ItaniumMangle] Fix mangling of GNU __null in an expression to match GCC

Author: jrtc27 Date: Mon Oct 7 19:28:57 2019 New Revision: 374013 URL: http://llvm.org/viewvc/llvm-project?rev=374013&view=rev Log: [ItaniumMangle] Fix mangling of GNU __null in an expression to match GCC Reviewers: rsmith Reviewed By: rsmith Subscribers: erik.pilkington, cfe-commits Tags: #c

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1699288 , @MyDeveloperDay wrote: > > I saw this issue when I submitted mine > > (https://bugs.llvm.org/show_bug.cgi?id=43306) which for now seems to be a > > harder fix, still looking for a solution there. > > oh boy

r374042 - [SVE][IR] Scalable Vector size queries and IR instruction support

Author: huntergr Date: Tue Oct 8 05:53:54 2019 New Revision: 374042 URL: http://llvm.org/viewvc/llvm-project?rev=374042&view=rev Log: [SVE][IR] Scalable Vector size queries and IR instruction support * Adds a TypeSize struct to represent the known minimum size of a type along with a flag to in

[PATCH] D53137: Scalable vector core instruction support + size queries

This revision was automatically updated to reflect the committed changes. Closed by commit rGb302561b763a: [SVE][IR] Scalable Vector size queries and IR instruction support (authored by huntergr). Changed prior to commit: https://reviews.llvm.org/D53137?vs=222593&id=223835#toc Repository: rG

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added a comment. Nice! Thanks for adding support for RISC-V. I like the use of the ABI register names rather than the numeric names. I have a few queries/nits, below. Comment at: libunwind/include/libunwind.h:835 +// 64-bit RISC-V registers +enum { P

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: mgorny. Herald added a project: clang. The Transformer library has been growing inside of lib/Tooling/Refactoring. However, it's not really related to anything else in that directory. This revision moves

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

ABataev added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:616 if (getLangOpts().CUDAIsDevice) { -return IsKnownEmitted(*this, dyn_cast(CurContext)) +return (getEmissionStatus(dyn_cast(CurContext)) == +FunctionEmissionStatus::Emitted)

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Update header guards? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68637/new/ https://reviews.llvm.org/D68637

[clang-tools-extra] r374047 - [clangd] Bump timeouts in speculative completion tests

Author: kadircet Date: Tue Oct 8 06:54:03 2019 New Revision: 374047 URL: http://llvm.org/viewvc/llvm-project?rev=374047&view=rev Log: [clangd] Bump timeouts in speculative completion tests Modified: clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cpp Modified: clang-tools-extra/t

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

ymandel updated this revision to Diff 223840. ymandel added a comment. update header guards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68637/new/ https://reviews.llvm.org/D68637 Files: clang-tools-extra/clang-tidy/utils/CMakeLists.txt clang

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. There's just one other use of `-fno-ms-compatibility` in clang-tidy's test suite, so I'm not 100% sure this is the way to go. It's better than disabling the test completely on Windows :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.l

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis created this revision. thakis added a reviewer: rnk. thakis added a comment. There's just one other use of `-fno-ms-compatibility` in clang-tidy's test suite, so I'm not 100% sure this is the way to go. It's better than disabling the test completely on Windows :) In MS compatibility mod

[clang-tools-extra] r374048 - [clangd] Disable expand auto on decltype(auto)

Author: ibiryukov Date: Tue Oct 8 07:03:45 2019 New Revision: 374048 URL: http://llvm.org/viewvc/llvm-project?rev=374048&view=rev Log: [clangd] Disable expand auto on decltype(auto) Summary: Applying it produces incorrect code at the moment. Reviewers: sammccall Reviewed By: sammccall Subscri

[PATCH] D68630: [clangd] Disable expand auto on decltype(auto)

ilya-biryukov added a comment. In D68630#1699371 , @kuhnel wrote: > as the automatic build report did not work: Definitely unrelated, `llvm-ar` does not depend on clangd... I think I was unlucky with the base revision... Repository: rG LLVM Github M

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr added a comment. Hmm, forgot to add the last round of minor fixes before committing. Sorry about that, will push them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53137/new/ https://reviews.llvm.org/D53137 ___

[PATCH] D68630: [clangd] Disable expand auto on decltype(auto)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b36caf45e5e: [clangd] Disable expand auto on decltype(auto) (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68630/new/ https://r

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

gribozavr added a comment. It looks to me that a better fix is to fix the checker to not emit this warning in MS compatibility mode. I'm OK with "fixing" the test like this, however, it should come with a TODO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.l

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: hiraditya. Nice, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 __

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. In D68640#1699563 , @gribozavr wrote: > It looks to me that a better fix is to fix the checker to not emit this > warning in MS compatibility mode. The warning is about emitting "here's a redundant declaration", and the test exp

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

gribozavr added a comment. I'm holding off on reviewing the code until we figure out what the rules are. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-make-member-function-const.rst:10 +The check conservatively tries to preserve logical costness in favor of

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman added a comment. In D68640#1699563 , @gribozavr wrote: > It looks to me that a better fix is to fix the checker to not emit this > warning in MS compatibility mode. +1 > I'm OK with "fixing" the test like this, however, it should come wit

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

gribozavr added a comment. > There's no shortage of possible implicit TODOs I don't see "-fno-ms-compatibility" as an implicit TODO. It is most commonly used as "this test does something that does not work in MS mode". When I read it, I can't tell why it is there. When other people write tests,

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

ymandel updated this revision to Diff 223856. ymandel added a comment. update another cmakelists file (uncovered by linking for shared libs) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68637/new/ https://reviews.llvm.org/D68637 Files: clang-to

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman added a comment. In D68640#1699605 , @thakis wrote: > In D68640#1699563 , @gribozavr wrote: > > > It looks to me that a better fix is to fix the checker to not emit this > > warning in MS compatibilit

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 223855. lewis-revill added a comment. Rebased to fix conflicts with recent split SP adjustments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/

r374057 - [OPENMP50]Allow functions in declare variant directive to have different

Author: abataev Date: Tue Oct 8 07:56:20 2019 New Revision: 374057 URL: http://llvm.org/viewvc/llvm-project?rev=374057&view=rev Log: [OPENMP50]Allow functions in declare variant directive to have different C linkage. After some discussion with OpenMP developers, it was decided that the functions

r374061 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

Author: zer0 Date: Tue Oct 8 08:23:14 2019 New Revision: 374061 URL: http://llvm.org/viewvc/llvm-project?rev=374061&view=rev Log: [clang][ifs] Clang Interface Stubs ToolChain plumbing. Second Landing Attempt: This patch enables end to end support for generating ELF interface stubs directly from

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 updated this revision to Diff 223871. jrtc27 added a comment. Rebased, added explicit no-warning test, clang-format'ed, updated assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 Fil

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 marked an inline comment as done. jrtc27 added a comment. In D58531#1662466 , @jdoerfert wrote: > I like the patch and I think it is fine. > > Small nits: > Could we have a test for " we can detect dodgy pthread_create declarations" > and maybe `

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1698864 , @t-tye wrote: > I am a little unclear what this patch is doing as it is mentioned that the > mangled name has a _stub in it. My understanding is that the intention was to > create a distinct unmangled name for

r374072 - [OPENMP50]Prohibit multiple context selector sets in context selectors.

Author: abataev Date: Tue Oct 8 08:56:43 2019 New Revision: 374072 URL: http://llvm.org/viewvc/llvm-project?rev=374072&view=rev Log: [OPENMP50]Prohibit multiple context selector sets in context selectors. According to OpenMP 5.0, 2.3.2 Context Selectors, Restrictions, each trait-set-selector-nam

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > LLVM produces a poison value if the dynamic swizzle indices are greater than > the vector size, but the WebAssembly instruction sets the corresponding > output lane to zero. Where do we s

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Is there any reason to use llvm_unreachable here? I t

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:947 - virtual bool validateOutputSize(StringRef /*Constraint*/, + virtual bool validateOutputSize(const llvm::StringMap &FeatureMap, + StringRef /*Constraint*

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

hliao created this revision. hliao added reviewers: sfantao, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68652 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-syntax-only.hip In

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Thank you, this looks very clean now. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + "represent *the* corresponding IEEE rounding rules" =

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský wrote: >> FWIW I found the "always evaluates to 'true'" bit important to >> understand the warning. > > Yeah. I moved this check somewhere else, so we can print precise message: > r373973 should emit "bitwise negation of a boolean expression always >

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 223898. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-tool

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:99 +return false; + if (!dyn_cast(TargetDirective->getDeclContext())) +return false; ilya-biryukov wrote: > I believe this check is redundant i

[PATCH] D67980: [BPF] do compile-once run-everywhere relocation for bitfields

ast accepted this revision. ast added a comment. perfect. ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.org/D67980 ___ cfe-commits mailing list cfe-commits@lists

r374093 - [OPENMP50]Do not allow multiple same context traits in the same context

Author: abataev Date: Tue Oct 8 10:47:52 2019 New Revision: 374093 URL: http://llvm.org/viewvc/llvm-project?rev=374093&view=rev Log: [OPENMP50]Do not allow multiple same context traits in the same context selector. According to OpenMP 5.0, 2.3.2 Context Selectors, Restrictions, each trait-select

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. I tried the patch and rebased it locally (as there were conflicts with the current trunk) The change caused other tests to fail (which doesn't completely surprise me) most tests failures look associated with positioning of trailing brace for example @@ -1,4 +

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64" ---

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64" tra wrote: > I'd include

r374097 - [driver][hip] Skip bundler if host action is nothing.

Author: hliao Date: Tue Oct 8 11:06:51 2019 New Revision: 374097 URL: http://llvm.org/viewvc/llvm-project?rev=374097&view=rev Log: [driver][hip] Skip bundler if host action is nothing. Reviewers: sfantao, tra, yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6334a59454ef: [driver][hip] Skip bundler if host action is nothing. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68652?vs=223890&id=223905#toc Repository: rG LLVM Github Mo

r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Author: jkorous Date: Tue Oct 8 11:13:04 2019 New Revision: 374098 URL: http://llvm.org/viewvc/llvm-project?rev=374098&view=rev Log: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows Previously disabled in d0c2d5daa3e Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c Modi

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

tlively marked an inline comment as done. tlively added a comment. In D68531#1699855 , @aheejin wrote: > > LLVM produces a poison value if the dynamic swizzle indices are greater > > than the vector size, but the WebAssembly instruction sets the > > corr

r374099 - [BPF] do compile-once run-everywhere relocation for bitfields

Author: yhs Date: Tue Oct 8 11:23:17 2019 New Revision: 374099 URL: http://llvm.org/viewvc/llvm-project?rev=374099&view=rev Log: [BPF] do compile-once run-everywhere relocation for bitfields A bpf specific clang intrinsic is introduced: u32 __builtin_preserve_field_info(member_access, info_ki

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223908. mibintc added a comment. I made a couple wording changes suggested by @rjmccall Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/incl

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. In D68640#1699628 , @aaron.ballman wrote: > In D68640#1699605 , @thakis wrote: > > > In D68640#1699563 , @gribozavr > > wrote: > > > > > It looks to

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

thakis added a comment. (It regressed in D62780 ; I had bisected that bit.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68099/new/ https://reviews.llvm.org/D68099 ___ cfe-commits m

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1341 + has been selected, then the compiler will issue a diagnostic warning + that the override has occurred. + rjmccall wrote: > That's not typica

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:927 def fdenormal_fp_math_EQ : Joined<["-"], "fdenormal-fp-math=">, Group, Flags<[CC1Option]>; +def ffp_model_EQ : Joined<["-"], "ffp-model=">, Group, Fla

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

thakis accepted this revision. thakis added a comment. lgtm. I finally got around to understanding the patch. Sorry for the delay, thanks for the fix! Next time you upload a patch, please upload it with more context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-int

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223911. mibintc added a comment. clean up some dead code Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis added a comment. > Can you clarify what exactly the TODO is? As-is, the check suggests removing > the redeclaration where it's a no-op (non-ms) but not where it isn't (C, ms > compat). If I understand your reply correctly, this is desired behavior. Is > the TODO then to have test coverag

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

tra added a comment. TL; DR; +1 to formalizing how we want -M*/-E/-S/-emit-llvm/-fsyntax-only to behave. OK with -M/-E/-S defaulting to host, and erroring out if applied to multiple sub-compilations. I'm still convinced that the tooling issue with multiple subcompilations is orthogonal to this

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

adamf added a comment. @thakis Yes please, I cannot commit this patch by myself, because I don't have commit access. Surely, next time I will add more context in diff. Thanks a lot for the effort. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68099/new/ https://

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

thakis updated this revision to Diff 223917. thakis edited the summary of this revision. thakis added a comment. make test more explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 Files: clang-tools-extra/test/clang-tidy/readability-redun

Re: r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Almost: http://45.33.8.238/win/78/step_6.txt C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error: INVALID-MAPPED-FILE: expected string not found in input // INVALID-MAPPED-FILE: invalid-virtual-file.blacklist': No such file or directory ^ :1:1: note: s

[clang-tools-extra] r374103 - Try to get readability-deleted-default.cpp to pass on Windows.

Author: nico Date: Tue Oct 8 12:14:34 2019 New Revision: 374103 URL: http://llvm.org/viewvc/llvm-project?rev=374103&view=rev Log: Try to get readability-deleted-default.cpp to pass on Windows. In MS compatibility mode, "extern inline void g()" is not a redundant declaration for "inline void g()"

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 ___ cfe

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7842 +// This implementation is inspired by Sema::mergeDeclAttributes. +void ASTNodeImporter::CopyInheritedAttributes(FunctionDecl *Old, + FunctionDecl *New) { ---

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @kousikk Thanks, I understand your patch better now. It makes more sense for sure. When we're opening the file we shouldn't `stat` before calling `open`, as there's a race condi

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb804a3c9ce: Try to get readability-deleted-default.cpp to pass on Windows. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

r374105 - Try to get ubsan-blacklist-vfs.c pass more on Windows

Author: nico Date: Tue Oct 8 12:25:49 2019 New Revision: 374105 URL: http://llvm.org/viewvc/llvm-project?rev=374105&view=rev Log: Try to get ubsan-blacklist-vfs.c pass more on Windows Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao added a comment. In D68587#1700178 , @tra wrote: > TL; DR; > +1 to formalizing how we want -M*/-E/-S/-emit-llvm/-fsyntax-only to behave. > OK with -M/-E/-S defaulting to host, and erroring out if applied to multiple > sub-compilations. > I'm st

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao abandoned this revision. hliao added a comment. need to more clarification and re-design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68587/new/ https://reviews.llvm.org/D68587 ___ cfe-commits m

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

Yeah, I tried to fix even that case but is not so simple so not worth any extra time/complexivity. > Dňa 8. 10. 2019 o 19:09 užívateľ Arthur O'Dwyer > napísal: > >  > On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský > wrote: > >> FWIW I found the "always evaluates to 'true'" bit important to

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - So far, we only recognize the compilation with offloading and skip the offloading part. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6866

r374107 - [OPENMP50]Multiple vendors in vendor context must be treated as logical

Author: abataev Date: Tue Oct 8 12:44:16 2019 New Revision: 374107 URL: http://llvm.org/viewvc/llvm-project?rev=374107&view=rev Log: [OPENMP50]Multiple vendors in vendor context must be treated as logical and of vendors, not or. If several vendors are provided in the same vendor context trait, t

Re: r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

Thanks for the fix! > On Oct 8, 2019, at 12:06 PM, Nico Weber wrote: > > Almost: http://45.33.8.238/win/78/step_6.txt > > > C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error: > INVALID-MAPPED-FILE: expected string not found in inp

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:38 + + if (!Args.hasArg(options::OPT_nostdlib)) { +CmdArgs.push_back("-e"); Test with Clangtana on terran, when no '-nostdlib' specified, since '-e' & '__start' are the defau

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Xiangling_L wrote: > Is there any reason to use llvm_unr

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D67112#1655937 , @aaronpuchert wrote: > If anyone shares my feeling that the boolean output parameters of > `CompareReferenceRelationship` should rather move to the return va

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

r374110 - [clang] Add llvm-ifs in test deps

Author: vitalybuka Date: Tue Oct 8 13:23:24 2019 New Revision: 374110 URL: http://llvm.org/viewvc/llvm-project?rev=374110&view=rev Log: [clang] Add llvm-ifs in test deps Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68663 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/cl

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68610/new/ https://reviews.llvm.org/D68610 ___ cfe-c

[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

hliao added a comment. Adding this support is aimed to prevent crashing or failure, it's not intended to be final output for -M or -E. So, hip fails on these options due to the unsupported type of clang-offload-bundler. Before we nail down the details on the expected output of -M or -E, especia

r374113 - [clang] enable_trivial_var_init_zero should not be Joined<>

Author: vitalybuka Date: Tue Oct 8 13:34:53 2019 New Revision: 374113 URL: http://llvm.org/viewvc/llvm-project?rev=374113&view=rev Log: [clang] enable_trivial_var_init_zero should not be Joined<> Reviewers: rnk Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

This revision was automatically updated to reflect the committed changes. Closed by commit rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<> (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68610/new/

[PATCH] D68640: Try to get readability-deleted-default.cpp to pass on Windows.

gribozavr added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68640/new/ https://reviews.llvm.org/D68640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added a reviewer: klimek. tra added a comment. Added Manuel as someone familiar with tooling. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator()

  1   2   >