r373844 - [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

Author: paulhoad Date: Sun Oct 6 02:37:58 2019 New Revision: 373844 URL: http://llvm.org/viewvc/llvm-project?rev=373844&view=rev Log: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs Summary: The Google C++ and Chromium style guides are broken in the clang-format docs. This

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

This revision was automatically updated to reflect the committed changes. Closed by commit rL373844: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker marked 10 inline comments as done. Tyker added a comment. update done tasks. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: mitchell-stellar. MyDeveloperDay added a project: clang-format. Herald added a project: clang. Before making a proposed change, ensure ClangFormat.cpp is fully clang-formatted, no functional change just clang-formatting using

[PATCH] D29039: Proposal for clang-format -r option

MyDeveloperDay added a comment. When I first saw this issue some time ago I tended to agree with the comment regarding the "its not clang-formats" job to do that... However, over the last couple of months I've seen more and more twitter and stack-overflow comments regarding "how do I check my w

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

MyDeveloperDay added a comment. This should really be a full context diff -U9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 ___ cfe-commits mailing li

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

chill added a comment. I hope I will be able to pick this up in the following weeks and land patches a couple of weeks later. Sorry for the delay, but priorities shift all the time ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62394/new/ https://reviews.llvm.org/D62394 __

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

jrtc27 added a comment. Having said that, the one warning this raised in FreeBSD (at least for our configuration) was a completely unnecessary use of a character buffer and could be cleaned up, so maybe this case is a useful one to catch. Does anyone else have an opinion on this? Repository:

r373847 - [InstCombine] don't assume 'inbounds' for bitcast pointer to GEP transform (PR43501)

Author: spatel Date: Sun Oct 6 06:08:08 2019 New Revision: 373847 URL: http://llvm.org/viewvc/llvm-project?rev=373847&view=rev Log: [InstCombine] don't assume 'inbounds' for bitcast pointer to GEP transform (PR43501) https://bugs.llvm.org/show_bug.cgi?id=43501 We can't declare a GEP 'inbounds'

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

lebedev.ri added a comment. There's not a single word in the patch's description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526 ___ cfe-commits mailing list c

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Eugene.Zelenko added a comment. If clang-format if clang-formatted now completely, I think will be good idea to add rule to check this during build, like Polly does. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68551/new/ https://reviews.llvm.org/D68551

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

jrtc27 added a comment. In D68526#1696587 , @lebedev.ri wrote: > There's not a single word in the patch's description. If I were to add a description, it would be something like: Character buffers are sometimes used to represent a pool of memory that

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

xbolva00 added a comment. I think I saw some false positives with char buffers, so I am not against this patch personally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, owenpan. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a subscriber: mgorny. Herald added a project: clang. Related somewhat to D29039: [clang-format] Proposal for clang-f

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

klimek added a comment. Why not build a tool that takes the diff output of clang-format and changes it to what you want? Wouldn't that be a couple of lines of python? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68554/new/ https://reviews.llvm.org/D68554 ___

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1696675 , @klimek wrote: > Why not build a tool that takes the diff output of clang-format and changes > it to what you want? Wouldn't that be a couple of lines of python? Thanks for taking the time to look at t

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 223429. Daniel599 added a comment. added -U99 to diff cmd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/Identi

r373862 - [Sema] Avoids an assertion failure when an invalid conversion declaration is used

Author: rsmith Date: Sun Oct 6 11:40:59 2019 New Revision: 373862 URL: http://llvm.org/viewvc/llvm-project?rev=373862&view=rev Log: [Sema] Avoids an assertion failure when an invalid conversion declaration is used Summary: When using a user-defined conversion function template with a deduced re

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL373862: [Sema] Avoids an assertion failure when an invalid conversion declaration is… (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

r373866 - Implements CWG 1601 in [over.ics.rank/4.2]

Author: rsmith Date: Sun Oct 6 11:50:40 2019 New Revision: 373866 URL: http://llvm.org/viewvc/llvm-project?rev=373866&view=rev Log: Implements CWG 1601 in [over.ics.rank/4.2] Summary: The overload resolution for enums with a fixed underlying type has changed in the C++14 standard. This patch im

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

This revision was automatically updated to reflect the committed changes. Closed by commit rL373866: Implements CWG 1601 in [over.ics.rank/4.2] (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 223440. xbolva00 added a comment. Added some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.def test/CodeGen/builtin-memfns.c test/CodeGen/memccpy-libcall.c

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 223441. xbolva00 added a comment. Added it for msvc too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.def test/CodeGen/builtin-memfns.c test/CodeGen/memccpy-libc

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a subscriber: RKSimon. xbolva00 added a comment. Hm, Maybe we have a bug in LLVM's TLI? TLI says Win32 has no memccpy. https://llvm.org/doxygen/TargetLibraryInfo_8cpp_source.html line 333 cc @RKSimon since he knows windows-related things more. CHANGES SINCE LAST ACTION https://

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. @stringham you seemingly have marked this revision so that no one else can edit it, so I cannot add it to the clang-format project or reassign reviewers, could you please change it to be public, it also means others cannot request changes or approve it (if they

[PATCH] D31574: [clang-format] update documentation

mrexodia updated this revision to Diff 223443. mrexodia edited the summary of this revision. mrexodia removed reviewers: klimek, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31574/new/

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added a comment. @MyDeveloperDay done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. Could this patch solve https://bugs.llvm.org/show_bug.cgi?id=43573? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:")

xbolva00 added a comment. Do you plan to land it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66043/new/ https://reviews.llvm.org/D66043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D31574: [clang-format] update documentation

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31574/new/ https://reviews.llvm.org/D31574 __

[PATCH] D67980: [CLANG][BPF] do compile-once run-everywhere relocation for bitfields

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. lgtm. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.org/D67980

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added a comment. Any reason we are testing library search path using libgcc.a? We could use any dummy path there, and upload a dummy archive library for the testing purpose. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:112 + +AIX::~AIX() {} + We ar

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added a comment. nit: We might want to add period consistently for all the comments in the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 ___ c

r373874 - Fix behavior of __builtin_bit_cast when the From and To types are the

Author: rsmith Date: Sun Oct 6 19:45:12 2019 New Revision: 373874 URL: http://llvm.org/viewvc/llvm-project?rev=373874&view=rev Log: Fix behavior of __builtin_bit_cast when the From and To types are the same. We were missing the lvalue-to-rvalue conversion entirely in this case, and in fact still

r373875 - [c++20] Check for a class-specific operator delete when deleting an

Author: rsmith Date: Sun Oct 6 20:14:28 2019 New Revision: 373875 URL: http://llvm.org/viewvc/llvm-project?rev=373875&view=rev Log: [c++20] Check for a class-specific operator delete when deleting an object of class type with a virtual destructor. Modified: cfe/trunk/lib/AST/ExprConstant.cpp