[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67549/new/ https://reviews.llvm.org/D67549 ___ cfe-commits mailing lis

[PATCH] D65433: [clangd] DefineInline action availability checks

hokein added a comment. mostly good to me, a few more comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:183 +/// a.h: +/// void foo() { return ; } +/// kadircet wrote: > hokein wrote: > > now we get a potential ODR violation in t

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

hokein added a comment. I think the helper is only used by the defineInline tweak? not sure XRef.h is the best place for putting these helpers. Will we have more helpers in the future? If so, we may put them all in a new file. Comment at: clang-tools-extra/clangd/unittests/XR

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/file-filter.cpp:60 +// CHECK4-QUIET: header.h:1:12: warning: single-argument constructors must be marked explicit +// CHECK5: header.h:3:12: warning: single-argument constructors must be marked expli

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

MyDeveloperDay added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:555 + StringRef FileName = File->tryGetRealPathName(); + if (FileName.empty()) { +FileName = File->getName(); elide the {} Repository: rCTE Cl

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

This revision was automatically updated to reflect the committed changes. Closed by commit rL372380: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 &… (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D67549?vs=220886&id=220988#t

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

xyb updated this revision to Diff 220997. xyb marked 2 inline comments as done. xyb added a comment. Updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67501/new/ https://reviews.llvm.org/D67501 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extr

[PATCH] D67825: [AST] Extrat Decl::printQualifier helper from Decl::printQualifiedName.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a subscriber: usaxena95. Herald added a project: clang. To be used in clangd, e.g. in D66647 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67825 File

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Allows to simplify pending code tweaks: - the upcoming DefineInline tweak (D66647 ) - rem

[PATCH] D67827: [clangd] Simplify name qualification in DefineInline

ilya-biryukov added a comment. It's probably better to land this as part of D66647 , posting this here for demonstrative purposes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67827/new/ https://reviews.llvm.org/D6

[PATCH] D67827: [clangd] Simplify name qualification in DefineInline

ilya-biryukov created this revision. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. ilya-biryukov added parent revisions: D67826: [clangd] A helper to find explicit references and their names, D67825: [AST] Extrat Decl::printQualifier helper from D

[PATCH] D67825: [AST] Extract Decl::printQualifier helper from Decl::printQualifiedName

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:313 + /// Returns only qualifier from printQualifiedName, including the :: at the + /// end. E.g. This doesn't return anything, so I

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

ilya-biryukov updated this revision to Diff 221002. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Update comments - Rename new function to printNestedNameSpecifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6782

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/Decl.h:313 + /// Returns only qualifier from printQualifiedName, including the :: at the + /// end. E.g. aaron.ballman wrote: > This doesn't return anything, so I think a better way to p

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, I know it is trivial, but some more unittests wouldn't hurt anyone :D Also could you update the summary to mention "doing string manipulations in the presence of template arguments i

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

ilya-biryukov added a comment. In D67825#1676528 , @kadircet wrote: > LGTM, I know it is trivial, but some more unittests wouldn't hurt anyone :D Yeah, good point, I'll add a few besides tests for `printQualifiedName`. > Also could you update the summar

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/AST/Decl.h:317-318 + ///this function returns "A::B::". + void printQualifier(raw_ostream &OS) const; + void printQualifier(raw_ostream &OS, const PrintingPolicy &P

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/Decl.h:317-318 + ///this function returns "A::B::". + void printQualifier(raw_ostream &OS) const; + void printQualifier(raw_ostream &OS, const PrintingP

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:56 + const auto *ID = Result.Nodes.getNodeAs("impl"); + diag(ID->getLocation(), "%0 i

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks! Please let me know if you need me to commit the patch for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67501/new/ https://reviews.llvm.org/D67501 __

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/SourceCodeBuilders.h:9 +/// +/// /file +/// This file collects facilities for generating source-code strings. "\file" Comment at: clang/include/clang/Tooling/R

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

xyb added a comment. Yes, I need your help to submit the patch. I don't have the permission. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67501/new/ https://reviews.llvm.org/D67501 ___ cfe-commits mailing list cfe-commits@lists.llv

r372386 - [StaticAnalyzer] Use llvm::StringLiteral instead of StringRef in few places

Author: d0k Date: Fri Sep 20 05:59:29 2019 New Revision: 372386 URL: http://llvm.org/viewvc/llvm-project?rev=372386&view=rev Log: [StaticAnalyzer] Use llvm::StringLiteral instead of StringRef in few places StringRef's constexpr constructor seems to be extremely slow in MSVC 2017, so don't use it

[PATCH] D67635: Fix for stringized function-macro args continued across lines

kousikk added a comment. > I think you should obtain commit access for your future patches/commits. You > can follow the instructions here: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Thanks, I've done that! Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:320 + }; +} May I ask to keep the implementation order consistent with the header file

r372387 - [SystemZ] Add SystemZ as supporting target in help text for -mfentry.

Author: jonpa Date: Fri Sep 20 06:13:50 2019 New Revision: 372387 URL: http://llvm.org/viewvc/llvm-project?rev=372387&view=rev Log: [SystemZ] Add SystemZ as supporting target in help text for -mfentry. => "Insert calls to fentry at function entry (x86/SystemZ only)" Review: Ulrich Weigand Modi

[PATCH] D67830: [AArch64][SVE] Implement punpk[hi|lo] intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, rovka. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following two intrinsics: - int_aarch64_sve_punpkhi - int_aarc

[clang-tools-extra] r372388 - [clang-tidy] Fix relative path in header-filter.

Author: gribozavr Date: Fri Sep 20 06:19:32 2019 New Revision: 372388 URL: http://llvm.org/viewvc/llvm-project?rev=372388&view=rev Log: [clang-tidy] Fix relative path in header-filter. Summary: Clang-tidy supports output diagnostics from header files if user specifies --header-filter. But it can'

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372388: [clang-tidy] Fix relative path in header-filter. (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D67052: Add reference type transformation builtins

zoecarver updated this revision to Diff 221014. zoecarver added a comment. Herald added a subscriber: erik.pilkington. - address review comments - fix warnings in build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.o

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3412 break; + case UnaryTransformType::RemoveReferenceType: +Out << "3err"; Eric, I looked at your comment, but it seems

[PATCH] D67830: [AArch64][SVE] Implement punpk[hi|lo] intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM. Looks like a straightforward fix and support for `punpk(hi|lo)` intrinsics. Comment at: llvm/lib/IR/Function.cpp:1213 // If this is a forward reference, d

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Agreed on all points and then some -- next revision will have a bunch of cleanups. I think the only major issue is the return type. See below. Comment at: clang/lib/Tooling/Refactoring/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This patch implements the code generation to use OpenMP 5.0 declare mapper (e.g., user-defined mapper) constructs. It looks up the proper mapper functi

[PATCH] D67826: [clangd] A helper to find explicit references and their names

kadircet added a comment. Thanks this mostly LG, but I think we need some tests feel free to copy the ones in D66647 as a start point. But I believe coverage for this one is bigger, as this tries to figure-out all references, whereas the define-inline patch onl

r372394 - [CUDA][HIP] Fix hostness of defaulted constructor

Author: yaxunl Date: Fri Sep 20 07:28:09 2019 New Revision: 372394 URL: http://llvm.org/viewvc/llvm-project?rev=372394&view=rev Log: [CUDA][HIP] Fix hostness of defaulted constructor Clang does not respect the explicit device host attributes of defaulted special members. Also clang does not respe

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL372394: [CUDA][HIP] Fix hostness of defaulted constructor (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder marked an inline comment as done. scott.linder added inline comments. Comment at: include/clang/Frontend/CompilerInstance.h:362-363 + /// If not set, this stream defaults to \c llvm::errs(). + void setVerboseOutputStream(raw_ostream &Value, +

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel updated this revision to Diff 221041. ymandel added a comment. address comments and some general cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67632/new/ https://reviews.llvm.org/D67632 Files: clang/include/clang/Tooling/Refactor

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. CUDA/HIP program may be compiled with -fopenmp. In this case, -fopenmp is only passed to host compilation to take advantages

[libunwind] r372407 - Unwind: prevent unw_get_proc_info from returning stale data

Author: compnerd Date: Fri Sep 20 08:53:42 2019 New Revision: 372407 URL: http://llvm.org/viewvc/llvm-project?rev=372407&view=rev Log: Unwind: prevent unw_get_proc_info from returning stale data If unwind info is not available at the current IP, unw_get_proc_info should return a zero-filled struc

[PATCH] D51372: FENV_ACCESS support for libm-style constrained intrinsics

kpn abandoned this revision. kpn added a comment. I believe Serge Pavlov has demonstrated a better way to do this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51372/new/ https://reviews.llvm.org/D51372 ___ cfe-commits mailing list cfe-com

[PATCH] D52839: Inform AST's UnaryOperator of FENV_ACCESS

kpn abandoned this revision. kpn added a comment. I believe Serge Pavlov has demonstrated a better way to do this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52839/new/ https://reviews.llvm.org/D52839 ___ cfe-commits mailing list cfe-com

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

ymandel updated this revision to Diff 221050. ymandel marked 2 inline comments as done. ymandel added a comment. reordered decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67621/new/ https://reviews.llvm.org/D67621 Files: clang/include/clang/

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

ymandel added inline comments. Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:320 + }; +} gribozavr wrote: > May I ask to keep the implementation order consistent with the header file? Moved the decl in the header to match the ordering in the implem

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

ymandel updated this revision to Diff 221052. ymandel added a comment. reordered tests to match as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67621/new/ https://reviews.llvm.org/D67621 Files: clang/include/clang/Tooling/Refactoring/Rang

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

rjmccall added inline comments. Comment at: lib/Sema/Sema.cpp:1511 +if (Loc != S.DeviceCallGraph.end()) + S.DeviceCallGraph.erase(Loc); return; There's an overload of `DenseMap::erase` that just takes a key value, so this whole thing can be `S.Devi

[PATCH] D32435: clang-cl: Add support for /permissive-

Trass3r added a comment. Has this ever gotten anywhere? I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32435/new/ https://reviews.llvm.o

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

krytarowski added a comment. Looks good to me but I will leave the final decision to someone else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r372410 - [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

Author: ymandel Date: Fri Sep 20 10:11:03 2019 New Revision: 372410 URL: http://llvm.org/viewvc/llvm-project?rev=372410&view=rev Log: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators. Summary: Adds two new combinators and corresponding tests to the RangeSelector library. * `ifBo

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372410: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

phosek requested changes to this revision. phosek added a comment. This revision now requires changes to proceed. Actually, can you please add a test akin to https://github.com/llvm/llvm-project/blob/master/clang/test/Lexer/has_feature_memory_sanitizer.cpp? CHANGES SINCE LAST ACTION https://r

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. SamMaier added a reviewer: thakis. Previously, in order to have clang-format //not// format something, you had to give both: SortIncludes: false DisableFormat: true This is confusing to us

[PATCH] D67843: DisableFormat also now disables SortIncludes

thakis added a comment. Makes sense to me, but krasimir should probably approve this. Please upload patches with lots of context (`git diff -U master`); that makes reviewing on phab easier. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67843/new/ https://re

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier updated this revision to Diff 221065. SamMaier added a comment. Diff with more context Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67843/new/ https://reviews.llvm.org/D67843 Files: clang/lib/Format/Format.cpp clang/test/Format/disable-format.cpp

r372414 - Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions'

Author: szelethus Date: Fri Sep 20 10:59:20 2019 New Revision: 372414 URL: http://llvm.org/viewvc/llvm-project?rev=372414&view=rev Log: Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions' Differential Revision: https://reviews.llvm.org/D54823 Modified: cfe/trunk/li

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221066. vsk retitled this revision from "[Mangle] Check ExternalASTSource before adding prefix to asm label names" to "[Mangle] Add flag to asm labels to disable global prefixing". vsk edited the summary of this revision. vsk added a comment. Thanks for your fee

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL372414: Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions' (authored by Szelethus, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

r372415 - [www] Turn 'Clang 9' boxes green in C++ status pages now Clang 9 is

Author: rsmith Date: Fri Sep 20 11:09:05 2019 New Revision: 372415 URL: http://llvm.org/viewvc/llvm-project?rev=372415&view=rev Log: [www] Turn 'Clang 9' boxes green in C++ status pages now Clang 9 is released. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_status.html c

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 221070. Charusso marked 9 inline comments as done. Charusso added a comment. - Try to do the math. - Create a consistent dynamic type API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D67079 Files: clang/incl

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:126 + + // If the casts have a common anchestor it could not be a succeeded downcast. + for (const auto &PreviousBase : PreviousRD->bases()) NoQ wrote: > Charusso

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder updated this revision to Diff 221075. scott.linder added a comment. After reading again I think I understand the ask now. Is this closer to what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 Files: include/clan

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:44 + +bool isDerivedFrom(QualType X, QualType Y) { + const CXXRecordDecl *XRD = X->getPointeeCXXRecordDecl(); Hmm, I think this function answers the question, at least in

r372419 - Fix a documentation error

Author: szelethus Date: Fri Sep 20 11:28:04 2019 New Revision: 372419 URL: http://llvm.org/viewvc/llvm-project?rev=372419&view=rev Log: Fix a documentation error Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cp

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

erichkeane created this revision. erichkeane added a reviewer: eli.friedman. Herald added a subscriber: jfb. RebuildAtomicExpr was skipping doing semantic analysis which broke in the cases where the expressions were not dependent. This resulted in the ImplicitCastExpr from an array to a pointer be

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

gribozavr added inline comments. Comment at: clang/lib/Tooling/Refactoring/SourceCodeBuilders.cpp:68 +std::string tooling::buildParens(const Expr &E, const ASTContext &Context) { + StringRef ExprText = getText(E, Context); + if (mayNeedParens(E)) ymandel wrote:

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo updated this revision to Diff 221086. mstorsjo added a comment. Updated the CUDA test based on the suggestion. @rsmith - What do you think of this version, the warning message, and the invariants for the `isInlineDefinitionExternallyVisible` method? CHANGES SINCE LAST ACTION https:/

r372422 - Ensure AtomicExpr goes through SEMA checking after TreeTransform

Author: erichkeane Date: Fri Sep 20 12:17:31 2019 New Revision: 372422 URL: http://llvm.org/viewvc/llvm-project?rev=372422&view=rev Log: Ensure AtomicExpr goes through SEMA checking after TreeTransform RebuildAtomicExpr was skipping doing semantic analysis which broke in the cases where the expre

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

This revision was automatically updated to reflect the committed changes. Closed by commit rL372422: Ensure AtomicExpr goes through SEMA checking after TreeTransform (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder updated this revision to Diff 221089. scott.linder added a comment. Same patch, this time with a working test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/Compile

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus added a comment. Welp, windows builtbots broke again. I'll try to see whats wrong with undef sanitizer, but fear this will end up in a revert. http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19769/steps/test-check-all/logs/stdio Repository: rL LLVM

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl updated this revision to Diff 221097. yaxunl added a comment. reuse the call tree. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: lib/Sema/Sema.cpp test/SemaCUDA/openmp-static-func.cu Index: test/SemaCUDA/openmp-static-func.

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso marked 3 inline comments as done. Charusso added a comment. Thanks! Comment at: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:22-33 +constexpr llvm::StringLiteral FuncExprName = "entire-called-function-expr"; +constexpr llvm::StringLiteral Cas

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 221096. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45050/new/ https://reviews.llvm.org/D45050 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLi

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/Sema.cpp:1511 +if (Loc != S.DeviceCallGraph.end()) + S.DeviceCallGraph.erase(Loc); return; rjmccall wrote: > There's an overload of `DenseMap::erase` that ju

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel updated this revision to Diff 221103. ymandel added a comment. converted builders to return optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67632/new/ https://reviews.llvm.org/D67632 Files: clang/include/clang/Tooling/Refactoring/

[libunwind] r372427 - Unwind: avoid warning about unused typedef

Author: compnerd Date: Fri Sep 20 13:46:33 2019 New Revision: 372427 URL: http://llvm.org/viewvc/llvm-project?rev=372427&view=rev Log: Unwind: avoid warning about unused typedef Move the definition of Elf_Addr typedef to the only place it is used, to avoid: ``` llvm-project/libunwind/src/Address

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach created this revision. dmaclach added a reviewer: alexfh. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, mgorny. Herald added a project: clang. We ran into a problem in protocol buffers recently when compiling with Xcode 11 that caused crashes on 32 bit ARM architecture

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added a comment. Looks like CUDA test-suite is triggering the assertion added by this patch: http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37301/steps/ninja%20build%20simple%20CUDA%20tests/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:725 let Spellings = [Keyword<"asm">, Keyword<"__asm__">]; - let Args = [StringArgument<"Label">]; + let Args = [StringArgument<"Label">, BoolArgument<"LiteralLabel">]; let SemaHandler = 0; -

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

rjmccall added inline comments. Comment at: lib/Sema/Sema.cpp:1511 +if (Loc != S.DeviceCallGraph.end()) + S.DeviceCallGraph.erase(Loc); return; yaxunl wrote: > rjmccall wrote: > > There's an overload of `DenseMap::erase` that just takes a key value,

r372436 - [SystemZ] Support z15 processor name

Author: uweigand Date: Fri Sep 20 16:06:03 2019 New Revision: 372436 URL: http://llvm.org/viewvc/llvm-project?rev=372436&view=rev Log: [SystemZ] Support z15 processor name The recently announced IBM z15 processor implements the architecture already supported as "arch13" in LLVM. This patch adds

r372437 - Fix assertion failure when constant evaluation of a switch jumps over an

Author: rsmith Date: Fri Sep 20 16:08:59 2019 New Revision: 372437 URL: http://llvm.org/viewvc/llvm-project?rev=372437&view=rev Log: Fix assertion failure when constant evaluation of a switch jumps over an uninitialized variable in an init-statement of a 'for' or 'if'. Modified: cfe/trunk/lib

r372438 - Remove outdated FIXME.

Author: rsmith Date: Fri Sep 20 16:12:51 2019 New Revision: 372438 URL: http://llvm.org/viewvc/llvm-project?rev=372438&view=rev Log: Remove outdated FIXME. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl added a comment. In D67509#1677528 , @tra wrote: > Looks like CUDA test-suite is triggering the assertion added by this patch: > > http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37301/steps/ninja%20build%20simple%20CUDA%20tests/logs/stdio

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 221128. dgatwood marked 5 inline comments as done. dgatwood added a comment. Renamed to ExemptClassPrefixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMak

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( + objcCategoryDecl())).bind(CustomCategoryMethodIdentifier), this); +} stephanemoo

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 221142. dgatwood added a comment. Updated the configuration key in the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-ex

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

zhaomo updated this revision to Diff 221140. zhaomo added a comment. In this new patch, I added a "level" field to type metadata when vtable interleaving is enabled. Currently type metadata is a (byte offset, type) pair. However, suppose T1 and T2 are compatible with the same offset of a vtable

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

Eugene.Zelenko added inline comments. Comment at: clang-tidy/objc/AvoidOSReadCheck.cpp:21 +void AvoidOSReadCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee((functionDecl(hasAnyName( Please add check if language is Objec

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

Eugene.Zelenko added inline comments. Comment at: clang-tidy/objc/AvoidOSReadCheck.h:5 +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. License was changed this year. Same in source file. Re

r372444 - [clang-scan-deps] strip the --serialize-diagnostics argument

Author: arphaman Date: Fri Sep 20 17:17:26 2019 New Revision: 372444 URL: http://llvm.org/viewvc/llvm-project?rev=372444&view=rev Log: [clang-scan-deps] strip the --serialize-diagnostics argument This ensures that clang-scan-deps won't write out diagnostics when scanning dependencies. Added:

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore requested changes to this revision. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( +

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Thanks for the review! Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:56 + const auto *ID = Result.Nodes.getNodeAs("impl"); + diag(ID->getLocation(), "%0 implements -isEqual: wi

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

This revision was automatically updated to reflect the committed changes. stephanemoore marked an inline comment as done. Closed by commit rL372445: [clang-tidy] Add check for classes missing -hash ⚠️ (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscrib

r372448 - Improve -Wtautological-overlap-compare

Author: rtrieu Date: Fri Sep 20 19:37:10 2019 New Revision: 372448 URL: http://llvm.org/viewvc/llvm-project?rev=372448&view=rev Log: Improve -Wtautological-overlap-compare Allow this warning to detect a larger number of constant values, including negative numbers, and handle non-int types better.

[PATCH] D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL372448: Improve -Wtautological-overlap-compare (authored by rtrieu, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r372452 - Revert assertion added by r372394

Author: yaxunl Date: Fri Sep 20 19:51:44 2019 New Revision: 372452 URL: http://llvm.org/viewvc/llvm-project?rev=372452&view=rev Log: Revert assertion added by r372394 The assertion added by r372394 causes CUDA test in test-suite to assert. The assertion was not there originally, so revert it.

r372453 - Merge and improve code that detects same value in comparisons.

Author: rtrieu Date: Fri Sep 20 20:02:26 2019 New Revision: 372453 URL: http://llvm.org/viewvc/llvm-project?rev=372453&view=rev Log: Merge and improve code that detects same value in comparisons. -Wtautological-overlap-compare and self-comparison from -Wtautological-compare relay on detecting the

  1   2   >