[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The check was generating a fix without taking qualifiers in return type into account. This patch changes the insertion location to be before qualif

r371021 - Rename of constants in ASTImporterVisibilityTest. NFC.

Author: balazske Date: Thu Sep 5 00:59:45 2019 New Revision: 371021 URL: http://llvm.org/viewvc/llvm-project?rev=371021&view=rev Log: Rename of constants in ASTImporterVisibilityTest. NFC. Reviewers: martong, a.sidorin, shafik Reviewed By: shafik Subscribers: shafik, rnkovacs, dkrupp, Szelethu

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

Szelethus added a comment. Also, please mark inlines done as you fix them :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D67174: Rename of constants in ASTImporterVisibilityTest. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371021: Rename of constants in ASTImporterVisibilityTest. NFC. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

Szelethus accepted this revision. Szelethus added a reviewer: steakhal. Szelethus added a comment. This revision is now accepted and ready to land. Some nits inline, otherwise LGTM. @steakhal, do you have anything to add to this? Comment at: lib/StaticAnalyzer/Checkers/Generic

[clang-tools-extra] r371022 - [clang-tidy] Fix definitions in headers check to respect qualifiers

Author: kadircet Date: Thu Sep 5 01:11:21 2019 New Revision: 371022 URL: http://llvm.org/viewvc/llvm-project?rev=371022&view=rev Log: [clang-tidy] Fix definitions in headers check to respect qualifiers Summary: The check was generating a fix without taking qualifiers in return type into account.

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371022: [clang-tidy] Fix definitions in headers check to respect qualifiers (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Author: hans Date: Thu Sep 5 01:43:00 2019 New Revision: 371027 URL: http://llvm.org/viewvc/llvm-project?rev=371027&view=rev Log: Revert r361885 "[Driver] Fix -working-directory issues" This made clang unable to open files using relative paths on network shares on Windows (PR43204). On the bug i

Re: r361885 - [Driver] Fix -working-directory issues

I've reverted this in r371027 as discussed on PR43204. On Wed, May 29, 2019 at 12:18 AM Michael J. Spencer via cfe-commits wrote: > > Author: mspencer > Date: Tue May 28 15:21:47 2019 > New Revision: 361885 > > URL: http://llvm.org/viewvc/llvm-project?rev=361885&view=rev > Log: > [Driver] Fix -wo

r371032 - [Sema] Refactor LookupVisibleDecls. NFC

Author: ibiryukov Date: Thu Sep 5 01:59:06 2019 New Revision: 371032 URL: http://llvm.org/viewvc/llvm-project?rev=371032&view=rev Log: [Sema] Refactor LookupVisibleDecls. NFC Summary: We accumulated some configuration parameters for LookupVisibleDecls that are being passed unchanged to recursive

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL371032: [Sema] Refactor LookupVisibleDecls. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook planned changes to this revision. simoncook added a comment. Thanks for the feedback. I will improve the test so it more reliably tests what it intends to. With regards to behaviour surrounding things such as argument registers, before submitting I checked what the riscv port of GCC d

[clang-tools-extra] r371036 - [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

Author: hokein Date: Thu Sep 5 02:14:04 2019 New Revision: 371036 URL: http://llvm.org/viewvc/llvm-project?rev=371036&view=rev Log: [clangd][vscode] Make SemanticHighlightingFeature more self-contained. Summary: so that we don't have too many usage from the client side (just a single occurrance

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371036: [clangd][vscode] Make SemanticHighlightingFeature more self-contained. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1658365 , @aaron.ballman wrote: > Ah, good to know! That reduces my concern, but doesn't negate it. AFAIK, we > haven't changed the interface such that it requires code changes rather than > just a recompile in recen

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein updated this revision to Diff 218864. hokein marked 2 inline comments as done. hokein added a comment. rebase and simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67096/new/ https://reviews.llvm.org/D67096 Files: clang-too

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature( +

[PATCH] D67216: [cfi] Add flag to always generate call frame information

dcandler created this revision. dcandler added reviewers: echristo, probinson, aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. This adds a flag to LLVM and clang to always generate call frame information, ev

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67096/new/ https://reviews.llvm.org/D67096

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

hokein added a comment. thanks for the fix. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67213/new/ https://reviews.llvm.org/D67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang-tools-extra] r371038 - [clangd][vscode] Add a flag to enable semantic highlighting in clangd

Author: hokein Date: Thu Sep 5 02:26:03 2019 New Revision: 371038 URL: http://llvm.org/viewvc/llvm-project?rev=371038&view=rev Log: [clangd][vscode] Add a flag to enable semantic highlighting in clangd Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL371038: [clangd][vscode] Add a flag to enable semantic highlighting in clangd (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r371041 - [libclang] Refactored SharedParsedRegionsStorage

Author: gribozavr Date: Thu Sep 5 02:48:39 2019 New Revision: 371041 URL: http://llvm.org/viewvc/llvm-project?rev=371041&view=rev Log: [libclang] Refactored SharedParsedRegionsStorage Summary: Removed the `PPRegionSetTy` typedef because it is only used 3 times, and obscures code more than it hel

Re: r370850 - Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"

Merged to release_90 in r371040. On Wed, Sep 4, 2019 at 10:17 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Wed Sep 4 01:19:30 2019 > New Revision: 370850 > > URL: http://llvm.org/viewvc/llvm-project?rev=370850&view=rev > Log: > Re-commit r363191 "[MS] Pretend constexpr variab

[PATCH] D67077: [libclang] Refactored SharedParsedRegionsStorage

This revision was automatically updated to reflect the committed changes. Closed by commit rL371041: [libclang] Refactored SharedParsedRegionsStorage (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D67216: [cfi] Add flag to always generate call frame information

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Does the name of the `-falways-need-cfi` option match any existing compiler (google doesn't find anything)? If not, I think it would make more sense as a `-g` option, as it's s

r371046 - [OpenCL] Add image type handling for builtins

Author: svenvh Date: Thu Sep 5 03:01:24 2019 New Revision: 371046 URL: http://llvm.org/viewvc/llvm-project?rev=371046&view=rev Log: [OpenCL] Add image type handling for builtins Image types were previously available, but not working. This patch adds image type handling. Rename the image type d

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware updated this revision to Diff 218876. baloghadamsoftware added a comment. Herald added a subscriber: srhines. Herald added a reviewer: jdoerfert. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64736/new/ https://reviews.llvm.org/D6473

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218878. kadircet marked 2 inline comments as done. kadircet added a comment. - Define more strict semantics around filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:130 +/// pointed by FID. +Tweak::Effect fileEdit(const SourceManager &SM, FileID FID, + tooling::Replacements Replacements); kadircet wrote: > kadircet wro

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham marked 2 inline comments as done. simon_tatham added a comment. On the general discomfort with this attribute existing: I'd be happy to lock it down, or mark it as "not recommended" in some way, if that's any help. I don't personally intend any use of it outside a single system head

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

lebedev.ri added a comment. In D67159#1659084 , @simon_tatham wrote: > On the general discomfort with this attribute existing: I'd be happy to lock > it down, or mark it as "not recommended" in some way, if that's any help. I > don't personally intend a

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218883. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham added a comment. Come to think of it, it would also not be too hard to constrain it to //only// be usable for a particular subset of builtins, and perhaps even only with a particular set of alias names for them. (I could easily derive all that information from the same Tablegen tha

Re: r369760 - [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Merged to release_90 in r371058. On Fri, Aug 23, 2019 at 4:19 PM Kristof Umann via cfe-commits wrote: > > Author: szelethus > Date: Fri Aug 23 07:21:13 2019 > New Revision: 369760 > > URL: http://llvm.org/viewvc/llvm-project?rev=369760&view=rev > Log: > [analyzer] Avoid unnecessary enum range che

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb updated this revision to Diff 218892. xyb added a comment. Update patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67056/new/ https://reviews.llvm.org/D67056 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extra/clang-tidy/bugprone/Argument

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Merged to release_90 in r371060. On Thu, Sep 5, 2019 at 10:41 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Thu Sep 5 01:43:00 2019 > New Revision: 371027 > > URL: http://llvm.org/viewvc/llvm-project?rev=371027&view=rev > Log: > Revert r361885 "[Driver] Fix -working-directory

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb updated this revision to Diff 218893. xyb added a comment. Rebase patch with current HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extra/test/clang

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:30 +ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "WhitelistedPrefixes", WhitelistedPrefixes); +} aaron.ballman wrote: >

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

steakhal added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:191 static TaintPropagationRule -getTaintPropagationRule(const FunctionDecl *FDecl, StringRef Name, +getTaintPropagationRule(const GenericTaintChecker *Checker, +

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. I have not seen this problem resurface to be honest. When we initially hit it, changing the path for the build worked around the problem for us so we weren't really hitting in any longer. I posted this because I realized the possibility exists of having these dangling

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, This Resolver should have the same lin

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook added a comment. For added context, I have gone and double-checked with GCC's implementation both for AArch64 and RISC-V and for registers used by the calling convention the compiler will still use them for argument passing and return values, but otherwise won't use it for any tempora

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added a comment. Actually... I think it might need to be weak_odr based on https://llvm.org/docs/LangRef.html#linkage-types We want the merge semantics, but need to make sure that the symbols aren't discarded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https:

r371066 - Add -m(no)-spe to clang

Author: jhibbits Date: Thu Sep 5 06:38:46 2019 New Revision: 371066 URL: http://llvm.org/viewvc/llvm-project?rev=371066&view=rev Log: Add -m(no)-spe to clang Summary: r337347 added support for the Signal Processing Engine (SPE) to LLVM. This follows that up with the clang side. This adds -mspe

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL371066: Add -m(no)-spe to clang (authored by jhibbits, committed by ). Herald added a project: LLVM. Herald added a subscr

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

aaron.ballman added a comment. In D67159#1659103 , @simon_tatham wrote: > Come to think of it, it would also not be too hard to constrain it to > //only// be usable for a particular subset of builtins, and perhaps even only > with a particular set of al

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits, thank you for merging. Will we have this in LLVM 9.0? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 ___ cfe-commits mailing list cfe-commi

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

Abpostelnicu added a comment. Herald added a project: clang. @aaron.ballman I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Steven to finish this work and replace auto by the "old" way. Do you think we can h

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. Currently, the completions are not shown to the user as VSCode tries to match 'filterText' against the text in the edit range. Since the text co

[clang-tools-extra] r371072 - [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

Author: alexfh Date: Thu Sep 5 07:13:57 2019 New Revision: 371072 URL: http://llvm.org/viewvc/llvm-project?rev=371072&view=rev Log: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked. Summary: For example: ``` void foo(int a); foo(-2); ``` should be fixed as:

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371072: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not… (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaron.ballman added a comment. In D66919#1658483 , @aaronpuchert wrote: > In D66919#1658355 , @aaron.ballman > wrote: > > > We do have numerous warnings that are default errors, you can look for > > `DefaultError

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Not in 9.0, but I will try to push for it in 9.0.1. To others, for posterity, I pushed *only* the SPE subset, not the 8548 CPU component. That will be a separate commit. I wanted it to be more than just a dummy stub, so that part will be a separate commit. The part

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1658969 , @gribozavr wrote: > In D67140#1658365 , @aaron.ballman > wrote: > > > Ah, good to know! That reduces my concern, but doesn't negate it. AFAIK, we > > haven't chan

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

aaron.ballman added a comment. In D54408#1659301 , @Abpostelnicu wrote: > @aaron.ballman > I think the auto usage improves and simplifies the code, however, as I would > really like to see this code landed, I would be ok to help Stephen to finish > th

[clang-tools-extra] r371076 - [clang-tidy] Make most ArgumentCommentCheck options local, as they should be

Author: alexfh Date: Thu Sep 5 07:48:31 2019 New Revision: 371076 URL: http://llvm.org/viewvc/llvm-project?rev=371076&view=rev Log: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ArgumentCommentCheck.cpp

[clang-tools-extra] r371075 - Add a bugprone-argument-comment option: IgnoreSingleArgument.

Author: alexfh Date: Thu Sep 5 07:48:23 2019 New Revision: 371075 URL: http://llvm.org/viewvc/llvm-project?rev=371075&view=rev Log: Add a bugprone-argument-comment option: IgnoreSingleArgument. Summary: Add bugprone-argument-comment option: IgnoreSingleArgument. When true, the check will ignore

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371075: Add a bugprone-argument-comment option: IgnoreSingleArgument. (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

sammccall updated this revision to Diff 218926. sammccall added a comment. remove special-case handling of VarDecl in ExtractFunction that is no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66872/new/ https://reviews.llvm.org/D6687

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Szelethus added a comment. In D67140#1658365 , @aaron.ballman wrote: > Then again, with the recent resurfacing of discussions about renaming > everything under the sun, maybe we've changed our community opinion here. :-D > I guess I don't see Check vs

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Changing behavior of clangd might affect other clients. It would be nice to find alternative ways to fix this. Nevertheless, posting this here as an example of a potential workaround for the problem. Repository: r

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. I'm still working on this, just been kinda busy. I'll try to get it out of the way asap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66716/new/ https://reviews.llvm.org/D66716 ___

r371079 - [ARM] Add support for the s,j,x,N,O inline asm constraints

Author: dcandler Date: Thu Sep 5 08:17:25 2019 New Revision: 371079 URL: http://llvm.org/viewvc/llvm-project?rev=371079&view=rev Log: [ARM] Add support for the s,j,x,N,O inline asm constraints A number of inline assembly constraints are currently supported by LLVM, but rejected as invalid by Cl

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rL371079: [ARM] Add support for the s,j,x,N,O inline asm constraints (authored by dcandler, committed by ). Changed prior to commit: https://reviews.llvm.org/D65863?vs=214205&id=218927#toc Repository:

r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: aganea Date: Thu Sep 5 08:24:49 2019 New Revision: 371080 URL: http://llvm.org/viewvc/llvm-project?rev=371080&view=rev Log: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial Differential Revision: https://reviews.llvm.org/D66328 Added: cfe/t

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rL371080: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as… (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D66328?vs=218515&id=218928

[clang-tools-extra] r371081 - [clangd] Initialize int field to zero. NFC

Author: ibiryukov Date: Thu Sep 5 08:30:05 2019 New Revision: 371081 URL: http://llvm.org/viewvc/llvm-project?rev=371081&view=rev Log: [clangd] Initialize int field to zero. NFC To make sure we do not have uninitialized values and undefined behavior. Modified: clang-tools-extra/trunk/clangd

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof, jakehehrlich

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo CHA

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCo

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCo

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

epastor updated this revision to Diff 218934. epastor added a comment. - Add testing for the new deprecation declarations mangling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67202/new/ https://reviews.llvm.org/D67202 Files: clang/include/clan

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

epastor added a comment. The change passes ninja check-clang - and I've added a test per your suggestions. Thanks! As for llvm-undname: it works reasonably well, but these are anonymous names. It successfully recognizes $S1, etc. as the "name", though! Repository: rG LLVM Github Monorepo C

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. I don't think you need prior frontend expertise, just some time and patience since the modules code has some technical debt. If you are still willing to look at it, I agree with Richard's suggestion that we could merge this with the map in the Module Manager. One a

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 218936. kadircet marked 4 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: cla

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

> On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: dexonsmith > Date: Mon Aug 26 11:29:51 2019 > New Revision: 369943 > > URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added a comment. Could you give it a slightly more general name and then use it in the main semantic check in ActOnFields? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256 __

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218953. dgatwood marked 7 inline comments as done. dgatwood added a comment. Fixed a couple of variable names in the .h file, renamed kCustomCategoryMethodIdentifier to CustomCategoryMethodIdentifier, and switched to llvm::any_of. CHANGES SINCE LAST ACTIO

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added a comment. Ah. I expected my comments to be submitted as part of uploading a new revision. Still learning this UI. :-/ Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name = method_declarat

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. I think I have addressed all comments posted so far. Do you have more notes/comments/suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing l

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 218959. pirama added a comment. Herald added a subscriber: emaste. Supported this flag for NetBSD and FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200 Fi

[PATCH] D67200: Add -static-openmp driver option

danalbert added a comment. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:503 bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, - const ArgList &Args, bool IsOffloadingHost, -

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Re llvm-undname: That seems to match behavior of MSVC's undname, so I'd say that's all good :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

On Thu, Sep 5, 2019 at 9:57 AM Duncan P. N. Exon Smith wrote: > > > On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dexonsmith >> Date: Mon Aug 26 11:29:51 2019 >>

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/SemaTemplate/instantiate-incomplete-typo-suggested-error-limit.cpp:1 +// RUN: not %clang -fsyntax-only -std=c++11 -ferror-limit=1 %s 2>&1 | FileCheck %s + aaron.ba

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 218965. Mordante marked an inline comment as done. Mordante added a comment. Removes the unnecessary std::move as suggested by @aaron.ballman. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64644/new/ https://reviews.llvm.org/D64644 Files: clang/

Re: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Hi Alexandre, Looks like this commit is causing crashes on darwin, can you take a look please? Here is a failing bot: http://lab.llvm.org:8080/green/job/clang-stage1-RA/1671/ Thanks! Erik On Thu, Sep 5, 2019 at 11:23 AM Alexandre Ganea via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Auth

r371112 - [AST][NFC] Doc comments for ASTNameGenerator

Author: jkorous Date: Thu Sep 5 13:04:11 2019 New Revision: 371112 URL: http://llvm.org/viewvc/llvm-project?rev=371112&view=rev Log: [AST][NFC] Doc comments for ASTNameGenerator Modified: cfe/trunk/include/clang/AST/Mangle.h Modified: cfe/trunk/include/clang/AST/Mangle.h URL: http://llvm.o

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

vsk added a comment. Still think this looks good. Have you tried running this on the llvm test suite, or some other interesting corpus? Would be curious to see any pre/post patch numbers. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4703-4720 +// 2) The sign of the diff

r371113 - Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: aganea Date: Thu Sep 5 13:12:20 2019 New Revision: 371113 URL: http://llvm.org/viewvc/llvm-project?rev=371113&view=rev Log: Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial Removed: cfe/trunk/test/CodeGenCXX/debug-info-atexit-stub.cp

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 218970. jpakkane marked 2 inline comments as done. jpakkane added a comment. Fixed issues raised in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/cppcoreguide

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1659356 , @aaron.ballman wrote: > In D67140#1658969 , @gribozavr wrote: > > > In D67140#1658365 , @aaron.ballman > > wrote: > > > > > A

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1658365 , @aaron.ballman wrote: > In D67140#1658353 , @gribozavr wrote: > > > In D67140#1658315 , @aaron.ballman > > wrote: > > > > > I

r371117 - [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator

Author: jkorous Date: Thu Sep 5 13:33:52 2019 New Revision: 371117 URL: http://llvm.org/viewvc/llvm-project?rev=371117&view=rev Log: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator Follow-up to: 3ff8c3b73f6, d5d15b4c1fd Should be NFC since the original patch just moved the cod

[PATCH] D67028: Use musttail for variadic method thunks when possible

rnk marked an inline comment as done. rnk added a comment. In D67028#1653439 , @efriedma wrote: > Do we have test coverage for a variadic, covariant thunk for a function > without a definition? I don't think there's any way for us to actually emit > tha

r371122 - [Diagnostics] Minor improvements for -Wxor-used-as-pow

Author: xbolva00 Date: Thu Sep 5 13:50:48 2019 New Revision: 371122 URL: http://llvm.org/viewvc/llvm-project?rev=371122&view=rev Log: [Diagnostics] Minor improvements for -Wxor-used-as-pow Extracted from D66397; implemented suggestion for 2^64; tests revisited. Modified: cfe/trunk/include/

r371124 - Implement Microsoft-compatible mangling for decomposition declarations.

Author: nico Date: Thu Sep 5 14:08:50 2019 New Revision: 371124 URL: http://llvm.org/viewvc/llvm-project?rev=371124&view=rev Log: Implement Microsoft-compatible mangling for decomposition declarations. Match cl.exe's mangling for decomposition declarations. Decomposition declarations are consid

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1659749 , @gribozavr wrote: > In D67140#1659356 , @aaron.ballman > wrote: > > > In D67140#1658969 , @gribozavr > > wrote: > > > > >

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371124: Implement Microsoft-compatible mangling for decomposition declarations. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

  1   2   >