[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. > Concretely, can you give an example of which node and what you'd want it to > point to? If it's just the single unqualified-name token, I agree and would > like to add it (as a separate

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall updated this revision to Diff 217576. sammccall marked an inline comment as done. sammccall added a comment. use llvm::Annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66751/new/ https://reviews.llvm.org/D66751 Files: clang-to

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370166: [analyzer] Add 9.0.0. release notes. (authored by hans, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`bugprone-posix-return + ` check. jcai19 wrote: > Eugene.Zelenko wrote: > > Check is not new, just modified. Such check should

[PATCH] D66759: [clangd] Surface errors from command-line parsing

ilya-biryukov updated this revision to Diff 217579. ilya-biryukov marked 2 inline comments as done and an inline comment as not done. ilya-biryukov added a comment. - Do not flushDiag() on EndSourceFile - Do not reset WasAdjusted outside flusLastDiag() - Add a test that unknown warnings do not pr

[PATCH] D66759: [clangd] Surface errors from command-line parsing

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:465 +Diags.insert(Diags.end(), Preamble->Diags.begin(), Preamble->Diags.end()); + // Finally, add diagnostics coming from the AST. + { kadircet wrote: > ilya-biryukov w

[PATCH] D66759: [clangd] Surface errors from command-line parsing

ilya-biryukov updated this revision to Diff 217581. ilya-biryukov added a comment. - Remove accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66759/new/ https://reviews.llvm.org/D66759 Files: clang-tools-extra/clangd/ClangdServer.c

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66759/new/ https://reviews.llvm.org/D66759 __

[PATCH] D66850: Avoid crash when dumping NULL Type as JSON

sidorovd added a comment. LGTM. I'm not an expert in JSON, but may be it makes sense to move the change a line earlier before creation of pointer representation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850

[PATCH] D66864: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66864 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingChe

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:208 } -if (isa(D)) { - addToken(Loc, HighlightingKind::Method); +if (const CXXMethodDecl *

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

lebedev.ri added a comment. Test coverage missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

r370175 - Delete minimize_source_to_dependency_directives_invalid_error.c

Author: hans Date: Wed Aug 28 02:14:00 2019 New Revision: 370175 URL: http://llvm.org/viewvc/llvm-project?rev=370175&view=rev Log: Delete minimize_source_to_dependency_directives_invalid_error.c It was added in r370129 with a .gitattributes file that means the file always shows up as having a loc

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

hans added a comment. In D66556#1648118 , @dexonsmith wrote: > In D66556#1648109 , @rnk wrote: > > > I'm not sure what happens, but I see you added .gitattributes. I'd commit > > it as is. Buildbots using svn will

[clang-tools-extra] r370177 - [clangd] Surface errors from command-line parsing

Author: ibiryukov Date: Wed Aug 28 02:24:55 2019 New Revision: 370177 URL: http://llvm.org/viewvc/llvm-project?rev=370177&view=rev Log: [clangd] Surface errors from command-line parsing Summary: Those errors are exposed at the first character of a file, for a lack of a better place. Previously,

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer added a comment. > Therefore, vectorize(disable) would also disable interleaving? I don't have strong opinions on this. I think there's something to say for both options that we have (i.e. `vectorize(disable)` disables interleaving or enables it). But I think it was @fhahn who ment

[PATCH] D66759: [clangd] Surface errors from command-line parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL370177: [clangd] Surface errors from command-line parsing (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or i

Re: r370073 - [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

Merged to release_90 in r370181. On Tue, Aug 27, 2019 at 5:39 PM Sam Elliott via cfe-commits wrote: > > Author: lenary > Date: Tue Aug 27 08:41:16 2019 > New Revision: 370073 > > URL: http://llvm.org/viewvc/llvm-project?rev=370073&view=rev > Log: > [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPr

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Correct order of fields and indirect fields in imported RecordD

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1645892 , @mgehre wrote: > I'm seeing the same issue `Not all CodeGen sections are inside any Frontend > section!` with python 3.7.1. Json: F9863382: check-time-trace-sections.json >

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 217594. dnsampaio added a comment. Fix / Update / Rebase - Avoid appending __noswap_ to intrinsics that are BigEndianSafe - Moved to monorepo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://

[PATCH] D66869: [clangd] Fix SelectionTree to allow selection range expression in foreach loops.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66869 Files: clang-tools-extra/clangd

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 217600. Tyker added a comment. Sorry for the long wait. Changes: - Rebased on current master - Duplicated test file so that it runs for both importing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files:

[PATCH] D66864: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66864/new/ https://reviews.llvm.org/D66864 __

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 217604. serge-sans-paille added a comment. @Meinersbur patch rebased. I removed the linker trick (which only work for global variables, not function, anyway), as it's no longer needed: target_compile_definitions(${name} PRIVATE LLVM_${name_upper}

[PATCH] D66869: [clangd] Fix SelectionTree to allow selection range expression in foreach loops.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:275 +void loop() { + for (const char* C : [[mak^eStr("f^oo")]]) +

[PATCH] D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

sammccall created this revision. sammccall added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously they would be marked as partially-selected based on the early claim, and never updated as n

[clang-tools-extra] r370191 - [clangd] Fix SelectionTree to allow selection range expression in foreach loops.

Author: sammccall Date: Wed Aug 28 05:05:12 2019 New Revision: 370191 URL: http://llvm.org/viewvc/llvm-project?rev=370191&view=rev Log: [clangd] Fix SelectionTree to allow selection range expression in foreach loops. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadir

[PATCH] D66869: [clangd] Fix SelectionTree to allow selection range expression in foreach loops.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL370191: [clangd] Fix SelectionTree to allow selection range expression in foreach loops. (authored by sammccall, committed by ). Herald added a project: LLVM. He

[clang-tools-extra] r370193 - [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides

Author: sammccall Date: Wed Aug 28 05:08:57 2019 New Revision: 370193 URL: http://llvm.org/viewvc/llvm-project?rev=370193&view=rev Log: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides Reviewers: ilya-biryukov Subscribers: xazax.hun, cfe-commits Tags: #

[PATCH] D66864: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides

This revision was automatically updated to reflect the committed changes. Closed by commit rL370193: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Cha

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

aaron.ballman added a comment. LGTM, but missing a test case. In D66850#1648557 , @sidorovd wrote: > LGTM. I'm not an expert in JSON, but may be it makes sense to move the change > a line earlier before creation of pointer representation? I would prefe

[PATCH] D66873: [Test][Time profiler] Fix test for python3

anton-afanasyev created this revision. anton-afanasyev added reviewers: mgehre, nathanchance. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test checking time profiler generates correct tracing json-file. `filter` works differently for python2 and python3, so unifying

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @nathanchance, @mgehre, fixed here: https://reviews.llvm.org/D66873, please, look at it to commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

[PATCH] D50147: clang-format: support external styles

sammccall added a subscriber: MyDeveloperDay. sammccall added a comment. Sorry about the long delays in responses. I don't think the feature, as you want to scope it, belongs in clang-format. @klimek @MyDeveloperDay may have different opinions. In D50147#1533892

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker updated this revision to Diff 217615. Tyker added a comment. Rebased @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea added a comment. In D66556#1648591 , @hans wrote: > In D66556#1648118 , @dexonsmith > wrote: > > > In D66556#1648109 , @rnk wrote: > > > > > I'm not sure what happens

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

hokein updated this revision to Diff 217617. hokein removed a subscriber: wuzish. hokein added a comment. Add newline at end of tile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66874/new/ https://reviews.llvm.org/D66874 Files: clang-tools-ext

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: clang. The recordIsTriviallyDefaultConstructible may cause an infinite loop when running on an ill-formed decl. Repository: rG LLVM Github Monorepo

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

mstorsjo added a comment. In D66556#1648591 , @hans wrote: > In D66556#1648118 , @dexonsmith > wrote: > > > In D66556#1648109 , @rnk wrote: > > > > > I'm not sure what happe

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. I'm wondering whether this should even warn pedantically. There are no format specifiers that apply directly to a `_Bool` datatype, so the user is left making a choice as to what specifier fits best. I think `hhd` and `hhu` are both equally reasonable types, as ar

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/TypeTraits.cpp:57 return true; + // Don't perform the check on an ill-formed Decl. As we will visit every clas

[PATCH] D66591: [RISCV] Correct Logic around ilp32e macros

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66591/new/ https://reviews.llvm.org/D66591

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

jvikstrom updated this revision to Diff 217618. jvikstrom added a comment. Added a RecursiveASTVisitor for finding 'underlying' types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66516/new/ https://reviews.llvm.org/D66516 Files: clang-tools-ex

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217619. SureYeaah marked 45 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: cla

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

riccibruno added a comment. I do not understand why this check is specific to FPGAs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:165 +else + SR.setEnd(ChildFileRange->getEnd()); + } kadircet wrote: > I suppose this relies on the fact that "AST contains the nodes ordered by >

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217620. SureYeaah added a comment. NFC: Whitespace formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeL

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a parent revision: D66875: [Index] Marked a bunch of classes 'final'. Doing so removes one reason to create a custom FrontendAction. FrontendActions are not desirable b

[PATCH] D66875: [Index] Marked a bunch of classes 'final'

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a reviewer: ilya-biryukov. gribozavr added a child revision: D66876: Indexing: create PP callbacks in the ASTConsumer. This file defines multiple inheritance hierarchie

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Doing so removes the last reason to expose a FrontendAction from libIndex. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66877 Files: clang/lib/Index/IndexingAct

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. gribozavr added reviewers: ilya-biryukov, jkorous. Herald added a subscriber: dexonsmith. gribozavr added a parent revision: D66877: Moved the IndexDataConsumer::finis

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. gribozavr added reviewers: ilya-biryukov, jkorous. Herald added a subscriber: dexonsmith. gribozavr added a parent revision: D66878: [Index] Stopped wrapping Frontend

[PATCH] D66875: [Index] Marked a bunch of classes 'final'

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66875/new/ https://reviews.llvm.org/D66875 _

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66876/new/ https://reviews.llvm.org/D66876 _

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

martong added a comment. Looks good, I just have a comment about the matcher. Comment at: clang/unittests/AST/ASTImporterTest.cpp:1434 +AST_MATCHER_P(RecordDecl, hasFieldIndirectFieldOrder, std::vector, + Order) { This name sounds strange for me,

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

hokein updated this revision to Diff 217628. hokein marked an inline comment as done. hokein added a comment. Tweak the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66874/new/ https://reviews.llvm.org/D66874 Files: clang-tools-extra/cla

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:77 +IndexCtx->getDataConsumer().setPreprocessor(PP); +PP->addPPCallbacks(std::make_unique(IndexCtx)); + } The fact that we call `addPPCallbacks` **after** creating `ASTCo

[clang-tools-extra] r370200 - [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

Author: hokein Date: Wed Aug 28 06:45:53 2019 New Revision: 370200 URL: http://llvm.org/viewvc/llvm-project?rev=370200&view=rev Log: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible. Summary: The recordIsTriviallyDefaultConstructible may cause an infinite loo

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370200: [clang-tidy] Fix the potential infinite loop in… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[clang-tools-extra] r370202 - [clangd] Cleans up the semantic highlighting resources if clangd stops.

Author: jvikstrom Date: Wed Aug 28 06:46:22 2019 New Revision: 370202 URL: http://llvm.org/viewvc/llvm-project?rev=370202&view=rev Log: [clangd] Cleans up the semantic highlighting resources if clangd stops. Summary: Disposes of the vscode listeners when clangd crashes and reuses the old highlig

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370202: [clangd] Cleans up the semantic highlighting resources if clangd stops. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

hans added a comment. In D66556#1648807 , @aganea wrote: > In D66556#1648591 , @hans wrote: > > > In D66556#1648118 , @dexonsmith > > wrote: > > > > > In D66556#1648109

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

ilya-biryukov added a comment. Overall LG, thanks! Not sure why we need to keep `IndexingOptions` everywhere, though, see the relevant comment. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217 std::unique_ptr Includes; + index::IndexingOptions Opts; std::u

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert updated this revision to Diff 217631. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Update according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files: c

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein created this revision. hokein added a reviewer: jvikstrom. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We miss a few places where we need to add them to the subscriptions. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

jvikstrom updated this revision to Diff 217638. jvikstrom added a comment. Updated to new master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66406/new/ https://reviews.llvm.org/D66406 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added a comment. In D63640#1648700 , @Tyker wrote: > Sorry for the long wait. > > Changes: > > - Rebased on current master > - Duplicated test file so that it runs for both importing Thanks for addressing the issues. The ASTImporter related chang

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--++ +| device extension | c

[PATCH] D66881: [clangd][vscode] Don't leak the resources

jvikstrom added a comment. Oh, was not aware we needed to dispose the extension as well. I think you should probably add the SemanticHighlightingFeature to the context.subscriptions as well, right? (because I didn't when I did the cleanup patch for it, sorry) Repository: rG LLVM Github Mono

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:77 +IndexCtx->getDataConsumer().setPreprocessor(PP); +PP->addPPCallbacks(std::make_unique(IndexCtx)); + } ilya-biryukov wrote: > T

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217 std::unique_ptr Includes; + index::IndexingOptions Opts; std::unique_ptr PragmaHandler; ilya-biryukov wrote: > Are t

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `err_typecheck_call_too_few_args diagnostic` takes arguments, but none were provided causing clang to crash when attempting to diagnose an enqueue_kernel cal

[PATCH] D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

sammccall updated this revision to Diff 217645. sammccall added a comment. remove printfs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66872/new/ https://reviews.llvm.org/D66872 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/

[PATCH] D65526: [Clangd] First version of ExtractFunction

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think we should go ahead and land this. The only points that I'd really like to see fixed is `shared_ptr`, mostly because it's a strong signal there's something complicated going on an

[PATCH] D65526: [Clangd] First version of ExtractFunction

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:165 +else + SR.setEnd(ChildFileRange->getEnd()); + } SureYeaah wrote: > kadircet wrote: > > I suppose thi

[PATCH] D66884: Removed dead code from clang/AST/NSAPI.h

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66884 Files: clang/include/clang/AST/NSAPI.h clang/lib/AST/NSAPI.cpp Index: clang/lib/AST/NSAPI.cpp ==

[PATCH] D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66883/new/ https://reviews.llvm.org/D66883 ___

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

jvikstrom updated this revision to Diff 217652. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Abandoned trying to highlight the same as the bound decl. Reasoning: If you have a reference to a parameter we are not trying to highlight the reference as a parameter, the refe

Re: r370035 - [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

Merged to release_90 in r370213. On Tue, Aug 27, 2019 at 12:02 PM David Carlier via cfe-commits wrote: > > Author: devnexen > Date: Tue Aug 27 03:04:03 2019 > New Revision: 370035 > > URL: http://llvm.org/viewvc/llvm-project?rev=370035&view=rev > Log: > [ReleaseNotes] MemorySanitizer support of A

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

hokein added a comment. please update the description of the patch. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:104 +vscode.workspace.onDidChangeConfiguration((conf) => { + if (!conf.affectsConfiguration('workbench')

r370214 - [OPENMP][Analysis] Add analysis of the map clauses.

Author: abataev Date: Wed Aug 28 07:55:08 2019 New Revision: 370214 URL: http://llvm.org/viewvc/llvm-project?rev=370214&view=rev Log: [OPENMP][Analysis] Add analysis of the map clauses. Summary: Added basic analysis of map clauses. Only map clauses with to and tofrom map type must be analyzed sin

[PATCH] D66668: [OPENMP][Analysis] Add analysis of the map clauses.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370214: [OPENMP][Analysis] Add analysis of the map clauses. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

Szelethus added a comment. In D66733#1647964 , @steakhal wrote: > @Szelethus The mispositioned report message was my fault. I used a different > version of clang for the analysis and to upload the results, which resulted > in some mispositioned reports.

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein added a comment. In D66881#1649044 , @jvikstrom wrote: > Oh, was not aware we needed to dispose the extension as well. > > I think you should probably add the SemanticHighlightingFeature to the > context.subscriptions as well, right? (because I did

[PATCH] D66881: [clangd][vscode] Don't leak the resources

hokein updated this revision to Diff 217657. hokein added a comment. dispose the semanticHighlighting feature as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66881/new/ https://reviews.llvm.org/D66881 Files: clang-tools-extra/clangd/clien

[clang-tools-extra] r370218 - [clangd][vscode] Don't leak the resources

Author: hokein Date: Wed Aug 28 08:09:04 2019 New Revision: 370218 URL: http://llvm.org/viewvc/llvm-project?rev=370218&view=rev Log: [clangd][vscode] Don't leak the resources Summary: We miss a few places where we need to add them to the subscriptions. Reviewers: jvikstrom Subscribers: ilya-bir

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:601 + llvm::inconvertibleErrorCode(), + "File contents differ on disk for %s, please save", FilePath.data()); +} you seem to be checking this both here and

[PATCH] D66881: [clangd][vscode] Don't leak the resources

This revision was automatically updated to reflect the committed changes. Closed by commit rL370218: [clangd][vscode] Don't leak the resources (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r370219 - Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

Author: aganea Date: Wed Aug 28 08:14:37 2019 New Revision: 370219 URL: http://llvm.org/viewvc/llvm-project?rev=370219&view=rev Log: Try fixing CRLF issues in Git with [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings Differential Revision: https://reviews.

[PATCH] D65433: [clangd] DefineInline action availability checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:59 + +void checkAvailable(StringRef ID, llvm::StringRef Input, bool Available, +const llvm::StringMap &AdditionalFiles) { This function, and all the

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea added a comment. rL370219 and rG3c307370c8f8 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 _

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal marked 2 inline comments as done. steakhal added a comment. Fixes for @NoQ's comments. I will update the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 ___ cfe-commits mailing list c

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added a comment. I would tend to write this function in the following form: // set up lower bound and upper bound if (r > upperBound) r = upperBound; if (!(r >= lowerBound)) r = lowerBound; // NaN is mapped to l.b. return static_cast(r); I prefer to avoid the explicit trunc call,

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added inline comments. Comment at: test/libcxx/numerics/truncating_cast.pass.cpp:36 + {static_cast(Lim::max()) + 1, Lim::max(), false}, + {static_cast(Lim::max()) + 1024, Lim::max(), false}, + }; Probably should test `nextafter(static_cast(Lim::

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal updated this revision to Diff 217665. steakhal added a comment. Changes: - Flag option marked as 'enabled by default'. - Reformat all the test cases for C, C++ and Obj C. - Now uses `-verify=tags` approach. - Fixes checker documentation. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Looks like there will be no more comments. If so, I will update the first part https://reviews.llvm.org/D65130 which adds clang-offload-wrapper tool with the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D6

  1   2   >