[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall wrote:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 217426. mibintc added a comment. I made a couple changes to the UserManual in response to @rjmccall review Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManu

r370081 - Use FileEntryRef for PPCallbacks::HasInclude

Author: arphaman Date: Tue Aug 27 10:32:42 2019 New Revision: 370081 URL: http://llvm.org/viewvc/llvm-project?rev=370081&view=rev Log: Use FileEntryRef for PPCallbacks::HasInclude This fixes the issue where a filename dependendency was missing if the file that was referenced with __has_include()

[clang-tools-extra] r370081 - Use FileEntryRef for PPCallbacks::HasInclude

Author: arphaman Date: Tue Aug 27 10:32:42 2019 New Revision: 370081 URL: http://llvm.org/viewvc/llvm-project?rev=370081&view=rev Log: Use FileEntryRef for PPCallbacks::HasInclude This fixes the issue where a filename dependendency was missing if the file that was referenced with __has_include()

r370083 - Change the X86 datalayout to add three address spaces for 32 bit signed,

Author: akhuang Date: Tue Aug 27 10:46:53 2019 New Revision: 370083 URL: http://llvm.org/viewvc/llvm-project?rev=370083&view=rev Log: Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit unsigned, and 64 bit pointers. Modified: cfe/trunk/lib/Basic/Targets/OSTargets.

r370087 - Move EH spec mismatches under -fms-compatibility

Author: rnk Date: Tue Aug 27 10:52:03 2019 New Revision: 370087 URL: http://llvm.org/viewvc/llvm-project?rev=370087&view=rev Log: Move EH spec mismatches under -fms-compatibility -fms-extensions is intended to enable conforming language extensions and -fms-compatibility is intended to language ru

[PATCH] D66813: Remove clang-tidy-vs plugin from clang-tools-extra

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66813/new/ https://reviews.llvm.org/D66813 ___ cfe-c

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

yamauchi accepted this revision. yamauchi added a comment. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang closed this revision. akhuang added a comment. Commited in r370083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 ___ cfe-commits mailing list cfe-comm

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG39aa8954a484: Move EH spec mismatches under -fms-compatibility (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66770/new/ https://reviews.l

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64le-ibm-linux-gnu -outputs=%t.res.tgt1 -inputs

r370093 - [driver][xray] fix the macOS support checker by supporting -macos

Author: arphaman Date: Tue Aug 27 11:26:36 2019 New Revision: 370093 URL: http://llvm.org/viewvc/llvm-project?rev=370093&view=rev Log: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin The previous check incorrectly checked for macOS support by allowi

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding @rsmith to see if we can make forward progress on this patch again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ c

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[clang-tools-extra] r370096 - Remove clang-tidy-vs from clang-tools-extra (PR41791)

Author: arphaman Date: Tue Aug 27 11:36:08 2019 New Revision: 370096 URL: http://llvm.org/viewvc/llvm-project?rev=370096&view=rev Log: Remove clang-tidy-vs from clang-tools-extra (PR41791) The clang-tidy-vs visual studio plugin in clang-tools-extra contains a security vulnerability in the YamlDot

[PATCH] D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL370093: [driver][xray] fix the macOS support checker by supporting -macos (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + mibintc wrote: > rjmccall wrote: > > Combined how? With

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall wrote: > mibintc wrote: > > rjmccall wro

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added a comment. In D64671#1644280 , @jpakkane wrote: > I used stdint to replicate a real world use case as I'd imagine those types > would match this search quite heavily. The problem is that this uses the system header search paths and s

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 217457. shafik marked an inline comment as done. shafik added a comment. Simplifying test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-exp

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

ABataev added a comment. Could you provide some more details about the problem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

logan-5 marked an inline comment as done. logan-5 added a comment. Thanks. I'll need someone with commit access to help me out with this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 _

[PATCH] D66822: Hardware cache line size builtins

zoecarver created this revision. Herald added a reviewer: jfb. Herald added subscribers: cfe-commits, kbarton, aheejin, javed.absar, nemanjai. Herald added a project: clang. Creates the `__builtin_hardware_destructive_interference_size` and `__builtin_hardware_constructive_interference_size` buil

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/docs/UsersManual.rst:1309 + + * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled. + * ``strict`` Enables precise and except, and disables contr

r370100 - Diagnose both _Complex and _Imaginary as C99 extensions.

Author: aaronballman Date: Tue Aug 27 12:15:24 2019 New Revision: 370100 URL: http://llvm.org/viewvc/llvm-project?rev=370100&view=rev Log: Diagnose both _Complex and _Imaginary as C99 extensions. Added: cfe/trunk/test/Parser/c99.c Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKin

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

JamesNagurne added a comment. In D65907#1645474 , @arphaman wrote: > In D65907#1643800 , @JamesNagurne > wrote: > > > In D65907#1643650 , @arphaman > > wrote: > > > > > No

r370101 - AMDGPU: Always emit amdgpu-flat-work-group-size

Author: arsenm Date: Tue Aug 27 12:25:40 2019 New Revision: 370101 URL: http://llvm.org/viewvc/llvm-project?rev=370101&view=rev Log: AMDGPU: Always emit amdgpu-flat-work-group-size The backend default maximum should be the hardware maximum, so the frontend should set the implementation defined de

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm closed this revision. arsenm added a comment. r370101 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66822: Hardware cache line size builtins

lebedev.ri added a comment. > My implementation switches on the target triple to get the max cache line > size for that target. I am not sure if this is the best way to implement > these builtins, but it will ensure that there is not an ABI break. Passing-by remark: i'm not sure it is possible

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. > Passing-by remark: i'm not sure it is possible to **guarantee** that this > will be always correct and that no ABI break will happen. You're right. I should have said, "least-likely to cause an ABI break." And I completely agree that there is **no way** to gaurentee

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

mgehre added a comment. Nice! Having no false-positives is most important because this is enabled by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66806/new/ https://reviews.llvm.org/D66806 _

[clang-tools-extra] r370103 - [clangd] Add a distinct highlighting for local variables

Author: nridge Date: Tue Aug 27 12:39:11 2019 New Revision: 370103 URL: http://llvm.org/viewvc/llvm-project?rev=370103&view=rev Log: [clangd] Add a distinct highlighting for local variables Summary: It's useful to be able to distinguish local variables from namespace scope variables. Reviewers:

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

NoQ added a comment. I don't understand. Isn't widening supposed to happen //after we exit the loop//? The loop isn't over yet when the bug is being reported. Why is this problem widening-specific? Given that we also have a weird invalidation of `b`, i suspect that we're doing widening in a wro

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

arphaman added a comment. Will the git monorepo handle `svn:eol-style` correctly? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86a4a530f435: [clangd] Add a distinct highlighting for local variables (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D66723?vs=217065&id=217476#toc Repository: rG LLVM Githu

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. It may be a good idea only to enable this when `-march=native`. And _maybe_ remove the constexpr requirement (though it would make this feature significantly less useful it would also make it significantly more accurate). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D66822: Hardware cache line size builtins

jyknight added a comment. numbers for cacheline size. In D66822#1647664 , @zoecarver wrote: > > Passing-by remark: i'm not sure it is possible to **guarantee** that this > > will be always correct and that no ABI break will happen. > > You're right. I sh

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: llvm-commits, cfe-commits, erik.pilkington, hiraditya, nhaehnle, jvesely, jholewinski. Herald added projects: clang, LLVM. Previously, these qualifiers were being parsed but otherwise ignored. This chan

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217479. paulkirth added a comment. Removes unused constructor, reformat code, and remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 6 inline comments as done. paulkirth added inline comments. Comment at: llvm/include/llvm/IR/DiagnosticInfo.h:1009 +public: + DiagnosticInfoMisExpect(const Function &Fn, const Twine &Msg, + const DiagnosticLocation &Loc = DiagnosticLocat

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev added a comment. Sure. The main unbundling loop looks as follows (see loop on line 745) while (!Worklist.empty()) { StringRef CurTriple = FH.get()->ReadBundleStart(Input); if (CurTriple.empty()) break; auto Output = Worklist.find(CurTriple); if (Output == W

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. We should probably tell people never to use this, period. That being said, I like your idea of having it be a constant. The only issue would be when, in the next few years, people start shipping CPUs with 256-byte-wide cache lines. Repository: rG LLVM Github Monore

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. In D66716#1647668 , @NoQ wrote: > I don't understand. Isn't widening supposed to happen //after we exit the > loop//? The loop isn't over yet when the bug is being reported. Why is this > problem widening-specific? Given that w

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:301 assert(CurBundleInfo != BundlesInfo.end() && "Invalid reader info!"); ++CurBundleInfo; } Just notic

r370107 - Debug Info: Support for DW_AT_export_symbols for anonymous structs

Author: shafik Date: Tue Aug 27 13:17:35 2019 New Revision: 370107 URL: http://llvm.org/viewvc/llvm-project?rev=370107&view=rev Log: Debug Info: Support for DW_AT_export_symbols for anonymous structs This implements the DWARF 5 feature described in: http://dwarfstd.org/ShowIssue.php?issue=141212

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. > BTW, I note that facebook uses 128 bytes for x86 They also use 64 for arm which is interesting (the opposite of this patch). Also, see this comment in the same snippet: > We assume a cache line size of 64, so we use a cache line pair size of 128 Which would indicat

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG528f5da6d862: Debug Info: Support for DW_AT_export_symbols for anonymous structs (authored by shafik). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D7?vs=217457&i

r370108 - Diagnose _Bool as a C99 extension.

Author: aaronballman Date: Tue Aug 27 13:33:05 2019 New Revision: 370108 URL: http://llvm.org/viewvc/llvm-project?rev=370108&view=rev Log: Diagnose _Bool as a C99 extension. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/Parser/c99.c Modified: cfe/trunk/lib/Parse/ParseDecl.cp

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); Sorry if I'm going b

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

lebedev.ri added a comment. Please can you clarify hat's the current layout of these patches? Is this patch required, or is it superseded by D66324 (and thus should be abandoned)? I'd like to begin reviewing, but i don't understand where to start. Repository:

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); Maybe just: ``` const BundleInfo &Bundle = *CurBundleI

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66828 Files: clang-tools-extra/cla

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); ABataev

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1646229 , @aganea wrote: > This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` > instead. Can we count on `tr` when we have `shell`? If so, I suggest this instead: // REQUIRES: shell // RUN

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

NoQ added a comment. > Do you think its ever okay to find a last store in a `BlockEdge`? *In a `BlockEntrance` into an empty block (that has no elements but does have a terminator). At least that's what your code is fixing. Attaching store notes to such program points is most likely not ok. We

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1647762 , @dexonsmith wrote: > In D66556#1646229 , @aganea wrote: > > > This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` > > instead. > > > Can we count

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth added a comment. In D65300#1647746 , @lebedev.ri wrote: > Please can you clarify hat's the current layout of these patches? > Is this patch required, or is it superseded by D66324 > (and thus should be abandone

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

lebedev.ri added a comment. In D65300#1647775 , @paulkirth wrote: > In D65300#1647746 , @lebedev.ri > wrote: > > > Please can you clarify hat's the current layout of these patches? > > Is this patch required, or i

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

BlackAngel35 requested changes to this revision. BlackAngel35 added a comment. This revision now requires changes to proceed. In D66564#1640584 , @Eugene.Zelenko wrote: > Please mention new module and check in Release Notes. CHANGES SINCE LAST ACTION

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217491. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove namespace qualifier & insert check for number of arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217494. paulkirth added a comment. Change check for minimum number of metadata operands. Branch weights must have at least 3 elements: metadata name, and a list of at least 2 branch weights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D66830: Consumed checker: various improvements

comex created this revision. comex added reviewers: delesley, dblaikie, rsmith. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Treat arguments to constructor calls the same way as arguments to other calls (fixes 42856). Previously, arguments t

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 3 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands();

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

comex added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65694/new/ https://reviews.llvm.org/D65694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth abandoned this revision. paulkirth added a comment. This is being abandoned in favor of D66324 , which reimplements this logic completely in the LLVM backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. When checking if block types are compatible, we are checking for compatibility their return types and parameters' types. As these types have different varianc

r370115 - [Clang][Bundler] Fix for a hang when unbundling fat binary

Author: sdmitriev Date: Tue Aug 27 14:47:52 2019 New Revision: 370115 URL: http://llvm.org/viewvc/llvm-project?rev=370115&view=rev Log: [Clang][Bundler] Fix for a hang when unbundling fat binary clang-offload-bundler tool may hang under certain conditions when it extracts a subset of all availab

r370116 - [clang][Index][NFC] Move IndexDataConsumer default implementation

Author: jkorous Date: Tue Aug 27 14:49:39 2019 New Revision: 370116 URL: http://llvm.org/viewvc/llvm-project?rev=370116&view=rev Log: [clang][Index][NFC] Move IndexDataConsumer default implementation Modified: cfe/trunk/include/clang/Index/IndexDataConsumer.h cfe/trunk/lib/Index/IndexingA

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); paulkirth wrote: > n

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/test/SemaObjC/block-type-safety.m:141 genericBlock = block; +block = genericBlock; // expected-error {{incompatible block pointer types assigning to 'NSAllArray *(^)(id)' from 'id

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

This revision was automatically updated to reflect the committed changes. Closed by commit rL370115: [Clang][Bundler] Fix for a hang when unbundling fat binary (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. Herald added a subscriber: wuzish. Is this still a problem? I'd be interested to understand *why* the preprocessor is going away here. Is the `CompilerInstance` being reused for two different compilations? Is that what we should fix instead? Repository: rC Clan

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not have been initially flagged because a different issue was causing a build failure which masked the problem. I have bisected the test failures to this change though. http://lab.llvm.org:8011/bui

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk added a comment. This change needs a clang CodeGen test to show that we generate IR with `__ptr32` / `__ptr64` in the correct places. We should already have some semantic tests, but we may need more. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1874 +case LangAS::ptr

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

rsmith added a comment. This isn't the right approach: instead of re-instantiating the parameter when we encounter a use of it, we should inject the parameters into the local instantiation scope before trying to instantiate a default argument (`Sema::CheckCXXDefaultArgExpr` should call `addInst

[PATCH] D66834: Driver tests: set `--sysroot` to "" to support toolchains with default sysroot

broadwaylamb created this revision. broadwaylamb added reviewers: rsmith, sfantao, sepavloff. Herald added a project: clang. Herald added a subscriber: cfe-commits. When testing clang that has been compiled with `-DDEFAULT_SYSROOT` set to some path, the test `VFSGCCInstallation` would fail, becau

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. In D64931#1647880 , @dyung wrote: > Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not > have been initially flagged because a different issue was causing a build > failure which masked the problem. I hav

r370122 - ArrayRef'ized CompilerInvocation::CreateFromArgs

Author: gribozavr Date: Tue Aug 27 15:13:31 2019 New Revision: 370122 URL: http://llvm.org/viewvc/llvm-project?rev=370122&view=rev Log: ArrayRef'ized CompilerInvocation::CreateFromArgs Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66797 Modified: cf

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rL370122: ArrayRef'ized CompilerInvocation::CreateFromArgs (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks

Author: emankov Date: Tue Aug 27 15:15:32 2019 New Revision: 370123 URL: http://llvm.org/viewvc/llvm-project?rev=370123&view=rev Log: [preprocessor] Add an opportunity to retain excluded conditional blocks It is handy for clang tooling, for instance, in source to source transformation. Reviewers

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF created this revision. EricWF added reviewers: mclow.lists, ldionne. Herald added subscribers: libcxx-commits, dexonsmith, christof. This is needed anytime we need to clamp an arbitrary floating point value to an integer type. Repository: rCXX libc++ https://reviews.llvm.org/D66836 F

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands();

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. @Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports. I've fixed the linked CodeChecker instance. CHANGES SINCE LAST ACTION https://revi

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver added reviewers: kparzysz, eli.friedman. zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/Sema/builtin-stackaddress

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/Sema/builtin-stackaddress.c:10 +// expected-error@+1 {{argument to '__builtin_return_address' must be a constant integer}} +return __builtin_return_address(x); }

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831 ___ cfe-commits mailing list cfe-commi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); paulkirth wrote: > n

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217522. sdmitriev marked an inline comment as done. sdmitriev added a comment. Added tests for each file type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundl

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

zoecarver added a comment. Seems like a very useful function. `__max_representable_int_for_float` also seems useful. Should this work in C++03? If so there are a few changes that need to be made. It would also be great if this could be a `constexpr` (but, obviously, not necessary). =

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217527. aganea added subscribers: jyknight, rnk. aganea added a comment. In D66556#1647669 , @arphaman wrote: > Will the git monorepo handle `svn:eol-style` correctly? Other files in the repo already use `svn:eol-styl

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) { Error = true; ---

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217528. paulkirth added a comment. Add comment to clarify choice of operands and reasoning about profiling metadata Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Fi

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1648109 , @rnk wrote: > I'm not sure what happens, but I see you added .gitattributes. I'd commit it > as is. Buildbots using svn will keep working. You can check that the monorepo > has the right line endings afterw

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

rnk added a comment. I'm not sure what happens, but I see you added .gitattributes. I'd commit it as is. Buildbots using svn will keep working. You can check that the monorepo has the right line endings afterwards, and try again if not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D665

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 ___ cfe-commits mailing list cfe-commits@l

<    1   2   3   >