[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. RecursiveASTVisitor was visiting implcit constructor initializers. This caused semantic highlighting in clangd to emit error logs. Fix

Re: r367520 - Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006)

Merged to release_90 in r367804. On Thu, Aug 1, 2019 at 10:00 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Thu Aug 1 01:01:09 2019 > New Revision: 367520 > > URL: http://llvm.org/viewvc/llvm-project?rev=367520&view=rev > Log: > Delay emitting dllexport explicitly defaulted me

Re: r367661 - Don't try emitting dllexported explicitly defaulted non-trivial ctors twice during explicit template instantiation definition (PR42857)

Merged to release_90 in r367805. On Fri, Aug 2, 2019 at 9:50 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Fri Aug 2 00:51:41 2019 > New Revision: 367661 > > URL: http://llvm.org/viewvc/llvm-project?rev=367661&view=rev > Log: > Don't try emitting dllexported explicitly default

[PATCH] D65655: [clangd] Fix a crash when presenting values for Hover

hans added a comment. In D65655#1612392 , @ilya-biryukov wrote: > @hans, could we merge this commit into the release branch? Sure, merged in r367807. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65655/new/ https://revi

Re: [clang-tools-extra] r367687 - [clangd] Fix a crash when presenting values for Hover

Merged to release_90 in r367807. On Fri, Aug 2, 2019 at 5:22 PM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Fri Aug 2 08:23:04 2019 > New Revision: 367687 > > URL: http://llvm.org/viewvc/llvm-project?rev=367687&view=rev > Log: > [clangd] Fix a crash when presenting values

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein added a comment. I think this is a reasonable fix, just a few comments on the test. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:26 + bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { +if (Init->getSourceLocati

r367809 - Adds a warning when an inline Doxygen comment has no argument

Author: gribozavr Date: Mon Aug 5 01:05:16 2019 New Revision: 367809 URL: http://llvm.org/viewvc/llvm-project?rev=367809&view=rev Log: Adds a warning when an inline Doxygen comment has no argument Summary: It warns for for comments like /** \pre \em */ where \em has no argument This warning is

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL367809: Adds a warning when an inline Doxygen comment has no argument (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[clang-tools-extra] r367811 - [clangd] Fix error message with incorrect TextDocumentcontentChangeEvent.rangeLength

Author: sammccall Date: Mon Aug 5 01:14:13 2019 New Revision: 367811 URL: http://llvm.org/viewvc/llvm-project?rev=367811&view=rev Log: [clangd] Fix error message with incorrect TextDocumentcontentChangeEvent.rangeLength Modified: clang-tools-extra/trunk/clangd/DraftStore.cpp Modified: clan

[clang-tools-extra] r367812 - [clangd] Expose -offset-encoding=utf-32, which has been implemented for ages

Author: sammccall Date: Mon Aug 5 01:14:17 2019 New Revision: 367812 URL: http://llvm.org/viewvc/llvm-project?rev=367812&view=rev Log: [clangd] Expose -offset-encoding=utf-32, which has been implemented for ages Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified: clang-to

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

hokein added a comment. In D65637#1613692 , @nridge wrote: > Do you plan to support text decoration options other than color, e.g. bold / > underline / italic? I think we'd just support color, and we don't have further plan to support richer renderings

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

ilya-biryukov added a comment. The fix looks good. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:17 // syntactic and semantic form. class InitListExprPreOrderVisitor : public ExpectedLocationVisitor { Could you cr

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213291. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Moved test to its own test file (also addressed comments about the test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213294. jvikstrom added a comment. Call the base Traverse.. function in the visitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/ https://reviews.llvm.org/D65735 Files: clang/include/clang/AST/

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:2 +//===- unittest/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp +//-===// +// we should make them one line even it exceeds 80 c

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

ilya-biryukov added a comment. LGTM from my side, a few optional NITs. Feel free to land as soon as @hokein stamps. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:16 + +// Check to ensure that CXXCtorInitializer is not visited when imp

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added a comment. Assuming this works and the other unit tests don't show issues then this LGTM. Please consider running this on your NetBSD code base before committing, if possible please also run on clang code based to ensure existing sorted headers aren't sorted unexpectedly.

r367823 - [OpenCL] Fix vector literal test broken in rL367675.

Author: stulova Date: Mon Aug 5 02:50:28 2019 New Revision: 367823 URL: http://llvm.org/viewvc/llvm-project?rev=367823&view=rev Log: [OpenCL] Fix vector literal test broken in rL367675. Avoid checking alignment unnecessary that is not portable among targets. Modified: cfe/trunk/test/CodeGe

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1614239 , @ebrevnov wrote: > Please be aware about build bot failure > (http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/2185) > most likely caused by this change. Thanks! I believe it is now fix

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: lib/Format/TokenAnnotator.cpp:2163 +if (Current->is(TT_BlockComment)){ + std::cout << "TYPE"isOneOf(TT_TemplateC

r367826 - Sidestep false positive due to a matching git repository name

Author: rogfer01 Date: Mon Aug 5 03:09:06 2019 New Revision: 367826 URL: http://llvm.org/viewvc/llvm-project?rev=367826&view=rev Log: Sidestep false positive due to a matching git repository name I have failures in this test because the grep @b gets confused by the clang version including a repo

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein added a comment. thanks for the detailed comments! Comment at: clang-tools-extra/clangd/test/request-reply.test:22 +--- +{"jsonrpc":"2.0","id":0,"result":{"applied":false}} +# CHECK: "code": -32001, sammccall wrote: > please use increasing IDs and

[PATCH] D65635: Sidestep false positive due to a matching git repository name

rogfer01 added a comment. Thanks @efriedma. I will commit this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65635/new/ https://reviews.llvm.org/D65635 ___ cfe-commits mailing list cfe-commits

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein updated this revision to Diff 213304. hokein marked 24 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65387/new/ https://reviews.llvm.org/D65387 Files: clang-tools-extra/cl

[PATCH] D65635: Sidestep false positive due to a matching git repository name

This revision was automatically updated to reflect the committed changes. Closed by commit rL367826: Sidestep false positive due to a matching git repository name (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

davezarzycki added a comment. Hello – This change seems to have exposed a bug in -Wdocumentation argument parsing. For example, this warns when it shouldn't(?): /// \c @foobar Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D6

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 213311. gamesh411 added a comment. - Remove unused member Limit - Rebase to current master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Files: clang/include/clan

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider added a comment. Eli, any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

Author: gamesh411 Date: Mon Aug 5 04:06:41 2019 New Revision: 367829 URL: http://llvm.org/viewvc/llvm-project?rev=367829&view=rev Log: [CrossTU][NFCI] Refactor loadExternalAST function Summary: Refactor loadExternalAST method of CrossTranslationUnitContext in order to reduce maintenance burden a

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

This revision was automatically updated to reflect the committed changes. Closed by commit rL367829: [CrossTU][NFCI] Refactor loadExternalAST function (authored by gamesh411, committed by ). Changed prior to commit: https://reviews.llvm.org/D64753?vs=213311&id=213315#toc Repository: rL LLVM

Re: r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++

Hi Yvan, Sorry for this, it should now be fixed in r367823. Thanks, Anastasia From: Yvan Roux Sent: 02 August 2019 14:09 To: Anastasia Stulova Cc: cfe-commits Subject: Re: r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++ Hi Anastasia

[PATCH] D63835: [Syntax] Add nodes for most common statements

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:99 /// An abstract node for C++ statements, e.g. 'while', 'if', etc. class Statement : public Tree { publi

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds a TextMate parser module to the vscode extension. It watches for changes to the vscode configuration

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213323. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Herald added a subscriber: mgorny. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/ https://reviews.llv

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:29 +if (!Init->isWritten()) + VisitedImplicitInitializer = true; +Match("initializer", Init->getSour

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:26 + VisitedImplicitInitializer = true; +Match("initializer", Init->get

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:278 ~ReplyOnce() { - if (Server && !Replied) { + if (Server && !Server->isDestructing() && !

[PATCH] D65665: Support for attributes on @class declarations

aaron.ballman added a comment. I don't think I know enough about ObjC semantics to say much about the language design aspects of this patch. Comment at: clang/include/clang/Parse/Parser.h:1496 + DeclGroupPtrTy ParseObjCAtClassDeclaration(SourceLocation atLoc, +

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL367839: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald ad

r367839 - [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

Author: jvikstrom Date: Mon Aug 5 05:20:43 2019 New Revision: 367839 URL: http://llvm.org/viewvc/llvm-project?rev=367839&view=rev Log: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers. Summary: RecursiveASTVisitor was visiting implcit constructor initializers. This cause

r367840 - [clang][NFC] Remove unused private variable 'CI' in CrossTranslationUnit.h

Author: teemperor Date: Mon Aug 5 05:23:39 2019 New Revision: 367840 URL: http://llvm.org/viewvc/llvm-project?rev=367840&view=rev Log: [clang][NFC] Remove unused private variable 'CI' in CrossTranslationUnit.h It seems because of the recent refactorings this variable has become unused and now we

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213331. jvikstrom marked an inline comment as done. jvikstrom added a comment. Formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65510/new/ https://reviews.llvm.org/D65510 Files: clang-tools-extra/c

[PATCH] D65573: Add User docs for ASTImporter

martong updated this revision to Diff 213332. martong added a comment. - Add description for `-ast-merge` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65573/new/ https://reviews.llvm.org/D65573 Files: clang/docs/LibASTImporter.rst clang/docs/

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLangOpts().ThreadsafeStatics) +ret

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein updated this revision to Diff 213334. hokein marked 8 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65387/new/ https://reviews.llvm.org/D65387 Files: clang-tools-extra/cla

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:205 + // Return a call id of the request. + int bindReply(Callback Reply) { +llvm::Optional>> OldestCB; sammccall wrote: > nit: I think this function could return json::V

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

sammccall accepted this revision. sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/fixits-command.test:206 --- +{"jsonrpc":"2.0","id":0,"result":{"applied":true}} +# CHECK: "id": 4, hoke

[clang-tools-extra] r367845 - [clangd] Add a callback mechanism for handling responses from client.

Author: hokein Date: Mon Aug 5 05:48:09 2019 New Revision: 367845 URL: http://llvm.org/viewvc/llvm-project?rev=367845&view=rev Log: [clangd] Add a callback mechanism for handling responses from client. Summary: The callback will be invoked in clangd when we receive a reply from the client. This

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367845: [clangd] Add a callback mechanism for handling responses from client. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 213339. lildmh added a comment. Fix declare mapper codegen test when the function argument has name attached. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/

[PATCH] D65706: [docs] Better documentation for -Weverything

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many diagnostics such as :option:`-Wno-c++98-compat` +:option:`-Wno-c++-compat`. + jf

Re: r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++

On Mon, 5 Aug 2019 at 13:16, Anastasia Stulova wrote: > > Hi Yvan, > > > Sorry for this, it should now be fixed in r367823. Issue fixed, Thanks Anastasia > > Thanks, > > Anastasia > > > > > From: Yvan Roux > Sent: 02 August 2019 14:09 > To: Anastasia Stulova >

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, yaxunl. A regression was introduced in D64400 because auto is using the same logic as templates. However, deduction of addr spaces wasn't working correctly

r367864 - Move LangStandard*, InputKind::Language to Basic

Author: ro Date: Mon Aug 5 06:59:26 2019 New Revision: 367864 URL: http://llvm.org/viewvc/llvm-project?rev=367864&view=rev Log: Move LangStandard*, InputKind::Language to Basic This patch is a prerequisite for using LangStandard from Driver in https://reviews.llvm.org/D64793. It moves LangStand

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rL367864: Move LangStandard*, InputKind::Language to Basic (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

The msan bot doesn't like this, it reports an uninitialized read a t clang/lib/CrossTU/CrossTranslationUnit.cpp : http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/34087/steps/check-clang%20msan/logs/stdio Testing: 0 FAIL: Clang :: Analysis/ctu-unknown-part

r367866 - [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

Author: ro Date: Mon Aug 5 07:06:16 2019 New Revision: 367866 URL: http://llvm.org/viewvc/llvm-project?rev=367866&view=rev Log: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris Builtins-*-sunos :: compiler_rt_logbf_test.c currently FAILs on Solaris, both SPARC and x86, 32 and 6

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367866: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib updated this revision to Diff 213356. bruntib edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65065/new/ https://reviews.llvm.org/D65065 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. Alright, I modified the commit accordingly. Thank you for the suggestions. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65065/new/ https://reviews.llvm.org/D65065 ___ cfe-commi

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache updated this revision to Diff 213360. modocache added a comment. Thanks for the reviews, @sammccall, @Quuxplusone, and @MyDeveloperDay. I added C++14 and C++17 options. In an earlier comment I mentioned splitting this work up into a series of commits, but it ended up being a smaller se

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:68 + if (const auto *TD = dyn_cast(D)) +return TD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation; + return false; jvikstrom wrote: > ilya-biryukov wrote:

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:68 + if (const auto *TD = dyn_cast(D)) +return TD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation; + return false; ilya-biryukov wrote: > jvikstrom wrote:

[PATCH] D65738: [clangd] Added a TextMate theme parser that updates when the current theme changes.

hokein added a comment. Haven't looked at the patch in details. Looks like the patch is doing different things, and the test just covers a small set of the code. 1. find and parse the theme definition files `json` ; 2. define related data structures to save the TM scopes and do the transformat

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. We accumulated some configuration parameters for LookupVisibleDecls that are being passed unchanged to recursive calls, e.g. LoadExt

r367875 - Undo what looks like an unintentional change in r367829

Author: nico Date: Mon Aug 5 08:23:10 2019 New Revision: 367875 URL: http://llvm.org/viewvc/llvm-project?rev=367875&view=rev Log: Undo what looks like an unintentional change in r367829 The MSan bot was (rightfully) complaining that NumASTLoaded was unitialized, so put the initialization removed

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov updated this revision to Diff 213371. ilya-biryukov added a comment. - Remove accidental change from revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65752/new/ https://reviews.llvm.org/D65752 Files: clang/lib/Sema/SemaLookup

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

The problem is probably this part from the diff: - unsigned NumASTLoaded{0u}; + + /// The number successfully loaded ASTs. Used to indicate, and - with the + /// appropriate threshold value - limit the memory usage of the + /// CrossTranslationUnitContext. + unsigned NumASTLoaded; i.e. yo

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov added a comment. This is just a proposal, there are probably other ways to reach better readability, e.g. group some of those parameters into a struct. But let me know what you think, happy to refactor in a slightly different manner or simply drop this revision. Repository: rG

[PATCH] D65753: Builtins: Add some v2f16 variants

arsenm created this revision. arsenm added reviewers: rjmccall, Anastasia, yaxunl, rsmith. Herald added a subscriber: wdng. arsenm added a parent revision: D65597: WIP: Builtins: Start adding half versions of math builtins. This will avoid hacks in the OpenCL builtin library. https://reviews.ll

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Removed assumption that begin and end need to be in same file id. - Fixes the crash at https://github.com/clang

r367885 - [AST] Fix RecursiveASTVisitorTest multiline string literal. NFC

Author: dmgreen Date: Mon Aug 5 09:27:36 2019 New Revision: 367885 URL: http://llvm.org/viewvc/llvm-project?rev=367885&view=rev Log: [AST] Fix RecursiveASTVisitorTest multiline string literal. NFC Some compiler, notably older gccs (< 8) can have trouble with multiline raw string literals inside

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 213379. paulkirth edited the summary of this revision. paulkirth added a comment. Update threshold values to match those assigned when lowering __builtin_expect intrinsic. I've modified the branch probability to match the probability assigned in LowerExpe

[PATCH] D65706: [docs] Better documentation for -Weverything

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many diagnostics such as :option:`-Wno-c++98-compat` +:option:`-Wno-c++-co

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLang

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLangOpts().ThreadsafeStatics) +return

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. I think it should warn; according to the documentation [1] `\c` expects a word. Testing with Doxygen indeed gives a warning. Can you post the real comment where this occurs? [1] http://www.doxygen.nl/manual/commands.html#cmdc Repository: rL LLVM CHANGES SINCE LAS

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213388. jvikstrom marked an inline comment as done. jvikstrom added a comment. Move isImplicitTemplateInstantiation and isExplicitTemplateSpecialization, also share implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D65706: [docs] Better documentation for -Weverything

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many diagnost

[PATCH] D65706: [docs] Better documentation for -Weverything

This revision was automatically updated to reflect the committed changes. Closed by commit rL367889: [docs] document -Weveything more betterer (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r367889 - [docs] document -Weveything more betterer

Author: jfb Date: Mon Aug 5 09:53:45 2019 New Revision: 367889 URL: http://llvm.org/viewvc/llvm-project?rev=367889&view=rev Log: [docs] document -Weveything more betterer Reviewers: aaron.ballman Subscribers: jkorous, dexonsmith, cfe-commits Tags: #clang Differential Revision: https://reviews

[PATCH] D65706: [docs] Better documentation for -Weverything

xbolva00 added a comment. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65706/new/ https://reviews.llvm.org/D65706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLang

r367892 - [AST] Fix buildbot failure because of raw string inside macro from 367839.

Author: jvikstrom Date: Mon Aug 5 10:14:46 2019 New Revision: 367892 URL: http://llvm.org/viewvc/llvm-project?rev=367892&view=rev Log: [AST] Fix buildbot failure because of raw string inside macro from 367839. Modified: cfe/trunk/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitia

[libclc] r367893 - Revert "Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC"

Author: jvesely Date: Mon Aug 5 10:23:23 2019 New Revision: 367893 URL: http://llvm.org/viewvc/llvm-project?rev=367893&view=rev Log: Revert "Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC" This reverts commit 58c814614d2ac69bcf79b09543505fac80ada4e6. Fixes build breakage using LLVM<7.

Re: [libclc] r367800 - Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC

I've reverted this change. It breaks libclc build using older LLVM version (which is still supported) and it was committed without review on phabricator or libclc mailing list. Please don't do that. Jan On Mon, Aug 5, 2019 at 1:43 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrot

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLangOpts().ThreadsafeStatics) +ret

Re: r367889 - [docs] document -Weveything more betterer

This breaks the sphinx bot: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio Warning, treated as error: /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:995: WARNING: unknown option: -Wno-c++98-compat On Mo

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213406. Nathan-Huckleberry added a comment. - Allow decl-specifier source location to propagate to decl parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D6483

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213407. Nathan-Huckleberry added a comment. - Remove changes from accidentally formatted files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files: clang

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. +1, looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, kristof.beyls, javed.absar, mgorny, mehdi_amini. Herald added projects: clang, LLVM. A new module pass (Transforms/CFGuard/CFGuard.cpp) inserts CFGuard checks on indirect functio

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:1767 } return ParseSimpleDeclaration(Context, DeclEnd, attrs, true); Should this also be passed `DeclSpecStart`? Comment

r367905 - [OpenMP 5.0] Codegen support for user-defined mappers.

Author: meinersbur Date: Mon Aug 5 11:43:21 2019 New Revision: 367905 URL: http://llvm.org/viewvc/llvm-project?rev=367905&view=rev Log: [OpenMP 5.0] Codegen support for user-defined mappers. This patch implements the code generation for OpenMP 5.0 declare mapper (user-defined mapper) constructs.

r367906 - [DirectoryWatcher][linux] Fix build for older kernels

Author: jkorous Date: Mon Aug 5 11:44:07 2019 New Revision: 367906 URL: http://llvm.org/viewvc/llvm-project?rev=367906&view=rev Log: [DirectoryWatcher][linux] Fix build for older kernels Apparently kernel support for IN_EXCL_UNLINK in inotify_add_watch() doesn't imply it's defined in sys/inotif

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 ___ cfe-commits mailing list cfe-commi

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213425. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Herald added a subscriber: jfb. Fix atomicity issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628 Files:

r367912 - Fix another uninit read found by msan after r367829

Author: nico Date: Mon Aug 5 12:35:59 2019 New Revision: 367912 URL: http://llvm.org/viewvc/llvm-project?rev=367912&view=rev Log: Fix another uninit read found by msan after r367829 Modified: cfe/trunk/include/clang/CrossTU/CrossTranslationUnit.h Modified: cfe/trunk/include/clang/CrossTU/Cr

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

There was yet another uninit read: Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. FAIL: Clang-Unit :: CrossTU/./CrossTUTests/CrossTranslationUnit.RespectsLoadThreshold (13891 of 15323) TEST 'Clang-Unit :: CrossTU/./CrossTUTests/CrossTranslationUnit.

  1   2   >