[PATCH] D64780: Disallow most calling convention attributes on PS4.

wristow accepted this revision. wristow added a comment. In D64780#1593624 , @aaron.ballman wrote: > LGTM aside from a nit. You should give other reviewers a chance to sign off > in case they have additional comments. LGTM too, once the line-length is

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

gribozavr added a comment. Looks like a good idea to me. Regarding tests, I couldn't find existing tests that check order either. Seems like you'd need to make some minimal infrastructure for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D649

[PATCH] D65005: [clang-doc] Fix output format of html

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. The children of a TagNode are rendered in the same line as the parent only if they are all TextNodes. When children are not inline; t

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, inglorion, Prazek, mehdi_amini. Herald added a project: clang. LTO Unit splitting does not apply to regular LTO modules, only ThinLTO (which must be consistently split into regular an

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added inline comments. Comment at: test/Analysis/taint-generic.c:24 +// CHECK-INVALID-FILE-SAME: 'alpha.security.taint.TaintPropagation:Config', +// CHECK-INVALID-FILE-SAME:that expects a valid filename Szelethus wrote: > NoQ wrote: > > Szel

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

heijink created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65012 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

pcc added a comment. Sorry, just realized this. If I do clang++ -c -flto a.cpp # "split" clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split clang++ a.o b.o this should fail, right? If I'm not mistaken, this patch series will cause this to succeed. I think we need to change th

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

Meinersbur added a comment. I prefer having the documentation change to be in the same patch as the functional change. Makes it easier to check whether they match. Comment at: clang/test/CodeGenCXX/pragma-loop.cpp:163 -// CHECK: ![[LOOP_1]] = distinct !{![[LOOP_1]], ![[UNROL

r366617 - Disallow most calling convention attributes on PS4

Author: ssrivastava Date: Fri Jul 19 14:38:34 2019 New Revision: 366617 URL: http://llvm.org/viewvc/llvm-project?rev=366617&view=rev Log: Disallow most calling convention attributes on PS4 PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi". Differential Revision: https://reviews.

[PATCH] D64646: [OPENMP]Add support for analysis of if clauses.

NoQ added inline comments. Comment at: test/Analysis/cfg-openmp.cpp:58-67 #pragma omp distribute simd for (int i = 0; i < 10; ++i) argc = x; -// CHECK-NEXT: 27: x -// CHECK-NEXT: 28: [B1.27] (ImplicitCastExpr, LValueToRValue, int) -// CHECK-NEXT: 29: argc -// CHECK-NE

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

smeenai added a comment. In D61479#1586987 , @sberg wrote: > eh, the summary here doesn't get updated from the actual git commit message :( > > thanks for the reviews! You can use `arc diff --verbatim` to update the summary based on your local commit me

[PATCH] D64780: Disallow most calling convention attributes on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366617: Disallow most calling convention attributes on PS4 (authored by ssrivastava, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. Herald added a subscriber: dmgreen. @jdoerfert @jyknight @lebedev.ri@rsmith @aaron.ballman This will appear as a 9.0 regression, right? Let's please consider a way to address it for 9.0 before it's released. Repository: rG LLVM Gi

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This patch fixes a regression introduced in r359947. Here: template struct Outer { template static constexpr auto x = 1;

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Thanks! Don't forget the CF version. Comment at: clang/lib/Format/FormatToken.h:793 IdentifierInfo *kw_CF_OPTIONS; + IdentifierInfo *kw_NS_CLOSED_ENUM

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

rsmith added a comment. Well, this restores an incorrect behaviour: we're not permitted to substitute into the initializer of the variable template here. Can you look into fixing this properly, by instantiating the type when forming the MemberExpr? If not, taking this to fix the regression seem

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/AST/OpenMPClause.h:2102-2103 child_range used_children() { -return child_range(child_iterator(), child_iterator()); +return child_range(rei

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

tejohnson added a comment. In D65009#1594009 , @pcc wrote: > Sorry, just realized this. If I do > > clang++ -c -flto a.cpp # "split" > clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split > clang++ a.o b.o > > > this should fail, right? If

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

tejohnson updated this revision to Diff 210918. tejohnson added a comment. Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65009/new/ https://reviews.llvm.org/D65009 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/split-lto-unit.c Index: tes

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2102-2103 child_range used_children() { -return child_range(child_iterator(), child_iterator()); +return child_range(reinterpret_cast(varlist_begin()),

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65009/new/ https://reviews.llvm.org/D65009 ___ cfe-commits mailing

r366623 - [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

Author: tejohnson Date: Fri Jul 19 16:02:58 2019 New Revision: 366623 URL: http://llvm.org/viewvc/llvm-project?rev=366623&view=rev Log: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 Summary: Regular LTO modules do not need LTO Unit splitting, only ThinLTO does (they must be consis

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

This revision was automatically updated to reflect the committed changes. Closed by commit rL366623: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

quantum created this revision. quantum added reviewers: tlively, aheejin, sbc100, sunfish, alexcrichton. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Add immutable WASM global `__tls_align` which stores the alignmen

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65028/new/ https://reviews.llvm.org/D65028 _

r366624 - [WebAssembly] Compute and export TLS block alignment

Author: quantum Date: Fri Jul 19 16:34:16 2019 New Revision: 366624 URL: http://llvm.org/viewvc/llvm-project?rev=366624&view=rev Log: [WebAssembly] Compute and export TLS block alignment Summary: Add immutable WASM global `__tls_align` which stores the alignment requirements of the TLS segment.

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL366624: [WebAssembly] Compute and export TLS block alignment (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D65028?vs=210930&id=210934#toc Repository: rL LLVM

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek created this revision. phosek added reviewers: vitalybuka, morehouse, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change introduces a pair of -fsanitize-link-deps and -fno-sanitize-link-deps flags which can be used to control linking of sanitizer runtime

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. This new index contains links to the main section of infos: Namespaces, Records, Functions, Enum

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Looks good now. Thanks Kadir! > On Jul 19, 2019, at 3:18 AM, Kadir Çetinkaya wrote: > > Hi Azhar, D64980 should fix the problem. I am reverting your revert while > adding the fix in r366559. > > On Fri, Jul 19, 2019 at 11:29 AM Azhar Mohammed > wrote: > Reverted in r36

r366620 - [NFC] Remove unused variable

Author: dendibakh Date: Fri Jul 19 14:59:42 2019 New Revision: 366620 URL: http://llvm.org/viewvc/llvm-project?rev=366620&view=rev Log: [NFC] Remove unused variable Change-Id: I5aee24dcdf6eebfbf788e52be22463387f23d927 Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/Co

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 ___ cfe-comm

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

sbc100 added inline comments. Comment at: lld/trunk/wasm/Symbols.h:438 + // __tls_size + // Symbol whose value is the alignment of the TLS block. __tls_align Comment at: lld/trunk/wasm/Symbols.h:439 + // __tls_size + // Symbol whose valu

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

MaskRay added a comment. There is an existing option `-fsanitize-minimal-runtime`, will `-fsanitize-no-runtime` be a name providing more consistency? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

pcc added subscribers: filcab, pcc. pcc added a comment. It's also worth asking whether `-nodefaultlibs` would work for this use case as @filcab suggested on D64547 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https

<    1   2