[PATCH] D63718: [ADT] Implement llvm::bsearch() with std::partition_point()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Funny, the int version was the original motivation and now seems totally unused. And apparently none of us know the standard library very well. Thanks for cleaning this up. Repository:

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

a_sidorin added a comment. Hello Gabor, Thank you for the explanation. I got the idea of this patch anyway, but it will be definitely useful for anyone digging into the code. Should we make it a comment for ImportPathTy? Comment at: clang/lib/AST/ASTImporter.cpp:8682 + +void

[clang-tools-extra] r364719 - [ADT] Implement llvm::bsearch() with std::partition_point()

Author: maskray Date: Sun Jun 30 02:17:59 2019 New Revision: 364719 URL: http://llvm.org/viewvc/llvm-project?rev=364719&view=rev Log: [ADT] Implement llvm::bsearch() with std::partition_point() Summary: Delete the begin-end form because the standard std::partition_point can be easily used as a re

[PATCH] D63718: [ADT] Implement llvm::bsearch() with std::partition_point()

This revision was automatically updated to reflect the committed changes. Closed by commit rL364719: [ADT] Implement llvm::bsearch() with std::partition_point() (authored by MaskRay, committed by ). Herald added subscribers: kristina, ilya-biryukov. Changed prior to commit: https://reviews.llvm

[clang-tools-extra] r364720 - Cleanup: llvm::bsearch -> llvm::partition_point after r364719

Author: maskray Date: Sun Jun 30 04:19:56 2019 New Revision: 364720 URL: http://llvm.org/viewvc/llvm-project?rev=364720&view=rev Log: Cleanup: llvm::bsearch -> llvm::partition_point after r364719 Modified: clang-tools-extra/trunk/clangd/index/Symbol.cpp Modified: clang-tools-extra/trunk/clan

r364720 - Cleanup: llvm::bsearch -> llvm::partition_point after r364719

Author: maskray Date: Sun Jun 30 04:19:56 2019 New Revision: 364720 URL: http://llvm.org/viewvc/llvm-project?rev=364720&view=rev Log: Cleanup: llvm::bsearch -> llvm::partition_point after r364719 Modified: cfe/trunk/lib/Tooling/Syntax/Tokens.cpp Modified: cfe/trunk/lib/Tooling/Syntax/Tokens.

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks for the explanation! It will be good if someone else takes a look at this patch. Comment at: clang/include/clang/AST/ASTImporterSharedState.h:40 + /// never cle

[PATCH] D61909: Add Clang shared library with C++ exports

kimgr added a comment. @sylvestre.ledru @beanz After this change, the Debian packaging on apt.llvm.org is basically broken. See https://bugs.llvm.org/show_bug.cgi?id=42432. I'm sure this can be fixed in packaging, but I don't know enough about it to know exactly what to do. At any rate I thin

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak added a comment. In D63508#1558390 , @rsmith wrote: > Patch generally looks good; just a minor concern about the output format. > Also, we don't need parentheses around the constant 0 or 1. That was consistent with what the current code does, b

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak updated this revision to Diff 207220. llunak added a comment. Updated patch, removed ()'s around 1/0, fixed to use CommentOutDirective(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 Files: clang/lib/Frontend/

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, The patch looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 __

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changing getFinalPhase to getPhasesToRun. Instead of only returning the final phase it returns the final phase as well as a collection of the phases to skip. This is useful for cases where you wa

[PATCH] D63978: Very early work on interface stub merger plumbing.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is really early. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63978 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains

[PATCH] D63978: Very early work on interface stub merger plumbing.

plotfi updated this revision to Diff 207224. plotfi added a comment. had some accidentally not-removed stray print output and/or expletives, apologies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Phases.h:30 +ID FinalPhase; +std::set SkipPhases; + }; I could change this to a SmallVector or SmallSet Repository: rG LLVM Github Monorepo

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org/D62329 __

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi updated this revision to Diff 207227. plotfi added a comment. Add full context, change std::set to llvm::SmallSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63977/new/ https://reviews.llvm.org/D63977 Files: clang/include/clang/Driver/D

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi updated this revision to Diff 207228. plotfi added a comment. Removing obvious comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63977/new/ https://reviews.llvm.org/D63977 Files: clang/include/clang/Driver/Driver.h clang/include/cl

[PATCH] D63979: actually also compile output in tests for -frewrite-includes

llunak created this revision. llunak added a project: clang. Herald added a subscriber: cfe-commits. This depends on https://reviews.llvm.org/D63508 (where I posted one version of a patch that created broken output without the tests catching it). Repository: rC Clang https://reviews.llvm.org

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak updated this revision to Diff 207229. llunak added a comment. Updated the patch again, commenting out just a part of #if didn't work either, so it seems there's no good way to comment out unwanted #if. This patch surrounds rewritten #if conditions by extra #if 0 #endif block to disable th

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. For now, it isn't part of the debian packaging. https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563 it is removed as packaging phase as I have been told it isn't ready. Anyway, the lib should not keep this name. By definition, on

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

a_sidorin added a comment. > The following happened: During the analysis we compared two Decls which > turned out to be inequivalent, so we cached them. Later during the analysis, > however, we added a new node to the redecl chain of one of these Decls which > we previously compared. Then anoth

[PATCH] D63954: Add lifetime categories attributes

mgehre added a comment. We can and should explore both options and see what works best. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 ___ cfe-commits mailing

[PATCH] D63954: Add lifetime categories attributes

mgehre updated this revision to Diff 207235. mgehre added a comment. Address some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 Files: clang/include/clang/Basic/Attr.td clang/include/

[PATCH] D63954: Add lifetime categories attributes

mgehre marked 2 inline comments as done. mgehre added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4560-4561 + if(AL.getKind() == ParsedAttr::AT_Owner) { +if (checkAttrMutualExclusion(S, D, AL)) + return; +if (const auto *Attr = D->getAttr()) {

r364724 - Various tweaks to MSVC natvis visualizers

Author: mps Date: Sun Jun 30 15:04:25 2019 New Revision: 364724 URL: http://llvm.org/viewvc/llvm-project?rev=364724&view=rev Log: Various tweaks to MSVC natvis visualizers Make more consistent use of na format. Improve visualization of deduction guides. Add visualizer for explicit specifier (incl