[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Is it ok now? I doubt that main code refactoring is a good way when adding support timer code. So ended with more robust solution, though it leads to two `Frontend` sections. Repository: rG LLVM Github Monorep

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

jvikstrom created this revision. jvikstrom added reviewers: hokein, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Emit publishSemanticHighlighting in LSP if enabled Repository: rG LLVM Github Monorepo https://review

r364630 - [CTU] Add missing statistics

Author: martong Date: Fri Jun 28 01:08:51 2019 New Revision: 364630 URL: http://llvm.org/viewvc/llvm-project?rev=364630&view=rev Log: [CTU] Add missing statistics Reviewers: xazax.hun Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #clang Differential Revision: https://r

[PATCH] D63878: [CTU] Add missing statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rL364630: [CTU] Add missing statistics (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63878

[PATCH] D63920: [CTU] Add support for virtual functions

martong created this revision. martong added reviewers: Szelethus, xazax.hun. Herald added subscribers: cfe-commits, gamesh411, dkrupp, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.

[PATCH] D63920: [CTU] Add support for virtual functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/ctu-main.cpp:112 + // We cannot decide about the dynamic type. + clang_analyzer_eval(obj->fvcl(1) == 8); // expected-warning{{FALSE}} expected-warning{{TRUE}} + clang

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

lebedev.ri added a comment. In D63845#1561793 , @jdoerfert wrote: > In D63845#1560605 , @aaron.ballman > wrote: > > > In D63845#1559995 , @lebedev.ri > > wrote: > > > > > W

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

wsmoses added a comment. Just to preface these comments -- this is work in progress and not intended to go in as is / without discussion (but happily is indeed inviting discussion). In D63845#1561983 , @lebedev.ri wrote: > In D63845#1561793

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a comment. Yes, CaseStmt is dropped in that case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63139/new/ https://reviews.llvm.org/D63139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Right, ok. I have been testing this for quite some time now, including maths, and so far had no issues. Can this get merged into 9.0? I do not believe there are enough obstacles to postpone it any further. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D63922: [clangd] Show better message when we rename macros.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, when we rename a macro, we get an error message of "there is no symbol found". This patch improves t

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:31 +// Contains all highlightings in a single line. +struct LineHighlighting { + LineHighlighting(unsigned int Line = 0, The structures defined here are similar to the stru

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63734/new/ https://reviews.llvm.org/D63734 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

jvikstrom updated this revision to Diff 207031. jvikstrom marked an inline comment as done. jvikstrom added a comment. Added SemanticHighlightingInformation and SemantigHighlightingParams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63919/new/ ht

r364468 - [WebAssembly] Implement Address Sanitizer for Emscripten

Author: quantum Date: Wed Jun 26 13:16:14 2019 New Revision: 364468 URL: http://llvm.org/viewvc/llvm-project?rev=364468&view=rev Log: [WebAssembly] Implement Address Sanitizer for Emscripten Summary: This diff enables address sanitizer on Emscripten. On Emscripten, real memory starts at the valu

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

vit9696 added a comment. Could somebody commit it into 9.0? Quite a lot of people depend on this option including us. Since it got accepted I do not see a reason for this to get postponed any further. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llv

[PATCH] D62855: Implementation of auto type expansion.

kuhnel updated this revision to Diff 207037. kuhnel marked 10 inline comments as done. kuhnel added a comment. fixed code review comments from sam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files:

[PATCH] D63926: [clangd] Make FixIt message be consistent with the clang-tidy diagnostic message.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We strip the "[clang-tidy-check]" suffix from the clang-tidy diagnostics, we should be consistent with the message in FixI

[PATCH] D62855: Implementation of auto type expansion.

kuhnel updated this revision to Diff 207039. kuhnel marked an inline comment as done. kuhnel added a comment. fixed merge error around hasDeducedType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files:

[PATCH] D62855: [clangd] Implementation of auto type expansion.

lebedev.ri added a comment. The patch is completely missing description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 ___ cfe-commits mailing list cfe-commit

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:332 + ClangdServerOpts.SemanticHighlighting = + Params.capabilities.SemanticHighlighting; I'm a bit nervous -- we will turn on this feature when the client states that

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

mbonadei created this revision. Herald added subscribers: llvm-commits, cfe-commits, xazax.hun, mgorny. Herald added projects: clang, LLVM. The new clang-tidy check "abseil-prefixed-thread-annotations" checks for usages of deprecated Abseil thread annotation macros and migrates them to the new m

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp:61 + if (const auto *AlwaysTrueOp = Result.Nodes.getNodeAs("atop")) { +diag(AlwaysTrueOp->getOperatorLoc(), "%0 returns zero on success and a positive value on failure s

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

gribozavr added a reviewer: gribozavr. gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Do you have commit access? Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:43 +FixItHint

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:43 +FixItHint hint = FixItHint::CreateInsertion(Range.getBegin(), "ABSL_"); +Check.diag(Range.getBegin(), "usage of unprefixed thread annotation") +

[PATCH] D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:123 TextGenerator Explanation; +// Include paths that to add to the file affected by this

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. @a_sidorin Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri added a comment. I have the same observation as with googletest patch (D62977 ), and i'd guess this applies to all these clang-tidy abseil checks (meaning the existing ones are all equally broken): there is no checking that the new macro actually exist

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri added a comment. (Stuck reviews are bad, but blind stamping is even worse..) Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:15-16 + +constexpr char kAbseilThreadAnnotationsHeader[] = +"absl/base/internal/thread_annotations.h";

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:41 + llvm::StringRef(kAbseilThreadAnnotationsHeader); + if (ac

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein updated this revision to Diff 207058. hokein added a comment. Rebase the code, and hide the tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57943/new/ https://reviews.llvm.org/D57943 Files: clang-tools-extra/clangd/refactor/tweaks/C

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein added a comment. In D57943#1441129 , @ilya-biryukov wrote: > Another alternative we could consider would be collecting these fixes when > producing the clang-tidy diagnostics. > We won't show the diagnostics to the users if they have the check di

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

thakis added a comment. Can you add a lit test for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697/new/ https://reviews.llvm.org/D63697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D63931: [clangd] Make PreambleStatusCache handle filenames more carefully

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - when we hit the cache, the reported filename should be that of the cache query, not that of the cache store. T

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/PrefixedThreadAnnotationsCheck.cpp:15-16 + +constexpr char kAbseilThreadAnnotationsHeader[] = +"absl/base/internal/thread_annotations.h"; + lebedev.ri wrote: > constexpr St

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. I'll commit it tonight. Was going to last night, but ran into a clang test failure, that turned out to be a long-standing failure with FreeBSD/powerpc64, not a problem with my change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan updated this revision to Diff 207062. yvvan added a comment. Sorry for delay. Test added, redundant comments removed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 Files: clang/include/clang/Tooling/ReplacementsYaml.h clang/unittests

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong updated this revision to Diff 207063. martong marked 4 inline comments as done. martong added a comment. - Add further checks for the DeclarationName overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124 + case DeclarationName::CXXConversionFunctionName: +return true; + a_sidorin wrote: > Should we check the equivalence of getCX

[PATCH] D62962: Clang implementation of sizeless types

lebedev.ri added a comment. Since this is an extension, it wouldb be great to have a (on-by-default? at least in `-Wall`) diagnostic for every instance of usage of this extension. (I guess this is actually true for clang vector extension, too..) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong added a comment. Alexei, thank you very much for the review, you caught quite a few missing things! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org/D62329 ___

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard created this revision. ostannard added reviewers: mehdi_amini, pcc, majnemer, tejohnson. Herald added subscribers: dang, dexonsmith, steven_wu, hiraditya, kristof.beyls, Prazek, javed.absar. Herald added projects: clang, LLVM. Currently, it is hard for the compiler to remove unused C++

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

lebedev.ri added a comment. To make this transformation safe, I have changed clang's code-generation to always load virtual function pointers using the llvm.type.checked.load intrinsic, instead of regular load instructions. I originally tried writing this using clang's existing code-genera

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Without switching to `llvm.type.checked.load`, the optimisation would trigger in some cases where it shouldn't trigger, thus miscompiling the code. This is because it needs to know about _every_ virtual call site, if we lose the information about some of them then it

r364647 - [OPENMP]Fix checks for DSA in simd constructs.

Author: abataev Date: Fri Jun 28 07:59:25 2019 New Revision: 364647 URL: http://llvm.org/viewvc/llvm-project?rev=364647&view=rev Log: [OPENMP]Fix checks for DSA in simd constructs. The errors for incorrectly specified data-sharing attributes for simd constructs must be emitted only for the explic

r364648 - [Hexagon] driver uses out-of-date option name and binary name

Author: kparzysz Date: Fri Jun 28 08:08:03 2019 New Revision: 364648 URL: http://llvm.org/viewvc/llvm-project?rev=364648&view=rev Log: [Hexagon] driver uses out-of-date option name and binary name Patch by A. Skrobov (t.yomitch). Differential Revision: https://reviews.llvm.org/D62127 Modified:

[PATCH] D62127: [Hexagon] driver uses out-of-date option name and binary name

This revision was automatically updated to reflect the committed changes. Closed by commit rL364648: [Hexagon] driver uses out-of-date option name and binary name (authored by kparzysz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong marked 2 inline comments as done. martong added a comment. In D62131#1517634 , @a_sidorin wrote: > Hi Gabor, > Could you provide an example of an import sequence leading to this behavior? > It's hard for me to imagine such a situation. Alexei,

r364650 - [OPENMP]Fix DSA for loop iteration variables in simd loops.

Author: abataev Date: Fri Jun 28 08:16:37 2019 New Revision: 364650 URL: http://llvm.org/viewvc/llvm-project?rev=364650&view=rev Log: [OPENMP]Fix DSA for loop iteration variables in simd loops. According to the OpenMP 5.0 standard, the loop iteration variable in the associated for-loop of a simd

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

vit9696 added a comment. @ruiu, we have some hardware, which bootloader does not support PT_GNU_STACK segments, and would therefore benefit quite a bit from this option. As this does not really depend on NetBSD support, could you please merge this patch in time for 9.0? Thanks! CHANGES SINCE

r364655 - [OPENMP]Fix top DSA for static members.

Author: abataev Date: Fri Jun 28 09:16:00 2019 New Revision: 364655 URL: http://llvm.org/viewvc/llvm-project?rev=364655&view=rev Log: [OPENMP]Fix top DSA for static members. Fixed handling of the data-sharing attributes for static members when requesting top most attribute. Previously, it might r

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

labrinea created this revision. labrinea added reviewers: simon_tatham, SjoerdMeijer, ostannard. Herald added subscribers: dmgreen, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. When processing the command line options `march`, `mcpu` and `mfpu`, we store the implied

[PATCH] D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.

ymandel updated this revision to Diff 207083. ymandel marked 2 inline comments as done. ymandel added a comment. comments tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63892/new/ https://reviews.llvm.org/D63892 Files: clang/include/clang/

[PATCH] D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes.

ymandel updated this revision to Diff 207085. ymandel added a comment. Added check for use of AddedIncludes before allocating/registering IncludeInserter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63893/new/ https://reviews.llvm.org/D63893 Fi

[PATCH] D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.

ymandel updated this revision to Diff 207082. ymandel added a comment. Responded to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63892/new/ https://reviews.llvm.org/D63892 Files: clang/include/clang/Tooling/Refactoring/Transformer.h

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + rjmccall wrote: > It loo

[PATCH] D63822: [Driver] Fix style issues of --print-supported-cpus

ziangwan accepted this revision. ziangwan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63822/new/ https://reviews.llvm.org/D63822 ___ cfe-commit

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk updated this revision to Diff 207086. tuktuk edited the summary of this revision. tuktuk added a comment. I followed Matt Morehouse's advice: mainly, I adapted the test so that it uses libFuzzer's default SanitizerCoverage options instead of `trace-pc`, and I rewrote some parts of the cod

[PATCH] D63922: [clangd] Show better message when we rename macros.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:661 + Preprocessor &PP) { + // Also handle possible macro at the searched

[PATCH] D63940: [NFC] Pass DataLayout into isBytewiseValue

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. vitalybuka added a parent revision: D63854: [NFC] Convert large lambda into method. We will need to handle IntToPtr which I will submit in a separate patch as it's

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah updated this revision to Diff 207084. SureYeaah added a comment. [Clangd] Refactored code - Created new class Extract to store information about the expression being extracted. - Doesn't fix all of previous comments Looking for comments on the new class stucture Repository: rG LLV

[clang-tools-extra] r364663 - Update CODE_OWNERS.txt for clang-doc

Author: juliehockett Date: Fri Jun 28 10:32:26 2019 New Revision: 364663 URL: http://llvm.org/viewvc/llvm-project?rev=364663&view=rev Log: Update CODE_OWNERS.txt for clang-doc Differential Revision: https://reviews.llvm.org/D63734 Modified: clang-tools-extra/trunk/CODE_OWNERS.TXT Modified:

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

This revision was automatically updated to reflect the committed changes. Closed by commit rL364663: Update CODE_OWNERS.txt for clang-doc (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

ArnaudBienner added a subscriber: xbolva00. ArnaudBienner added a comment. Thanks @xbolva00 for adding reviewers and @rjmccall for reviewing! @rjmccall as you might remember, we had a discussion on the mailing list ("Warning when calling virtual functions from constructor/desctructor?") and fr

r364664 - [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

Author: vsapsai Date: Fri Jun 28 10:42:17 2019 New Revision: 364664 URL: http://llvm.org/viewvc/llvm-project?rev=364664&view=rev Log: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. `Selector::getIdentifierInfoForSlot` returns NULL if a slot has no corresponding identi

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364664: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 updated this revision to Diff 207102. jcai19 added a comment. Update warning messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D63943: ObjC: Squeeze in one more bit for the count of protocols in 'id' types

jordan_rose created this revision. jordan_rose added reviewers: jfb, doug.gregor, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Someone actually had an Objective-C object pointer type with more than 64 protocols, probably collected through typedefs. Raise the

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL364670: [clang-doc] De-duplicate comments and locations (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[clang-tools-extra] r364670 - [clang-doc] De-duplicate comments and locations

Author: juliehockett Date: Fri Jun 28 11:17:58 2019 New Revision: 364670 URL: http://llvm.org/viewvc/llvm-project?rev=364670&view=rev Log: [clang-doc] De-duplicate comments and locations De-duplicate comments and declaration locations in reduce function. When two files include the same header fil

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 _

[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

rjmccall added a comment. Oh, sorry, I had completely forgotten about that. My contributions to Clang are primarily code review these days; I am not working on that idea. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56366/new/ https://reviews.llvm.org/D56366

[clang-tools-extra] r364674 - [clang-doc] Handle anonymous namespaces

Author: juliehockett Date: Fri Jun 28 12:07:56 2019 New Revision: 364674 URL: http://llvm.org/viewvc/llvm-project?rev=364674&view=rev Log: [clang-doc] Handle anonymous namespaces Improves output for anonymous decls, and updates the '--public' flag to exclude everything under an anonymous namespa

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL364674: [clang-doc] Handle anonymous namespaces (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + ahatanak wrote: > rjmccall wrote: > > It looks like you're generall

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran updated this revision to Diff 207126. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Herald added subscribers: kadircet, arphaman. Add comments. Extract repeated logic into mapDecl function in SerializeTest.cpp Use EmptySID instead of specific US

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341 + Parent->USR = ParentUSR; + Parent->ChildNamespaces.emplace_back(I->USR, I->Name, InfoType::IT_namespace); + return {std::unique_ptr{std::move(I)}, juliehockett

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D63857 replaces this revision. Nodes that represent each HTML tag are used instead of templates, it's easier to maintain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63666/new/

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk added a comment. Thanks for the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

r364679 - Revert enabling frame pointer elimination on OpenBSD for now.

Author: brad Date: Fri Jun 28 12:57:51 2019 New Revision: 364679 URL: http://llvm.org/viewvc/llvm-project?rev=364679&view=rev Log: Revert enabling frame pointer elimination on OpenBSD for now. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/frame-pointer-elim.c

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:366 + + if (I->Namespace[0].RefType == InfoType::IT_namespace) { +auto Parent = llvm::make_unique(); Can you make this a switch statement, doing the appropriate things

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I don't have any other comments. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 ___ cfe

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207133. Charusso edited the summary of this revision. Charusso added a comment. - Make it match the class name. (Whoops!) - Reorder the tuple (swap the return value with the call name). - Remove the Projects option. - Remove unnecessary input validation. CH

[PATCH] D63954: Add lifetime categories attributes

mgehre created this revision. mgehre added a reviewer: gribozavr. Herald added a project: clang. This is the first part of work announced in "[RFC] Adding lifetime analysis to clang" [0], i.e. the addition of the [[gsl::Owner(T)]] and [[gsl::Pointer(T)]] attributes, which will enable user-defined

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207135. Charusso added a comment. - Fix the note as the class name is optional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/S

[PATCH] D63954: Add lifetime categories attributes

mgehre updated this revision to Diff 207138. mgehre added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.

r364683 - [OPENMP]Improve analysis of implicit captures.

Author: abataev Date: Fri Jun 28 13:45:14 2019 New Revision: 364683 URL: http://llvm.org/viewvc/llvm-project?rev=364683&view=rev Log: [OPENMP]Improve analysis of implicit captures. If the variable is used in the OpenMP region implicitly, we need to check the data-sharing attributes for such varia

[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The NonnullGlobalConstants checker models the rule "it does

[PATCH] D62962: Clang implementation of sizeless types

efriedma added a comment. > Since this is an extension, it wouldb be great to have a (on-by-default? at > least in -Wall) diagnostic for every instance of usage of this extension. We generally only add warnings for extensions which are not allowed by the standard. It's impossible to define a s

[PATCH] D63954: Add lifetime categories attributes

erik.pilkington added a comment. > We explicitly allow to add an annotation after > the definition of the class to allow adding annotations > to external source from by the user, e.g. > > #include > > namespace std { > template > class [[gsl::Owner(T)]] vector; > } Wait, does tha

[PATCH] D63180: [clang-doc] Adds HTML generator

jakehehrlich added a comment. I'm getting confused in all the different patches. I reviewed the HTML generator one like yesterday and was awaiting changes. Doesn't this do the same thing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63180/new/ https://reviews.llvm.org/D63180 _

[PATCH] D63954: Add lifetime categories attributes

mgehre added a comment. We can try to add the annotations to libcxx (which will still take time), but there are also other standard libraries (libstdc++, MSVC) that can be used with clang. Eventually everybody will have lifetime annotations (of course ;-) ), but in the meantime there seems to be n

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't this do the > same thing? Diego, why don't

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:91 +struct HTMLFile { + llvm::SmallString<16> DoctypeDecl{""}; + std::vector> Children; // List of child nodes jakehehrlich wrote: > Does this ever change? If not t

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran updated this revision to Diff 207148. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Make DoctypeDecl a constexpr. Early exit in TagNode::Render. Functions of HTMLGenerator now return HTMLNodes instead of adding children to a Node passed by refe

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran updated this revision to Diff 207153. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Change an if statement for a switch statement in `emitInfo(const RecordDecl *D, ...)`, it now handles correctly unexpected info types. Fix spelling in comments.

[PATCH] D63954: Add lifetime categories attributes

xazax.hun added a comment. I actually think we should hard code STL (and maybe some other popular) types into the compiler. I.e.: if an STL type is unannotated and the warnings are turned on, we could look up the default annotations from a table and append them during parsing. This could be don

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added a comment. Aha, nice, thanks for adding a description, it is a very good thing to do. Like, every commit should be obvious. Even though i know what's going on, nobody else does, so it's good to explain that this is for modeling certain weird LLVM-specific APIs that intentionally alway

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - Calls to consteval function and constructors are not evaluated as soon as they are reached. - Add diagnostic for taking address of a consteval function i

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim abandoned this revision. hctim added a comment. Abandoned as this was merged in small chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60593/new/ https://reviews.llvm.org/D60593 ___ cfe-comm

  1   2   >